From d1b266ae59035edd194c27adf2fc4b42e794306f Mon Sep 17 00:00:00 2001 From: Stoiko Ivanov Date: Wed, 29 Nov 2023 15:17:14 +0100 Subject: [PATCH] pbs2to3: add check for dkms modules ported over from pve-manager: 'pve7to8: Add check for dkms modules' `0329876ccf1d78b848897718bb0c2337c6a55fbb` Signed-off-by: Stoiko Ivanov --- src/bin/pbs2to3.rs | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/bin/pbs2to3.rs b/src/bin/pbs2to3.rs index 9a18d7b2f..a9b537fd5 100644 --- a/src/bin/pbs2to3.rs +++ b/src/bin/pbs2to3.rs @@ -263,12 +263,38 @@ impl Checker { Ok(()) } + fn check_dkms_modules(&mut self) -> Result<(), Error> { + let kver = std::process::Command::new("uname") + .arg("-r") + .output() + .map_err(|err| format_err!("failed to retrieve running kernel version - {err}"))?; + + let output = std::process::Command::new("dkms") + .arg("status") + .arg("-k") + .arg(std::str::from_utf8(&kver.stdout)?) + .output(); + match output { + Err(_err) => self.output.log_skip("could not get dkms status")?, + Ok(ret) => { + let num_dkms_modules = std::str::from_utf8(&ret.stdout)?.lines().count(); + if num_dkms_modules == 0 { + self.output.log_pass("no dkms modules found")?; + } else { + self.output.log_warn("dkms modules found, this might cause issues during upgrade.")?; + } + } + } + Ok(()) + } + pub fn check_misc(&mut self) -> Result<(), Error> { self.output.print_header("MISCELLANEOUS CHECKS")?; self.check_pbs_services()?; self.check_time_sync()?; self.check_apt_repos()?; self.check_bootloader()?; + self.check_dkms_modules()?; Ok(()) }