Thomas Lamprecht
fe0efb25e8
backup: index readers: drop useless shared lock
This is only acquired in those two methods, both as shared. So it has no use. It seems, that it was planned in the past that the index deletion should take the exclusive, while read and write takes the shared flock on the index, as one can guess from the lock comments in commit 046521895307aa8bde8bab7ea3ef9e437d5ab5e5 But then later, in commit c8ec450e379f54e7ac648b3a3ff701b37e9a6620) the documented semantics where changed to use a temp file and do an atomic rename instead for atomicity. The reader shared flock on the index file was done inbetween, probably as preparatory step, but was not removed again when strategy was changed to using the file rename instead. Do so now, to avoid confusion of readers and a useless flock. Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
``rustup`` Toolchain ==================== We normally want to build with the ``rustc`` Debian package. To do that you can set the following ``rustup`` configuration: # rustup toolchain link system /usr # rustup default system Versioning of proxmox helper crates =================================== To use current git master code of the proxmox* helper crates, add:: git = "ssh://gitolite3@proxdev.maurer-it.com/rust/proxmox" or:: path = "../proxmox/proxmox" to the proxmox dependency, and update the version to reflect the current, pre-release version number (e.g., "0.1.1-dev.1" instead of "0.1.0"). Local cargo config ================== This repository ships with a ``.cargo/config`` that replaces the crates.io registry with packaged crates located in ``/usr/share/cargo/registry``. A similar config is also applied building with dh_cargo. Cargo.lock needs to be deleted when switching between packaged crates and crates.io, since the checksums are not compatible. To reference new dependencies (or updated versions) that are not yet packaged, the dependency needs to point directly to a path or git source (e.g., see example for proxmox crate above). Build ===== on Debian Buster Setup: 1. add 'deb http://repo.proxmox.com/staging/devel/ buster devel-10' to your sources.list 2. [sudo] wget http://download.proxmox.com/debian/proxmox-ve-release-6.x.gpg -O /etc/apt/trusted.gpg.d/proxmox-ve-release-6.x.gpg 3. [sudo] apt update 4. [sudo] apt install devscripts debcargo 5. git clone git://git.proxmox.com/git/proxmox-backup.git 6. [sudo] mk-build-deps -i Note: 2. may be skipped if you already added the pve or pbs package repository You are now able to build using the Makefile or cargo itself.
Description
Languages
Rust
86.9%
JavaScript
12.3%
Makefile
0.3%
Handlebars
0.2%
CSS
0.2%