From 5588ef734845b0f4bed2b07bf07cdb1e538eabc4 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Thu, 3 Sep 2020 19:05:20 +0300 Subject: [PATCH] doc: add missing fsync FIXME --- src/repo/fs.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/repo/fs.rs b/src/repo/fs.rs index 6eb590bd..574c1ae3 100644 --- a/src/repo/fs.rs +++ b/src/repo/fs.rs @@ -215,6 +215,8 @@ impl BlockStore for FsBlockStore { .parent() .expect("we already have at least the shard parent"); + // FIXME: missing fsync on directories; for example after winning the race we could + // fsync the parent and parent.parent std::fs::create_dir_all(sharded)?; let target = std::fs::OpenOptions::new()