From d1d8bc0df10269d915565f48df20cf11bd68d1a0 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Thu, 13 Aug 2020 19:47:09 +0300 Subject: [PATCH] doc: update contributing, minimal patches --- CONTRIBUTING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7fefb16b..34fe681c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,9 +9,11 @@ Welcome, and thank you for your interest in contributing to Rust IPFS. Issues an ## First Principles -1. Keep the build time small +1. Keep the patch size minimal 2. Aim for high (but not absolute) code coverage in testing +By keeping the patch size minimal we hope to avoid difficult to review situations where there are lot of lines changed with only a few necessary changes. If you wish to submit a pull request for reorganizing something, please keep all unnecessary changes out. + ## Target Build Rust IPFS will always target the current _stable_ version of Rust that is released. Our CI/CD tests will reflect this. See [instructions here on how to install the rust toolchain](https://doc.rust-lang.org/book/ch01-01-installation.html).