tsarevvv/rust-ipfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

doc: apply suggestions from code review

Browse Source 
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>
This commit is contained in:
Joonas Koivunen 2020-06-16 13:10:40 +03:00 committed by Joonas Koivunen
parent 72f68871ef
commit eec4598c90
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unixfs/examples/get.rs
View File

@ -57,7 +57,7 @@ fn walk(blocks: ShardedBlockStore, start: &Cid) -> Result<(), Error> {
use ipfs_unixfs::dir::walk::{Walker, Walk, ContinuedWalk};
use sha2::{Digest, Sha256};
// The blockstore specific way of reading the block. Here we assume go-ipfs 0.5 default flatfs
// The blockstore-specific way of reading the block. Here we assume go-ipfs 0.5 default flatfs
// configuration, which puts the files at sharded directories and names the blocks as base32
// upper and a suffix of "data".
//

12
unixfs/src/dir/walk.rs
View File

@ -17,7 +17,7 @@ pub struct Walker {
/// walk in which case we shortcircuit to continue it.
next: Option<(Cid, String, usize)>,
pending: Vec<(Cid, String, usize)>,
// tried to recycle the names but that was consistently at fast and used more memory than just
// tried to recycle the names but that was consistently as fast and used more memory than just
// cloning the strings
}
@ -80,7 +80,7 @@ impl Walker {
.into_iter()
.enumerate()
// 2 == number of ancestors this link needs to have on the path, this is after
// some trial and error so not entirely sure why ... ancestors always includes
// some trial and error so not entirely sure why ... ancestors always include
// the empty root in our case.
.map(|(nth, link)| convert_link(2, nth, link));
@ -92,7 +92,7 @@ impl Walker {
let links = flat.links
.into_iter()
.enumerate()
// 1 == ancestors should be only the [""]
// 1 == ancestors should only be the [""]
.map(|(nth, link)| convert_sharded_link(1, nth, link));
Self::walk_directory(links, inner)
@ -323,7 +323,7 @@ impl Walker {
}
}
// TODO: we could easily split an 'static value for a directory or bucket, which would pop all
// TODO: we could easily split a 'static value for a directory or bucket, which would pop all
// entries at a single level out to do some parallel walking, though the skipping could already
// be used to do that... Maybe we could return the filevisit on Skipped to save user from
// re-creating one? How to do the same for directories?
@ -621,7 +621,6 @@ enum State {
#[derive(Debug)]
pub enum ContinuedWalk<'a> {
// should this be just the description of what we just walked into?
File(FileSegment<'a>, Item),
Directory(Item),
Symlink(&'a [u8], Item),
@ -721,6 +720,9 @@ mod tests {
fn sharded_dir() {
use std::fmt::Write;
// the hamt sharded directory is such that the root only has buckets so all of the actual files
// are at second level buckets, each bucket should have 2 files. the actual files is in fact a single empty
// file, linked from many names.
let mut counts = walk_everything("QmZbFPTnDBMWbQ6iBxQAhuhLz8Nu9XptYS96e7cuf5wvbk");
assert_eq!(counts.remove(&PathBuf::from("")), Some(9));