756e29fdc9
Don't require a rebuild every time the common module changes status. Cherry picked from libguestfs commit ededdce3c11d8e767d136130a15afe5941a1010c. For virt-v2v I re-added the cfg.mk file in this commit. It is called from maint.mk.
142 lines
5.6 KiB
Makefile
142 lines
5.6 KiB
Makefile
# Customize Makefile.maint. -*- makefile -*-
|
|
# Copyright (C) 2003-2012 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Use alpha.gnu.org for alpha and beta releases.
|
|
# Use ftp.gnu.org for major releases.
|
|
gnu_ftp_host-alpha = alpha.gnu.org
|
|
gnu_ftp_host-beta = alpha.gnu.org
|
|
gnu_ftp_host-major = ftp.gnu.org
|
|
gnu_rel_host = $(gnu_ftp_host-$(RELEASE_TYPE))
|
|
|
|
url_dir_list = \
|
|
ftp://$(gnu_rel_host)/gnu/coreutils
|
|
|
|
# Exclude some filenames.
|
|
exclude_file_name_regexp--sc_bindtextdomain = ^(daemon|erlang|examples|tests)/|/test-
|
|
exclude_file_name_regexp--sc_error_message_period = ^(generator|php|po-docs)/
|
|
exclude_file_name_regexp--sc_prohibit_always-defined_macros = ^examples/|^tests/xml/fake-libvirt-xml\.c|^daemon/guestfsd\.c
|
|
exclude_file_name_regexp--sc_prohibit_doubled_word = ^po/
|
|
exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = ^test-data/|\.patch$|\.png$
|
|
exclude_file_name_regexp--sc_prohibit_magic_number_exit = ^(po|po-docs)/|\.pod$|^fuse/guestunmount\.c
|
|
exclude_file_name_regexp--sc_prohibit_strcmp = ^(examples|po-docs)/|\.pod$
|
|
exclude_file_name_regexp--sc_prohibit_strcmp_and_strncmp = ^(examples|po-docs)/|\.pod$
|
|
exclude_file_name_regexp--sc_prohibit_strncpy = ^lib/launch-.*\.c$
|
|
exclude_file_name_regexp--sc_require_config_h = ^examples/|^tests/c-api/test-just-header\.c$
|
|
exclude_file_name_regexp--sc_require_config_h_first = ^examples/|^tests/c-api/test-just-header\.c$|^python/guestfs-py-byhand\.c$
|
|
|
|
# Tests not to run as part of "make distcheck".
|
|
local-checks-to-skip = \
|
|
sc_po_check \
|
|
sc_GPL_version \
|
|
sc_error_exit_success \
|
|
sc_file_system \
|
|
sc_makefile_path_separator_check \
|
|
sc_obsolete_symbols \
|
|
sc_prohibit_atoi_atof \
|
|
sc_prohibit_quote_without_use \
|
|
sc_prohibit_quotearg_without_use \
|
|
sc_prohibit_stat_st_blocks \
|
|
sc_space_tab \
|
|
sc_two_space_separator_in_usage \
|
|
sc_error_message_uppercase \
|
|
sc_program_name \
|
|
$(disable_temporarily) \
|
|
sc_useless_cpp_parens \
|
|
sc_cast_of_argument_to_free
|
|
|
|
disable_temporarily = \
|
|
sc_makefile_check \
|
|
sc_unmarked_diagnostics \
|
|
sc_prohibit_ctype_h \
|
|
sc_prohibit_asprintf \
|
|
sc_avoid_write
|
|
|
|
# Avoid uses of write(2). Either switch to streams (fwrite), or use
|
|
# the safewrite wrapper.
|
|
sc_avoid_write:
|
|
@if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then \
|
|
grep '\<write *(' $$($(VC_LIST_EXCEPT) | grep '\.c$$') && \
|
|
{ echo "$(ME): the above files use write;" \
|
|
" consider using the safewrite wrapper instead" \
|
|
1>&2; exit 1; } || :; \
|
|
else :; \
|
|
fi
|
|
|
|
# Use STREQ rather than comparing strcmp == 0, or != 0.
|
|
# Similarly, use STREQLEN or STRPREFIX rather than strncmp.
|
|
sc_prohibit_strcmp_and_strncmp:
|
|
@grep -nE '! *strn?cmp *\(|\<strn?cmp *\([^)]+\) *==' \
|
|
$$($(VC_LIST_EXCEPT)) \
|
|
| grep -vE ':# *define STREQ(LEN)?\(' && \
|
|
{ echo '$(ME): use STREQ(LEN) in place of the above uses of strcmp(strncmp)' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Use virAsprintf rather than a'sprintf since *strp is undefined on error.
|
|
sc_prohibit_asprintf:
|
|
@re='\<[a]sprintf\>' \
|
|
msg='use virAsprintf, not a'sprintf \
|
|
$(_prohibit_regexp)
|
|
|
|
# Prohibit the inclusion of <ctype.h>.
|
|
sc_prohibit_ctype_h:
|
|
@grep -E '^# *include *<ctype\.h>' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo "$(ME): don't use ctype.h; instead, use c-ctype.h" \
|
|
1>&2; exit 1; } || :
|
|
|
|
ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\
|
|
|isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper
|
|
|
|
sc_avoid_ctype_macros:
|
|
@grep -E '\b($(ctype_re)) *\(' /dev/null \
|
|
$$($(VC_LIST_EXCEPT)) && \
|
|
{ echo "$(ME): don't use ctype macros (use c-ctype.h)" \
|
|
1>&2; exit 1; } || :
|
|
|
|
sc_prohibit_virBufferAdd_with_string_literal:
|
|
@prohibit='\<virBufferAdd *\([^,]+, *"[^"]' \
|
|
halt='use virBufferAddLit, not virBufferAdd, with a string literal' \
|
|
$(_sc_search_regexp)
|
|
|
|
# Not only do they fail to deal well with ipv6, but the gethostby*
|
|
# functions are also not thread-safe.
|
|
sc_prohibit_gethostby:
|
|
@prohibit='\<gethostby(addr|name2?) *\(' \
|
|
halt='use getaddrinfo, not gethostby*' \
|
|
$(_sc_search_regexp)
|
|
|
|
# We don't use this feature of maint.mk.
|
|
prev_version_file = /dev/null
|
|
|
|
ifeq (0,$(MAKELEVEL))
|
|
_curr_status = .git-module-status
|
|
# The sed filter accommodates those who check out on a commit from which
|
|
# no tag is reachable. In that case, git submodule status prints a "-"
|
|
# in column 1 and does not print a "git describe"-style string after the
|
|
# submodule name. Contrast these:
|
|
# -b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib
|
|
# b653eda3ac4864de205419d9f41eec267cb89eeb .gnulib (v0.0-2286-gb653eda)
|
|
# $ cat .git-module-status
|
|
# b653eda3ac4864de205419d9f41eec267cb89eeb
|
|
_submodule_hash = sed 's/^[ +-]//;s/ .*//'
|
|
_update_required := $(shell \
|
|
actual=$$(git submodule status | grep gnulib | $(_submodule_hash)); \
|
|
stamp="$$($(_submodule_hash) $(_curr_status) 2>/dev/null)"; \
|
|
test "$$stamp" = "$$actual"; echo $$?)
|
|
ifeq (1,$(_update_required))
|
|
$(error gnulib update required; run ./autogen.sh first)
|
|
endif
|
|
endif
|