IF YOU WOULD LIKE TO GET AN ACCOUNT, please write an
email to Administrator. User accounts are meant only to access repo
and report issues and/or generate pull requests.
This is a purpose-specific Git hosting for
BaseALT
projects. Thank you for your understanding!
Только зарегистрированные пользователи имеют доступ к сервису!
Для получения аккаунта, обратитесь к администратору.
We now query the guest status before starting the console to provide
a start button if it's not yet running, but that requires VM.Audit
privileges, so more than just VM.Console on the guest.
So, ignore a `403 Forbidden` response, as that just means we cannot
query the VM info to see if it's running, rather just continue
connecting.
See: https://forum.proxmox.com/threads/116176/
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
[ T: reworked commit message ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
when the vm is stopped and the user clicks on the 'start now' button,
there really is no need for confirmation again
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Starting an already running container results in an sync-error
instead of a task that fails async. So, to have similar behaviour
between VMs and CTs, check any request error for the start command
and silent the 'already running' one.
Put this change in the first downstream patch and rebase the rest of
them
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
it's a minor but annoying issue, and novnc does not release that often,
so backport the patch
also rebases our patches on top
we can drop this with the next novnc release
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
0.5s is a bit long, it feels borderline "slow".
The existing native noVNC menu thingy uses 0.1s for its ease in, but
with only scaling in (compared to moving in) that's feeling weird to,
so settle for 0.2s as middle ground.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this patch adds a check for the guests status, and show a start button
instead of connecting to a non-started guest
this should reduce confusion when a guest is not running, and also
reduce the number of false-positive failed console tasks
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
[ T: re-use existing power symbol, change VM/CT to Guest ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
- patch 16 allows one to hide the fullscreen button
- patch 17 makes the error message dismissable
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
rebase patches for 1.3.0
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
[ T: address gone-wrong rebase and missed push ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
sneak in some cleanups like dropping the manual loading of the
es6-module loader only to remove it again a few patches later
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
We want to deprecate the 'upgrade' parameter in favor of a more
general 'cmd' parameter, which is easier to extend, e.g., for
installing pveceph through the WebUI.
Signed-off-by: Tim Marx <t.marx@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
noVNC logic is this: do not show a local cursor, except when the server
sends it
this cannot happen with qemu (excluding QXL) and so we only ever have
the remote cursor.
since that is sometimes very laggy, add the option to show the local
cursor in addition
this reinstates the old behaviour where the user would (normally)
see two mouse cursors: one remote and one local, but since
this can be configured now, users which do not want this can
turn it off
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch rebases the patches onto the current master and changes some
things:
* show the noVNC settings window/button (but still hide the advanced
options there, since those only contain connection relevant settings)
* decouple the window autoresize somewhat from the 'resize' setting, so
that a user can deactivate that and still have the wanted scaling
(but keep the default behaviour, incl. changing the scaling on
fullscreen change)
* do not use the updateSetings call anymore (since it lost its second
parameter) use forceSetting/initSettings instead
(we have to give the resize parameter in pve-manager for this
to correctly work)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
