Proxmox/proxmox-widget-toolkit
5
0
Fork 0
Code Pull Requests Releases Activity

update store: move store parameter into config, use getter/setter

Browse Source 
this allows to drop setting the default values and ensures that when
interval is updated it actually effects the used update frequency.

Anything which was saved in "me" before, for example me.autoStart, is
still there and gets also updated on a me.setIsStopped(), so there
should be no effects on code using internals.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2020-04-03 08:50:39 +02:00
parent 94f1770488
commit 4a2f360d45
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
data/UpdateStore.js
View File

@ -11,9 +11,13 @@ Ext.define('Proxmox.data.UpdateStore', {
extend: 'Ext.data.Store',
alias: 'store.update',
isStopped: true,
config: {
interval: 3000,
autoStart: false,
isStopped: true,
autoStart: false,
},
destroy: function() {
let me = this;
@ -26,10 +30,6 @@ Ext.define('Proxmox.data.UpdateStore', {
config = config || {};
if (!config.interval) {
config.interval = 3000;
}
if (!config.storeid) {
throw "no storeid specified";
}
@ -37,7 +37,7 @@ Ext.define('Proxmox.data.UpdateStore', {
let load_task = new Ext.util.DelayedTask();
let run_load_task = function() {
if (me.isStopped) {
if (me.getIsStopped()) {
return;
}
@ -45,7 +45,7 @@ Ext.define('Proxmox.data.UpdateStore', {
let start = new Date();
me.load(function() {
let runtime = (new Date()) - start;
let interval = config.interval + runtime*2;
let interval = me.getInterval() + runtime*2;
load_task.delay(interval, run_load_task);
});
} else {
@ -55,12 +55,12 @@ Ext.define('Proxmox.data.UpdateStore', {
Ext.apply(config, {
startUpdate: function() {
me.isStopped = false;
me.setIsStopped(false);
// run_load_task(); this makes problems with chrome
load_task.delay(1, run_load_task);
},
stopUpdate: function() {
me.isStopped = true;
me.setIsStopped(true);
load_task.cancel();
}
});
@ -69,7 +69,7 @@ Ext.define('Proxmox.data.UpdateStore', {
me.load_task = load_task;
if (me.autoStart) {
if (me.getAutoStart()) {
me.startUpdate();
}
}