563 Commits

Author SHA1 Message Date
Thomas Lamprecht
16c0a0b570 Ext.Msg: switch from depreacated msg to message property
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 12:58:50 +01:00
Thomas Lamprecht
4beef5c455 node network: adapt pending changes diff text
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 12:13:09 +01:00
Thomas Lamprecht
03e93db5d5 node network: disable revert button if there are no changes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 12:07:06 +01:00
Thomas Lamprecht
1cf31d6bac node network: add separators in top bar
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 12:06:42 +01:00
Thomas Lamprecht
2877ddea0b ask for confirmation before hot-applying network changes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 12:06:05 +01:00
Dominik Csapak
21cd6c09e2 NetworkView: add apply config button
when the host has ifupdown2 installed, we can hot apply the config
add a button to do this

if the user does not meet the requirements, the api call
will show why and throw an error (without changing anything)

the button has to be enabled via 'showApplyBtn', because for now,
we do not want it for pmg

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-26 10:11:30 +01:00
Dominik Csapak
f32aa3df74 ComboGrid: correctly set/mark multiSelect fields
in fields with 'multiSelect: true', we get an array as value instead
of a string, but a check of !![] results in true (since an array
is an object), so we have to explicitely check for arraylength
in 'setValue' (for correctly showing the trigger) and in the
load handler (to not set an empty field wrongfully to invalid)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-25 18:42:04 +01:00
Dominik Csapak
013cbd6425 fix #2421: ComboGrid: correctly validate multiSelect variant
on multiSelect we have to check the values that is in the values
array, but we get the 'displaystring' in the validator so we
have to get the 'real' value (aka the underlying array of values)
before checking if they are in the store

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-25 18:18:43 +01:00
Thomas Lamprecht
ceca281f92 bump version to 2.0-9
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-20 20:28:16 +01:00
Oguz Bektas
d1dc9b56e7 add reboot for containers into task description table
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-14 12:10:56 +01:00
Tim Marx
35eec238b2 fix comboBox validation when forceSelection is true
Prevent the comboBox from displaying a validation error although
forceSelection is true. If you change a valid selection by removing
characters manually and click somewhere else, the comboBox restores
the selection with the previous value. The validation logic then
checked the restored value, but couldn't find it in the store,
because the store is still filtered with the erroneous query.

We now clear the local filter before the actual check to prevent
this.

[Thomas]:
This was fixed in the 6.2 based GPL release of ExtJS, and can be seen
as backport.

Signed-off-by: Tim Marx <t.marx@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-25 17:43:23 +02:00
Thomas Lamprecht
23446ca9f2 bump version to 2.0-8
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-10 17:05:10 +02:00
Stoiko Ivanov
3e8c6d3c6b add pmx-hint css class
since we need it in PMG as well - pull it here (and independently
refactor pve-manager)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2019-10-09 09:10:33 +02:00
Thomas Lamprecht
dc4f36a2bd utils: sort language_map in code
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-05 13:48:23 +02:00
Aaron Lauterer
13fc756dfd tree-wide trailing whitespace cleanup
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-09-30 08:00:34 +02:00
Dominik Csapak
7c67159cdc add qmreboot task description
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-09-19 13:19:05 +02:00
Dominic Jäger
317eb5611b Add hebrew to list of languages
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2019-09-03 09:04:01 +02:00
Thomas Lamprecht
a24e57bc12 bump version to 2.0-7
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-08-16 12:45:41 +02:00
Thomas Lamprecht
c59a0a3e43 combogrid: fix validation if valueField is different than displayField
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-08-16 12:44:33 +02:00
Thomas Lamprecht
e57e32d5d9 bump version to 2.0-6
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-08-13 16:00:32 +02:00
Dominik Csapak
94953ba8ea ComboGrid: add trigger to delete from ComboGrid
when we have a combogrid that may be empty, we now show a
little 'x' where the user can delete the content

this is not shown when the field is not allowed to be empty

we add a new css for this because triggers need a background image
with a very specific layout:

110x22px which is 5 icons in one image for the various states
(normal, hover, active, focused, focused hover)

the icon is taken from the theme-crisp
form/tag-field-item-close.png but rearranged to fit the size

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-08-13 15:37:26 +02:00
Dominik Csapak
28de30b20e add css and image directory to packaging
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-08-13 15:37:26 +02:00
Thomas Lamprecht
d0af658440 followup code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-25 13:22:42 +02:00
Dominic Jäger
2280ae09a9 Fix #582: Add delay to button
The StdRemoveButton can now pass a delay parameter to the API.
It is set undefined as default so that users of the button
can set the parameter themselves.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2019-07-25 13:20:12 +02:00
Thomas Lamprecht
1ccb53ecdb combogrid: add handling for historic set values currently not available
We can often run into situations where a value set in the past is not
valid anymore. An example could be a deleted network bridge, e.g., we
set the vNIC of a VM to 'vmbr1' but then we decide to obsolete that
and delete that one, one would now expect that the field gets marked
as invalid when editing the VM's vNIC, so add that behavior.

As sometimes this can be valid and wanted behavior (e.g., usb
passthrough, which is hot-pluggable), also add a switch do restore
the old behavior.

Note that the empty value is not handled by this change, we let the
existing "allowBlank" config switch handle that one.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-18 15:55:38 +02:00
Thomas Lamprecht
f59a7b2350 combogrid: always set the initial value, even if not found
as else one lies to the user and only creates strange behavior,
one should see the values even if not there anymore, if this is a
invalid state is left for a later patch.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-17 16:17:59 +02:00
Thomas Lamprecht
ef2235c91a bump version to 2.0-5
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 19:34:00 +02:00
Oguz Bektas
c8b66b2bfd KVComboBox: add setComboItems function
this allows to change the comboItems of a KVComboBox on the run

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-07-11 15:00:14 +02:00
Dominik Csapak
312310e0f2 override Ext.Components 'validIdRe' to include '@'
we use itemIds with '@' already in the ceph dashboard, and in
non-debug modeit works (as expected) but throws an error
while using ext-all-debug.js so override it to include the '@'

the regex was in place because in html4 the 'id' tag could only consist
letters ofthe mentioned regex, this was lifted in html5 though[0]

0: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-11 14:37:24 +02:00
Thomas Lamprecht
227fb07f0c follouwp: code cleanup for render_bond_mode
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-10 12:42:26 +02:00
Thomas Lamprecht
61e428c29d follouwp: code cleanup for bond_mode_array
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-10 12:36:57 +02:00
Dominik Csapak
211bdf934f node network: add Bond Mode and Hash Policy columns
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-10 12:26:54 +02:00
Dominik Csapak
8311c0b1af node network: refactor bond mode array generation
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-10 12:26:54 +02:00
Dominik Csapak
4211996ab0 node network: hide ip and netmask by default
CIDR column displays the same information in only on column,
no need to duplicate the information (by default)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-10 12:26:54 +02:00
Dominik Csapak
8093ded0c3 fix syslog resizing
makes the logview autosize with the window

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-02 13:29:03 +02:00
Thomas Lamprecht
7d0340d701 bump version to 2.0-4
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-28 20:31:07 +02:00
Thomas Lamprecht
1dd799589b network selector: allow to select IP too
not only CIDR.. maybe it could make sense to add a small child class
which  overwrites just the displayField and valueField to address

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 21:51:02 +02:00
Thomas Lamprecht
227159eca2 combogrid: add deleteEmpty and skipEmptyText
Slightly adapted from the proxmox textfield version of this

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 14:21:46 +02:00
Thomas Lamprecht
b69c301a94 textfield: validate after allowBlank 2019-06-27 14:21:17 +02:00
Thomas Lamprecht
a8131b5bce combo grid: add setAllowBlank to help bindings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-26 16:05:56 +02:00
Thomas Lamprecht
3154bb784e use https links to our sites
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-26 16:05:34 +02:00
Thomas Lamprecht
18983bdaa1 bump version to 2.0-3
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-24 17:54:58 +02:00
Dominik Csapak
1098bee4d4 refactor info/link extraction from onlinehelp to utils
so that we can reuse that code for getting links from the docs

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-06-21 15:16:39 +02:00
Thomas Lamprecht
9a8c1d01b6 bump version to 2.0-2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-14 20:48:02 +02:00
Thomas Lamprecht
e6bf8a81ac followup: network selector: refactor cidr6 merge logic
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-12 13:07:32 +02:00
Thomas Lamprecht
ce8c5365c2 followup: network selector: reorder columns and adapt widths
and use format_boolean to render the active column
also hide the type column by default, it often is not too important,
and can be derived from the interface name, e.g., vmbrX -> bridge,
bondX -> bond, etc.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-12 13:03:25 +02:00
Tim Marx
607c37efd1 add network selector widget
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2019-06-12 11:17:44 +02:00
Thomas Lamprecht
f12e1aba6e node/APT: whitespace cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-03 16:38:49 +02:00
Thomas Lamprecht
6895e13f39 node/apt updates: show full package description conditionally
The full package description is often quite long, and for upgrades
it's not relevant most of the time. But, it can be intresting to
have, if one wonders what a package is even used for.
So add a checkbox in the top bar which allows to switch between
showing and hiding the description, simply done by re-using the
'grid-row-body-hidden' ExtJS CSS class (got the idea from the
RowBody feature source code).
Default it to off, as it's better to not overwhelm users here with a
huge pile of text by default, showing the list of package with the
short one line title is enough most of the times, I'd guess.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Tim Marx <t.marx@proxmox.com>
2019-06-03 16:37:57 +02:00
Dominik Csapak
acfbf25527 backport fix for ExtJS pie chart tooltip for 0% entries
this fixes bug EXTJS_18900 where the tooltip of a piechart was always
shown for the first data entry with 0 percent of the pie chart

the relevant lines for the fix are
...
if (a === b) {
    return false;
}
...

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-05-31 10:58:11 +02:00