Commit Graph

486 Commits

Author SHA1 Message Date
Thomas Lamprecht
3f81450686 bump version to 2.4-6
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-03-05 20:22:05 +01:00
Thomas Lamprecht
757a2696e1 edit window: advanced: only show advanced fields on invalid temporary
makes no sense to permanently enable them, that makes for weird
experience.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-03-05 20:18:05 +01:00
Dominik Csapak
bbcc3b3c5c panel/DiskList: return empty text for status on partitions
instead of returning 'unknown'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-03-05 17:15:41 +01:00
Thomas Lamprecht
be3e4b4cb1 task viewer: increase height
500 px still fit nicely in our minimum requirements of "HD ready"
(1280 x 720 px) and for any slightly longer running task the extra
pixel are really nice, I frequently find myself resizing the height
immediately after a task window opens so lets up the default a bit...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-03-05 17:13:37 +01:00
Thomas Lamprecht
2d99e60eea bump version to 2.4-5
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-02-09 14:33:12 +01:00
Dominic Jäger
0174c45815 vlan edit: Match explicit values to name field
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-02-09 13:45:11 +01:00
Dominic Jäger
705f92a1e4 vlan edit: Set valid default name
Using find_next_iface_id we get a valid VLAN name.
This way, inserting a vlan raw device is still required (but everything that is
inserted so far is valid).

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-02-09 13:45:11 +01:00
Dominic Jäger
4ed84281a2 vlan edit: Move example from default value to tooltip
We usually choose default values that are valid input for the field.
interfaceX.1 is rejected by the API.

Instead, use a tooltip to demonstrate possible valid inputs for the field.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-02-09 13:45:11 +01:00
Dominic Jäger
418ec858aa vlan edit: Forbid blank vlan raw device
Users certainly have to insert a vlan raw device when the textfield is enabled.
Currently, they only see `invalid network interface name "` when submitting.
Forbidding the blank field shows the problem earlier.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-02-09 13:45:11 +01:00
Dominic Jäger
7bff067a38 vlan edit: Fix automatic field disabling
The regex are are created as literals (with // and not new RegExp).
Therefore
 - The old Vlan_match value with double \\  has matched e.g. vlan\ddd instead
   of e.g. vlan123 and
 - the old VlanInterface_match value with double \\ has matched e.g.
   \www\X\dddd instead of e.g. vmbr0.1234

This fixes automatically disabling the fields vlan-raw-device and vlan-id (VLAN
tag) in the VLAN edit window.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-02-09 13:45:11 +01:00
Fabian Ebner
98edb91665 move DiskList.js from grid/ to panel/
because it's a treepanel now.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-02-09 12:01:24 +01:00
Fabian Ebner
d9e5b6711e convert disk list to disk tree and conditionally include partitions
Assigning the store directly to the treepanel doesn't work, more manual
handling is needed. This is mostly based on what we do for PBS's datastore
content view. The store monitoring also needs to be changed slightly.

The buttons are restricted to work on disks only, based on the parent
attribute, that only partitions have.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-02-09 12:01:24 +01:00
Fabian Ebner
fef397f558 prune panel: make keep-last label text like the others
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-01-26 18:54:49 +01:00
Dominic Jäger
bcc48f062c input panel: Add drawing of layout
The drawing makes clear in a few seconds:
 - what columnT and columnB stand for
 - what additional containers and panels are created
 - to which of those the elements of column1, column2... go to

When you're in the JS debugger and lost overview of where in this
element hierarchy you are, you can quickly check xtype + layout. Then
consulting this drawing solves the mistery.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-01-26 18:54:49 +01:00
Dominik Csapak
0753b980c8 fix usage of findRecord
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensiti
and an exactmatch (we never want the default behaviour afaics).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-01-26 18:54:18 +01:00
Dominik Csapak
938a7b9f55 grid/DiskList: restore info about ceph
previously we printed this ceph info, but it got lost during
refactoring to widget-toolkit, restore a slightly modified
version of the code

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-01-26 18:53:32 +01:00
Thomas Lamprecht
74ecb4118d bump version to 2.4-4
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-15 16:24:12 +01:00
Thomas Lamprecht
fe8855e032 reader: JsonObject: cope with empty (null) return value
there may be cases where the backend serialization plumping code
makes it easier to return null instead of a emtpy object if a
(sub)property or whole config is not configured, as it's closer to
the truth (not configured == null, configured but empty would be {})

For objects this resulted in a exception, as the null value was tried
to be dereferenced, avoid that by defaulting to an empty object in
that case.
For arrays we already coped with that by luck, make that more
explicit to avoid future breakage.

Both result to a empty array being returned as values, which means
empty store and is deemed to be OK in that case.

The rowdef.required still applies and adds empty values though, this
could be argued to not be really fitting - for now lets keep it that
way, we could make this opt-in though if it shows that it is not
always correct.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-15 16:21:45 +01:00
Thomas Lamprecht
bf51bc492f reader: JsonObject: whitespace fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-15 16:17:35 +01:00
Dominic Jäger
0915cbb1fe ui: network: Remove bond-primary gettext
The corresponding option  in /etc/network/interfaces is exactly "bond-primary".
Translating this might easily make unclear what is meant.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-01-12 11:40:21 +01:00
Thomas Lamprecht
f8c424ef80 bump version to 2.4-3
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 18:46:09 +01:00
Thomas Lamprecht
9de5e64e53 prune panel: allow to pass emptyText for keep-last
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 18:17:53 +01:00
Thomas Lamprecht
bdabc5633f prune field: use dirtychange event to hide/show clear-trigger
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 18:17:23 +01:00
Thomas Lamprecht
455f5fe5ed input panel: support convenience top column
mirrors columnB (column bottom) but is placed on the top, i.e.,
columnT.

One can no conveniently set the following layout:

  +-------------------------------------+
  |                                     |
  |               columnT               |
  |                                     |
  +------------------+------------------+
  |                  |                  |
  |                  |                  |
  |   column1        |   column2        |
  |                  |                  |
  |                  |                  |
  +------------------+------------------+
  |                                     |
  |               columnB               |
  |                                     |
  +-------------------------------------+

(4 columns should work too, but we do not use that anywhere FWICT)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 13:19:27 +01:00
Thomas Lamprecht
9150498ca3 bump version to 2.4-2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 08:14:55 +01:00
Thomas Lamprecht
914070be3e fixup prune field usage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 08:08:12 +01:00
Thomas Lamprecht
1268e9fbe9 bump version to 2.4-1
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 18:12:59 +01:00
Thomas Lamprecht
abbb481864 css: unify button icon font-size to 14px
in a central place, we already have some of those set in pve or pbs
css

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 18:12:59 +01:00
Thomas Lamprecht
8969bdadf6 edit window: url is optional if both loadUrl and submitUrl are set
but it cannot be the default identityFn in that case..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:03:18 +01:00
Thomas Lamprecht
8b1217145c edit window: add loadUrl to config
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:03:18 +01:00
Thomas Lamprecht
4d07ee6cb9 edit window: add submitUrl config
Helps for those cases where the id is in the API path itself.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:03:18 +01:00
Thomas Lamprecht
9beeadc77a input panel: make advanced column check more flexible
allow that any of the three column/docked definitions can be set,
without setting the first one to an empty array to go in that if
branch.

Note, column2 works fine, but I did not greatly test a sole
advancedColumnB definition, so there may be still some improvements
for fixes - but at that point the user could also use advancedItems
to have full control.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:03:18 +01:00
Thomas Lamprecht
03ea6d7971 toolkit: drop old jslint control comments
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:03:18 +01:00
Thomas Lamprecht
04eb02d970 panel: add PruneInputPanel
over from PBS

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:02:50 +01:00
Thomas Lamprecht
9b4b2e745b form: add PruneKeepField
over from PBS

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:02:45 +01:00
Aaron Lauterer
71a084c2ff InputPanel: remove old code for useFieldContainer
`useFieldContainer` doesn't seem to be used anymore in any of our
products:
* PVE
* PMG
* PBS

it therefore can be considered dead code.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-11-19 12:39:00 +01:00
Aaron Lauterer
71d5316545 InputPanel: fix column scaling behavior
When scaling the browsers content either via the browser itself or
because the OS has a different scaling / DPI setting, it can happen that
not all columns have enough space next to each other and thus the last
column is moved further below.

This happens especially on chromium bases browsers (e.g. chrome, edge).

Changing the layout to use extjs HBOXes with flex instead of columns
solves works well.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-11-19 12:39:00 +01:00
Thomas Lamprecht
2622cc7cca buildsys: add lint incremental mode, use stricter check mode for full build
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-12 10:10:19 +01:00
Thomas Lamprecht
a19ccbb9cd bump version to 2.3-10
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-10 16:29:15 +01:00
Thomas Lamprecht
63ec56e5bc utils: get help info: fix normalization with multiple minuses
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-10 16:27:43 +01:00
Thomas Lamprecht
1f905769b1 Revert "Utils: fix help section normalization"
replaceAll is not supported by all browser we try to guarantee to
support.

This reverts commit f7b816a399.
2020-11-10 16:26:27 +01:00
Thomas Lamprecht
4b21b8cc8e bump version to 2.3-9
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-10 12:09:02 +01:00
Aaron Lauterer
f7b816a399 Utils: fix help section normalization
We need to replace all occurences when normalizing underscores or
dashes.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-11-10 11:53:29 +01:00
Dominik Csapak
5efbff97f8 comboGrid: set errorMask on store load failure
if there occured an error in the api call of the store, show this error
on the picker when opened, instead of just showing an empty picker

this makes it possible to see that there was an error while accessing the api

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-09 08:01:11 +01:00
Thomas Lamprecht
6fb81c1519 enable ARIA again
we have everything updated to ExtJS 6.x since quite a bit, and some
quick checks on various components did not show any error - lets
enable this again.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-09 07:56:42 +01:00
Thomas Lamprecht
58c180044a bump version to 2.3-8
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-03 17:52:09 +01:00
Thomas Lamprecht
20bf242648 Revert "css: avoid inherit of font-size on .fa class, set to 14px"
this is not yet safe everywhere, makes some dashboard icons quite
small

This reverts commit 96ffa5693e.
2020-11-03 17:51:12 +01:00
Thomas Lamprecht
2c0a748f42 task type selector: add clear trigger
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-03 14:41:43 +01:00
Dominik Csapak
3571d71343 Utils: remove product specific task descriptions
we use 'override_task_descriptions' in the specific products to
add the ones that are not used everywhere

took the chance and sorted the remaining alphabetically

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-03 12:40:45 +01:00
Thomas Lamprecht
96ffa5693e css: avoid inherit of font-size on .fa class, set to 14px
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-03 12:40:14 +01:00