2696 Commits

Author SHA1 Message Date
Thomas Lamprecht
43d65515e0 ui/sdn: better spelling and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-22 15:06:45 +02:00
Thomas Lamprecht
dfa5cb77ed ui: node: lower statusStore interval outside of summary panel
We normally only use that information for the nodes power management
buttons, only the Summary panel profits from more frequent updates
(due to the uptime, and resource usage graphs).
So use 5s interval in general and switch to 1s for the summary panel
only.

This also fixes a bug where the node-config panel owned store got
stopped by mistake if the summary panel, which shared the use of that
store, was "destroyed" (left).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-09 17:06:52 +02:00
Thomas Lamprecht
231394dd17 ui: call more update store functions in the store scope
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-09 16:45:22 +02:00
Thomas Lamprecht
6d27374f71 ui: node/config: use simply boolean expression for powermngt check
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-03 07:01:25 +02:00
Thomas Lamprecht
a1a73865e0 ui: cleanups and some s/var/let/ transformations
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-02 14:15:16 +02:00
Thomas Lamprecht
e475a7788c ui: ceph/ServiceList: do not autoLoad the rstore
The 'autoStart' triggers a initial load already

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-02 12:48:15 +02:00
Dominik Csapak
1c416fbdec ui: ceph/ServiceList: do not autoLoad the updatestore
they load once anyway with 'autoStart'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-02 11:10:51 +02:00
Dominik Csapak
0f61838046 ui: ceph/ServiceList: stop leaky versionsstores
on the view destroy we have to stop the updatestore again,
they do not get cleaned up by a destroy because until they are stopped
the have a reference on themselves, which prevent a garbage collection

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-02 11:10:48 +02:00
Dominik Csapak
69d7d3f843 ui: ceph/ServiceList: correctly set 'mixedversions'
We need to set mixedversions also if
data.version.parts < view.maxversion
so lets do that.

This avoids a bug when the first version in the list already is the
highest one.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-02 09:00:03 +02:00
Stefan Reiter
63d5fd6f50 gui/cluster: fix translation for cluster join button
New version including the cluster name didn't work in some languages,
e.g. german: "Beitreten 'cluster'" vs the correct "'cluster' beitreten"

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-04-01 18:57:56 +02:00
Thomas Lamprecht
cb8dd773ab ui: ceph: use displayfield with tooltip for overview version
And drop the git shorthash for now, albeit we could add it to the
tooltip..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-01 18:39:08 +02:00
Dominik Csapak
480a09aee4 gui: ceph: add highest cluster version in summary
so that the admin knows what the 'expected' ceph version is
partially fixes #2468

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-01 17:15:41 +02:00
Dominik Csapak
d3d31fef34 gui: ceph: icons for versions in ServiceList
this makes it closer to the OSD list, using the new 'version-only'
metadata api call

this partially fixes #2468

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-01 17:15:41 +02:00
Dominik Csapak
6de110a95f gui: ceph: let compare_ceph_versions accept arrays directly
instead of always expecting a '.' separated version string
we will use this for the 'structured' version data

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-01 17:15:41 +02:00
Thomas Lamprecht
4901c4a15a ui: fix optionview caps
there's no caps.dc['Sys.Modify'] in our heuristic caps-for-frontend
and the === undefined check was wrong

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-01 17:14:42 +02:00
Thomas Lamprecht
d41b681815 ui: user edit: use new pmxExpireDate field
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-01 17:14:42 +02:00
Thomas Lamprecht
6bd3ef9a1d drop Makefile.rej rebase/am left over
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-31 18:07:33 +02:00
Thomas Lamprecht
15d21d66f6 ui: rng edit: drop useless gettext for integer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-31 18:05:27 +02:00
Thomas Lamprecht
09fdd51fd9 ui: cluster join: trigger defered call to full reload earlier
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-26 16:16:21 +01:00
Thomas Lamprecht
3c18c32eac followup sdn: move a bit below and fix showing on initial load
if the webinterface got loaded the api call to check if SDN is
available did not yet returned, so we could show it by accident -
even if libpve-network-perl wasn't instralled.
Fix that by hiding it (once) in the failure callback of the API call.

also move menu entries below, before Firewall, this fits better to
networking.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-26 15:21:13 +01:00
Alexandre Derumier
a2acde2586 add sdn icons
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-26 12:17:53 +01:00
Alexandre Derumier
db9a78c0b3 sdn: enable SDN menu if /cluster/sdn api exist
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-03-23 14:43:29 +01:00
Alexandre Derumier
d8ffcb9333 add sdn gui
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-03-23 14:43:26 +01:00
Thomas Lamprecht
0cd44a69cf ui: let grid column filter symbol float right
So it has a more fixed position, independent of the column header
length. Also, this brings it nearer to the button where one can
adapt/turn off filters.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-07 19:04:22 +01:00
Thomas Lamprecht
f1045ce4d3 css: move smilar filter rules closer together
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-07 19:03:50 +01:00
Dominik Csapak
65787bf08e gui: make grid column filter more obvious
by adding the icon 'fa-filter' (see fontawesome.css) after the column header
and making it slightly darker than the text

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-03-07 18:50:36 +01:00
Thomas Lamprecht
5a320e34cb ui: dc/options: add max_workers setting
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:42:16 +01:00
Thomas Lamprecht
3281e50383 ui dc/options: refactor render_bwlimits
while this /could/ (not benched marked in any way) be slower it
operates on so small data sets that this isn't worth it having double
the code lines.

A map + join is still quite readable and not yet "code golfy"

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:19:12 +01:00
Thomas Lamprecht
a077d43baa ui dc/options: add trailing commas
just to avoid making those lines dirty again in a future property
addition..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:16:32 +01:00
Stefan Reiter
0ce7cbe9ab fix #2611: gui: use backendUnit and pretty renderer
Slightly confusing with the units:
* Backend stores values in KiB/s
* Frontend displays MiB/s (which is a good choice when considering
  current generation network speeds as opposed to huge KiB numbers IMO)
* Renderer previously showed no units, which would usually be interpreted
  as Bytes/s

So add a pretty renderer that shows units and set backendUnit to submit
correctly converted values.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-03-06 19:56:49 +01:00
Dietmar Maurer
0f31a2a2f9 ui: ContentView: consider new ctime value
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 19:05:28 +01:00
Stefan Reiter
a0fbcd83b3 qemu: change virtio-rng icon to die
'die' as in 'dice', not what Perl does

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-03-06 18:19:39 +01:00
Stefan Reiter
46af2bed06 qemu: add virtio-rng option to GUI
Warn the user when selecting /dev/random or disabling speed limits.

'hardware_counts' is used since technically more than one RNG could be
attached to a QEMU machine. It is limited to 1 however, since the
usefulness of such a setup is more than questionable, considering the
linux kernel only ever uses one hwrng at a time anyway.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-03-06 18:19:39 +01:00
Stefan Reiter
9da0d3d573 qemu: fix icon alignment in "Add Hardware" menu
It was ever so slightly off.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-03-06 18:19:39 +01:00
Thomas Lamprecht
7d673a026e ui: add date column in per-guest backup archive panel
Similar to commit f8211903de77e7e7f0959aeb10143f8a3129410b which
added this column to the storage content grid let's also add it here.
As we also base off the 'pve-storage-content' it's just a matter of
copying over the column definition 1:1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-02-21 16:36:50 +01:00
Dietmar Maurer
15a992c217 storage content GUI: improve detection of backup volumes
Include new proxmox backup server volumes.
2020-02-19 14:02:05 +01:00
Stefan Reiter
a56498448d gui: pci passthrough: fix 'Add PCI' dialog for new devices
Commit 6033f465b8 (gui: pci passthrough: consider domain in PCISelector)
used 'values.host' without checking if it's set, resulting in an error
when the dialog was opened for a new device (where values.host is
undefined).

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-02-17 15:34:38 +01:00
Stefan Reiter
53d248599b gui/cluster: show all links (up to 8) in cluster overview
Show only links found on the cluster.

'enableColumnHide' is set to false, since it causes confusing behaviour
for the user, considering we'd overwrite part of their choices every 5
seconds.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-02-13 09:52:10 +01:00
Dominik Csapak
2de4c3bd34 gui: form/ControllerSelector: fix autoselection
changing from Ext.Array.each to a for loop and changing the return
to a 'break', resulted in exiting the wrong loop (previously the outer,
now the inner) resulting in wrongly looping through all controllers
instead of only until we found a match

using a label and labeled break, we can break the outer loop

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-02-12 12:34:53 +01:00
Dominik Csapak
cd4dde8d5c gui: dc/Summary: improve dashboard storage calculation
if no storage is selected in 'My Settings' our calculatin was done as follows:
* for every node, count 'local',
* every other storage gets only counted *once*, even if it is a local storage

as we have the 'shared' flag available, we can count local storages
for every node where they are defined which results in a storage total
calculation:
sum of all local storages on all nodes + all shared storages once

should make a better overview of storage for a cluster with local storages

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-02-12 12:03:03 +01:00
Dominik Csapak
987f4acf29 gui: dc/TFAEdit: show an error message if tfa api call fails
setting the loadmask did not really work, so show a messagebox instead
and close the window

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-02-11 18:51:28 +01:00
Dominik Csapak
0cc92e1ded gui: TFAEdit: use viemodel binding for hiding/showing qr code
the verification textfield, and the selected tab.

also remove the code that used the value by the userview panel, since
this is the only way to have a consistent behaviour on the userview
setting and the usermenu tfa setting

this fixes the issue that on the 'user menu' we accidentally showed
the qr code and verification field, even if the user already had a
totp code

now it shows 'Unchanged' like when opened via dc/UserView

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-02-11 18:51:28 +01:00
Thomas Lamprecht
6513e2c49b ui: lxc/network: fix initial empty text on edit
Editing an existing interface with DHCP set showed the emptyText
"None", which is confusing (and wrong)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-02-10 16:34:47 +01:00
Dominik Csapak
8695c8b85d gui: lxc/Network: add 'None' EmptyText for static mode
this way it is more clear that leaving that field empty results in
no configured ip for that interface, this may help prevent
users to select 'dhcp' for e.g. ipv6 when they do not want an ipv6
and do not have a dhcp6 server in the network (which would result
in a long boot time of the container, because of the dhcp timeout)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-02-10 16:27:20 +01:00
Dominik Csapak
cd8a8890c8 gui: lxc/Network: remove trailing whitespace
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-02-10 11:16:32 +01:00
Thomas Lamprecht
93da209eeb ui: snapshots: move hint to bottom and make it shorter
Moving it to the bottom of the dialog avoids other UI elements
jumping around when it gets displayed.

Further shorten the text itself, while the originally was good it was
a bit on the long side, users tend to overead to long warnings/hints
more easily, so try to be more terse.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-02-06 22:39:25 +01:00
Fabian Ebner
1b360fa885 Warn about file system state when a freeze would be needed, but isn't possible
If a snapshot of a running VM is taken and the RAM is not included, the backend
checks whether the QEMU Guest Agent is running inside the VM. If it is, it freezes
the file system, otherwise the snapshot is taken without freezing, which
could lead to an inconsistent file system state in the snapshot.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-02-06 22:31:39 +01:00
Fabian Ebner
2425a0237d Hide 'Include RAM' when VM isn't running
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-02-06 22:31:39 +01:00
Fabian Ebner
09262250a4 Use 'isCreate' instead of 'snapname' to determine window layout
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-02-06 22:31:39 +01:00
Fabian Ebner
3de56f0882 Fix error message
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-02-06 22:31:39 +01:00