5321 Commits

Author SHA1 Message Date
Fabian Grünbichler
ac527c6f84 replication: target is a required parameter
no need to check for definedness

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-08-20 13:47:21 +02:00
Fabian Grünbichler
6f0b90ae14 replication: refactor source checks on job creation
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-08-20 13:47:21 +02:00
Thomas Lamprecht
6b60218af9 api: ACME revoke: do not abort if CA is just expired
Else, a user would need to renew it first before being able to revoke
it, which does not make much sense..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-08-19 18:52:48 +02:00
Thomas Lamprecht
12f089b5de api: ACME renew: handle error from revoking old cert gracefully
this normally just means that the old cert is already expired, we do
not care for that - after all: we got a new (renewed) valid cert
successfully.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-08-19 18:49:20 +02:00
Thomas Lamprecht
96adad96dd ui: fix PBS edit typos
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-08-19 15:48:51 +02:00
Thomas Lamprecht
769b3236fc ui: fixup gettext quoting
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-08-18 18:27:43 +02:00
Fabian Grünbichler
e7dc440222 test: fix mail_test for non-root user
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-08-13 12:54:51 +02:00
Fabian Ebner
30b6ae310e Set source when creating a new replication job
If source is missing, pvesr will set it via job_status
on the next run. But the info is already present here,
so it doesn't hurt to use it.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-08-11 13:54:21 +02:00
Dominik Csapak
f9f2aaaec2 ui: filter on exact vmid
so that backups of vmid 1000 do not show up on vm 100 with 'filte vmid'
enabled

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-08-11 13:48:19 +02:00
Aaron Lauterer
8deb25a63f backup: fix #2913 order jobs numerically by VMID
At this point, the VMIDs are already numerically sorted by the
PVE::VZDump::check_vmids method. Calling another sort on the array,
especially without `{$a <=> $b}`, resulted in reordering the array
alphabetically.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-08-11 13:48:19 +02:00
Fabian Grünbichler
e5313cb092 vzdump: use configured tmpdir for PBS
instead of always using the default hard-coded one.

otherwise, suspend mode container backups might run out of space even though the admin configured a big enough tmpdir.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-08-06 16:03:05 +02:00
Hannes Laimer
89416582f3 ui: Close #2908: fixed password validator for adding PBS as storage
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
2020-08-03 08:08:08 +02:00
Fabian Grünbichler
4568bc58ac fix #2890: also detect & renew DNS-only ACME certs
this call site was apparently missed when we refactored the node config
/ ACME interaction.

Suggested/Reported-by: Frédéric Bourqui
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-07-27 10:53:32 +02:00
Thomas Lamprecht
22fb49838a bump version to 6.2-11
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-24 19:31:31 +02:00
Thomas Lamprecht
4a99d7df53 followup: use true as inputValue
and normalize original value comparison, just to be sure.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-24 19:31:31 +02:00
Thomas Lamprecht
e60959f99d ui: Proxmox Backup: allow to autogenerate an encryption key
a bit more complicated than wished, but if we want to have at least a
bsaic OK user experience we need to give good feedback that the key
will be deleted.

We definitively want to extend this, allow uploading their own,
export if root@pam, only move not delete on "removal", for safety.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-24 19:17:50 +02:00
Thomas Lamprecht
884ba424ea ui: node/services: use safer reload as restart command
avoids service interruptions

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-24 15:24:02 +02:00
Thomas Lamprecht
9f0a47d9c3 api/services: fallback to restart in reload
And document that it is preferred

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-24 15:24:02 +02:00
Thomas Lamprecht
cae3d32732 api/services: improve essential service check, allow reload and start
reload is actually preferred, and even if most of the time this even
won't reach the API, allowing to start them is still definitively
fine!

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-24 15:24:02 +02:00
Thomas Lamprecht
e22c173089 api/services: whitespace cleanup, modern closure call
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-24 15:24:02 +02:00
Thomas Lamprecht
5c92823160 ui: node: eslint and style fixes
xtype must be the first definition

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-24 15:24:02 +02:00
Alwin Antreich
15948f7dd3 Allow setting device class on osd create
In some situations Ceph's auto-detection doesn't recognize the device
class correctly. The option allows to set it directly on osd create,
instead of altering it afterwards. This way the cluster doesn't need to
shift data back and forth unnecessarily.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2020-07-24 10:26:11 +02:00
Thomas Lamprecht
b01637f82d ui: running chart: assign getTime directly
no sense in doing it everywhere the Date variables are used, if it's
the only  thing we do on them.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:35:07 +02:00
Thomas Lamprecht
cb91ab464f ui: ceph status/running chart: disable trackRemoved
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:30:51 +02:00
Thomas Lamprecht
82e579d27c ui: running chart: avoid breakage if tooltip was on deleted record
if we cleanup records and there was a "stale" tooltip on one of them
we get an access on undefined value exception here

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:29:06 +02:00
Thomas Lamprecht
486e7af640 ui: comment length cleanup to improve readability
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:27:45 +02:00
Thomas Lamprecht
44fa87a0ab ui: ceph status: note that its recovery/rebalance#
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-21 19:49:52 +02:00
Dominik Csapak
b4943e8995 ui: add ceph recovery graph and progressbar
shows a runningChart (like for reads) for the recovery speed
also shows a progressbar of the health percentage of the cluster
with an estimate of how long the recovery might need
(unhealthy objects) / (objects per second)

only show them when a recovery is ongoing or there are unhealthy
objects

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-07-21 16:30:43 +02:00
Thomas Lamprecht
a47b6c21fe buildsys: www/manager: all target needs to be first one
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-20 16:34:31 +02:00
Thomas Lamprecht
a20769ed74 bump version to 6.2-10
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-14 10:28:44 +02:00
Stoiko Ivanov
b3dec633d0 VZDump: add TARFILE to environment for hookscripts
The renaming of tarfile to target in 848cf539e59b4553559b9ff3207a3c5556dc1cc0
can break existing vzdump hook scripts of users.
by setting the TARFILE variable in addition to TARGET the scripts will continue
to work.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2020-07-14 10:27:18 +02:00
Stoiko Ivanov
eecf466937 vzdump-hook-script: rename TARFILE to TARGET
with the change introduced in 848cf539e59b4553559b9ff3207a3c5556dc1cc0 the
exported variable name changed from tarfile to target.

this patch reflects the renaming in the example hook script.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2020-07-14 10:27:18 +02:00
Thomas Lamprecht
6c8cb5130e vzdump: use more general 'guest' instead of 'vm'
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-14 10:26:50 +02:00
Thomas Lamprecht
1a9a974219 vzdump: render a duration of 0s as <1s
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-14 10:26:14 +02:00
Aaron Lauterer
74b0304ac0 ui: not backed: add emptyText to search field
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-07-13 12:27:23 +02:00
Thomas Lamprecht
0ced4b148e ui: storage selector: improve handling PBS special case
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-10 08:13:08 +02:00
Thomas Lamprecht
4d363c5bb2 bump version to 6.2-9
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-09 20:12:16 +02:00
Thomas Lamprecht
174b75e28a ui: storage: adapt pbs hint sligtly
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-09 20:09:51 +02:00
Thomas Lamprecht
05a002764f ui: backup now: disable compression field for PBS storage
a bit hacky but well..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-09 20:04:52 +02:00
Thomas Lamprecht
cd1f2ee061 ui: backup detail: rename button to "Job Detail"
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-09 20:04:32 +02:00
Thomas Lamprecht
ec7f020143 ui: backup detail: some small nits + padding adation
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-09 20:04:04 +02:00
Thomas Lamprecht
4a24405db4 ui: backup detail: move search bar in panel header to save vspace
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-09 20:02:55 +02:00
Aaron Lauterer
d62260b86e fix #2609 gui: backup: add window for not backed guests
In case that there are guests which are not covered by any backup job, a
notification is shown and a window with a grid can be opened to view
these guests.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-07-09 14:12:59 +02:00
Aaron Lauterer
51e9270184 fix #2609 api: backupinfo: add non job specific endpoint
Adds a new api endpoint at cluster/backupinfo for cluster wide backup
stuff. This is necessary because cluster/backup expects a backup job ID
at the next level and thus other endpoints are hard to impossible to
implement under that hierarchy.

The only api endpoint available for now is the `not_backed_up` which
returns a list of all guests which are not covered by any backup job.

The top level index endpoint is left unsused for now to be available for
a more generic summary endpoint in the future.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-07-09 14:12:59 +02:00
Aaron Lauterer
bf3bcd103f gui: dc/backup: add new backup job detail view
The new detail view for backup jobs shows the settings similar to the
edit dialog but read only. Additionally it does show a list of all
included guests with their volumes and whether these volumes will be
included in the backup.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-07-09 14:12:59 +02:00
Aaron Lauterer
3e6eab2ae3 gui: dc/backup: move renderers to Utils.js
Moving the following renderers to Utils.js to be able to use them in
more than one place:
* render_backup_days_of_week
* render_backup_selection

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-07-09 14:12:59 +02:00
Aaron Lauterer
ad08468b43 api: backup: add endpoint to list included guests and volumes
This patch adds a new API endpoint that returns a list of included
guests, their volumes and whether they are included in a backup.

The output is formatted to be used with the extJS tree panel.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-07-09 14:12:59 +02:00
Aaron Lauterer
597bc2b007 vzdump: included_guest: return empty hash if no guests selected
This will fix the behaviour when calling `vzdump --stop` to cause all
local guests to be backed up.

When refactoring this logic in commit be308647, the assumption was that
every call will have one of the following parameters set: pool, list of
VMIDs or all (intentional or when exclude is used).

There is an addtional possibility, that vzdump is called with only
--stop. Thus there are no other parameters that would indicate which
VMIDs to include.

In this case we want to return the empty hash.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-07-09 13:30:47 +02:00
Thomas Lamprecht
f257f54d48 ui: storage: add beta hint to PBS panel
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-08 14:55:17 +02:00
Thomas Lamprecht
76a03ccbd4 backup: update job: add missing permission description
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-08 13:53:57 +02:00