5321 Commits

Author SHA1 Message Date
Dominik Csapak
6f2e578024 ui: add ability to show and edit comments for backups
for now we filter out pbs storages

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-24 13:47:07 +01:00
Dominik Csapak
5e8f8fa3dc ui: change comment column to notes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-24 13:47:07 +01:00
Thomas Lamprecht
64af01261f followup code cleanup
actually cleaning up the initial state, the last patch was OK as is..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-24 13:38:52 +01:00
Dominic Jäger
8b39216c17 storage: base edit: Don't send delete during creation
... as this is now allowed by the API (createSchema() in PVE::SectionConfig).
It is only allowed by the update API call (updateSchema()).

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2020-11-24 13:23:40 +01:00
Dylan Whyte
4809d5c5bd UI: Ceph Wizard: language fixup
Improve the language found in the ceph install Wizard.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
2020-11-24 12:10:02 +01:00
Thomas Lamprecht
1a4d651b88 ui: wizard: fix ceph docs link
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-24 09:27:18 +01:00
Thomas Lamprecht
2ae2d45cd7 ui: avoid ||=
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 20:12:56 +01:00
Thomas Lamprecht
ad114987a9 bump version to 6.2-16
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 19:35:42 +01:00
Thomas Lamprecht
d5da205c88 ui: storage: pbs: add hint for backup retention
Normally it's better to configure pruning (backup retention) on the
backup server only, as then multiple client settings may not
interfere with each other due to outdated or to strict prune
settings (remember, the strictest prune setting always wins).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 19:33:02 +01:00
Thomas Lamprecht
f0f4b8385d storage: drop max backup fields, replaced by pruning
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 19:33:02 +01:00
Thomas Lamprecht
261ef3f6ff storage: base edit: add Backup Retention tab
Support all prune keep- settings we have.

masked if the storage cannot support backups.

We do not care if it is disabled as content type for now, a user can
just set them nonetheless (could show a hint though).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 19:33:02 +01:00
Thomas Lamprecht
c9d802e858 storage: base edit: move main inputpanel into tab panel
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 19:13:18 +01:00
Thomas Lamprecht
80cfe27041 ui: storage base panel: cope with undefined column2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 19:13:18 +01:00
Thomas Lamprecht
3e0e1478c9 d/control: bump versioned dependency of libpve-storage-perl 6.2-11
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 16:04:12 +01:00
Fabian Ebner
a76885903c cleanup keep-all handling
If keep-all is set to 0, adding it doesn't make a difference,
if the key is not in the hash, it won't show up in the 'values'.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-11-23 16:03:08 +01:00
Fabian Ebner
7806065d78 vzdump: adapt to new keep-all prune option
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-11-23 16:03:08 +01:00
Thomas Lamprecht
e8a66c818a ui: snapshot tree: add separator between rollback and edit button
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 14:00:07 +01:00
Moayad Almalat
f0c82f0f01 close #3114: ui: snapshots: switch Edit and Remove Button & add warning logo
Signed-off-by: Moayad Almalat <m.almalat@proxmox.com>
2020-11-23 13:57:40 +01:00
Thomas Lamprecht
6bcc29f971 pveceph: update octopus repository
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-23 12:01:52 +01:00
Thomas Lamprecht
2bc6f69610 ui: ceph install wizard: fix indentation
Hi to the people from the future which came here due to git blame or
the like. `git show -w` should proof that you got the wrong one.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 18:51:21 +01:00
Fabian Ebner
dc1d16e23c ui: make remaining content views not stateful
Commit c2b949f05bb8942b4827df4aeec91e10e09c1b2f removed the statefulness from
the other storage content views, so remove it from the remaining ones too.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-11-22 18:39:16 +01:00
Fabian Ebner
fea44a06ec ui: storage: get content types from resources
to avoid waiting for a status API call.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-11-22 18:39:16 +01:00
Fabian Ebner
903e8ace45 cluster resources: include content type for storages
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-11-22 18:39:16 +01:00
Thomas Lamprecht
09b9073a62 ui: ceph install mask: avoid showing version
we do not know yet which version will get installed for real, so just
drop that part.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 17:59:36 +01:00
Thomas Lamprecht
7910cb9829 ui: ceph: allow selecting which version to install
Try to find out the newest version in the cluster and select that (if
in the known OK list).

Slightly hacky, but nothing really out of the ordinary, so should be
OK.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 17:59:36 +01:00
Thomas Lamprecht
4710634b2c ui: ceph wizard: move out info panel to separate component
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 17:59:36 +01:00
Thomas Lamprecht
a1e5819bc2 ceph: do not require allow-experimental flag for octopus anymore
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 17:59:36 +01:00
Thomas Lamprecht
c5027524ca ui: console: add beforeLoad callback
we sometimes need to adapt parameters, but in a lot contexts the
component is already created, and the activate event order of
components may make this hard to do in a deterministic way.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 17:59:36 +01:00
Thomas Lamprecht
8f49acaca1 api: nodes: allow root to pass arbitrary arguments to commands
If the command itself allows it, which normally means it has good
verification of passed arguments.

We may want to re-evaluate security here if we allow execution for a
group of non-root users.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 17:59:36 +01:00
Thomas Lamprecht
cf485f2a36 api: cluster/ceph: allow version metadata call on non-ceph nodes
the information comes only from the key value store in the pmxcfs, so
we do not actually require ceph to be installed.

So only check if ceph is locally initialized and create the rados
connection after the early return when only versions scope is set.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 17:59:36 +01:00
Thomas Lamprecht
2a5d20c843 ceph services: cleanup variable names
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 17:59:36 +01:00
Thomas Lamprecht
9e6ce53915 ui: lxc: code cleanup ssh key upload
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-22 10:22:10 +01:00
Thomas Lamprecht
c23d74d32d ui: metrics: set default for port
while it may not be always correct, we can only win by setting a
reasonable default, taken from

* graphite:
  https://graphite.readthedocs.io/en/stable/feeding-carbon.html#the-plaintext-protocol
* influxdb, udp port:
  https://docs.influxdata.com/influxdb/v1.8/administration/ports/

Also, changing that is easy for the admin and can always be done
afterwards.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:55:15 +01:00
Thomas Lamprecht
37b4b9cfab ui: metrics: move server and port on same line
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:55:04 +01:00
Thomas Lamprecht
709784e21a ui: metrics: style cleanup: defined xtype first, name second
those are both the most important for what the field is, so they
should come first.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:53:05 +01:00
Thomas Lamprecht
26f876e281 ui: metrics: advancedColumn1 may now be empty
we have now improved detection in widget toolkit, not yet packaged
though

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:53:05 +01:00
Thomas Lamprecht
e4566d81e5 ui: metrics: use icons for add server
we could use the official influxdata one, they provide it in their
branding guide - and the use here would seem to comply with their
rules, and would fall under fair-user, probably.

Still, not 100% clear for me and Graphite is not easy to find a good
one with clear rules, so just reuse the bar-graph Font Awesome one,
better than nothing (looks empty-wrong)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:53:05 +01:00
Thomas Lamprecht
336b11738d ui/api: metrics: move server to subpath, post to path with ID
We actually wanted to use that scheme for more new API paths, lets
see if it is really fitting starting with this.

Use the new widget-toolkit submitUrl helper to add the ID on create.

And unify the edit/create window creation, which may fit better in a
separate commit, it's quite small and was to cumbersome to untangle,
so just go against my one rules here... :(

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:53:05 +01:00
Thomas Lamprecht
d244c47246 ui: metrics: add server base edit window
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:39:33 +01:00
Dominik Csapak
bd714ac558 ui: add MetricServerView to Datacenter
adds ui support for configuring the External Metric servers.
for now, influxdb and graphite edit windows do not share code,
it would be ideal to do that once we add more plugins

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-21 20:39:33 +01:00
Thomas Lamprecht
24c8594d5c api: drop Config from MetricServer module name
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:39:33 +01:00
Dominik Csapak
af17f1b5c9 api2/cluster: add 'metricserver' api endpoints
modeled after our typical api endpoints for sectionschema configs

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-21 20:39:33 +01:00
Thomas Lamprecht
4ca31af852 influxdb: avoid three line comment if one is enough
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:39:33 +01:00
Thomas Lamprecht
4412216f61 ui: manager: use eslint for lint target
not yet linting by default, we need to fix a few thousands linter
errors before that (most are trivial though)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:34:18 +01:00
Thomas Lamprecht
571328f6a7 http server: allow duplicate params (URI and form) if equal
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-21 20:34:18 +01:00
Dominik Csapak
972941fc57 ui: fix 'no iommu found' message for setups
sometimes, the first device in the pci api call is not in a separate
iommu group (see e.g. [0]), but it is active and should work

instead of testing the first, test all, and only show the message
if no device has a set iommu group

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-20 15:34:27 +01:00
Dominik Csapak
846ff6395b fix iteration over hash without keys
without 'keys' we iterate also over the values and use them as keys

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-20 15:34:27 +01:00
Dominik Csapak
d1cbfe0fa2 Status/Plugin: add id to schema
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-20 14:00:16 +01:00
Dominik Csapak
48fd18565b Status/Plugin: fix jsonschema for MTU
jsonschema wants 'minimum' not 'min'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-20 14:00:16 +01:00
Dominic Jäger
1f152d9f6e vzdump mail: Refactor text part
Less lines exeeding the character limit, less nesting, less duplicate code,
more readable sprintf arguments.

Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2020-11-17 14:13:11 +01:00