6442 Commits

Author SHA1 Message Date
Matthias Heiserer
87e222300c GUI: OS defaults: use SCSI single as default controller
Existing installs are not changed by this.

Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
2022-11-08 17:50:38 +01:00
Matthias Heiserer
94b5e53a48 GUI: HDEdit: check iothread by default and move it from advanced section
Existing disks are not changed by this.
Especially in benchmarks, iothreads significantly improve IO performance.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
2022-11-08 17:50:38 +01:00
Stefan Sterz
ec1d12dbb9 ui: add javascript source to OnlineHelpInfo.js prerequisites
by adding the javascript files as prerequisites, the
`OnlineHelpInfo.js` will get re-generated if a new `onlineHelp` key
is used. thus, this avoids an issue were valid keys might not get
mapped correctly because the info in `OnlineHelpInfo.js` wasn't
updated.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
2022-11-08 16:28:42 +01:00
Fiona Ebner
a3b5c220f9 ui: lxc/qemu: cpu edit: use emptyText for cpuunits
This makes it slightly clearer that it's a default value (not being
written to the config explicitly). It's also in preparation to bind
the default based on the cgroup version, where it's a bit nicer to
bind the emptyText instead of the value (or a user set value would be
overwritten when the binding updates).

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2022-11-08 16:24:49 +01:00
Fiona Ebner
61c0338790 ui: qemu/lxc: cpu edit: fix 'create' parameter for delete_if_default()
For lxc, commit 53395db1 ("lxc/ResoureEdit: move some cpu fields to
advanced options") made the fields available in the create wizard, so
the comment is also wrong.

Both wizards do a 'delete kv.delete' in their onSubmit() function, so
it didn't actually matter in practice.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2022-11-08 16:24:49 +01:00
Fiona Ebner
aafc29e9f7 ui: lxc: cpu edit: drop superfluous delete_if_default
Commit bf96f60d ("use IntegerField from widget toolkit") switched to
using an Promxox IntegerField with 'deleteEmpty: true'. This means
that a value of '' already is removed from 'values' and added to
'delete' before onGetValues() is called here.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2022-11-08 16:24:49 +01:00
Dominik Csapak
79767edcf4 Jobs/Plugin: remove 'vzdump' from id description
it's not necessarily a vzdump job

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-11-07 17:14:11 +01:00
Dominik Csapak
9f1a43c125 Jobs: provide id and schedule to the job
we need that for realmsync jobs

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-11-07 17:14:11 +01:00
Fiona Ebner
cf6b65a292 ui: {guest, node} summary: use correct unit for CPU usage
One could also think about showing something like '% of N CPUs', but
this can be inaccurate for older data, because the number of CPUs can
change.

Reported in the community forum:
https://forum.proxmox.com/threads/117362/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2022-11-07 11:20:59 +01:00
Wolfgang Bumiller
55fb2eadb1 fixup /cluster/resources schema
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2022-11-04 16:20:18 +01:00
Daniel Tschlatscher
98246fb7ea gui: fix firewall security group help button chapter link
The help button under Datacenter > Firewall > Security Group did not
have the proper help chapter link set.

First reported here:
https://forum.proxmox.com/threads/broken-help-link-in-proxmox-gui.117503/

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
2022-11-04 10:32:44 +01:00
Thomas Lamprecht
4314ba846b pveupdate: reword comment slightly and adapt text width
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-04 10:32:38 +01:00
Stefan Hrdlicka
1a3e2e9f5d cleanup: style fix
Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
2022-10-24 13:38:23 +02:00
Stefan Hrdlicka
1eb7b17f3a fix #1981: get next free disk id on change of bus/device
Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
2022-10-24 13:38:23 +02:00
Thomas Lamprecht
2f9fc81190 ui: node: rework layout of certificate viewer
Move the raw cert into a fieldset and collapse that by default, also
make it render monospace and pre-wrap whitespace.

Use a inputpanel to get top, col 1/2 & bottom layout so that rsa key
type/size and validity range can be rendered more compactly

n addition to that limit the whole windows height but make it
scrollable, this allows to sanely use the viewer on certs with many
SANs even on small window/browser sizes.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-19 15:14:18 +02:00
Aaron Lauterer
d9416caa1d ui: dc: subscription: fix subscription check
With the change to the rust backend for the subscription check, the
return value changed as well.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2022-10-19 14:05:20 +02:00
Aaron Lauterer
c46eb47e53 report: add arcstat
One of the infos, that can sometimes be usable.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2022-10-19 07:49:45 +02:00
Aaron Lauterer
655080eeeb api: ceph: pools: get_storages: set pool name if missing
This avoids errors about the use of uninitialized values if the 'pool'
parameter is not present in the storage configuration.

The 'pool' property for an RBD storage config is not mandatory.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2022-10-14 15:43:53 +02:00
Thomas Lamprecht
d3d4873615 ui: node certificate: make panel only vertical scrollable
Otherwise, a browser window breaks the responsive horizontal
flex-flow/grid-column resize, and just displays the vertical scroll
bar instead, which can look a bit odd.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-10 16:28:28 +02:00
Dominik Csapak
6a594c50cb ui: node certificate: make parent panel scrollable
The `ACME` panel may be rendered out of sight (overflow) when there
are enough SANs on the upper `Certificates` panel to push it down
enough and the browser/display height is too small.

Enable the `scrollable` config for the parent certificate view panel
to make ExtJS automatically add a scrollbar if the content overflows.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-10 16:28:28 +02:00
Wolfgang Bumiller
a66ad60f57 d/control: bump guest-common dependency
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2022-10-10 14:50:27 +02:00
Fiona Ebner
93880785c8 vzdump: handle new 'performance' property string
Also generalizes the way vzdump property strings are handled for jobs.
Something similar could be done in VZDump.pm, but there the maxfiles
and prune-backups settings are currently coupled, so a dedicated
parse_performance() is used instead. Can be changed once maxfiles is
dropped.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2022-10-10 13:04:17 +02:00
Thomas Lamprecht
2831d8061b ui: mdev selector: avoid separate gettext for "Avail"
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-04 13:54:10 +02:00
Thomas Lamprecht
5366e88eda pveupdate: split/sort perl module usage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-29 14:20:29 +02:00
Dominik Csapak
13799d5b9e ui: eslint: fix undefined check
'typeof' cannot return 'undefined' only the string '"undefined"', newer
eslint versions detect that as error

to fix it, directly check it for undefined instead of using typeof

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-09-16 12:50:56 +02:00
Fabian Grünbichler
d088f89b16 apt: add proxmox-offline-mirror-helper package
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-15 09:07:11 +02:00
Fabian Grünbichler
8794bb15de apt: sort list of optional packages
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-15 09:07:11 +02:00
Thomas Lamprecht
87df8bde1d ui: ceph: use quincy as new default for fresh installations
Note that we still check the cluster for an already used installation
and will select that, if any, so this is really just for setting up a
completely new cluster.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-15 07:42:24 +02:00
Thomas Lamprecht
0ae45fc612 bump version to 7.2-11
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-14 13:15:25 +02:00
Thomas Lamprecht
2833e1e1c5 d/postinst: set_lvm_conf: early return to avoid indentation level
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-14 10:48:53 +02:00
Thomas Lamprecht
60b5e2d824 d/postinst: fix indentation to four spaces
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-14 10:48:19 +02:00
Fabian Grünbichler
bf09acfe7f postinst: migrate/update APT auth config
missed when switching over to Proxmox::RS::Subscription, which stores
the same info in the product-specific /etc/apt/auth.conf.d/pve.conf .

the top-level file might contain non-PVE-managed entries, so only remove
entries matching "our" machine.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-14 10:37:56 +02:00
Thomas Lamprecht
f31d010c80 ui: workspace: fix lxc widget xtype
the real bug is to name the widget xtypes like classes

Fixes: 16875928d37d586a08f173766cdcf8d41bd87a4b
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-13 17:51:45 +02:00
Thomas Lamprecht
5888ba939d ui: guest summary: fix qemu specific class name
call sites already used the 'pveGuestSummary'

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-12 17:01:35 +02:00
Thomas Lamprecht
16875928d3 ui: lxc: fix alias definition of PVE.lxc.Config
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-12 17:00:58 +02:00
Stoiko Ivanov
c5b25c00ff report: stabilize order of guests and network
both categories have '40' as their order - leading to random swaps
between those 2 categories in the actual report.

I only increased the order of network, instead of renumerating all
succeeding categories by 10 (mostly for better readability of the
patch)

Suggested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2022-09-12 16:04:18 +02:00
Stoiko Ivanov
ef09450c1d report: add proxmox-boot-tool status output
while needed seldomly we had a few cases recently where this would
have saved the user and us one roundtrip.

adding to storage, to be close to the `findmnt` output (which usually
tells us if the system is booted in efi or legacy mode)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2022-09-12 16:04:18 +02:00
Fabian Grünbichler
ccc9fc7cb0 d/control: recommend proxmox-offline-mirror-helper
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-12 10:55:13 +02:00
Fabian Grünbichler
18145e3f2a bump version to 7.2-10
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-12 09:15:59 +02:00
Fabian Grünbichler
774c5031b4 pvesubscription: remove leftover $key
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-09 15:06:26 +02:00
Thomas Lamprecht
a058076de4 bump version to 7.2-9
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-08 14:57:32 +02:00
Aaron Lauterer
219293bd1d ui: CephInstall: fix a/an typo
and switch to template string

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2022-09-07 15:25:09 +02:00
Aaron Lauterer
f25c38553e ui: CephInstallWizard: make first mon node static
Removes the possibility to select the node on which to create the first
monitor in the configuration / initialization step and always sets it to
the current node.

This prevents that a user might select another node on which the Ceph
packages have not yet been installed. If a user did that, they would get
an error, but the Ceph config file would have been written. If the user
then does not select a valid node to create the first mon, but aborts
the wizard, they are greeted with a rados_connect error because the
config file exists, but it does not contain any mon infos that are
needed to connect to the Ceph cluster.

Creating a mon manually will remedy such a situation, but especially for
new users, this behavior is not ideal and confusing.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2022-09-07 15:25:09 +02:00
Fabian Grünbichler
25eaf729d7 subscription: handle missing subscription info
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-07 14:50:32 +02:00
Thomas Lamprecht
dbfcac27d5 api: nodes: code/style rework start/stop list generation
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-07 09:47:48 +02:00
Thomas Lamprecht
79d6202636 api: nodes: style/perlcritic fixes
no semantic change intended

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-07 09:47:48 +02:00
Fabian Grünbichler
d35b9e6b13 bump version to 7.2-8
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-06 11:02:59 +02:00
Fabian Grünbichler
dc17baee74 www: subscription: add Signed/Offline status
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-06 11:02:59 +02:00
Fabian Grünbichler
d4df1b145c pvesubscription: add 'set-offline-key' command
and disallow updating signed offline keys via regular check/update code
path.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-06 11:02:59 +02:00
Fabian Grünbichler
d017de1f91 subscription: switch to Proxmox::RS::Subscription
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-06 11:02:59 +02:00