4678 Commits

Author SHA1 Message Date
Thomas Lamprecht
c58378c327 api/bulk migrate: split long param list in multiple lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 17:06:40 +01:00
Thomas Lamprecht
b908970d6a api/bulk migrate: rework pre-condition check outputs
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 17:06:37 +01:00
Thomas Lamprecht
1a0ea0c403 follow bulk-migrate gui adaptions
show both, checkbox and hint in one row, there more horizontal space
than vertical.

s/Warning/Note/

default to on for convenience

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 16:24:53 +01:00
Tim Marx
d61ee9cee4 ui: add checkbox to bulk migrate window to allow migration with local disks
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2019-11-30 15:25:18 +01:00
Tim Marx
d86824376b api: add migrate precondition checks to bulk migrate api
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2019-11-30 15:25:18 +01:00
Tim Marx
013bacec9d api: add migrate with local disks to bulk migrate api
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2019-11-30 15:25:18 +01:00
Thomas Lamprecht
0f1e5f323e ui: lxc: fix cmd menu separator hiding
use same condition boolean line as VMs have

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 14:39:25 +01:00
Oguz Bektas
2739a690b2 add reboot button to right-click menu for VMs
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-30 14:31:22 +01:00
Thomas Lamprecht
840ff5c2d5 api: apt/versions: track ifupdown and ifupdown2 as optional package
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 14:30:58 +01:00
Thomas Lamprecht
80036e4e55 ui: dc/options: fix capabillities for u2f, bwlimits, ha settings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-29 15:20:32 +01:00
Fabian Ebner
95df382e90 LXC: Disable resize button when volume is unusued
The size of an unused volume is not visible to the user and trying to resize
an unused volume runs into a 'parameter verification failed' anyways.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-29 08:41:52 +01:00
Thomas Lamprecht
a764f165ac pvesr service: order after pve-cluster
avoids errors from this service on boot as it could be started before
pve-cluster.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-28 10:54:12 +01:00
Thomas Lamprecht
b87589da3d d/control: build depend on newes doc-gen 6.1-1
to ensure we have all the online references available

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 19:36:04 +01:00
Thomas Lamprecht
d4defed969 ui: dc/options: add onlineHelp to u2f and ha edit window
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 19:35:17 +01:00
Dominik Csapak
3aead630e1 gui: Bandwidth limits: increase labelWidth to 120
in some languages (e.g. German) the default (100) is too short for some labels,
resulting in cut-off text. We often use 120 in such cases, so we should
do here as well

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-27 18:40:30 +01:00
Dominik Csapak
4e9348b22a gui: UserView: show api call errors
otherwise, an api error leads to an empty UserView, and the user
wonders why no users show up

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-27 16:51:15 +01:00
Thomas Lamprecht
701270e36b bump version to 6.1-1
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:37:39 +01:00
Thomas Lamprecht
473983800c fixup whitespace error
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:36:19 +01:00
Thomas Lamprecht
ef6dea728c ui: dc/options: add bandwidth limit editor
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:25:51 +01:00
Thomas Lamprecht
68932ebcdf ui: add Bandwidth selector widget
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:24:46 +01:00
Thomas Lamprecht
77f410bc03 followup: add intermediate directory index for sdn/zones
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 17:58:01 +01:00
Alexandre Derumier
bfc672d562 api2 : nodes : use zones api status
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2019-11-26 17:08:23 +01:00
Alexandre Derumier
2b40aa3345 api2 : reload : use zones/controllers sdn plugins 2019-11-26 17:08:23 +01:00
Alexandre Derumier
263d64e219 pvestatd: fix require PVE::Network::SDN
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2019-11-26 17:08:23 +01:00
Oguz Bektas
ccae37d332 lxc: disable remove button for pending resource changes
for a pending change, it's 'revert's job to do this. pressing remove
doesn't do anything and it might be confusing for users.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-26 17:06:27 +01:00
Thomas Lamprecht
2ad296b1f7 ui: dc/options: allow to set U2F
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 17:02:01 +01:00
Thomas Lamprecht
e44e27f6f2 ui: printPropertyString: skip empty string values
This cannot work anyway, and it simplifies some editors for
format-string backed properties, like the upcoming u2f settings
integration.

If such a value was passed to the backend one would get:
> invalid format - missing key in comma-separated list property

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 17:00:29 +01:00
Thomas Lamprecht
a69d28e5fa api mon: allow full-mesh routed setup for monitor IP
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 15:42:24 +01:00
Thomas Lamprecht
1e7bd21d03 node config: allow - in config property keys
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 13:27:30 +01:00
Thomas Lamprecht
ea93e03e55 followup: be slightly more verbose on error or renew
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 13:23:45 +01:00
Dominik Csapak
9c284459e9 renew pve-ssl.pem when it nearly expires
but only if the cert is issued by the ca in /etc/pve/pve-root-ca.pem
(by checking the issuer and openssl verify)

this way we can reduce the lifetime of the certs without having
to worry that they ran out

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-26 13:13:04 +01:00
Thomas Lamprecht
f7ca922678 api: network reload: more granular OVS change check
Just because OVS is installed it doesn't mean that OVS interface
(changes) are configured - so check for that.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 11:43:43 +01:00
Dominik Csapak
2aec108d62 gui: node network: enable apply config button
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-26 10:13:12 +01:00
Thomas Lamprecht
c88b8df4cc allow to set 'migrate' shutdown policy in datacenter options
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-25 19:54:44 +01:00
Thomas Lamprecht
2239954c5a ui: lxc: switch reboot and stop button to match VMs
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-25 06:40:50 +01:00
Thomas Lamprecht
fdf2d1b58d ceph tools: adapt version to accept -pveX too
this is a precautional measure

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-23 17:59:17 +01:00
Dominik Csapak
544dbff874 fix #2462: ACMEAccount: make tos in get_tos optional
the code returns undef in case there is no 'tos', and the code
calling this api call handles a non-existing tos already, but
fails in that case becasue of the failing return value verification

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-22 12:19:27 +01:00
Thomas Lamprecht
52b9148135 bump version to 6.0-15
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-21 15:16:33 +01:00
Stefan Reiter
1e18c15ad1 Fix #2476: Fix auto-ballooning QMP command
Commit 77123edbd0 (statd: refactor update_node_status) changed $target
in pvestatd's auto_balloning sub into a variable:

    my $target = int($res->{$vmid});

but then uses it in a string as a parameter to the $log function:

    $log->("BALLOON $vmid to $target (%d)\n", $target - $current);

This surprisingly causes the variable to be incorrectly converted into a
JSON string by perl's to_json (called in QMPClient after mon_cmd):

    {"value":"1234"}

instead of

    {"value":1234}

which causes QEMU to report the parameter as invalid:

    "Invalid parameter type for 'value', expected: integer"

This behaviour is made even trickier, since $target internally is still
considered more of an 'int' (although that's a weak claim in perl
anyway), showing up without quotes in Dumper et. al. - but the perldoc
for to_json scheds some light:

    simple scalars
        Simple Perl scalars (any scalar that is not a reference) are the
        most difficult objects to encode: this module will encode undefined
        scalars as JSON "null" values, scalars that have last been used in a
        string context before encoding as JSON strings, and anything else as
        number value

So coerce to_json to treat $target as an integer by using it as one and
everything is fine again.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2019-11-21 14:23:58 +01:00
Thomas Lamprecht
fd783e0cb3 api/ceph: skip merging metadata if hostname is undefined
It's a bit hard to figure out the exact constellation required for
this to happen, but we saw it in live systems when one node was dead
in a three node cluster.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-21 10:57:50 +01:00
Thomas Lamprecht
91e37bb032 ceph/api: cleanup comment on extra line
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-21 10:57:21 +01:00
Thomas Lamprecht
3cd396fc48 bump version to 6.0-14
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-20 20:46:21 +01:00
Thomas Lamprecht
416d6c9468 followup: vm QGA type: handle a explicit set virtio type
as else we'd show "Unknown" if one set the type explicitly to
"virtio", either over API/CLI or editing the configuration directly

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-20 20:45:30 +01:00
Matt Dunwoodie
07c07da9eb Add 'type' option to AgentFeatureSelector
This adds an extra field to the AgentFeatureSelector that reflects the
change in qemu-server.

Changes since previous version:

 * Use map rather than if/else if/else for type display string.
 * Use Proxmox.Utils.unknownText for unknown type (should not occur with
   regular use).
 * Keep existing fields as boxLabel rather than fieldLabel, as they
   look crammed with fieldLabel.
 * Use __default__ for default option, to save space and replicate
   behaviour in other places.
 * Store option in advancedItems as it is a special case.

Even though the map only contains one item, it will be easily added to
in the future. There is only one item as there is no need to have a
string for "virtio" as it is not displayed because of __default__.

Signed-off-by: Matt Dunwoodie <ncon@noconroy.net>
2019-11-20 20:45:30 +01:00
Oguz Bektas
b8ea21c1e9 lxc: add reboot button
to right-click menu and dropdown menu

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-20 20:28:53 +01:00
Oguz Bektas
5b27c13ce7 lxc: refactor stop button
move stopBtn into shutdownBtn as a menu item.

we can remove the setDisabled() call for stopBtn near the end, since when
shutdownBtn is disabled, so is stopBtn.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-20 20:28:53 +01:00
Thomas Lamprecht
ca0fc07dd4 fix #844: allow to pre-delay start-all-marked guests on boot
Add a simple ExecStartPre command which reads the local node config,
and if a delay is set the helper sleeps that long then exists.

The systemd-unit approach was chosen as this ensures that we really
only delay when doing the startall on node boot. The pve-guests
service does not allows manual stops, starts or restarts, it can only
be pulled in by the multi-user.target

Mark this command with "-" to tell systemd that errors of it should
not cause an abort, it's a best-effort approach.

The journal from a 2 second delay would look like:
> Nov 19 13:13:48 dev6 systemd[1]: Starting PVE guests...
> Nov 19 13:13:48 dev6 pve-startall-delay[2318]: Delaying on-boot 'startall' command for 2 second(s).
> ...
> Nov 19 13:13:50 dev6 pve-guests[2339]: <root@pam> starting task UPID:dev6:00000924:00000529:5DD3DC7E:startall::root@pam:

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-20 20:20:58 +01:00
Dominik Csapak
6033f465b8 gui: pci passthrough: consider domain in PCISelector
but remove the default domain '0000' before sending to the backend,
and add it if no domain is given in the config

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-20 19:43:31 +01:00
Thomas Lamprecht
b775eeb0fc d/control: bump version dependency to qemu-server
for mon_cmd refactoring

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-20 19:43:31 +01:00
Stefan Reiter
447bae61ef refactor: vm_mon_cmd is now Monitor::mon_cmd
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2019-11-20 18:25:49 +01:00