5
0
mirror of git://git.proxmox.com/git/pve-zsync.git synced 2025-03-13 00:58:41 +03:00

cleanup ugly hash usage

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2018-08-24 11:40:46 +02:00
parent eac174d718
commit 5dbe7f7f0c

View File

@ -201,39 +201,40 @@ sub read_cron {
sub parse_argv { sub parse_argv {
my (@arg) = @_; my (@arg) = @_;
my $param = {}; my $param = {
$param->{dest} = undef; dest => undef,
$param->{source} = undef; source => undef,
$param->{verbose} = undef; verbose => undef,
$param->{limit} = undef; limit => undef,
$param->{maxsnap} = undef; maxsnap => undef,
$param->{name} = undef; name => undef,
$param->{skip} = undef; skip => undef,
$param->{method} = undef; method => undef,
$param->{source_user} = undef; source_user => undef,
$param->{dest_user} = undef; dest_user => undef,
};
my ($ret, $ar) = GetOptionsFromArray(\@arg, my ($ret) = GetOptionsFromArray(
'dest=s' => \$param->{dest}, \@arg,
'source=s' => \$param->{source}, 'dest=s' => \$param->{dest},
'verbose' => \$param->{verbose}, 'source=s' => \$param->{source},
'limit=i' => \$param->{limit}, 'verbose' => \$param->{verbose},
'maxsnap=i' => \$param->{maxsnap}, 'limit=i' => \$param->{limit},
'name=s' => \$param->{name}, 'maxsnap=i' => \$param->{maxsnap},
'skip' => \$param->{skip}, 'name=s' => \$param->{name},
'method=s' => \$param->{method}, 'skip' => \$param->{skip},
'source-user=s' => \$param->{source_user}, 'method=s' => \$param->{method},
'dest-user=s' => \$param->{dest_user}); 'source-user=s' => \$param->{source_user},
'dest-user=s' => \$param->{dest_user}
);
if ($ret == 0) { die "can't parse options\n" if $ret == 0;
die "can't parse options\n";
}
$param->{name} = "default" if !$param->{name}; $param->{name} //= "default";
$param->{maxsnap} = 1 if !$param->{maxsnap}; $param->{maxsnap} //= 1;
$param->{method} = "ssh" if !$param->{method}; $param->{method} //= "ssh";
$param->{source_user} = "root" if(!$param->{source_user}); $param->{source_user} //= "root";
$param->{dest_user} = "root" if(!$param->{dest_user}); $param->{dest_user} //= "root";
return $param; return $param;
} }
@ -266,14 +267,10 @@ sub encode_cron {
my $param = parse_argv(@arg); my $param = parse_argv(@arg);
if ($param->{source} && $param->{dest}) { if ($param->{source} && $param->{dest}) {
$cfg->{$param->{source}}->{$param->{name}}->{dest} = $param->{dest}; my $source = delete $param->{source};
$cfg->{$param->{source}}->{$param->{name}}->{verbose} = $param->{verbose}; my $name = delete $param->{name};
$cfg->{$param->{source}}->{$param->{name}}->{limit} = $param->{limit};
$cfg->{$param->{source}}->{$param->{name}}->{maxsnap} = $param->{maxsnap}; $cfg->{$source}->{$name} = $param;
$cfg->{$param->{source}}->{$param->{name}}->{skip} = $param->{skip};
$cfg->{$param->{source}}->{$param->{name}}->{method} = $param->{method};
$cfg->{$param->{source}}->{$param->{name}}->{source_user} = $param->{source_user};
$cfg->{$param->{source}}->{$param->{name}}->{dest_user} = $param->{dest_user};
} }
} }