Commit Graph

1904 Commits

Author SHA1 Message Date
Roman Zulak
182954b87f Windows: Match UCRT Version from build environment if possible.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:22 +02:00
Roman Zulak
4c97ee61c6 Log progress adding environmental library paths.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:22 +02:00
Roman Zulak
37f86f9a4a Add platform::kEnvDelim to avoid having #ifdefs for calls to SplitPaths.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:22 +02:00
Roman Zulak
f5633ed248 Use std::string for IncrementalJIT symbol lookup. Many callers already have a string, most functions called want them, and it's cheaper to construct an llvm::StringRef than a std::string when needed.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:21 +02:00
Roman Zulak
8f44fe40c5 Remove unnecessary StringRefs and strlen calls to construct them.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:21 +02:00
Roman Zulak
c3869d00cc Windows: Fix looking up data symbols in process' libraries. Consolidate llvm::DynamicLibrary usage into IncrementalJIT.cpp. Add comments describing larger issue.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:21 +02:00
Roman Zulak
2bc6a5c66b Move windows::LookupSymbol to platform::DLSym
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:21 +02:00
Roman Zulak
0cf6aec6a7 Lookup Windows functions in process.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:21 +02:00
Roman Zulak
71eb51a1d2 Windows: Make CheckABICompatibility check a header dependent constant.
Previously the check was for a standard installation of VisualStudio.
That check will have likely passed already, but the user could have
forced the include paths making the prior check somewhat meaningless.

Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:21 +02:00
Roman Zulak
1dadbe2495 Refactor CheckABICompatibility into a more legible version. Standardize error message. Return whether the ABI matched or not.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:21 +02:00
Roman Zulak
6c2ab5c9d2 Reformat includes and remove Windows.h dependency.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:21 +02:00
Roman Zulak
ffadea2c21 Add platform::DLOpen and platform::DLClose.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:20 +02:00
Roman Zulak
fb4769cecb Add platform::NormalizePath.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:20 +02:00
Roman Zulak
6dc1c06512 Add platform::GetSystemLibraryPaths.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:20 +02:00
Roman Zulak
cce7d69844 Move platform specific code from CIFactory.cpp into separate modules.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-18 17:53:20 +02:00
Vassil Vassilev
98c827ebdc Do not resolve the REALPATH too early.
In some ccache setups we have the compiler soft link to ccache.

Eg. /usr/local/bin/g++ -> /usr/local/bin/ccache. If we resolve the link too
early we will take the wrong branch assuming the compiler was set as
CMAKE_CXX_COMPILER="ccache g++" and try to get the second token of the command.
2016-10-18 15:55:55 +02:00
Vassil Vassilev
ae18e8eca6 Allow correct automatic relocatability of cling and ROOT.
Patch by Roman Zulak <machtyrtle@gmail.com>!

Patch tested and requested by Chris Green (ROOT-8379).
2016-10-18 15:55:55 +02:00
Pere Mato
bd5d32f9e5 Fix for ROOT-8392 - CMake missing dependency 2016-10-12 12:59:44 +02:00
Roman Zulak
35c0ef1cdd Remove unused stream argument.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-05 10:53:00 +02:00
Roman Zulak
973e380989 Fix size argument for runtime::copyArray.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-05 10:53:00 +02:00
Roman Zulak
dde76efa31 Fix crash if print debug state changes during execution. Ensure ~ClangInternalState runs before ~PushTransactionRAII.
Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>
2016-10-05 10:53:00 +02:00
Frederich Munch
9759ee7557 Peek inside extern "C" declarations only after name hasn't been matched. Change initial for loop use != comparison rather than < 2016-09-30 10:14:28 +02:00
Frederich Munch
e1854092b5 Move DeclUnloader and ParserStateRAII into cling namespace. 2016-09-22 15:15:27 +02:00
Frederich Munch
2bf05c5188 Fix extern "C" declarations not being called from .x command.
This handles top-level declarations only (i.e. not nested in namespaces).
2016-09-16 21:39:49 +02:00
Frederich Munch
213ba748cd Don't check if argument exists twice, and remove impossible else. 2016-09-16 21:39:49 +02:00
Frederich Munch
ceedc351f3 Update comments for TransactionPool. 2016-09-16 21:39:49 +02:00
Frederich Munch
8296c01d95 Don't test for no_such_file_or_directory to know if a file exists.
There are many errors (is_a_directory, permission_denied, etc.),.
Any one of which will mean Magic is in an undefined state.
2016-09-16 17:59:55 +02:00
Frederich Munch
a5c1828daf Value::GetNumberOfElements should use size_t and not unsigned long.
This was triggering an assert on Windows.
2016-09-16 17:59:55 +02:00
Axel Naumann
109ed8c33d Remove consumer's dangling reference. 2016-09-13 09:59:43 +02:00
Axel Naumann
e0ba0a3f1e Remove unused function. 2016-09-13 09:59:43 +02:00
Axel Naumann
5637a11329 Fix Coverity CID66882 - clash with parameter name. 2016-09-12 22:31:57 +02:00
Axel Naumann
139d0144a5 Fix Coverity CID67986,67987 - clash with parameter name. 2016-09-12 22:31:57 +02:00
Axel Naumann
1f4d6c063a Fix Coverity CID60779,60780 - clash with parameter name. 2016-09-12 22:31:57 +02:00
Axel Naumann
56e748da0e Fix Coverity CID53317 - clash with parameter name. More explicit than op bool. 2016-09-12 22:31:57 +02:00
Axel Naumann
26580a75ee Fix Coverity CID60778 - control flow depends on compile time constant. 2016-09-12 22:31:56 +02:00
Axel Naumann
b26d955f67 Fix Coverity CID61311 - potential null deref. 2016-09-12 22:31:56 +02:00
Axel Naumann
2c9afd5243 Fix Coverity CID68091 - missing member init. 2016-09-12 21:44:20 +02:00
Axel Naumann
6c155bfc52 Fix Coverity CID68726 - potential null deref. 2016-09-12 21:44:20 +02:00
Axel Naumann
59b2e26209 Fix Coverity CID68743. 2016-09-12 21:44:20 +02:00
Frederich Munch
4fb7f8ee07 Restore prior behavior always allocating a Transaction in Debug. 2016-09-12 17:29:21 +02:00
Frederich Munch
265061cd10 Move macro definitions to enums in TransactionPool. 2016-09-12 17:29:21 +02:00
Frederich Munch
c6b24d764c Fix TransactionPool placement new and delete.
TransactionPool was using placement new and delete improperly which could lead to Transaction::~Transaction running twice.
Make Transaction constructor private to make sure TransactionPool has allocated all Transactions it contains.
Remove "*Very useful for debugging purposes" leak on every allocation.
2016-09-12 17:29:20 +02:00
Axel Naumann
bb142011b4 Reverse the unload order, from derived to fundamental.
Else all GlobalValues from Decls from thus Transaction will be undefined, because unloading the Decl will remove the GlobalValue.
2016-09-09 21:14:06 +02:00
Axel Naumann
e1b6ce53fa Unload GlobalValues from Module even if the (deferred) Decl is from an earlier transaction. 2016-09-09 21:14:06 +02:00
Axel Naumann
a06cbba65b Forget Decls by removing them from the DeferredDecls. Put DeferredDecls back if needed. 2016-09-09 21:14:06 +02:00
Frederich Munch
9f0314d1c5 Fix missing call to pclose, introduced in 877a1f4. Fix assert checking a full line was received. 2016-09-09 21:14:06 +02:00
Axel Naumann
8d1d56edd0 Whitespace. 2016-09-09 13:29:08 +02:00
Frederich Munch
877a1f46af OS X: Fallback to getting system version with sw_vers.
This is necessary to support gcc > 10.9 and Gestalt is deprecated/may be removed.
Don't warn about deprecation in that section only, not the whole file.
Log progress in getting SDK when in verbose mode.
2016-09-09 13:29:08 +02:00
Frederich Munch
a34f2512c4 Windows: Fix DynamicLibraryManager error reporting. 2016-09-09 09:29:49 +02:00
Frederich Munch
ede2c165c3 Windows: Add verbose logging in AddHostArguments. 2016-09-09 09:29:49 +02:00