Commit Graph

5062 Commits

Author SHA1 Message Date
Axel Naumann
6d52a95449 Revert "Add a module for stl_iterator_base_funcs.h avoiding merging issues for c++20"
This reverts commit a4c07502a3e76c82f30828200f5fe4ae935ac166.

While this itself might not cause build issues, the related commit 90ffa89ae4 does;
handle them together.
2023-03-21 15:29:04 +01:00
Axel Naumann
f2bc02a68b Revert "[cxxmodules] Add more bits headers to fix module merging issues."
This reverts commit 90ffa89ae46b48c634547d6abd861a524a5d27c7.
It causes build failures on GCC 12.2.1 / c++17 with

```
[ 70%] Generating G__Core.cxx, ../lib/Core.pcm
In file included from input_line_7:111:
/home/linev/build/webgui/include/ROOT/RDirectoryEntry.hxx:31:33: error: missing '#include <bits/chrono.h>'; 'system_clock' must be declared before it is used
   using clock_t = std::chrono::system_clock;
                                ^
/usr/include/c++/12/bits/chrono.h:1110:12: note: declaration here is not visible
    struct system_clock
           ^
In module 'std' imported from input_line_1:1:
/usr/include/c++/12/bits/move.h:204:11: error: missing '#include <bits/chrono.h>'; 'time_point' must be defined before it is used
      _Tp __tmp = _GLIBCXX_MOVE(__a);
          ^
/home/linev/build/webgui/include/ROOT/RDirectoryEntry.hxx:89:4: note: in instantiation of function template specialization 'std::swap<std::chrono::time_point<std::chrono::system_clock, std::chrono::duration<long, std::ratio<1, 1000000000>>>>' requested here
   swap(fDate, other.fDate);
   ^
/usr/include/c++/12/bits/chrono.h:856:14: note: definition here is not reachable
      struct time_point
```
2023-03-21 15:29:04 +01:00
Vassil Vassilev
782cc41a6c Add more bits headers to fix module merging issues. 2023-03-21 09:29:07 +01:00
Vassil Vassilev
2cebf663dc Add a module for stl_iterator_base_funcs.h avoiding merging issues for c++20 2023-03-21 09:29:07 +01:00
Jonas Hahnfeld
1499c8c74f Use compiled Module for stored states
Since the upgrade to LLVM 13, the JIT infrastructure takes ownership
of the Module. After JIT compilation, we get back a (const) pointer
to the compiled module.

This fixes the Cling test ErrorRecovery/StoredState.C.
2023-03-09 11:14:07 +01:00
Axel Naumann
33de07df48 Do not try to find runtime headers in ./:
These headers are part of cling, not user code, so starting
with the current directory is pointless and can actually be
counterproductive.

This helps with https://github.com/root-project/root/issues/12409
but not enough; any dictionary header will still try to access "./".
2023-03-03 17:59:05 +01:00
Jonas Hahnfeld
8c3b18f683 Forward ABIName to MCTargetOptions
This is required on RISC-V where Linux uses the lp64d ABI that allows
the usage of floating point registers to pass arguments. It seems to
work out-of-the-box upstream in clang-repl which passes through the
function initTargetOptions in clang/lib/CodeGen/BackendUtil.cpp with
the same effect.
2023-03-01 19:14:06 +01:00
Jonas Hahnfeld
eb82dc505a Use JITLink on RISC-V
RuntimeDyld does not support RISC-V, so it makes sense to enable
JITLink by default. This also makes relocations work without support
for a large code model.

See the equivalent change upstream in https://reviews.llvm.org/D129092,
committed for LLVM 15 in a4e2c1f762
2023-03-01 19:14:06 +01:00
Jonas Hahnfeld
e65614cb92 Disable outline-atomics on AArch64
The routines __aarch64_* are defined in the static library libgcc.a
and not necessarily included in libCling or otherwise present in the
process, so the interpreter has a hard time finding them.

Fixes #12294
2023-02-20 22:14:04 +01:00
Vassil Vassilev
e26c70ae49 Remove the problematic uses_allocator_args.h
It is not present on some versions of libstdc++ which makes the compilation
of Core.pcm fail.
2023-02-17 10:29:02 +01:00
Vassil Vassilev
b474a0ab43 Add a module for experimental/string_view
Recent gcc updates somehow make experimental/string_view available through
module string_view. Then it wrongly decides it needs to include
"bits/ranges_base.h" which is a c++14 header and breaks the compilation in case
of c++11.

This patch adds a proper experimental/string_view to disallow such shadowing.
2023-02-17 10:29:02 +01:00
Bertrand Bellenot
b3b15d60e1 Fix modules and modules.idx generation on Windows and disable a few more modules causing potential crashes (#12252)
* Fix modules and modules.idx generation on Windows and disable a few more modules causing potential crashes

* Introduce a new TROOT::GetSharedLibDir() method to reduce the need of #ifdef R__WIN32

* Use the value of ROOT_GET_LIBRARY_OUTPUT_DIR instead of CMAKE_RUNTIME_OUTPUT_DIRECTORY (which is the same anyway)

* cleanup the code

* Remove unnecessary check
2023-02-17 08:44:05 +01:00
Jonas Hahnfeld
75930f9dfd Set DataLayout from our TargetMachine (#12335)
Otherwise LLJIT's constructor will ask the LLJITBuilder's JTMB to
create a DataLayout. As we don't propagate the JTMB (yet -- we
probably should!), this will be wrong if target features influence
the DataLayout.

This should fix #12293.
2023-02-16 20:44:03 +01:00
Axel Naumann
e122c6dcc6 Revert "Disable GlobalISel on AArch64":
This reverts fcab0add4a79379b5087fe786261f4ab0cc9776a which is not
needed anymore since llvm13 / ORCv2 / JITLink.
2023-02-16 17:14:03 +01:00
Jonas Hahnfeld
38154308df Switch back to large code model for macOS on AArch64
It results in relocation targets that are out-of-range.
2023-02-07 08:59:05 +01:00
Vassil Vassilev
bc0a44c2b7 Enable a few modules for Windows. Now we can run hsimple.C. 2023-02-07 08:59:05 +01:00
Vassil Vassilev
727908e8af Adapt the cling-demo to the new cling::Value interface. 2023-02-05 22:59:03 +01:00
Jonas Hahnfeld
1d93ee8d58 Simplify creation of TargetMachine
We know exactly which target triple and features the CompilerInstance
wants, we don't need to (and probably must not) second-guess that. This
brings us closer to upstream clang-repl and also includes the change of
https://reviews.llvm.org/D128853 which is crucial for RISC-V.
2023-02-05 12:59:03 +01:00
Jonas Hahnfeld
1603be8b87 Set up TargetMachine for JITLink
I missed this in commit 3ff7c1e8e2 and it seems to work by chance on
macOS, but this is needed on Linux: Before, CLING_JTLINK=1 on x86_64
complained about "Unspported personality pointer encoding 0x00" and
crashed entirely on RISC-V.
2023-02-05 12:59:03 +01:00
Vassil Vassilev
6ef68e5512 Fix potential pre-existing issue for big endian 2023-02-03 07:29:07 +01:00
Vassil Vassilev
643cfe84ab Improve performance by allowing most of cling::Value to inline.
We introduce an enum which mirrors the type kind and we use it in the getAs and
castAs operations to allow the compiler/interpreter to see all of the functions
and potentially inline them.

This patch brings the performance to similar levels with what we have in the
master.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
afadc28b05 Mark m_Storage as a const ref. 2023-02-03 07:29:07 +01:00
Vassil Vassilev
632aba9c56 Implement a rigorous type checking when we call getX and setX.
These interfaces assume we know the type and we should compare if the underlying
type is the one we expect when using the setters and getters. Unfortunately,
this is not the case and we need to further investigate.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
5add0d7732 Rename simplisticCast to castAs. 2023-02-03 07:29:07 +01:00
Vassil Vassilev
ad78ae2c61 Remove unused constructor 2023-02-03 07:29:07 +01:00
Vassil Vassilev
320d63785f Improve the templated Create interface to capture compile-time types.
This interface allows us to set a value and deduce its corresponding type very
efficiently. This is useful when we use cling::Value to model input arguments
for a function call in the JIT (eg. via TClingCallFunc).

That patch essentially makes cling::Value to hold a value and a type that
correctly models the compiled code.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
07c4469328 Improve consistency in cling::Value.
The improvements are:
  * We provide getX and setX interfaces instead of returning the address for the
    non const methods. This allows us to be more consistent in terms of
    lifetimes as now users cannot take the address of block of memory which can
    be freed by the cling::Value.
  * We remove the storage types and we rely on the clang::Type which we have in
    the cling::Value.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
e18104aa12 Make function file static to reduce includes 2023-02-03 07:29:07 +01:00
Vassil Vassilev
44cac5e3af Implement more robust conversion via getAs in cling::Value.
Here we enumerate most of the builtin types and we the generate template
specializations for all of them which are capable to perform the correct
conversions.
2023-02-03 07:29:07 +01:00
Vassil Vassilev
a55501d540 Add variant to the modulemap to address a cmssw-related issue. 2023-02-02 12:14:04 +01:00
Jonas Hahnfeld
dc6ee2401b Add back basic support for JITLink
The custom memory manager is only needed to avoid freeing the memory
segments; the default InProcessMemoryManager (which is mostly copied)
already does slab allocation to keep all segments together which is
needed for exception handling support.

A limitation of this rudimentary support is that CLING_DEBUG and
CLING_PROFILE do not work, they need to be registered as plugins.
2023-02-01 13:44:06 +01:00
Javier Lopez-Gomez
41c41c26df Add missing const in operator== and operator!=
Add missing `const` in `{DelayCall,MacroDirective}Info::operator==`
and `operator!=`. This fixes the following warnings in C++20
```
interpreter/cling/lib/Interpreter/Transaction.cpp:173:23: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'cling::Transaction::DelayCallInfo' and 'cling::Transaction::DelayCallInfo') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator]
interpreter/cling/lib/Interpreter/Transaction.cpp:218:21: warning: ISO C++20 considers use of overloaded operator '==' (with operand types 'cling::Transaction::MacroDirectiveInfo' and 'cling::Transaction::MacroDirectiveInfo') to be ambiguous despite there being a unique best viable function [-Wambiguous-reversed-operator]
```
2023-02-01 08:29:04 +01:00
Vassil Vassilev
c0cebd2c70 Adjust the modulemap for c++20 2023-02-01 08:29:04 +01:00
Vassil Vassilev
93e72c9d88 Revert "[cling] Add dedicated C++20 stl-modulemap:"
This reverts commit 82f1619a7179088c61bedd2f5d38d158957c7bde.
2023-02-01 08:29:04 +01:00
Axel Naumann
b8edc28315 Add dedicated C++20 stl-modulemap:
The bits/ headers have different include behavior (mostly due to ranges)
that makes it significantly harder to find a configuration working for
C++14, 17, and 20. Instead, create a dedicated modulemap for C++20.
2023-02-01 08:29:04 +01:00
Axel Naumann
f2b325b312 Keep private symbols private:
llvm IR naming of private constants (CodeGenModule::createUnnamedGlobalFrom(),
line 1136) will name private symbols without caring about possible name clashes.
We will create these name clashes by marking such private symbols as weak ones,
re-using previously emitted symbols (e.g. in JITDylib::defineImpl() where they
get added to MUDefsOverridden and thus re-used instead of re-emitted).

Let me see what happens when we keep private symbols private. In principle, the
interpreter should have no means fo accessing them from another transaction -
private symbols seem to be function-local ones.

Fixes https://github.com/root-project/root/pull/12183
2023-01-31 22:59:06 +01:00
Jiang Yi
da57784037 Set history size to ${CLING_HISTSIZE}
It was left unset. Then the default hist size was

static_cast<size_t>(-1), which is practically equivalent to unlimited

history size.
2023-01-30 10:29:07 +01:00
ferdymercury
c3dd723262 fix some more warnings in core 2023-01-30 10:29:07 +01:00
Sergey Linev
f4d11176e6 Use nullptr in core/textinput classes 2023-01-30 10:29:07 +01:00
ferdymercury
a78c5a41eb Implement .help edit (show line editor keybindings)
Co-authored-by: Javier Lopez-Gomez <javier.lopez.gomez@cern.ch>
Co-authored-by: Olivier Couet <Olivier.Couet@cern.ch>
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
401f877780 Do not assign ESC a special meaning on history search mode
UNIX terminals, e.g. vt100, send escape sequences for many special
key combinations. Entering the history search mode assigned a specific
meaning to the ESC character and disabled the processing of escape
sequences, thus accidentally printing some characters that are part
of a CSI.

As a workaround, avoid changing the meaning of ESC; users can still
use the well-known `ESC ESC` sequence (or any other editor command,
e.g. move left/right) to exit the history search mode.

This change only affects UNIX terminals.

Closes issue #10209.
2023-01-30 10:29:07 +01:00
ferdymercury
0d46b6dead Implement forward history search
Co-authored-by: Javier Lopez-Gomez <javier.lopez.gomez@cern.ch>

Fixes #10137
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
07120b98da Clear undo buffer after taking an input line
The undo buffer should only be kept for the current line (as in GNU readline).

Fixes #10182.
2023-01-30 10:29:07 +01:00
ferdymercury
97166bc3b2 prevent accessing empty vector
Fixes https://github.com/root-project/root/issues/10180
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
a575990cfc Fix implementation of the kCmdWordTo{Lower,Upper} editor commands
These commands, bound respectively to `ESC l` and `ESC u`, should {lower,upper}case
the next word; however, only the first character was changed.

Fixes #10136.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
01ffa06f0a Add a missing new-line after .q if quitting a ROOT session via Ctrl+D (EOF)
Fixes #10135.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
2dd8debdfb Fix implementation of kCmdSwapThisAndLeftThenMoveRight
This editor command (usually binded to Ctrl+T), transposes the character located
at the cursor and the one to its left.
However, its behavior was incorrect if the cursor was at end of the line,
invoking `std::string::operator[]()` passing an index that is out of bounds.

In that case, as per GNU Readline behavior, it should swap the two last
characters.

Closes #10133.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
3914be144e Bind Ctrl+Del to Editor::kCmdCutNextWord (kill next word)
This change is equivalent to the popular GNU Readline keybinding
```
"\e[3;5~": kill-word
```

As a requirement, the `[3;5~` CSI was added in StreamReaderUnix.cpp. No
additional changes required to StreamReaderWin.cpp.
2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
3a448596c6 Fix [-Winconsistent-missing-override] warnings on Apple's clang 2023-01-30 10:29:07 +01:00
Javier Lopez-Gomez
d654717749 Clear the terminal screen on Ctrl+L
Fixes #10057.
2023-01-30 10:29:07 +01:00