2019-06-04 11:11:32 +03:00
// SPDX-License-Identifier: GPL-2.0-only
2011-11-10 16:57:22 +04:00
/*
2012-06-28 11:23:08 +04:00
* Kernel - based Virtual Machine - - Performance Monitoring Unit support
2011-11-10 16:57:22 +04:00
*
2015-06-19 16:45:05 +03:00
* Copyright 2015 Red Hat , Inc . and / or its affiliates .
2011-11-10 16:57:22 +04:00
*
* Authors :
* Avi Kivity < avi @ redhat . com >
* Gleb Natapov < gleb @ redhat . com >
2015-06-19 16:45:05 +03:00
* Wei Huang < wei @ redhat . com >
2011-11-10 16:57:22 +04:00
*/
KVM: x86: Unify pr_fmt to use module name for all KVM modules
Define pr_fmt using KBUILD_MODNAME for all KVM x86 code so that printks
use consistent formatting across common x86, Intel, and AMD code. In
addition to providing consistent print formatting, using KBUILD_MODNAME,
e.g. kvm_amd and kvm_intel, allows referencing SVM and VMX (and SEV and
SGX and ...) as technologies without generating weird messages, and
without causing naming conflicts with other kernel code, e.g. "SEV: ",
"tdx: ", "sgx: " etc.. are all used by the kernel for non-KVM subsystems.
Opportunistically move away from printk() for prints that need to be
modified anyways, e.g. to drop a manual "kvm: " prefix.
Opportunistically convert a few SGX WARNs that are similarly modified to
WARN_ONCE; in the very unlikely event that the WARNs fire, odds are good
that they would fire repeatedly and spam the kernel log without providing
unique information in each print.
Note, defining pr_fmt yields undesirable results for code that uses KVM's
printk wrappers, e.g. vcpu_unimpl(). But, that's a pre-existing problem
as SVM/kvm_amd already defines a pr_fmt, and thankfully use of KVM's
wrappers is relatively limited in KVM x86 code.
Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Message-Id: <20221130230934.1014142-35-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-12-01 02:09:18 +03:00
# define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
2011-11-10 16:57:22 +04:00
# include <linux/types.h>
# include <linux/kvm_host.h>
# include <linux/perf_event.h>
2022-01-15 08:24:26 +03:00
# include <linux/bsearch.h>
# include <linux/sort.h>
2014-08-20 14:25:52 +04:00
# include <asm/perf_event.h>
2022-05-18 20:01:16 +03:00
# include <asm/cpu_device_id.h>
2011-11-10 16:57:22 +04:00
# include "x86.h"
# include "cpuid.h"
# include "lapic.h"
2015-06-19 14:54:23 +03:00
# include "pmu.h"
2011-11-10 16:57:22 +04:00
2019-07-18 21:38:18 +03:00
/* This is enough to filter the vast majority of currently defined events. */
# define KVM_PMU_EVENT_FILTER_MAX_EVENTS 300
2019-07-11 04:25:15 +03:00
2022-04-11 13:19:44 +03:00
struct x86_pmu_capability __read_mostly kvm_pmu_cap ;
EXPORT_SYMBOL_GPL ( kvm_pmu_cap ) ;
2022-05-18 20:01:16 +03:00
static const struct x86_cpu_id vmx_icl_pebs_cpu [ ] = {
X86_MATCH_INTEL_FAM6_MODEL ( ICELAKE_D , NULL ) ,
X86_MATCH_INTEL_FAM6_MODEL ( ICELAKE_X , NULL ) ,
{ }
} ;
2015-06-19 16:45:05 +03:00
/* NOTE:
* - Each perf counter is defined as " struct kvm_pmc " ;
* - There are two types of perf counters : general purpose ( gp ) and fixed .
* gp counters are stored in gp_counters [ ] and fixed counters are stored
* in fixed_counters [ ] respectively . Both of them are part of " struct
* kvm_pmu " ;
* - pmu . c understands the difference between gp counters and fixed counters .
* However AMD doesn ' t support fixed - counters ;
* - There are three types of index to access perf counters ( PMC ) :
* 1. MSR ( named msr ) : For example Intel has MSR_IA32_PERFCTRn and AMD
2022-05-18 16:25:02 +03:00
* has MSR_K7_PERFCTRn and , for families 15 H and later ,
* MSR_F15H_PERF_CTRn , where MSR_F15H_PERF_CTR [ 0 - 3 ] are
* aliased to MSR_K7_PERFCTRn .
2015-06-19 16:45:05 +03:00
* 2. MSR Index ( named idx ) : This normally is used by RDPMC instruction .
* For instance AMD RDPMC instruction uses 0000 _0003h in ECX to access
* C001_0007h ( MSR_K7_PERCTR3 ) . Intel has a similar mechanism , except
* that it also supports fixed counters . idx can be used to as index to
* gp and fixed counters .
* 3. Global PMC Index ( named pmc ) : pmc is an index specific to PMU
* code . Each pmc , stored in kvm_pmc . idx field , is unique across
* all perf counters ( both gp and fixed ) . The mapping relationship
* between pmc and perf counters is as the following :
2022-09-19 12:10:07 +03:00
* * Intel : [ 0 . . KVM_INTEL_PMC_MAX_GENERIC - 1 ] < = > gp counters
2015-06-19 16:45:05 +03:00
* [ INTEL_PMC_IDX_FIXED . . INTEL_PMC_IDX_FIXED + 2 ] < = > fixed
2022-05-18 16:25:02 +03:00
* * AMD : [ 0 . . AMD64_NUM_COUNTERS - 1 ] and , for families 15 H
* and later , [ 0 . . AMD64_NUM_COUNTERS_CORE - 1 ] < = > gp counters
2015-06-19 16:45:05 +03:00
*/
2011-11-10 16:57:22 +04:00
2022-03-30 02:50:52 +03:00
static struct kvm_pmu_ops kvm_pmu_ops __read_mostly ;
2022-03-30 02:50:54 +03:00
# define KVM_X86_PMU_OP(func) \
DEFINE_STATIC_CALL_NULL ( kvm_x86_pmu_ # # func , \
* ( ( ( struct kvm_pmu_ops * ) 0 ) - > func ) ) ;
# define KVM_X86_PMU_OP_OPTIONAL KVM_X86_PMU_OP
# include <asm/kvm-x86-pmu-ops.h>
2022-03-30 02:50:52 +03:00
void kvm_pmu_ops_update ( const struct kvm_pmu_ops * pmu_ops )
{
memcpy ( & kvm_pmu_ops , pmu_ops , sizeof ( kvm_pmu_ops ) ) ;
2022-03-30 02:50:54 +03:00
# define __KVM_X86_PMU_OP(func) \
static_call_update ( kvm_x86_pmu_ # # func , kvm_pmu_ops . func ) ;
# define KVM_X86_PMU_OP(func) \
WARN_ON ( ! kvm_pmu_ops . func ) ; __KVM_X86_PMU_OP ( func )
# define KVM_X86_PMU_OP_OPTIONAL __KVM_X86_PMU_OP
# include <asm/kvm-x86-pmu-ops.h>
# undef __KVM_X86_PMU_OP
2022-03-30 02:50:52 +03:00
}
static inline bool pmc_is_enabled ( struct kvm_pmc * pmc )
{
2022-03-30 02:50:54 +03:00
return static_call ( kvm_x86_pmu_pmc_is_enabled ) ( pmc ) ;
2022-03-30 02:50:52 +03:00
}
2015-06-19 14:44:45 +03:00
static void kvm_pmi_trigger_fn ( struct irq_work * irq_work )
2011-11-10 16:57:22 +04:00
{
2015-06-19 15:00:33 +03:00
struct kvm_pmu * pmu = container_of ( irq_work , struct kvm_pmu , irq_work ) ;
struct kvm_vcpu * vcpu = pmu_to_vcpu ( pmu ) ;
2011-11-10 16:57:22 +04:00
2015-06-19 14:44:45 +03:00
kvm_pmu_deliver_pmi ( vcpu ) ;
2011-11-10 16:57:22 +04:00
}
2021-11-30 10:42:19 +03:00
static inline void __kvm_perf_overflow ( struct kvm_pmc * pmc , bool in_pmi )
2011-11-10 16:57:22 +04:00
{
2015-06-19 15:00:33 +03:00
struct kvm_pmu * pmu = pmc_to_pmu ( pmc ) ;
2022-04-11 13:19:37 +03:00
bool skip_pmi = false ;
2015-06-19 15:15:28 +03:00
2022-04-11 13:19:37 +03:00
if ( pmc - > perf_event & & pmc - > perf_event - > attr . precise_ip ) {
2022-08-31 11:53:23 +03:00
if ( ! in_pmi ) {
/*
* TODO : KVM is currently _choosing_ to not generate records
* for emulated instructions , avoiding BUFFER_OVF PMI when
* there are no records . Strictly speaking , it should be done
* as well in the right context to improve sampling accuracy .
*/
skip_pmi = true ;
} else {
/* Indicate PEBS overflow PMI to guest. */
skip_pmi = __test_and_set_bit ( GLOBAL_STATUS_BUFFER_OVF_BIT ,
( unsigned long * ) & pmu - > global_status ) ;
}
2022-04-11 13:19:37 +03:00
} else {
__set_bit ( pmc - > idx , ( unsigned long * ) & pmu - > global_status ) ;
}
2021-11-30 10:42:19 +03:00
2022-04-11 13:19:37 +03:00
if ( ! pmc - > intr | | skip_pmi )
2021-11-30 10:42:19 +03:00
return ;
/*
* Inject PMI . If vcpu was in a guest mode during NMI PMI
* can be ejected on a guest mode re - entry . Otherwise we can ' t
* be sure that vcpu wasn ' t executing hlt instruction at the
* time of vmexit and is not going to re - enter guest mode until
* woken up . So we should wake it , but this is impossible from
* NMI context . Do it from irq work instead .
*/
2022-01-16 17:15:14 +03:00
if ( in_pmi & & ! kvm_handling_nmi_from_guest ( pmc - > vcpu ) )
2021-11-30 10:42:19 +03:00
irq_work_queue ( & pmc_to_pmu ( pmc ) - > irq_work ) ;
else
kvm_make_request ( KVM_REQ_PMI , pmc - > vcpu ) ;
2011-11-10 16:57:22 +04:00
}
2021-11-30 10:42:19 +03:00
static void kvm_perf_overflow ( struct perf_event * perf_event ,
struct perf_sample_data * data ,
struct pt_regs * regs )
2011-11-10 16:57:22 +04:00
{
struct kvm_pmc * pmc = perf_event - > overflow_handler_context ;
2015-06-19 15:15:28 +03:00
KVM: x86/pmu: Defer counter emulated overflow via pmc->prev_counter
Defer reprogramming counters and handling overflow via KVM_REQ_PMU
when incrementing counters. KVM skips emulated WRMSR in the VM-Exit
fastpath, the fastpath runs with IRQs disabled, skipping instructions
can increment and reprogram counters, reprogramming counters can
sleep, and sleeping is disallowed while IRQs are disabled.
[*] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:580
[*] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 2981888, name: CPU 15/KVM
[*] preempt_count: 1, expected: 0
[*] RCU nest depth: 0, expected: 0
[*] INFO: lockdep is turned off.
[*] irq event stamp: 0
[*] hardirqs last enabled at (0): [<0000000000000000>] 0x0
[*] hardirqs last disabled at (0): [<ffffffff8121222a>] copy_process+0x146a/0x62d0
[*] softirqs last enabled at (0): [<ffffffff81212269>] copy_process+0x14a9/0x62d0
[*] softirqs last disabled at (0): [<0000000000000000>] 0x0
[*] Preemption disabled at:
[*] [<ffffffffc2063fc1>] vcpu_enter_guest+0x1001/0x3dc0 [kvm]
[*] CPU: 17 PID: 2981888 Comm: CPU 15/KVM Kdump: 5.19.0-rc1-g239111db364c-dirty #2
[*] Call Trace:
[*] <TASK>
[*] dump_stack_lvl+0x6c/0x9b
[*] __might_resched.cold+0x22e/0x297
[*] __mutex_lock+0xc0/0x23b0
[*] perf_event_ctx_lock_nested+0x18f/0x340
[*] perf_event_pause+0x1a/0x110
[*] reprogram_counter+0x2af/0x1490 [kvm]
[*] kvm_pmu_trigger_event+0x429/0x950 [kvm]
[*] kvm_skip_emulated_instruction+0x48/0x90 [kvm]
[*] handle_fastpath_set_msr_irqoff+0x349/0x3b0 [kvm]
[*] vmx_vcpu_run+0x268e/0x3b80 [kvm_intel]
[*] vcpu_enter_guest+0x1d22/0x3dc0 [kvm]
Add a field to kvm_pmc to track the previous counter value in order
to defer overflow detection to kvm_pmu_handle_event() (the counter must
be paused before handling overflow, and that may increment the counter).
Opportunistically shrink sizeof(struct kvm_pmc) a bit.
Suggested-by: Wanpeng Li <wanpengli@tencent.com>
Fixes: 9cd803d496e7 ("KVM: x86: Update vPMCs when retiring instructions")
Signed-off-by: Like Xu <likexu@tencent.com>
Link: https://lore.kernel.org/r/20220831085328.45489-6-likexu@tencent.com
[sean: avoid re-triggering KVM_REQ_PMU on overflow, tweak changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20220923001355.3741194-5-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-09-23 03:13:55 +03:00
/*
* Ignore overflow events for counters that are scheduled to be
* reprogrammed , e . g . if a PMI for the previous event races with KVM ' s
* handling of a related guest WRMSR .
*/
if ( test_and_set_bit ( pmc - > idx , pmc_to_pmu ( pmc ) - > reprogram_pmi ) )
return ;
2021-11-30 10:42:19 +03:00
__kvm_perf_overflow ( pmc , true ) ;
KVM: x86/pmu: Defer counter emulated overflow via pmc->prev_counter
Defer reprogramming counters and handling overflow via KVM_REQ_PMU
when incrementing counters. KVM skips emulated WRMSR in the VM-Exit
fastpath, the fastpath runs with IRQs disabled, skipping instructions
can increment and reprogram counters, reprogramming counters can
sleep, and sleeping is disallowed while IRQs are disabled.
[*] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:580
[*] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 2981888, name: CPU 15/KVM
[*] preempt_count: 1, expected: 0
[*] RCU nest depth: 0, expected: 0
[*] INFO: lockdep is turned off.
[*] irq event stamp: 0
[*] hardirqs last enabled at (0): [<0000000000000000>] 0x0
[*] hardirqs last disabled at (0): [<ffffffff8121222a>] copy_process+0x146a/0x62d0
[*] softirqs last enabled at (0): [<ffffffff81212269>] copy_process+0x14a9/0x62d0
[*] softirqs last disabled at (0): [<0000000000000000>] 0x0
[*] Preemption disabled at:
[*] [<ffffffffc2063fc1>] vcpu_enter_guest+0x1001/0x3dc0 [kvm]
[*] CPU: 17 PID: 2981888 Comm: CPU 15/KVM Kdump: 5.19.0-rc1-g239111db364c-dirty #2
[*] Call Trace:
[*] <TASK>
[*] dump_stack_lvl+0x6c/0x9b
[*] __might_resched.cold+0x22e/0x297
[*] __mutex_lock+0xc0/0x23b0
[*] perf_event_ctx_lock_nested+0x18f/0x340
[*] perf_event_pause+0x1a/0x110
[*] reprogram_counter+0x2af/0x1490 [kvm]
[*] kvm_pmu_trigger_event+0x429/0x950 [kvm]
[*] kvm_skip_emulated_instruction+0x48/0x90 [kvm]
[*] handle_fastpath_set_msr_irqoff+0x349/0x3b0 [kvm]
[*] vmx_vcpu_run+0x268e/0x3b80 [kvm_intel]
[*] vcpu_enter_guest+0x1d22/0x3dc0 [kvm]
Add a field to kvm_pmc to track the previous counter value in order
to defer overflow detection to kvm_pmu_handle_event() (the counter must
be paused before handling overflow, and that may increment the counter).
Opportunistically shrink sizeof(struct kvm_pmc) a bit.
Suggested-by: Wanpeng Li <wanpengli@tencent.com>
Fixes: 9cd803d496e7 ("KVM: x86: Update vPMCs when retiring instructions")
Signed-off-by: Like Xu <likexu@tencent.com>
Link: https://lore.kernel.org/r/20220831085328.45489-6-likexu@tencent.com
[sean: avoid re-triggering KVM_REQ_PMU on overflow, tweak changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20220923001355.3741194-5-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-09-23 03:13:55 +03:00
kvm_make_request ( KVM_REQ_PMU , pmc - > vcpu ) ;
2011-11-10 16:57:22 +04:00
}
2022-09-23 03:13:53 +03:00
static int pmc_reprogram_counter ( struct kvm_pmc * pmc , u32 type , u64 config ,
bool exclude_user , bool exclude_kernel ,
bool intr )
2011-11-10 16:57:22 +04:00
{
2022-04-11 13:19:37 +03:00
struct kvm_pmu * pmu = pmc_to_pmu ( pmc ) ;
2011-11-10 16:57:22 +04:00
struct perf_event * event ;
struct perf_event_attr attr = {
. type = type ,
. size = sizeof ( attr ) ,
. pinned = true ,
. exclude_idle = true ,
. exclude_host = 1 ,
. exclude_user = exclude_user ,
. exclude_kernel = exclude_kernel ,
. config = config ,
} ;
2022-04-11 13:19:37 +03:00
bool pebs = test_bit ( pmc - > idx , ( unsigned long * ) & pmu - > pebs_enable ) ;
2015-06-19 15:15:28 +03:00
2020-02-22 05:34:13 +03:00
attr . sample_period = get_sample_period ( pmc , pmc - > counter ) ;
KVM: x86: never specify a sample period for virtualized in_tx_cp counters
pmc_reprogram_counter() always sets a sample period based on the value of
pmc->counter. However, hsw_hw_config() rejects sample periods less than
2^31 - 1. So for example, if a KVM guest does
struct perf_event_attr attr;
memset(&attr, 0, sizeof(attr));
attr.type = PERF_TYPE_RAW;
attr.size = sizeof(attr);
attr.config = 0x2005101c4; // conditional branches retired IN_TXCP
attr.sample_period = 0;
int fd = syscall(__NR_perf_event_open, &attr, 0, -1, -1, 0);
ioctl(fd, PERF_EVENT_IOC_DISABLE, 0);
ioctl(fd, PERF_EVENT_IOC_ENABLE, 0);
the guest kernel counts some conditional branch events, then updates the
virtual PMU register with a nonzero count. The host reaches
pmc_reprogram_counter() with nonzero pmc->counter, triggers EOPNOTSUPP
in hsw_hw_config(), prints "kvm_pmu: event creation failed" in
pmc_reprogram_counter(), and silently (from the guest's point of view) stops
counting events.
We fix event counting by forcing attr.sample_period to always be zero for
in_tx_cp counters. Sampling doesn't work, but it already didn't work and
can't be fixed without major changes to the approach in hsw_hw_config().
Signed-off-by: Robert O'Callahan <robert@ocallahan.org>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
2017-02-01 07:06:11 +03:00
2022-03-09 11:42:57 +03:00
if ( ( attr . config & HSW_IN_TX_CHECKPOINTED ) & &
guest_cpuid_is_intel ( pmc - > vcpu ) ) {
KVM: x86: never specify a sample period for virtualized in_tx_cp counters
pmc_reprogram_counter() always sets a sample period based on the value of
pmc->counter. However, hsw_hw_config() rejects sample periods less than
2^31 - 1. So for example, if a KVM guest does
struct perf_event_attr attr;
memset(&attr, 0, sizeof(attr));
attr.type = PERF_TYPE_RAW;
attr.size = sizeof(attr);
attr.config = 0x2005101c4; // conditional branches retired IN_TXCP
attr.sample_period = 0;
int fd = syscall(__NR_perf_event_open, &attr, 0, -1, -1, 0);
ioctl(fd, PERF_EVENT_IOC_DISABLE, 0);
ioctl(fd, PERF_EVENT_IOC_ENABLE, 0);
the guest kernel counts some conditional branch events, then updates the
virtual PMU register with a nonzero count. The host reaches
pmc_reprogram_counter() with nonzero pmc->counter, triggers EOPNOTSUPP
in hsw_hw_config(), prints "kvm_pmu: event creation failed" in
pmc_reprogram_counter(), and silently (from the guest's point of view) stops
counting events.
We fix event counting by forcing attr.sample_period to always be zero for
in_tx_cp counters. Sampling doesn't work, but it already didn't work and
can't be fixed without major changes to the approach in hsw_hw_config().
Signed-off-by: Robert O'Callahan <robert@ocallahan.org>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
2017-02-01 07:06:11 +03:00
/*
* HSW_IN_TX_CHECKPOINTED is not supported with nonzero
* period . Just clear the sample period so at least
* allocating the counter doesn ' t fail .
*/
attr . sample_period = 0 ;
}
2022-04-11 13:19:37 +03:00
if ( pebs ) {
/*
* The non - zero precision level of guest event makes the ordinary
* guest event becomes a guest PEBS event and triggers the host
* PEBS PMI handler to determine whether the PEBS overflow PMI
* comes from the host counters or the guest .
*
* For most PEBS hardware events , the difference in the software
* precision levels of guest and host PEBS events will not affect
* the accuracy of the PEBS profiling result , because the " event IP "
* in the PEBS record is calibrated on the guest side .
*
* On Icelake everything is fine . Other hardware ( GLC + , TNT + ) that
* could possibly care here is unsupported and needs changes .
*/
attr . precise_ip = 1 ;
2022-04-11 13:19:38 +03:00
if ( x86_match_cpu ( vmx_icl_pebs_cpu ) & & pmc - > idx = = 32 )
attr . precise_ip = 3 ;
2022-04-11 13:19:37 +03:00
}
2011-11-10 16:57:22 +04:00
event = perf_event_create_kernel_counter ( & attr , - 1 , current ,
kvm_perf_overflow , pmc ) ;
if ( IS_ERR ( event ) ) {
2019-07-18 08:35:14 +03:00
pr_debug_ratelimited ( " kvm_pmu: event creation failed %ld for pmc->idx = %d \n " ,
PTR_ERR ( event ) , pmc - > idx ) ;
2022-09-23 03:13:53 +03:00
return PTR_ERR ( event ) ;
2011-11-10 16:57:22 +04:00
}
pmc - > perf_event = event ;
2019-10-27 13:52:43 +03:00
pmc_to_pmu ( pmc ) - > event_count + + ;
KVM: x86/pmu: Introduce pmc->is_paused to reduce the call time of perf interfaces
Based on our observations, after any vm-exit associated with vPMU, there
are at least two or more perf interfaces to be called for guest counter
emulation, such as perf_event_{pause, read_value, period}(), and each one
will {lock, unlock} the same perf_event_ctx. The frequency of calls becomes
more severe when guest use counters in a multiplexed manner.
Holding a lock once and completing the KVM request operations in the perf
context would introduce a set of impractical new interfaces. So we can
further optimize the vPMU implementation by avoiding repeated calls to
these interfaces in the KVM context for at least one pattern:
After we call perf_event_pause() once, the event will be disabled and its
internal count will be reset to 0. So there is no need to pause it again
or read its value. Once the event is paused, event period will not be
updated until the next time it's resumed or reprogrammed. And there is
also no need to call perf_event_period twice for a non-running counter,
considering the perf_event for a running counter is never paused.
Based on this implementation, for the following common usage of
sampling 4 events using perf on a 4u8g guest:
echo 0 > /proc/sys/kernel/watchdog
echo 25 > /proc/sys/kernel/perf_cpu_time_max_percent
echo 10000 > /proc/sys/kernel/perf_event_max_sample_rate
echo 0 > /proc/sys/kernel/perf_cpu_time_max_percent
for i in `seq 1 1 10`
do
taskset -c 0 perf record \
-e cpu-cycles -e instructions -e branch-instructions -e cache-misses \
/root/br_instr a
done
the average latency of the guest NMI handler is reduced from
37646.7 ns to 32929.3 ns (~1.14x speed up) on the Intel ICX server.
Also, in addition to collecting more samples, no loss of sampling
accuracy was observed compared to before the optimization.
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20210728120705.6855-1-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
2021-07-28 15:07:05 +03:00
pmc - > is_paused = false ;
2022-04-11 13:19:37 +03:00
pmc - > intr = intr | | pebs ;
2022-09-23 03:13:53 +03:00
return 0 ;
2011-11-10 16:57:22 +04:00
}
KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
The perf_event_create_kernel_counter() in the pmc_reprogram_counter() is
a heavyweight and high-frequency operation, especially when host disables
the watchdog (maximum 21000000 ns) which leads to an unacceptable latency
of the guest NMI handler. It limits the use of vPMUs in the guest.
When a vPMC is fully enabled, the legacy reprogram_*_counter() would stop
and release its existing perf_event (if any) every time EVEN in most cases
almost the same requested perf_event will be created and configured again.
For each vPMC, if the reuqested config ('u64 eventsel' for gp and 'u8 ctrl'
for fixed) is the same as its current config AND a new sample period based
on pmc->counter is accepted by host perf interface, the current event could
be reused safely as a new created one does. Otherwise, do release the
undesirable perf_event and reprogram a new one as usual.
It's light-weight to call pmc_pause_counter (disable, read and reset event)
and pmc_resume_counter (recalibrate period and re-enable event) as guest
expects instead of release-and-create again on any condition. Compared to
use the filterable event->attr or hw.config, a new 'u64 current_config'
field is added to save the last original programed config for each vPMC.
Based on this implementation, the number of calls to pmc_reprogram_counter
is reduced by ~82.5% for a gp sampling event and ~99.9% for a fixed event.
In the usage of multiplexing perf sampling mode, the average latency of the
guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up).
If host disables watchdog, the minimum latecy of guest NMI handler could be
speed up at ~3413x (from 20407603 to 5979 ns) and at ~786x in the average.
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2019-10-27 13:52:42 +03:00
static void pmc_pause_counter ( struct kvm_pmc * pmc )
{
u64 counter = pmc - > counter ;
KVM: x86/pmu: Introduce pmc->is_paused to reduce the call time of perf interfaces
Based on our observations, after any vm-exit associated with vPMU, there
are at least two or more perf interfaces to be called for guest counter
emulation, such as perf_event_{pause, read_value, period}(), and each one
will {lock, unlock} the same perf_event_ctx. The frequency of calls becomes
more severe when guest use counters in a multiplexed manner.
Holding a lock once and completing the KVM request operations in the perf
context would introduce a set of impractical new interfaces. So we can
further optimize the vPMU implementation by avoiding repeated calls to
these interfaces in the KVM context for at least one pattern:
After we call perf_event_pause() once, the event will be disabled and its
internal count will be reset to 0. So there is no need to pause it again
or read its value. Once the event is paused, event period will not be
updated until the next time it's resumed or reprogrammed. And there is
also no need to call perf_event_period twice for a non-running counter,
considering the perf_event for a running counter is never paused.
Based on this implementation, for the following common usage of
sampling 4 events using perf on a 4u8g guest:
echo 0 > /proc/sys/kernel/watchdog
echo 25 > /proc/sys/kernel/perf_cpu_time_max_percent
echo 10000 > /proc/sys/kernel/perf_event_max_sample_rate
echo 0 > /proc/sys/kernel/perf_cpu_time_max_percent
for i in `seq 1 1 10`
do
taskset -c 0 perf record \
-e cpu-cycles -e instructions -e branch-instructions -e cache-misses \
/root/br_instr a
done
the average latency of the guest NMI handler is reduced from
37646.7 ns to 32929.3 ns (~1.14x speed up) on the Intel ICX server.
Also, in addition to collecting more samples, no loss of sampling
accuracy was observed compared to before the optimization.
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20210728120705.6855-1-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
2021-07-28 15:07:05 +03:00
if ( ! pmc - > perf_event | | pmc - > is_paused )
KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
The perf_event_create_kernel_counter() in the pmc_reprogram_counter() is
a heavyweight and high-frequency operation, especially when host disables
the watchdog (maximum 21000000 ns) which leads to an unacceptable latency
of the guest NMI handler. It limits the use of vPMUs in the guest.
When a vPMC is fully enabled, the legacy reprogram_*_counter() would stop
and release its existing perf_event (if any) every time EVEN in most cases
almost the same requested perf_event will be created and configured again.
For each vPMC, if the reuqested config ('u64 eventsel' for gp and 'u8 ctrl'
for fixed) is the same as its current config AND a new sample period based
on pmc->counter is accepted by host perf interface, the current event could
be reused safely as a new created one does. Otherwise, do release the
undesirable perf_event and reprogram a new one as usual.
It's light-weight to call pmc_pause_counter (disable, read and reset event)
and pmc_resume_counter (recalibrate period and re-enable event) as guest
expects instead of release-and-create again on any condition. Compared to
use the filterable event->attr or hw.config, a new 'u64 current_config'
field is added to save the last original programed config for each vPMC.
Based on this implementation, the number of calls to pmc_reprogram_counter
is reduced by ~82.5% for a gp sampling event and ~99.9% for a fixed event.
In the usage of multiplexing perf sampling mode, the average latency of the
guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up).
If host disables watchdog, the minimum latecy of guest NMI handler could be
speed up at ~3413x (from 20407603 to 5979 ns) and at ~786x in the average.
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2019-10-27 13:52:42 +03:00
return ;
/* update counter, reset event value to avoid redundant accumulation */
counter + = perf_event_pause ( pmc - > perf_event , true ) ;
pmc - > counter = counter & pmc_bitmask ( pmc ) ;
KVM: x86/pmu: Introduce pmc->is_paused to reduce the call time of perf interfaces
Based on our observations, after any vm-exit associated with vPMU, there
are at least two or more perf interfaces to be called for guest counter
emulation, such as perf_event_{pause, read_value, period}(), and each one
will {lock, unlock} the same perf_event_ctx. The frequency of calls becomes
more severe when guest use counters in a multiplexed manner.
Holding a lock once and completing the KVM request operations in the perf
context would introduce a set of impractical new interfaces. So we can
further optimize the vPMU implementation by avoiding repeated calls to
these interfaces in the KVM context for at least one pattern:
After we call perf_event_pause() once, the event will be disabled and its
internal count will be reset to 0. So there is no need to pause it again
or read its value. Once the event is paused, event period will not be
updated until the next time it's resumed or reprogrammed. And there is
also no need to call perf_event_period twice for a non-running counter,
considering the perf_event for a running counter is never paused.
Based on this implementation, for the following common usage of
sampling 4 events using perf on a 4u8g guest:
echo 0 > /proc/sys/kernel/watchdog
echo 25 > /proc/sys/kernel/perf_cpu_time_max_percent
echo 10000 > /proc/sys/kernel/perf_event_max_sample_rate
echo 0 > /proc/sys/kernel/perf_cpu_time_max_percent
for i in `seq 1 1 10`
do
taskset -c 0 perf record \
-e cpu-cycles -e instructions -e branch-instructions -e cache-misses \
/root/br_instr a
done
the average latency of the guest NMI handler is reduced from
37646.7 ns to 32929.3 ns (~1.14x speed up) on the Intel ICX server.
Also, in addition to collecting more samples, no loss of sampling
accuracy was observed compared to before the optimization.
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20210728120705.6855-1-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
2021-07-28 15:07:05 +03:00
pmc - > is_paused = true ;
KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
The perf_event_create_kernel_counter() in the pmc_reprogram_counter() is
a heavyweight and high-frequency operation, especially when host disables
the watchdog (maximum 21000000 ns) which leads to an unacceptable latency
of the guest NMI handler. It limits the use of vPMUs in the guest.
When a vPMC is fully enabled, the legacy reprogram_*_counter() would stop
and release its existing perf_event (if any) every time EVEN in most cases
almost the same requested perf_event will be created and configured again.
For each vPMC, if the reuqested config ('u64 eventsel' for gp and 'u8 ctrl'
for fixed) is the same as its current config AND a new sample period based
on pmc->counter is accepted by host perf interface, the current event could
be reused safely as a new created one does. Otherwise, do release the
undesirable perf_event and reprogram a new one as usual.
It's light-weight to call pmc_pause_counter (disable, read and reset event)
and pmc_resume_counter (recalibrate period and re-enable event) as guest
expects instead of release-and-create again on any condition. Compared to
use the filterable event->attr or hw.config, a new 'u64 current_config'
field is added to save the last original programed config for each vPMC.
Based on this implementation, the number of calls to pmc_reprogram_counter
is reduced by ~82.5% for a gp sampling event and ~99.9% for a fixed event.
In the usage of multiplexing perf sampling mode, the average latency of the
guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up).
If host disables watchdog, the minimum latecy of guest NMI handler could be
speed up at ~3413x (from 20407603 to 5979 ns) and at ~786x in the average.
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2019-10-27 13:52:42 +03:00
}
static bool pmc_resume_counter ( struct kvm_pmc * pmc )
{
if ( ! pmc - > perf_event )
return false ;
/* recalibrate sample period and check if it's accepted by perf core */
2022-12-07 10:15:05 +03:00
if ( is_sampling_event ( pmc - > perf_event ) & &
perf_event_period ( pmc - > perf_event ,
2020-02-22 05:34:13 +03:00
get_sample_period ( pmc , pmc - > counter ) ) )
KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
The perf_event_create_kernel_counter() in the pmc_reprogram_counter() is
a heavyweight and high-frequency operation, especially when host disables
the watchdog (maximum 21000000 ns) which leads to an unacceptable latency
of the guest NMI handler. It limits the use of vPMUs in the guest.
When a vPMC is fully enabled, the legacy reprogram_*_counter() would stop
and release its existing perf_event (if any) every time EVEN in most cases
almost the same requested perf_event will be created and configured again.
For each vPMC, if the reuqested config ('u64 eventsel' for gp and 'u8 ctrl'
for fixed) is the same as its current config AND a new sample period based
on pmc->counter is accepted by host perf interface, the current event could
be reused safely as a new created one does. Otherwise, do release the
undesirable perf_event and reprogram a new one as usual.
It's light-weight to call pmc_pause_counter (disable, read and reset event)
and pmc_resume_counter (recalibrate period and re-enable event) as guest
expects instead of release-and-create again on any condition. Compared to
use the filterable event->attr or hw.config, a new 'u64 current_config'
field is added to save the last original programed config for each vPMC.
Based on this implementation, the number of calls to pmc_reprogram_counter
is reduced by ~82.5% for a gp sampling event and ~99.9% for a fixed event.
In the usage of multiplexing perf sampling mode, the average latency of the
guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up).
If host disables watchdog, the minimum latecy of guest NMI handler could be
speed up at ~3413x (from 20407603 to 5979 ns) and at ~786x in the average.
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2019-10-27 13:52:42 +03:00
return false ;
2022-08-31 11:53:24 +03:00
if ( test_bit ( pmc - > idx , ( unsigned long * ) & pmc_to_pmu ( pmc ) - > pebs_enable ) ! =
( ! ! pmc - > perf_event - > attr . precise_ip ) )
2022-04-11 13:19:37 +03:00
return false ;
KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
The perf_event_create_kernel_counter() in the pmc_reprogram_counter() is
a heavyweight and high-frequency operation, especially when host disables
the watchdog (maximum 21000000 ns) which leads to an unacceptable latency
of the guest NMI handler. It limits the use of vPMUs in the guest.
When a vPMC is fully enabled, the legacy reprogram_*_counter() would stop
and release its existing perf_event (if any) every time EVEN in most cases
almost the same requested perf_event will be created and configured again.
For each vPMC, if the reuqested config ('u64 eventsel' for gp and 'u8 ctrl'
for fixed) is the same as its current config AND a new sample period based
on pmc->counter is accepted by host perf interface, the current event could
be reused safely as a new created one does. Otherwise, do release the
undesirable perf_event and reprogram a new one as usual.
It's light-weight to call pmc_pause_counter (disable, read and reset event)
and pmc_resume_counter (recalibrate period and re-enable event) as guest
expects instead of release-and-create again on any condition. Compared to
use the filterable event->attr or hw.config, a new 'u64 current_config'
field is added to save the last original programed config for each vPMC.
Based on this implementation, the number of calls to pmc_reprogram_counter
is reduced by ~82.5% for a gp sampling event and ~99.9% for a fixed event.
In the usage of multiplexing perf sampling mode, the average latency of the
guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up).
If host disables watchdog, the minimum latecy of guest NMI handler could be
speed up at ~3413x (from 20407603 to 5979 ns) and at ~786x in the average.
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2019-10-27 13:52:42 +03:00
/* reuse perf_event to serve as pmc_reprogram_counter() does*/
perf_event_enable ( pmc - > perf_event ) ;
KVM: x86/pmu: Introduce pmc->is_paused to reduce the call time of perf interfaces
Based on our observations, after any vm-exit associated with vPMU, there
are at least two or more perf interfaces to be called for guest counter
emulation, such as perf_event_{pause, read_value, period}(), and each one
will {lock, unlock} the same perf_event_ctx. The frequency of calls becomes
more severe when guest use counters in a multiplexed manner.
Holding a lock once and completing the KVM request operations in the perf
context would introduce a set of impractical new interfaces. So we can
further optimize the vPMU implementation by avoiding repeated calls to
these interfaces in the KVM context for at least one pattern:
After we call perf_event_pause() once, the event will be disabled and its
internal count will be reset to 0. So there is no need to pause it again
or read its value. Once the event is paused, event period will not be
updated until the next time it's resumed or reprogrammed. And there is
also no need to call perf_event_period twice for a non-running counter,
considering the perf_event for a running counter is never paused.
Based on this implementation, for the following common usage of
sampling 4 events using perf on a 4u8g guest:
echo 0 > /proc/sys/kernel/watchdog
echo 25 > /proc/sys/kernel/perf_cpu_time_max_percent
echo 10000 > /proc/sys/kernel/perf_event_max_sample_rate
echo 0 > /proc/sys/kernel/perf_cpu_time_max_percent
for i in `seq 1 1 10`
do
taskset -c 0 perf record \
-e cpu-cycles -e instructions -e branch-instructions -e cache-misses \
/root/br_instr a
done
the average latency of the guest NMI handler is reduced from
37646.7 ns to 32929.3 ns (~1.14x speed up) on the Intel ICX server.
Also, in addition to collecting more samples, no loss of sampling
accuracy was observed compared to before the optimization.
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20210728120705.6855-1-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
2021-07-28 15:07:05 +03:00
pmc - > is_paused = false ;
KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
The perf_event_create_kernel_counter() in the pmc_reprogram_counter() is
a heavyweight and high-frequency operation, especially when host disables
the watchdog (maximum 21000000 ns) which leads to an unacceptable latency
of the guest NMI handler. It limits the use of vPMUs in the guest.
When a vPMC is fully enabled, the legacy reprogram_*_counter() would stop
and release its existing perf_event (if any) every time EVEN in most cases
almost the same requested perf_event will be created and configured again.
For each vPMC, if the reuqested config ('u64 eventsel' for gp and 'u8 ctrl'
for fixed) is the same as its current config AND a new sample period based
on pmc->counter is accepted by host perf interface, the current event could
be reused safely as a new created one does. Otherwise, do release the
undesirable perf_event and reprogram a new one as usual.
It's light-weight to call pmc_pause_counter (disable, read and reset event)
and pmc_resume_counter (recalibrate period and re-enable event) as guest
expects instead of release-and-create again on any condition. Compared to
use the filterable event->attr or hw.config, a new 'u64 current_config'
field is added to save the last original programed config for each vPMC.
Based on this implementation, the number of calls to pmc_reprogram_counter
is reduced by ~82.5% for a gp sampling event and ~99.9% for a fixed event.
In the usage of multiplexing perf sampling mode, the average latency of the
guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up).
If host disables watchdog, the minimum latecy of guest NMI handler could be
speed up at ~3413x (from 20407603 to 5979 ns) and at ~786x in the average.
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2019-10-27 13:52:42 +03:00
return true ;
}
2022-05-17 08:12:36 +03:00
static int cmp_u64 ( const void * pa , const void * pb )
2022-01-15 08:24:26 +03:00
{
2022-05-17 08:12:36 +03:00
u64 a = * ( u64 * ) pa ;
u64 b = * ( u64 * ) pb ;
return ( a > b ) - ( a < b ) ;
2022-01-15 08:24:26 +03:00
}
2022-05-18 16:25:03 +03:00
static bool check_pmu_event_filter ( struct kvm_pmc * pmc )
{
struct kvm_pmu_event_filter * filter ;
struct kvm * kvm = pmc - > vcpu - > kvm ;
bool allow_event = true ;
__u64 key ;
int idx ;
2022-05-18 16:25:12 +03:00
if ( ! static_call ( kvm_x86_pmu_hw_event_available ) ( pmc ) )
return false ;
2022-05-18 16:25:03 +03:00
filter = srcu_dereference ( kvm - > arch . pmu_event_filter , & kvm - > srcu ) ;
if ( ! filter )
goto out ;
if ( pmc_is_gp ( pmc ) ) {
key = pmc - > eventsel & AMD64_RAW_EVENT_MASK_NB ;
if ( bsearch ( & key , filter - > events , filter - > nevents ,
sizeof ( __u64 ) , cmp_u64 ) )
allow_event = filter - > action = = KVM_PMU_EVENT_ALLOW ;
else
allow_event = filter - > action = = KVM_PMU_EVENT_DENY ;
} else {
idx = pmc - > idx - INTEL_PMC_IDX_FIXED ;
if ( filter - > action = = KVM_PMU_EVENT_DENY & &
test_bit ( idx , ( ulong * ) & filter - > fixed_counter_bitmap ) )
allow_event = false ;
if ( filter - > action = = KVM_PMU_EVENT_ALLOW & &
! test_bit ( idx , ( ulong * ) & filter - > fixed_counter_bitmap ) )
allow_event = false ;
}
out :
return allow_event ;
}
2022-09-23 03:13:54 +03:00
static void reprogram_counter ( struct kvm_pmc * pmc )
2011-11-10 16:57:22 +04:00
{
2022-05-18 16:25:03 +03:00
struct kvm_pmu * pmu = pmc_to_pmu ( pmc ) ;
2022-05-18 16:25:06 +03:00
u64 eventsel = pmc - > eventsel ;
KVM: x86/pmu: Use PERF_TYPE_RAW to merge reprogram_{gp,fixed}counter()
The code sketch for reprogram_{gp, fixed}_counter() is similar, while the
fixed counter using the PERF_TYPE_HARDWAR type and the gp being
able to use either PERF_TYPE_HARDWAR or PERF_TYPE_RAW type
depending on the pmc->eventsel value.
After 'commit 761875634a5e ("KVM: x86/pmu: Setup pmc->eventsel
for fixed PMCs")', the pmc->eventsel of the fixed counter will also have
been setup with the same semantic value and will not be changed during
the guest runtime.
The original story of using the PERF_TYPE_HARDWARE type is to emulate
guest architecture PMU on a host without architecture PMU (the Pentium 4),
for which the guest vPMC needs to be reprogrammed using the kernel
generic perf_hw_id. But essentially, "the HARDWARE is just a convenience
wrapper over RAW IIRC", quoated from Peterz. So it could be pretty safe
to use the PERF_TYPE_RAW type only in practice to program both gp and
fixed counters naturally in the reprogram_counter().
To make the gp and fixed counters more semantically symmetrical,
the selection of EVENTSEL_{USER, OS, INT} bits is temporarily translated
via fixed_ctr_ctrl before the pmc_reprogram_counter() call.
Cc: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20220518132512.37864-9-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-05-18 16:25:09 +03:00
u64 new_config = eventsel ;
u8 fixed_ctr_ctrl ;
2012-02-26 18:55:40 +04:00
KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
The perf_event_create_kernel_counter() in the pmc_reprogram_counter() is
a heavyweight and high-frequency operation, especially when host disables
the watchdog (maximum 21000000 ns) which leads to an unacceptable latency
of the guest NMI handler. It limits the use of vPMUs in the guest.
When a vPMC is fully enabled, the legacy reprogram_*_counter() would stop
and release its existing perf_event (if any) every time EVEN in most cases
almost the same requested perf_event will be created and configured again.
For each vPMC, if the reuqested config ('u64 eventsel' for gp and 'u8 ctrl'
for fixed) is the same as its current config AND a new sample period based
on pmc->counter is accepted by host perf interface, the current event could
be reused safely as a new created one does. Otherwise, do release the
undesirable perf_event and reprogram a new one as usual.
It's light-weight to call pmc_pause_counter (disable, read and reset event)
and pmc_resume_counter (recalibrate period and re-enable event) as guest
expects instead of release-and-create again on any condition. Compared to
use the filterable event->attr or hw.config, a new 'u64 current_config'
field is added to save the last original programed config for each vPMC.
Based on this implementation, the number of calls to pmc_reprogram_counter
is reduced by ~82.5% for a gp sampling event and ~99.9% for a fixed event.
In the usage of multiplexing perf sampling mode, the average latency of the
guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up).
If host disables watchdog, the minimum latecy of guest NMI handler could be
speed up at ~3413x (from 20407603 to 5979 ns) and at ~786x in the average.
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2019-10-27 13:52:42 +03:00
pmc_pause_counter ( pmc ) ;
2011-11-10 16:57:22 +04:00
KVM: x86/pmu: Use PERF_TYPE_RAW to merge reprogram_{gp,fixed}counter()
The code sketch for reprogram_{gp, fixed}_counter() is similar, while the
fixed counter using the PERF_TYPE_HARDWAR type and the gp being
able to use either PERF_TYPE_HARDWAR or PERF_TYPE_RAW type
depending on the pmc->eventsel value.
After 'commit 761875634a5e ("KVM: x86/pmu: Setup pmc->eventsel
for fixed PMCs")', the pmc->eventsel of the fixed counter will also have
been setup with the same semantic value and will not be changed during
the guest runtime.
The original story of using the PERF_TYPE_HARDWARE type is to emulate
guest architecture PMU on a host without architecture PMU (the Pentium 4),
for which the guest vPMC needs to be reprogrammed using the kernel
generic perf_hw_id. But essentially, "the HARDWARE is just a convenience
wrapper over RAW IIRC", quoated from Peterz. So it could be pretty safe
to use the PERF_TYPE_RAW type only in practice to program both gp and
fixed counters naturally in the reprogram_counter().
To make the gp and fixed counters more semantically symmetrical,
the selection of EVENTSEL_{USER, OS, INT} bits is temporarily translated
via fixed_ctr_ctrl before the pmc_reprogram_counter() call.
Cc: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20220518132512.37864-9-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-05-18 16:25:09 +03:00
if ( ! pmc_speculative_in_use ( pmc ) | | ! pmc_is_enabled ( pmc ) )
2022-09-23 03:13:53 +03:00
goto reprogram_complete ;
2011-11-10 16:57:22 +04:00
2022-05-18 16:25:03 +03:00
if ( ! check_pmu_event_filter ( pmc ) )
2022-09-23 03:13:53 +03:00
goto reprogram_complete ;
2019-07-11 04:25:15 +03:00
KVM: x86/pmu: Defer counter emulated overflow via pmc->prev_counter
Defer reprogramming counters and handling overflow via KVM_REQ_PMU
when incrementing counters. KVM skips emulated WRMSR in the VM-Exit
fastpath, the fastpath runs with IRQs disabled, skipping instructions
can increment and reprogram counters, reprogramming counters can
sleep, and sleeping is disallowed while IRQs are disabled.
[*] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:580
[*] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 2981888, name: CPU 15/KVM
[*] preempt_count: 1, expected: 0
[*] RCU nest depth: 0, expected: 0
[*] INFO: lockdep is turned off.
[*] irq event stamp: 0
[*] hardirqs last enabled at (0): [<0000000000000000>] 0x0
[*] hardirqs last disabled at (0): [<ffffffff8121222a>] copy_process+0x146a/0x62d0
[*] softirqs last enabled at (0): [<ffffffff81212269>] copy_process+0x14a9/0x62d0
[*] softirqs last disabled at (0): [<0000000000000000>] 0x0
[*] Preemption disabled at:
[*] [<ffffffffc2063fc1>] vcpu_enter_guest+0x1001/0x3dc0 [kvm]
[*] CPU: 17 PID: 2981888 Comm: CPU 15/KVM Kdump: 5.19.0-rc1-g239111db364c-dirty #2
[*] Call Trace:
[*] <TASK>
[*] dump_stack_lvl+0x6c/0x9b
[*] __might_resched.cold+0x22e/0x297
[*] __mutex_lock+0xc0/0x23b0
[*] perf_event_ctx_lock_nested+0x18f/0x340
[*] perf_event_pause+0x1a/0x110
[*] reprogram_counter+0x2af/0x1490 [kvm]
[*] kvm_pmu_trigger_event+0x429/0x950 [kvm]
[*] kvm_skip_emulated_instruction+0x48/0x90 [kvm]
[*] handle_fastpath_set_msr_irqoff+0x349/0x3b0 [kvm]
[*] vmx_vcpu_run+0x268e/0x3b80 [kvm_intel]
[*] vcpu_enter_guest+0x1d22/0x3dc0 [kvm]
Add a field to kvm_pmc to track the previous counter value in order
to defer overflow detection to kvm_pmu_handle_event() (the counter must
be paused before handling overflow, and that may increment the counter).
Opportunistically shrink sizeof(struct kvm_pmc) a bit.
Suggested-by: Wanpeng Li <wanpengli@tencent.com>
Fixes: 9cd803d496e7 ("KVM: x86: Update vPMCs when retiring instructions")
Signed-off-by: Like Xu <likexu@tencent.com>
Link: https://lore.kernel.org/r/20220831085328.45489-6-likexu@tencent.com
[sean: avoid re-triggering KVM_REQ_PMU on overflow, tweak changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20220923001355.3741194-5-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-09-23 03:13:55 +03:00
if ( pmc - > counter < pmc - > prev_counter )
__kvm_perf_overflow ( pmc , false ) ;
KVM: x86/pmu: Use PERF_TYPE_RAW to merge reprogram_{gp,fixed}counter()
The code sketch for reprogram_{gp, fixed}_counter() is similar, while the
fixed counter using the PERF_TYPE_HARDWAR type and the gp being
able to use either PERF_TYPE_HARDWAR or PERF_TYPE_RAW type
depending on the pmc->eventsel value.
After 'commit 761875634a5e ("KVM: x86/pmu: Setup pmc->eventsel
for fixed PMCs")', the pmc->eventsel of the fixed counter will also have
been setup with the same semantic value and will not be changed during
the guest runtime.
The original story of using the PERF_TYPE_HARDWARE type is to emulate
guest architecture PMU on a host without architecture PMU (the Pentium 4),
for which the guest vPMC needs to be reprogrammed using the kernel
generic perf_hw_id. But essentially, "the HARDWARE is just a convenience
wrapper over RAW IIRC", quoated from Peterz. So it could be pretty safe
to use the PERF_TYPE_RAW type only in practice to program both gp and
fixed counters naturally in the reprogram_counter().
To make the gp and fixed counters more semantically symmetrical,
the selection of EVENTSEL_{USER, OS, INT} bits is temporarily translated
via fixed_ctr_ctrl before the pmc_reprogram_counter() call.
Cc: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20220518132512.37864-9-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-05-18 16:25:09 +03:00
if ( eventsel & ARCH_PERFMON_EVENTSEL_PIN_CONTROL )
printk_once ( " kvm pmu: pin control bit is ignored \n " ) ;
2011-11-10 16:57:22 +04:00
KVM: x86/pmu: Use PERF_TYPE_RAW to merge reprogram_{gp,fixed}counter()
The code sketch for reprogram_{gp, fixed}_counter() is similar, while the
fixed counter using the PERF_TYPE_HARDWAR type and the gp being
able to use either PERF_TYPE_HARDWAR or PERF_TYPE_RAW type
depending on the pmc->eventsel value.
After 'commit 761875634a5e ("KVM: x86/pmu: Setup pmc->eventsel
for fixed PMCs")', the pmc->eventsel of the fixed counter will also have
been setup with the same semantic value and will not be changed during
the guest runtime.
The original story of using the PERF_TYPE_HARDWARE type is to emulate
guest architecture PMU on a host without architecture PMU (the Pentium 4),
for which the guest vPMC needs to be reprogrammed using the kernel
generic perf_hw_id. But essentially, "the HARDWARE is just a convenience
wrapper over RAW IIRC", quoated from Peterz. So it could be pretty safe
to use the PERF_TYPE_RAW type only in practice to program both gp and
fixed counters naturally in the reprogram_counter().
To make the gp and fixed counters more semantically symmetrical,
the selection of EVENTSEL_{USER, OS, INT} bits is temporarily translated
via fixed_ctr_ctrl before the pmc_reprogram_counter() call.
Cc: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20220518132512.37864-9-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-05-18 16:25:09 +03:00
if ( pmc_is_fixed ( pmc ) ) {
fixed_ctr_ctrl = fixed_ctrl_field ( pmu - > fixed_ctr_ctrl ,
pmc - > idx - INTEL_PMC_IDX_FIXED ) ;
if ( fixed_ctr_ctrl & 0x1 )
eventsel | = ARCH_PERFMON_EVENTSEL_OS ;
if ( fixed_ctr_ctrl & 0x2 )
eventsel | = ARCH_PERFMON_EVENTSEL_USR ;
if ( fixed_ctr_ctrl & 0x8 )
eventsel | = ARCH_PERFMON_EVENTSEL_INT ;
new_config = ( u64 ) fixed_ctr_ctrl ;
}
2011-11-10 16:57:22 +04:00
KVM: x86/pmu: Use PERF_TYPE_RAW to merge reprogram_{gp,fixed}counter()
The code sketch for reprogram_{gp, fixed}_counter() is similar, while the
fixed counter using the PERF_TYPE_HARDWAR type and the gp being
able to use either PERF_TYPE_HARDWAR or PERF_TYPE_RAW type
depending on the pmc->eventsel value.
After 'commit 761875634a5e ("KVM: x86/pmu: Setup pmc->eventsel
for fixed PMCs")', the pmc->eventsel of the fixed counter will also have
been setup with the same semantic value and will not be changed during
the guest runtime.
The original story of using the PERF_TYPE_HARDWARE type is to emulate
guest architecture PMU on a host without architecture PMU (the Pentium 4),
for which the guest vPMC needs to be reprogrammed using the kernel
generic perf_hw_id. But essentially, "the HARDWARE is just a convenience
wrapper over RAW IIRC", quoated from Peterz. So it could be pretty safe
to use the PERF_TYPE_RAW type only in practice to program both gp and
fixed counters naturally in the reprogram_counter().
To make the gp and fixed counters more semantically symmetrical,
the selection of EVENTSEL_{USER, OS, INT} bits is temporarily translated
via fixed_ctr_ctrl before the pmc_reprogram_counter() call.
Cc: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20220518132512.37864-9-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-05-18 16:25:09 +03:00
if ( pmc - > current_config = = new_config & & pmc_resume_counter ( pmc ) )
2022-09-23 03:13:53 +03:00
goto reprogram_complete ;
KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter
The perf_event_create_kernel_counter() in the pmc_reprogram_counter() is
a heavyweight and high-frequency operation, especially when host disables
the watchdog (maximum 21000000 ns) which leads to an unacceptable latency
of the guest NMI handler. It limits the use of vPMUs in the guest.
When a vPMC is fully enabled, the legacy reprogram_*_counter() would stop
and release its existing perf_event (if any) every time EVEN in most cases
almost the same requested perf_event will be created and configured again.
For each vPMC, if the reuqested config ('u64 eventsel' for gp and 'u8 ctrl'
for fixed) is the same as its current config AND a new sample period based
on pmc->counter is accepted by host perf interface, the current event could
be reused safely as a new created one does. Otherwise, do release the
undesirable perf_event and reprogram a new one as usual.
It's light-weight to call pmc_pause_counter (disable, read and reset event)
and pmc_resume_counter (recalibrate period and re-enable event) as guest
expects instead of release-and-create again on any condition. Compared to
use the filterable event->attr or hw.config, a new 'u64 current_config'
field is added to save the last original programed config for each vPMC.
Based on this implementation, the number of calls to pmc_reprogram_counter
is reduced by ~82.5% for a gp sampling event and ~99.9% for a fixed event.
In the usage of multiplexing perf sampling mode, the average latency of the
guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up).
If host disables watchdog, the minimum latecy of guest NMI handler could be
speed up at ~3413x (from 20407603 to 5979 ns) and at ~786x in the average.
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2019-10-27 13:52:42 +03:00
pmc_release_perf_event ( pmc ) ;
KVM: x86/pmu: Use PERF_TYPE_RAW to merge reprogram_{gp,fixed}counter()
The code sketch for reprogram_{gp, fixed}_counter() is similar, while the
fixed counter using the PERF_TYPE_HARDWAR type and the gp being
able to use either PERF_TYPE_HARDWAR or PERF_TYPE_RAW type
depending on the pmc->eventsel value.
After 'commit 761875634a5e ("KVM: x86/pmu: Setup pmc->eventsel
for fixed PMCs")', the pmc->eventsel of the fixed counter will also have
been setup with the same semantic value and will not be changed during
the guest runtime.
The original story of using the PERF_TYPE_HARDWARE type is to emulate
guest architecture PMU on a host without architecture PMU (the Pentium 4),
for which the guest vPMC needs to be reprogrammed using the kernel
generic perf_hw_id. But essentially, "the HARDWARE is just a convenience
wrapper over RAW IIRC", quoated from Peterz. So it could be pretty safe
to use the PERF_TYPE_RAW type only in practice to program both gp and
fixed counters naturally in the reprogram_counter().
To make the gp and fixed counters more semantically symmetrical,
the selection of EVENTSEL_{USER, OS, INT} bits is temporarily translated
via fixed_ctr_ctrl before the pmc_reprogram_counter() call.
Cc: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Like Xu <likexu@tencent.com>
Message-Id: <20220518132512.37864-9-likexu@tencent.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-05-18 16:25:09 +03:00
pmc - > current_config = new_config ;
2022-09-23 03:13:53 +03:00
/*
* If reprogramming fails , e . g . due to contention , leave the counter ' s
* regprogram bit set , i . e . opportunistically try again on the next PMU
* refresh . Don ' t make a new request as doing so can stall the guest
* if reprogramming repeatedly fails .
*/
if ( pmc_reprogram_counter ( pmc , PERF_TYPE_RAW ,
( eventsel & pmu - > raw_event_mask ) ,
! ( eventsel & ARCH_PERFMON_EVENTSEL_USR ) ,
! ( eventsel & ARCH_PERFMON_EVENTSEL_OS ) ,
eventsel & ARCH_PERFMON_EVENTSEL_INT ) )
return ;
reprogram_complete :
clear_bit ( pmc - > idx , ( unsigned long * ) & pmc_to_pmu ( pmc ) - > reprogram_pmi ) ;
KVM: x86/pmu: Defer counter emulated overflow via pmc->prev_counter
Defer reprogramming counters and handling overflow via KVM_REQ_PMU
when incrementing counters. KVM skips emulated WRMSR in the VM-Exit
fastpath, the fastpath runs with IRQs disabled, skipping instructions
can increment and reprogram counters, reprogramming counters can
sleep, and sleeping is disallowed while IRQs are disabled.
[*] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:580
[*] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 2981888, name: CPU 15/KVM
[*] preempt_count: 1, expected: 0
[*] RCU nest depth: 0, expected: 0
[*] INFO: lockdep is turned off.
[*] irq event stamp: 0
[*] hardirqs last enabled at (0): [<0000000000000000>] 0x0
[*] hardirqs last disabled at (0): [<ffffffff8121222a>] copy_process+0x146a/0x62d0
[*] softirqs last enabled at (0): [<ffffffff81212269>] copy_process+0x14a9/0x62d0
[*] softirqs last disabled at (0): [<0000000000000000>] 0x0
[*] Preemption disabled at:
[*] [<ffffffffc2063fc1>] vcpu_enter_guest+0x1001/0x3dc0 [kvm]
[*] CPU: 17 PID: 2981888 Comm: CPU 15/KVM Kdump: 5.19.0-rc1-g239111db364c-dirty #2
[*] Call Trace:
[*] <TASK>
[*] dump_stack_lvl+0x6c/0x9b
[*] __might_resched.cold+0x22e/0x297
[*] __mutex_lock+0xc0/0x23b0
[*] perf_event_ctx_lock_nested+0x18f/0x340
[*] perf_event_pause+0x1a/0x110
[*] reprogram_counter+0x2af/0x1490 [kvm]
[*] kvm_pmu_trigger_event+0x429/0x950 [kvm]
[*] kvm_skip_emulated_instruction+0x48/0x90 [kvm]
[*] handle_fastpath_set_msr_irqoff+0x349/0x3b0 [kvm]
[*] vmx_vcpu_run+0x268e/0x3b80 [kvm_intel]
[*] vcpu_enter_guest+0x1d22/0x3dc0 [kvm]
Add a field to kvm_pmc to track the previous counter value in order
to defer overflow detection to kvm_pmu_handle_event() (the counter must
be paused before handling overflow, and that may increment the counter).
Opportunistically shrink sizeof(struct kvm_pmc) a bit.
Suggested-by: Wanpeng Li <wanpengli@tencent.com>
Fixes: 9cd803d496e7 ("KVM: x86: Update vPMCs when retiring instructions")
Signed-off-by: Like Xu <likexu@tencent.com>
Link: https://lore.kernel.org/r/20220831085328.45489-6-likexu@tencent.com
[sean: avoid re-triggering KVM_REQ_PMU on overflow, tweak changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20220923001355.3741194-5-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-09-23 03:13:55 +03:00
pmc - > prev_counter = 0 ;
2011-11-10 16:57:22 +04:00
}
2015-06-19 16:51:47 +03:00
void kvm_pmu_handle_event ( struct kvm_vcpu * vcpu )
{
struct kvm_pmu * pmu = vcpu_to_pmu ( vcpu ) ;
int bit ;
2019-10-21 13:55:04 +03:00
for_each_set_bit ( bit , pmu - > reprogram_pmi , X86_PMC_IDX_MAX ) {
2022-03-30 02:50:54 +03:00
struct kvm_pmc * pmc = static_call ( kvm_x86_pmu_pmc_idx_to_pmc ) ( pmu , bit ) ;
2015-06-19 16:51:47 +03:00
2022-09-23 03:13:54 +03:00
if ( unlikely ( ! pmc ) ) {
2019-10-21 13:55:04 +03:00
clear_bit ( bit , pmu - > reprogram_pmi ) ;
2015-06-19 16:51:47 +03:00
continue ;
}
2022-09-23 03:13:54 +03:00
2022-05-18 16:25:05 +03:00
reprogram_counter ( pmc ) ;
2015-06-19 16:51:47 +03:00
}
2019-10-27 13:52:43 +03:00
/*
* Unused perf_events are only released if the corresponding MSRs
* weren ' t accessed during the last vCPU time slice . kvm_arch_sched_in
* triggers KVM_REQ_PMU if cleanup is needed .
*/
if ( unlikely ( pmu - > need_cleanup ) )
kvm_pmu_cleanup ( vcpu ) ;
2015-06-19 16:51:47 +03:00
}
/* check if idx is a valid index to access PMU */
2021-11-05 23:20:58 +03:00
bool kvm_pmu_is_valid_rdpmc_ecx ( struct kvm_vcpu * vcpu , unsigned int idx )
2015-06-19 16:51:47 +03:00
{
2022-03-30 02:50:54 +03:00
return static_call ( kvm_x86_pmu_is_valid_rdpmc_ecx ) ( vcpu , idx ) ;
2015-06-19 17:16:59 +03:00
}
2018-03-12 14:12:53 +03:00
bool is_vmware_backdoor_pmc ( u32 pmc_idx )
{
switch ( pmc_idx ) {
case VMWARE_BACKDOOR_PMC_HOST_TSC :
case VMWARE_BACKDOOR_PMC_REAL_TIME :
case VMWARE_BACKDOOR_PMC_APPARENT_TIME :
return true ;
}
return false ;
}
static int kvm_pmu_rdpmc_vmware ( struct kvm_vcpu * vcpu , unsigned idx , u64 * data )
{
u64 ctr_val ;
switch ( idx ) {
case VMWARE_BACKDOOR_PMC_HOST_TSC :
ctr_val = rdtsc ( ) ;
break ;
case VMWARE_BACKDOOR_PMC_REAL_TIME :
2019-06-21 23:32:48 +03:00
ctr_val = ktime_get_boottime_ns ( ) ;
2018-03-12 14:12:53 +03:00
break ;
case VMWARE_BACKDOOR_PMC_APPARENT_TIME :
2019-06-21 23:32:48 +03:00
ctr_val = ktime_get_boottime_ns ( ) +
2018-03-12 14:12:53 +03:00
vcpu - > kvm - > arch . kvmclock_offset ;
break ;
default :
return 1 ;
}
* data = ctr_val ;
return 0 ;
}
2015-06-19 17:16:59 +03:00
int kvm_pmu_rdpmc ( struct kvm_vcpu * vcpu , unsigned idx , u64 * data )
{
bool fast_mode = idx & ( 1u < < 31 ) ;
2019-03-25 22:10:17 +03:00
struct kvm_pmu * pmu = vcpu_to_pmu ( vcpu ) ;
2015-06-19 17:16:59 +03:00
struct kvm_pmc * pmc ;
2019-05-20 18:20:40 +03:00
u64 mask = fast_mode ? ~ 0u : ~ 0ull ;
2015-06-19 17:16:59 +03:00
2019-03-25 22:10:17 +03:00
if ( ! pmu - > version )
return 1 ;
2018-03-12 14:12:53 +03:00
if ( is_vmware_backdoor_pmc ( idx ) )
return kvm_pmu_rdpmc_vmware ( vcpu , idx , data ) ;
2022-03-30 02:50:54 +03:00
pmc = static_call ( kvm_x86_pmu_rdpmc_ecx_to_pmc ) ( vcpu , idx , & mask ) ;
2015-06-19 17:16:59 +03:00
if ( ! pmc )
return 1 ;
2020-07-08 10:44:09 +03:00
if ( ! ( kvm_read_cr4 ( vcpu ) & X86_CR4_PCE ) & &
2021-01-15 06:27:56 +03:00
( static_call ( kvm_x86_get_cpl ) ( vcpu ) ! = 0 ) & &
2020-07-08 10:44:09 +03:00
( kvm_read_cr0 ( vcpu ) & X86_CR0_PE ) )
return 1 ;
2019-05-20 18:20:40 +03:00
* data = pmc_read_counter ( pmc ) & mask ;
2015-06-19 16:51:47 +03:00
return 0 ;
}
void kvm_pmu_deliver_pmi ( struct kvm_vcpu * vcpu )
{
2021-02-01 08:10:36 +03:00
if ( lapic_in_kernel ( vcpu ) ) {
2022-03-30 02:50:54 +03:00
static_call_cond ( kvm_x86_pmu_deliver_pmi ) ( vcpu ) ;
2015-06-19 16:51:47 +03:00
kvm_apic_local_deliver ( vcpu - > arch . apic , APIC_LVTPC ) ;
2021-02-01 08:10:36 +03:00
}
2015-06-19 16:51:47 +03:00
}
2022-06-11 03:57:52 +03:00
bool kvm_pmu_is_valid_msr ( struct kvm_vcpu * vcpu , u32 msr )
2011-11-10 16:57:22 +04:00
{
2022-03-30 02:50:54 +03:00
return static_call ( kvm_x86_pmu_msr_idx_to_pmc ) ( vcpu , msr ) | |
2022-06-11 03:57:52 +03:00
static_call ( kvm_x86_pmu_is_valid_msr ) ( vcpu , msr ) ;
2011-11-10 16:57:22 +04:00
}
2019-10-27 13:52:43 +03:00
static void kvm_pmu_mark_pmc_in_use ( struct kvm_vcpu * vcpu , u32 msr )
{
struct kvm_pmu * pmu = vcpu_to_pmu ( vcpu ) ;
2022-03-30 02:50:54 +03:00
struct kvm_pmc * pmc = static_call ( kvm_x86_pmu_msr_idx_to_pmc ) ( vcpu , msr ) ;
2019-10-27 13:52:43 +03:00
if ( pmc )
__set_bit ( pmc - > idx , pmu - > pmc_in_use ) ;
}
2020-05-29 10:43:44 +03:00
int kvm_pmu_get_msr ( struct kvm_vcpu * vcpu , struct msr_data * msr_info )
2011-11-10 16:57:22 +04:00
{
2022-03-30 02:50:54 +03:00
return static_call ( kvm_x86_pmu_get_msr ) ( vcpu , msr_info ) ;
2011-11-10 16:57:22 +04:00
}
2013-03-28 20:18:35 +04:00
int kvm_pmu_set_msr ( struct kvm_vcpu * vcpu , struct msr_data * msr_info )
2011-11-10 16:57:22 +04:00
{
2019-10-27 13:52:43 +03:00
kvm_pmu_mark_pmc_in_use ( vcpu , msr_info - > index ) ;
2022-03-30 02:50:54 +03:00
return static_call ( kvm_x86_pmu_set_msr ) ( vcpu , msr_info ) ;
2011-11-10 16:57:22 +04:00
}
2015-06-19 15:15:28 +03:00
/* refresh PMU settings. This function generally is called when underlying
* settings are changed ( such as changes of PMU CPUID by guest VMs ) , which
* should rarely happen .
*/
2015-06-19 14:44:45 +03:00
void kvm_pmu_refresh ( struct kvm_vcpu * vcpu )
2011-11-10 16:57:22 +04:00
{
2022-03-30 02:50:54 +03:00
static_call ( kvm_x86_pmu_refresh ) ( vcpu ) ;
2011-11-10 16:57:22 +04:00
}
void kvm_pmu_reset ( struct kvm_vcpu * vcpu )
{
2015-06-19 15:00:33 +03:00
struct kvm_pmu * pmu = vcpu_to_pmu ( vcpu ) ;
2011-11-10 16:57:22 +04:00
irq_work_sync ( & pmu - > irq_work ) ;
2022-03-30 02:50:54 +03:00
static_call ( kvm_x86_pmu_reset ) ( vcpu ) ;
2011-11-10 16:57:22 +04:00
}
2015-06-19 16:51:47 +03:00
void kvm_pmu_init ( struct kvm_vcpu * vcpu )
2011-11-10 16:57:22 +04:00
{
2015-06-19 15:00:33 +03:00
struct kvm_pmu * pmu = vcpu_to_pmu ( vcpu ) ;
2011-11-10 16:57:22 +04:00
2015-06-19 16:51:47 +03:00
memset ( pmu , 0 , sizeof ( * pmu ) ) ;
2022-03-30 02:50:54 +03:00
static_call ( kvm_x86_pmu_init ) ( vcpu ) ;
2015-06-19 16:51:47 +03:00
init_irq_work ( & pmu - > irq_work , kvm_pmi_trigger_fn ) ;
2019-10-27 13:52:43 +03:00
pmu - > event_count = 0 ;
pmu - > need_cleanup = false ;
2015-06-19 16:51:47 +03:00
kvm_pmu_refresh ( vcpu ) ;
}
2019-10-27 13:52:43 +03:00
/* Release perf_events for vPMCs that have been unused for a full time slice. */
void kvm_pmu_cleanup ( struct kvm_vcpu * vcpu )
{
struct kvm_pmu * pmu = vcpu_to_pmu ( vcpu ) ;
struct kvm_pmc * pmc = NULL ;
DECLARE_BITMAP ( bitmask , X86_PMC_IDX_MAX ) ;
int i ;
pmu - > need_cleanup = false ;
bitmap_andnot ( bitmask , pmu - > all_valid_pmc_idx ,
pmu - > pmc_in_use , X86_PMC_IDX_MAX ) ;
for_each_set_bit ( i , bitmask , X86_PMC_IDX_MAX ) {
2022-03-30 02:50:54 +03:00
pmc = static_call ( kvm_x86_pmu_pmc_idx_to_pmc ) ( pmu , i ) ;
2019-10-27 13:52:43 +03:00
if ( pmc & & pmc - > perf_event & & ! pmc_speculative_in_use ( pmc ) )
pmc_stop_counter ( pmc ) ;
}
2022-03-30 02:50:54 +03:00
static_call_cond ( kvm_x86_pmu_cleanup ) ( vcpu ) ;
2021-02-01 08:10:37 +03:00
2019-10-27 13:52:43 +03:00
bitmap_zero ( pmu - > pmc_in_use , X86_PMC_IDX_MAX ) ;
}
2015-06-19 16:51:47 +03:00
void kvm_pmu_destroy ( struct kvm_vcpu * vcpu )
{
kvm_pmu_reset ( vcpu ) ;
2011-11-10 16:57:22 +04:00
}
2019-07-11 04:25:15 +03:00
2021-11-30 10:42:20 +03:00
static void kvm_pmu_incr_counter ( struct kvm_pmc * pmc )
{
KVM: x86/pmu: Defer counter emulated overflow via pmc->prev_counter
Defer reprogramming counters and handling overflow via KVM_REQ_PMU
when incrementing counters. KVM skips emulated WRMSR in the VM-Exit
fastpath, the fastpath runs with IRQs disabled, skipping instructions
can increment and reprogram counters, reprogramming counters can
sleep, and sleeping is disallowed while IRQs are disabled.
[*] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:580
[*] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 2981888, name: CPU 15/KVM
[*] preempt_count: 1, expected: 0
[*] RCU nest depth: 0, expected: 0
[*] INFO: lockdep is turned off.
[*] irq event stamp: 0
[*] hardirqs last enabled at (0): [<0000000000000000>] 0x0
[*] hardirqs last disabled at (0): [<ffffffff8121222a>] copy_process+0x146a/0x62d0
[*] softirqs last enabled at (0): [<ffffffff81212269>] copy_process+0x14a9/0x62d0
[*] softirqs last disabled at (0): [<0000000000000000>] 0x0
[*] Preemption disabled at:
[*] [<ffffffffc2063fc1>] vcpu_enter_guest+0x1001/0x3dc0 [kvm]
[*] CPU: 17 PID: 2981888 Comm: CPU 15/KVM Kdump: 5.19.0-rc1-g239111db364c-dirty #2
[*] Call Trace:
[*] <TASK>
[*] dump_stack_lvl+0x6c/0x9b
[*] __might_resched.cold+0x22e/0x297
[*] __mutex_lock+0xc0/0x23b0
[*] perf_event_ctx_lock_nested+0x18f/0x340
[*] perf_event_pause+0x1a/0x110
[*] reprogram_counter+0x2af/0x1490 [kvm]
[*] kvm_pmu_trigger_event+0x429/0x950 [kvm]
[*] kvm_skip_emulated_instruction+0x48/0x90 [kvm]
[*] handle_fastpath_set_msr_irqoff+0x349/0x3b0 [kvm]
[*] vmx_vcpu_run+0x268e/0x3b80 [kvm_intel]
[*] vcpu_enter_guest+0x1d22/0x3dc0 [kvm]
Add a field to kvm_pmc to track the previous counter value in order
to defer overflow detection to kvm_pmu_handle_event() (the counter must
be paused before handling overflow, and that may increment the counter).
Opportunistically shrink sizeof(struct kvm_pmc) a bit.
Suggested-by: Wanpeng Li <wanpengli@tencent.com>
Fixes: 9cd803d496e7 ("KVM: x86: Update vPMCs when retiring instructions")
Signed-off-by: Like Xu <likexu@tencent.com>
Link: https://lore.kernel.org/r/20220831085328.45489-6-likexu@tencent.com
[sean: avoid re-triggering KVM_REQ_PMU on overflow, tweak changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20220923001355.3741194-5-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-09-23 03:13:55 +03:00
pmc - > prev_counter = pmc - > counter ;
2021-11-30 10:42:20 +03:00
pmc - > counter = ( pmc - > counter + 1 ) & pmc_bitmask ( pmc ) ;
KVM: x86/pmu: Defer counter emulated overflow via pmc->prev_counter
Defer reprogramming counters and handling overflow via KVM_REQ_PMU
when incrementing counters. KVM skips emulated WRMSR in the VM-Exit
fastpath, the fastpath runs with IRQs disabled, skipping instructions
can increment and reprogram counters, reprogramming counters can
sleep, and sleeping is disallowed while IRQs are disabled.
[*] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:580
[*] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 2981888, name: CPU 15/KVM
[*] preempt_count: 1, expected: 0
[*] RCU nest depth: 0, expected: 0
[*] INFO: lockdep is turned off.
[*] irq event stamp: 0
[*] hardirqs last enabled at (0): [<0000000000000000>] 0x0
[*] hardirqs last disabled at (0): [<ffffffff8121222a>] copy_process+0x146a/0x62d0
[*] softirqs last enabled at (0): [<ffffffff81212269>] copy_process+0x14a9/0x62d0
[*] softirqs last disabled at (0): [<0000000000000000>] 0x0
[*] Preemption disabled at:
[*] [<ffffffffc2063fc1>] vcpu_enter_guest+0x1001/0x3dc0 [kvm]
[*] CPU: 17 PID: 2981888 Comm: CPU 15/KVM Kdump: 5.19.0-rc1-g239111db364c-dirty #2
[*] Call Trace:
[*] <TASK>
[*] dump_stack_lvl+0x6c/0x9b
[*] __might_resched.cold+0x22e/0x297
[*] __mutex_lock+0xc0/0x23b0
[*] perf_event_ctx_lock_nested+0x18f/0x340
[*] perf_event_pause+0x1a/0x110
[*] reprogram_counter+0x2af/0x1490 [kvm]
[*] kvm_pmu_trigger_event+0x429/0x950 [kvm]
[*] kvm_skip_emulated_instruction+0x48/0x90 [kvm]
[*] handle_fastpath_set_msr_irqoff+0x349/0x3b0 [kvm]
[*] vmx_vcpu_run+0x268e/0x3b80 [kvm_intel]
[*] vcpu_enter_guest+0x1d22/0x3dc0 [kvm]
Add a field to kvm_pmc to track the previous counter value in order
to defer overflow detection to kvm_pmu_handle_event() (the counter must
be paused before handling overflow, and that may increment the counter).
Opportunistically shrink sizeof(struct kvm_pmc) a bit.
Suggested-by: Wanpeng Li <wanpengli@tencent.com>
Fixes: 9cd803d496e7 ("KVM: x86: Update vPMCs when retiring instructions")
Signed-off-by: Like Xu <likexu@tencent.com>
Link: https://lore.kernel.org/r/20220831085328.45489-6-likexu@tencent.com
[sean: avoid re-triggering KVM_REQ_PMU on overflow, tweak changelog]
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20220923001355.3741194-5-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2022-09-23 03:13:55 +03:00
kvm_pmu_request_counter_reprogam ( pmc ) ;
2021-11-30 10:42:20 +03:00
}
static inline bool eventsel_match_perf_hw_id ( struct kvm_pmc * pmc ,
unsigned int perf_hw_id )
{
2022-05-18 16:25:11 +03:00
return ! ( ( pmc - > eventsel ^ perf_get_hw_event_config ( perf_hw_id ) ) &
AMD64_RAW_EVENT_MASK_NB ) ;
2021-11-30 10:42:20 +03:00
}
static inline bool cpl_is_matched ( struct kvm_pmc * pmc )
{
bool select_os , select_user ;
2022-09-23 03:13:54 +03:00
u64 config ;
2021-11-30 10:42:20 +03:00
if ( pmc_is_gp ( pmc ) ) {
2022-09-23 03:13:54 +03:00
config = pmc - > eventsel ;
2021-11-30 10:42:20 +03:00
select_os = config & ARCH_PERFMON_EVENTSEL_OS ;
select_user = config & ARCH_PERFMON_EVENTSEL_USR ;
} else {
2022-09-23 03:13:54 +03:00
config = fixed_ctrl_field ( pmc_to_pmu ( pmc ) - > fixed_ctr_ctrl ,
pmc - > idx - INTEL_PMC_IDX_FIXED ) ;
2021-11-30 10:42:20 +03:00
select_os = config & 0x1 ;
select_user = config & 0x2 ;
}
return ( static_call ( kvm_x86_get_cpl ) ( pmc - > vcpu ) = = 0 ) ? select_os : select_user ;
}
void kvm_pmu_trigger_event ( struct kvm_vcpu * vcpu , u64 perf_hw_id )
{
struct kvm_pmu * pmu = vcpu_to_pmu ( vcpu ) ;
struct kvm_pmc * pmc ;
int i ;
for_each_set_bit ( i , pmu - > all_valid_pmc_idx , X86_PMC_IDX_MAX ) {
2022-03-30 02:50:54 +03:00
pmc = static_call ( kvm_x86_pmu_pmc_idx_to_pmc ) ( pmu , i ) ;
2021-11-30 10:42:20 +03:00
if ( ! pmc | | ! pmc_is_enabled ( pmc ) | | ! pmc_speculative_in_use ( pmc ) )
continue ;
/* Ignore checks for edge detect, pin control, invert and CMASK bits */
if ( eventsel_match_perf_hw_id ( pmc , perf_hw_id ) & & cpl_is_matched ( pmc ) )
kvm_pmu_incr_counter ( pmc ) ;
}
}
EXPORT_SYMBOL_GPL ( kvm_pmu_trigger_event ) ;
2019-07-11 04:25:15 +03:00
int kvm_vm_ioctl_set_pmu_event_filter ( struct kvm * kvm , void __user * argp )
{
struct kvm_pmu_event_filter tmp , * filter ;
2022-09-23 03:13:52 +03:00
struct kvm_vcpu * vcpu ;
unsigned long i ;
2019-07-11 04:25:15 +03:00
size_t size ;
int r ;
if ( copy_from_user ( & tmp , argp , sizeof ( tmp ) ) )
return - EFAULT ;
if ( tmp . action ! = KVM_PMU_EVENT_ALLOW & &
tmp . action ! = KVM_PMU_EVENT_DENY )
return - EINVAL ;
2019-07-18 21:38:18 +03:00
if ( tmp . flags ! = 0 )
return - EINVAL ;
2019-07-11 04:25:15 +03:00
if ( tmp . nevents > KVM_PMU_EVENT_FILTER_MAX_EVENTS )
return - E2BIG ;
size = struct_size ( filter , events , tmp . nevents ) ;
filter = kmalloc ( size , GFP_KERNEL_ACCOUNT ) ;
if ( ! filter )
return - ENOMEM ;
r = - EFAULT ;
if ( copy_from_user ( filter , argp , size ) )
goto cleanup ;
/* Ensure nevents can't be changed between the user copies. */
* filter = tmp ;
2022-01-15 08:24:26 +03:00
/*
* Sort the in - kernel list so that we can search it with bsearch .
*/
sort ( & filter - > events , filter - > nevents , sizeof ( __u64 ) , cmp_u64 , NULL ) ;
2019-07-11 04:25:15 +03:00
mutex_lock ( & kvm - > lock ) ;
2019-09-24 01:15:35 +03:00
filter = rcu_replace_pointer ( kvm - > arch . pmu_event_filter , filter ,
mutex_is_locked ( & kvm - > lock ) ) ;
2022-09-23 03:13:52 +03:00
synchronize_srcu_expedited ( & kvm - > srcu ) ;
BUILD_BUG_ON ( sizeof ( ( ( struct kvm_pmu * ) 0 ) - > reprogram_pmi ) >
sizeof ( ( ( struct kvm_pmu * ) 0 ) - > __reprogram_pmi ) ) ;
kvm_for_each_vcpu ( i , vcpu , kvm )
atomic64_set ( & vcpu_to_pmu ( vcpu ) - > __reprogram_pmi , - 1ull ) ;
kvm_make_all_cpus_request ( kvm , KVM_REQ_PMU ) ;
2019-07-11 04:25:15 +03:00
mutex_unlock ( & kvm - > lock ) ;
2019-07-18 21:38:18 +03:00
r = 0 ;
2019-07-11 04:25:15 +03:00
cleanup :
kfree ( filter ) ;
2019-07-18 21:38:18 +03:00
return r ;
2019-07-11 04:25:15 +03:00
}