2018-07-12 02:42:11 +03:00
// SPDX-License-Identifier: GPL-2.0
2006-12-08 02:43:59 +03:00
/*
* OMAP mailbox driver
*
2009-03-24 04:07:24 +03:00
* Copyright ( C ) 2006 - 2009 Nokia Corporation . All rights reserved .
2016-04-06 20:37:37 +03:00
* Copyright ( C ) 2013 - 2016 Texas Instruments Incorporated - http : //www.ti.com
2006-12-08 02:43:59 +03:00
*
2009-03-24 04:07:24 +03:00
* Contact : Hiroshi DOYU < Hiroshi . DOYU @ nokia . com >
2014-06-25 04:43:41 +04:00
* Suman Anna < s - anna @ ti . com >
2006-12-08 02:43:59 +03:00
*/
# include <linux/interrupt.h>
2010-06-11 19:51:49 +04:00
# include <linux/spinlock.h>
# include <linux/mutex.h>
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 11:04:11 +03:00
# include <linux/slab.h>
2010-05-05 19:33:09 +04:00
# include <linux/kfifo.h>
# include <linux/err.h>
2011-08-01 00:14:14 +04:00
# include <linux/module.h>
2014-09-10 23:20:59 +04:00
# include <linux/of_device.h>
2014-06-25 04:43:41 +04:00
# include <linux/platform_device.h>
# include <linux/pm_runtime.h>
# include <linux/omap-mailbox.h>
2014-11-04 02:05:50 +03:00
# include <linux/mailbox_controller.h>
# include <linux/mailbox_client.h>
2014-06-25 04:43:41 +04:00
2015-09-23 03:14:52 +03:00
# include "mailbox.h"
2014-06-25 04:43:41 +04:00
# define MAILBOX_REVISION 0x000
# define MAILBOX_MESSAGE(m) (0x040 + 4 * (m))
# define MAILBOX_FIFOSTATUS(m) (0x080 + 4 * (m))
# define MAILBOX_MSGSTATUS(m) (0x0c0 + 4 * (m))
# define OMAP2_MAILBOX_IRQSTATUS(u) (0x100 + 8 * (u))
# define OMAP2_MAILBOX_IRQENABLE(u) (0x104 + 8 * (u))
# define OMAP4_MAILBOX_IRQSTATUS(u) (0x104 + 0x10 * (u))
# define OMAP4_MAILBOX_IRQENABLE(u) (0x108 + 0x10 * (u))
# define OMAP4_MAILBOX_IRQENABLE_CLR(u) (0x10c + 0x10 * (u))
# define MAILBOX_IRQSTATUS(type, u) (type ? OMAP4_MAILBOX_IRQSTATUS(u) : \
OMAP2_MAILBOX_IRQSTATUS ( u ) )
# define MAILBOX_IRQENABLE(type, u) (type ? OMAP4_MAILBOX_IRQENABLE(u) : \
OMAP2_MAILBOX_IRQENABLE ( u ) )
# define MAILBOX_IRQDISABLE(type, u) (type ? OMAP4_MAILBOX_IRQENABLE_CLR(u) \
: OMAP2_MAILBOX_IRQENABLE ( u ) )
# define MAILBOX_IRQ_NEWMSG(m) (1 << (2 * (m)))
# define MAILBOX_IRQ_NOTFULL(m) (1 << (2 * (m) + 1))
2016-04-06 20:37:37 +03:00
/* Interrupt register configuration types */
# define MBOX_INTR_CFG_TYPE1 0
# define MBOX_INTR_CFG_TYPE2 1
2014-06-25 04:43:41 +04:00
struct omap_mbox_fifo {
unsigned long msg ;
unsigned long fifo_stat ;
unsigned long msg_stat ;
unsigned long irqenable ;
unsigned long irqstatus ;
unsigned long irqdisable ;
2014-06-25 04:43:42 +04:00
u32 intr_bit ;
2014-06-25 04:43:41 +04:00
} ;
struct omap_mbox_queue {
spinlock_t lock ;
struct kfifo fifo ;
struct work_struct work ;
struct omap_mbox * mbox ;
bool full ;
} ;
2018-07-12 02:42:12 +03:00
struct omap_mbox_match_data {
u32 intr_type ;
} ;
2014-06-25 04:43:43 +04:00
struct omap_mbox_device {
struct device * dev ;
struct mutex cfg_lock ;
void __iomem * mbox_base ;
2016-04-07 02:37:18 +03:00
u32 * irq_ctx ;
2014-06-25 04:43:43 +04:00
u32 num_users ;
u32 num_fifos ;
2016-04-07 02:37:17 +03:00
u32 intr_type ;
2014-06-25 04:43:43 +04:00
struct omap_mbox * * mboxes ;
2014-11-04 02:05:50 +03:00
struct mbox_controller controller ;
2014-06-25 04:43:43 +04:00
struct list_head elem ;
} ;
2014-09-10 23:20:59 +04:00
struct omap_mbox_fifo_info {
int tx_id ;
int tx_usr ;
int tx_irq ;
int rx_id ;
int rx_usr ;
int rx_irq ;
const char * name ;
2015-09-23 03:14:52 +03:00
bool send_no_irq ;
2014-09-10 23:20:59 +04:00
} ;
2014-06-25 04:43:41 +04:00
struct omap_mbox {
const char * name ;
int irq ;
2014-11-04 02:05:50 +03:00
struct omap_mbox_queue * rxq ;
2014-06-25 04:43:41 +04:00
struct device * dev ;
2014-06-25 04:43:43 +04:00
struct omap_mbox_device * parent ;
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo tx_fifo ;
struct omap_mbox_fifo rx_fifo ;
u32 intr_type ;
2014-11-04 02:05:50 +03:00
struct mbox_chan * chan ;
2015-09-23 03:14:52 +03:00
bool send_no_irq ;
2014-06-25 04:43:41 +04:00
} ;
2014-06-25 04:43:43 +04:00
/* global variables for the mailbox devices */
static DEFINE_MUTEX ( omap_mbox_devices_lock ) ;
static LIST_HEAD ( omap_mbox_devices ) ;
2009-11-22 21:11:22 +03:00
2010-05-05 19:33:09 +04:00
static unsigned int mbox_kfifo_size = CONFIG_OMAP_MBOX_KFIFO_SIZE ;
module_param ( mbox_kfifo_size , uint , S_IRUGO ) ;
MODULE_PARM_DESC ( mbox_kfifo_size , " Size of omap's mailbox kfifo (bytes) " ) ;
2014-11-04 02:05:50 +03:00
static struct omap_mbox * mbox_chan_to_omap_mbox ( struct mbox_chan * chan )
{
if ( ! chan | | ! chan - > con_priv )
return NULL ;
return ( struct omap_mbox * ) chan - > con_priv ;
}
2014-06-25 04:43:43 +04:00
static inline
unsigned int mbox_read_reg ( struct omap_mbox_device * mdev , size_t ofs )
2014-06-25 04:43:41 +04:00
{
2014-06-25 04:43:43 +04:00
return __raw_readl ( mdev - > mbox_base + ofs ) ;
2014-06-25 04:43:41 +04:00
}
2014-06-25 04:43:43 +04:00
static inline
void mbox_write_reg ( struct omap_mbox_device * mdev , u32 val , size_t ofs )
2014-06-25 04:43:41 +04:00
{
2014-06-25 04:43:43 +04:00
__raw_writel ( val , mdev - > mbox_base + ofs ) ;
2014-06-25 04:43:41 +04:00
}
2009-03-24 04:07:26 +03:00
/* Mailbox FIFO handle functions */
2014-06-25 04:43:41 +04:00
static mbox_msg_t mbox_fifo_read ( struct omap_mbox * mbox )
2009-03-24 04:07:26 +03:00
{
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo * fifo = & mbox - > rx_fifo ;
2016-04-06 20:37:40 +03:00
return ( mbox_msg_t ) mbox_read_reg ( mbox - > parent , fifo - > msg ) ;
2009-03-24 04:07:26 +03:00
}
2014-06-25 04:43:41 +04:00
static void mbox_fifo_write ( struct omap_mbox * mbox , mbox_msg_t msg )
2009-03-24 04:07:26 +03:00
{
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo * fifo = & mbox - > tx_fifo ;
2016-04-06 20:37:40 +03:00
2014-06-25 04:43:43 +04:00
mbox_write_reg ( mbox - > parent , msg , fifo - > msg ) ;
2009-03-24 04:07:26 +03:00
}
2014-06-25 04:43:41 +04:00
static int mbox_fifo_empty ( struct omap_mbox * mbox )
2009-03-24 04:07:26 +03:00
{
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo * fifo = & mbox - > rx_fifo ;
2016-04-06 20:37:40 +03:00
2014-06-25 04:43:43 +04:00
return ( mbox_read_reg ( mbox - > parent , fifo - > msg_stat ) = = 0 ) ;
2009-03-24 04:07:26 +03:00
}
2014-06-25 04:43:41 +04:00
static int mbox_fifo_full ( struct omap_mbox * mbox )
2009-03-24 04:07:26 +03:00
{
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo * fifo = & mbox - > tx_fifo ;
2016-04-06 20:37:40 +03:00
2014-06-25 04:43:43 +04:00
return mbox_read_reg ( mbox - > parent , fifo - > fifo_stat ) ;
2009-03-24 04:07:26 +03:00
}
/* Mailbox IRQ handle functions */
2014-06-25 04:43:41 +04:00
static void ack_mbox_irq ( struct omap_mbox * mbox , omap_mbox_irq_t irq )
2009-03-24 04:07:26 +03:00
{
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo * fifo = ( irq = = IRQ_TX ) ?
& mbox - > tx_fifo : & mbox - > rx_fifo ;
u32 bit = fifo - > intr_bit ;
u32 irqstatus = fifo - > irqstatus ;
2014-06-25 04:43:41 +04:00
2014-06-25 04:43:43 +04:00
mbox_write_reg ( mbox - > parent , bit , irqstatus ) ;
2014-06-25 04:43:41 +04:00
/* Flush posted write for irq status to avoid spurious interrupts */
2014-06-25 04:43:43 +04:00
mbox_read_reg ( mbox - > parent , irqstatus ) ;
2009-03-24 04:07:26 +03:00
}
2014-06-25 04:43:41 +04:00
static int is_mbox_irq ( struct omap_mbox * mbox , omap_mbox_irq_t irq )
2009-03-24 04:07:26 +03:00
{
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo * fifo = ( irq = = IRQ_TX ) ?
& mbox - > tx_fifo : & mbox - > rx_fifo ;
u32 bit = fifo - > intr_bit ;
u32 irqenable = fifo - > irqenable ;
u32 irqstatus = fifo - > irqstatus ;
2014-06-25 04:43:43 +04:00
u32 enable = mbox_read_reg ( mbox - > parent , irqenable ) ;
u32 status = mbox_read_reg ( mbox - > parent , irqstatus ) ;
2014-06-25 04:43:41 +04:00
return ( int ) ( enable & status & bit ) ;
2009-03-24 04:07:26 +03:00
}
2014-11-04 02:05:50 +03:00
static void _omap_mbox_enable_irq ( struct omap_mbox * mbox , omap_mbox_irq_t irq )
2013-03-13 02:55:29 +04:00
{
2014-06-25 04:43:42 +04:00
u32 l ;
struct omap_mbox_fifo * fifo = ( irq = = IRQ_TX ) ?
& mbox - > tx_fifo : & mbox - > rx_fifo ;
u32 bit = fifo - > intr_bit ;
u32 irqenable = fifo - > irqenable ;
2014-06-25 04:43:41 +04:00
2014-06-25 04:43:43 +04:00
l = mbox_read_reg ( mbox - > parent , irqenable ) ;
2014-06-25 04:43:41 +04:00
l | = bit ;
2014-06-25 04:43:43 +04:00
mbox_write_reg ( mbox - > parent , l , irqenable ) ;
2013-03-13 02:55:29 +04:00
}
2014-11-04 02:05:50 +03:00
static void _omap_mbox_disable_irq ( struct omap_mbox * mbox , omap_mbox_irq_t irq )
2013-03-13 02:55:29 +04:00
{
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo * fifo = ( irq = = IRQ_TX ) ?
& mbox - > tx_fifo : & mbox - > rx_fifo ;
u32 bit = fifo - > intr_bit ;
u32 irqdisable = fifo - > irqdisable ;
2014-06-25 04:43:41 +04:00
/*
* Read and update the interrupt configuration register for pre - OMAP4 .
* OMAP4 and later SoCs have a dedicated interrupt disabling register .
*/
2014-06-25 04:43:42 +04:00
if ( ! mbox - > intr_type )
2014-06-25 04:43:43 +04:00
bit = mbox_read_reg ( mbox - > parent , irqdisable ) & ~ bit ;
2014-06-25 04:43:41 +04:00
2014-06-25 04:43:43 +04:00
mbox_write_reg ( mbox - > parent , bit , irqdisable ) ;
2013-03-13 02:55:29 +04:00
}
2014-11-04 02:05:50 +03:00
void omap_mbox_enable_irq ( struct mbox_chan * chan , omap_mbox_irq_t irq )
2006-12-08 02:43:59 +03:00
{
2014-11-04 02:05:50 +03:00
struct omap_mbox * mbox = mbox_chan_to_omap_mbox ( chan ) ;
2006-12-08 02:43:59 +03:00
2014-11-04 02:05:50 +03:00
if ( WARN_ON ( ! mbox ) )
return ;
2010-05-05 19:33:09 +04:00
2014-11-04 02:05:50 +03:00
_omap_mbox_enable_irq ( mbox , irq ) ;
}
EXPORT_SYMBOL ( omap_mbox_enable_irq ) ;
2010-05-05 19:33:09 +04:00
2014-11-04 02:05:50 +03:00
void omap_mbox_disable_irq ( struct mbox_chan * chan , omap_mbox_irq_t irq )
{
struct omap_mbox * mbox = mbox_chan_to_omap_mbox ( chan ) ;
if ( WARN_ON ( ! mbox ) )
return ;
_omap_mbox_disable_irq ( mbox , irq ) ;
2006-12-08 02:43:59 +03:00
}
2014-11-04 02:05:50 +03:00
EXPORT_SYMBOL ( omap_mbox_disable_irq ) ;
2006-12-08 02:43:59 +03:00
/*
* Message receiver ( workqueue )
*/
static void mbox_rx_work ( struct work_struct * work )
{
struct omap_mbox_queue * mq =
container_of ( work , struct omap_mbox_queue , work ) ;
mbox_msg_t msg ;
2010-05-05 19:33:09 +04:00
int len ;
while ( kfifo_len ( & mq - > fifo ) > = sizeof ( msg ) ) {
len = kfifo_out ( & mq - > fifo , ( unsigned char * ) & msg , sizeof ( msg ) ) ;
WARN_ON ( len ! = sizeof ( msg ) ) ;
2006-12-08 02:43:59 +03:00
2014-11-04 02:05:50 +03:00
mbox_chan_received_data ( mq - > mbox - > chan , ( void * ) msg ) ;
2010-11-29 23:24:11 +03:00
spin_lock_irq ( & mq - > lock ) ;
if ( mq - > full ) {
mq - > full = false ;
2014-11-04 02:05:50 +03:00
_omap_mbox_enable_irq ( mq - > mbox , IRQ_RX ) ;
2010-11-29 23:24:11 +03:00
}
spin_unlock_irq ( & mq - > lock ) ;
2006-12-08 02:43:59 +03:00
}
}
/*
* Mailbox interrupt handler
*/
static void __mbox_tx_interrupt ( struct omap_mbox * mbox )
{
2014-11-04 02:05:50 +03:00
_omap_mbox_disable_irq ( mbox , IRQ_TX ) ;
2006-12-08 02:43:59 +03:00
ack_mbox_irq ( mbox , IRQ_TX ) ;
2014-11-04 02:05:50 +03:00
mbox_chan_txdone ( mbox - > chan , 0 ) ;
2006-12-08 02:43:59 +03:00
}
static void __mbox_rx_interrupt ( struct omap_mbox * mbox )
{
2010-05-05 19:33:09 +04:00
struct omap_mbox_queue * mq = mbox - > rxq ;
2006-12-08 02:43:59 +03:00
mbox_msg_t msg ;
2010-05-05 19:33:09 +04:00
int len ;
2006-12-08 02:43:59 +03:00
while ( ! mbox_fifo_empty ( mbox ) ) {
2010-05-05 19:33:09 +04:00
if ( unlikely ( kfifo_avail ( & mq - > fifo ) < sizeof ( msg ) ) ) {
2014-11-04 02:05:50 +03:00
_omap_mbox_disable_irq ( mbox , IRQ_RX ) ;
2010-11-29 23:24:11 +03:00
mq - > full = true ;
2006-12-08 02:43:59 +03:00
goto nomem ;
2010-02-08 22:35:40 +03:00
}
2006-12-08 02:43:59 +03:00
msg = mbox_fifo_read ( mbox ) ;
2010-05-05 19:33:09 +04:00
len = kfifo_in ( & mq - > fifo , ( unsigned char * ) & msg , sizeof ( msg ) ) ;
WARN_ON ( len ! = sizeof ( msg ) ) ;
2006-12-08 02:43:59 +03:00
}
/* no more messages in the fifo. clear IRQ source. */
ack_mbox_irq ( mbox , IRQ_RX ) ;
2009-03-24 04:07:24 +03:00
nomem :
2011-01-26 14:12:50 +03:00
schedule_work ( & mbox - > rxq - > work ) ;
2006-12-08 02:43:59 +03:00
}
static irqreturn_t mbox_interrupt ( int irq , void * p )
{
2007-10-26 13:40:22 +04:00
struct omap_mbox * mbox = p ;
2006-12-08 02:43:59 +03:00
if ( is_mbox_irq ( mbox , IRQ_TX ) )
__mbox_tx_interrupt ( mbox ) ;
if ( is_mbox_irq ( mbox , IRQ_RX ) )
__mbox_rx_interrupt ( mbox ) ;
return IRQ_HANDLED ;
}
static struct omap_mbox_queue * mbox_queue_alloc ( struct omap_mbox * mbox ,
2014-11-04 02:05:50 +03:00
void ( * work ) ( struct work_struct * ) )
2006-12-08 02:43:59 +03:00
{
struct omap_mbox_queue * mq ;
2014-11-04 02:05:50 +03:00
if ( ! work )
return NULL ;
2016-04-06 20:37:38 +03:00
mq = kzalloc ( sizeof ( * mq ) , GFP_KERNEL ) ;
2006-12-08 02:43:59 +03:00
if ( ! mq )
return NULL ;
spin_lock_init ( & mq - > lock ) ;
2010-05-05 19:33:09 +04:00
if ( kfifo_alloc ( & mq - > fifo , mbox_kfifo_size , GFP_KERNEL ) )
2006-12-08 02:43:59 +03:00
goto error ;
2014-11-04 02:05:50 +03:00
INIT_WORK ( & mq - > work , work ) ;
2006-12-08 02:43:59 +03:00
return mq ;
2014-11-04 02:05:50 +03:00
2006-12-08 02:43:59 +03:00
error :
kfree ( mq ) ;
return NULL ;
}
static void mbox_queue_free ( struct omap_mbox_queue * q )
{
2010-05-05 19:33:09 +04:00
kfifo_free ( & q - > fifo ) ;
2006-12-08 02:43:59 +03:00
kfree ( q ) ;
}
2009-11-22 21:11:19 +03:00
static int omap_mbox_startup ( struct omap_mbox * mbox )
2006-12-08 02:43:59 +03:00
{
2009-11-22 21:11:22 +03:00
int ret = 0 ;
2006-12-08 02:43:59 +03:00
struct omap_mbox_queue * mq ;
2014-11-04 02:05:50 +03:00
mq = mbox_queue_alloc ( mbox , mbox_rx_work ) ;
if ( ! mq )
return - ENOMEM ;
mbox - > rxq = mq ;
mq - > mbox = mbox ;
ret = request_irq ( mbox - > irq , mbox_interrupt , IRQF_SHARED ,
mbox - > name , mbox ) ;
if ( unlikely ( ret ) ) {
pr_err ( " failed to register mailbox interrupt:%d \n " , ret ) ;
goto fail_request_irq ;
}
2006-12-08 02:43:59 +03:00
2015-09-23 03:14:52 +03:00
if ( mbox - > send_no_irq )
mbox - > chan - > txdone_method = TXDONE_BY_ACK ;
2014-11-04 02:05:50 +03:00
_omap_mbox_enable_irq ( mbox , IRQ_RX ) ;
2012-05-13 16:33:04 +04:00
2006-12-08 02:43:59 +03:00
return 0 ;
2013-02-02 06:37:06 +04:00
fail_request_irq :
mbox_queue_free ( mbox - > rxq ) ;
2006-12-08 02:43:59 +03:00
return ret ;
}
static void omap_mbox_fini ( struct omap_mbox * mbox )
{
2014-11-04 02:05:50 +03:00
_omap_mbox_disable_irq ( mbox , IRQ_RX ) ;
free_irq ( mbox - > irq , mbox ) ;
flush_work ( & mbox - > rxq - > work ) ;
mbox_queue_free ( mbox - > rxq ) ;
2006-12-08 02:43:59 +03:00
}
2014-06-25 04:43:43 +04:00
static struct omap_mbox * omap_mbox_device_find ( struct omap_mbox_device * mdev ,
const char * mbox_name )
2006-12-08 02:43:59 +03:00
{
2011-02-11 22:56:43 +03:00
struct omap_mbox * _mbox , * mbox = NULL ;
2014-06-25 04:43:43 +04:00
struct omap_mbox * * mboxes = mdev - > mboxes ;
int i ;
2006-12-08 02:43:59 +03:00
2010-06-11 19:51:46 +04:00
if ( ! mboxes )
2014-06-25 04:43:43 +04:00
return NULL ;
2006-12-08 02:43:59 +03:00
2011-02-11 22:56:43 +03:00
for ( i = 0 ; ( _mbox = mboxes [ i ] ) ; i + + ) {
2014-06-25 04:43:43 +04:00
if ( ! strcmp ( _mbox - > name , mbox_name ) ) {
2011-02-11 22:56:43 +03:00
mbox = _mbox ;
2010-06-11 19:51:46 +04:00
break ;
2011-02-11 22:56:43 +03:00
}
}
2014-06-25 04:43:43 +04:00
return mbox ;
}
2014-11-04 02:05:50 +03:00
struct mbox_chan * omap_mbox_request_channel ( struct mbox_client * cl ,
const char * chan_name )
2014-06-25 04:43:43 +04:00
{
2014-11-04 02:05:50 +03:00
struct device * dev = cl - > dev ;
2014-06-25 04:43:43 +04:00
struct omap_mbox * mbox = NULL ;
struct omap_mbox_device * mdev ;
2014-11-04 02:05:50 +03:00
struct mbox_chan * chan ;
unsigned long flags ;
2014-06-25 04:43:43 +04:00
int ret ;
2014-11-04 02:05:50 +03:00
if ( ! dev )
return ERR_PTR ( - ENODEV ) ;
if ( dev - > of_node ) {
pr_err ( " %s: please use mbox_request_channel(), this API is supported only for OMAP non-DT usage \n " ,
__func__ ) ;
return ERR_PTR ( - ENODEV ) ;
}
2014-06-25 04:43:43 +04:00
mutex_lock ( & omap_mbox_devices_lock ) ;
list_for_each_entry ( mdev , & omap_mbox_devices , elem ) {
2014-11-04 02:05:50 +03:00
mbox = omap_mbox_device_find ( mdev , chan_name ) ;
2014-06-25 04:43:43 +04:00
if ( mbox )
break ;
}
mutex_unlock ( & omap_mbox_devices_lock ) ;
2010-06-11 19:51:46 +04:00
2014-11-04 02:05:50 +03:00
if ( ! mbox | | ! mbox - > chan )
2010-06-11 19:51:46 +04:00
return ERR_PTR ( - ENOENT ) ;
2006-12-08 02:43:59 +03:00
2014-11-04 02:05:50 +03:00
chan = mbox - > chan ;
spin_lock_irqsave ( & chan - > lock , flags ) ;
chan - > msg_free = 0 ;
chan - > msg_count = 0 ;
chan - > active_req = NULL ;
chan - > cl = cl ;
init_completion ( & chan - > tx_complete ) ;
spin_unlock_irqrestore ( & chan - > lock , flags ) ;
2010-11-29 23:24:14 +03:00
2014-11-04 02:05:50 +03:00
ret = chan - > mbox - > ops - > startup ( chan ) ;
2012-05-13 16:33:04 +04:00
if ( ret ) {
2014-11-04 02:05:50 +03:00
pr_err ( " Unable to startup the chan (%d) \n " , ret ) ;
mbox_free_channel ( chan ) ;
chan = ERR_PTR ( ret ) ;
2012-05-13 16:33:04 +04:00
}
2014-11-04 02:05:50 +03:00
return chan ;
2006-12-08 02:43:59 +03:00
}
2014-11-04 02:05:50 +03:00
EXPORT_SYMBOL ( omap_mbox_request_channel ) ;
2006-12-08 02:43:59 +03:00
2010-05-18 17:15:32 +04:00
static struct class omap_mbox_class = { . name = " mbox " , } ;
2014-06-25 04:43:43 +04:00
static int omap_mbox_register ( struct omap_mbox_device * mdev )
2006-12-08 02:43:59 +03:00
{
2010-06-11 19:51:46 +04:00
int ret ;
int i ;
2014-06-25 04:43:43 +04:00
struct omap_mbox * * mboxes ;
2006-12-08 02:43:59 +03:00
2014-06-25 04:43:43 +04:00
if ( ! mdev | | ! mdev - > mboxes )
2006-12-08 02:43:59 +03:00
return - EINVAL ;
2014-06-25 04:43:43 +04:00
mboxes = mdev - > mboxes ;
2010-06-11 19:51:46 +04:00
for ( i = 0 ; mboxes [ i ] ; i + + ) {
struct omap_mbox * mbox = mboxes [ i ] ;
2016-04-06 20:37:40 +03:00
2014-11-04 02:05:50 +03:00
mbox - > dev = device_create ( & omap_mbox_class , mdev - > dev ,
0 , mbox , " %s " , mbox - > name ) ;
2010-06-11 19:51:46 +04:00
if ( IS_ERR ( mbox - > dev ) ) {
ret = PTR_ERR ( mbox - > dev ) ;
goto err_out ;
}
}
2014-06-25 04:43:43 +04:00
mutex_lock ( & omap_mbox_devices_lock ) ;
list_add ( & mdev - > elem , & omap_mbox_devices ) ;
mutex_unlock ( & omap_mbox_devices_lock ) ;
2014-11-04 02:05:50 +03:00
ret = mbox_controller_register ( & mdev - > controller ) ;
2009-03-24 04:07:24 +03:00
2010-06-11 19:51:46 +04:00
err_out :
2014-11-04 02:05:50 +03:00
if ( ret ) {
while ( i - - )
device_unregister ( mboxes [ i ] - > dev ) ;
}
2006-12-08 02:43:59 +03:00
return ret ;
}
2014-06-25 04:43:43 +04:00
static int omap_mbox_unregister ( struct omap_mbox_device * mdev )
2006-12-08 02:43:59 +03:00
{
2010-06-11 19:51:46 +04:00
int i ;
2014-06-25 04:43:43 +04:00
struct omap_mbox * * mboxes ;
2006-12-08 02:43:59 +03:00
2014-06-25 04:43:43 +04:00
if ( ! mdev | | ! mdev - > mboxes )
2010-06-11 19:51:46 +04:00
return - EINVAL ;
2014-06-25 04:43:43 +04:00
mutex_lock ( & omap_mbox_devices_lock ) ;
list_del ( & mdev - > elem ) ;
mutex_unlock ( & omap_mbox_devices_lock ) ;
2014-11-04 02:05:50 +03:00
mbox_controller_unregister ( & mdev - > controller ) ;
2014-06-25 04:43:43 +04:00
mboxes = mdev - > mboxes ;
2010-06-11 19:51:46 +04:00
for ( i = 0 ; mboxes [ i ] ; i + + )
device_unregister ( mboxes [ i ] - > dev ) ;
return 0 ;
2006-12-08 02:43:59 +03:00
}
2014-06-25 04:43:41 +04:00
2014-11-04 02:05:50 +03:00
static int omap_mbox_chan_startup ( struct mbox_chan * chan )
{
struct omap_mbox * mbox = mbox_chan_to_omap_mbox ( chan ) ;
struct omap_mbox_device * mdev = mbox - > parent ;
int ret = 0 ;
mutex_lock ( & mdev - > cfg_lock ) ;
pm_runtime_get_sync ( mdev - > dev ) ;
ret = omap_mbox_startup ( mbox ) ;
if ( ret )
pm_runtime_put_sync ( mdev - > dev ) ;
mutex_unlock ( & mdev - > cfg_lock ) ;
return ret ;
}
static void omap_mbox_chan_shutdown ( struct mbox_chan * chan )
{
struct omap_mbox * mbox = mbox_chan_to_omap_mbox ( chan ) ;
struct omap_mbox_device * mdev = mbox - > parent ;
mutex_lock ( & mdev - > cfg_lock ) ;
omap_mbox_fini ( mbox ) ;
pm_runtime_put_sync ( mdev - > dev ) ;
mutex_unlock ( & mdev - > cfg_lock ) ;
}
2015-09-23 03:14:52 +03:00
static int omap_mbox_chan_send_noirq ( struct omap_mbox * mbox , void * data )
2014-11-04 02:05:50 +03:00
{
int ret = - EBUSY ;
2015-09-23 03:14:52 +03:00
if ( ! mbox_fifo_full ( mbox ) ) {
_omap_mbox_enable_irq ( mbox , IRQ_RX ) ;
mbox_fifo_write ( mbox , ( mbox_msg_t ) data ) ;
ret = 0 ;
_omap_mbox_disable_irq ( mbox , IRQ_RX ) ;
/* we must read and ack the interrupt directly from here */
mbox_fifo_read ( mbox ) ;
ack_mbox_irq ( mbox , IRQ_RX ) ;
}
return ret ;
}
static int omap_mbox_chan_send ( struct omap_mbox * mbox , void * data )
{
int ret = - EBUSY ;
2014-11-04 02:05:50 +03:00
if ( ! mbox_fifo_full ( mbox ) ) {
mbox_fifo_write ( mbox , ( mbox_msg_t ) data ) ;
ret = 0 ;
}
/* always enable the interrupt */
_omap_mbox_enable_irq ( mbox , IRQ_TX ) ;
return ret ;
}
2015-09-23 03:14:52 +03:00
static int omap_mbox_chan_send_data ( struct mbox_chan * chan , void * data )
{
struct omap_mbox * mbox = mbox_chan_to_omap_mbox ( chan ) ;
int ret ;
if ( ! mbox )
return - EINVAL ;
if ( mbox - > send_no_irq )
ret = omap_mbox_chan_send_noirq ( mbox , data ) ;
else
ret = omap_mbox_chan_send ( mbox , data ) ;
return ret ;
}
2015-05-04 20:36:35 +03:00
static const struct mbox_chan_ops omap_mbox_chan_ops = {
2014-11-04 02:05:50 +03:00
. startup = omap_mbox_chan_startup ,
. send_data = omap_mbox_chan_send_data ,
. shutdown = omap_mbox_chan_shutdown ,
} ;
2016-04-07 02:37:18 +03:00
# ifdef CONFIG_PM_SLEEP
static int omap_mbox_suspend ( struct device * dev )
{
struct omap_mbox_device * mdev = dev_get_drvdata ( dev ) ;
2016-04-07 02:37:19 +03:00
u32 usr , fifo , reg ;
2016-04-07 02:37:18 +03:00
if ( pm_runtime_status_suspended ( dev ) )
return 0 ;
2016-04-07 02:37:19 +03:00
for ( fifo = 0 ; fifo < mdev - > num_fifos ; fifo + + ) {
if ( mbox_read_reg ( mdev , MAILBOX_MSGSTATUS ( fifo ) ) ) {
dev_err ( mdev - > dev , " fifo %d has unexpected unread messages \n " ,
fifo ) ;
return - EBUSY ;
}
}
2016-04-07 02:37:18 +03:00
for ( usr = 0 ; usr < mdev - > num_users ; usr + + ) {
reg = MAILBOX_IRQENABLE ( mdev - > intr_type , usr ) ;
mdev - > irq_ctx [ usr ] = mbox_read_reg ( mdev , reg ) ;
}
return 0 ;
}
static int omap_mbox_resume ( struct device * dev )
{
struct omap_mbox_device * mdev = dev_get_drvdata ( dev ) ;
u32 usr , reg ;
if ( pm_runtime_status_suspended ( dev ) )
return 0 ;
for ( usr = 0 ; usr < mdev - > num_users ; usr + + ) {
reg = MAILBOX_IRQENABLE ( mdev - > intr_type , usr ) ;
mbox_write_reg ( mdev , mdev - > irq_ctx [ usr ] , reg ) ;
}
return 0 ;
}
# endif
static const struct dev_pm_ops omap_mbox_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS ( omap_mbox_suspend , omap_mbox_resume )
} ;
2018-07-12 02:42:12 +03:00
static const struct omap_mbox_match_data omap2_data = { MBOX_INTR_CFG_TYPE1 } ;
static const struct omap_mbox_match_data omap4_data = { MBOX_INTR_CFG_TYPE2 } ;
2014-09-10 23:20:59 +04:00
static const struct of_device_id omap_mailbox_of_match [ ] = {
{
. compatible = " ti,omap2-mailbox " ,
2018-07-12 02:42:12 +03:00
. data = & omap2_data ,
2014-09-10 23:20:59 +04:00
} ,
{
. compatible = " ti,omap3-mailbox " ,
2018-07-12 02:42:12 +03:00
. data = & omap2_data ,
2014-09-10 23:20:59 +04:00
} ,
{
. compatible = " ti,omap4-mailbox " ,
2018-07-12 02:42:12 +03:00
. data = & omap4_data ,
2014-09-10 23:20:59 +04:00
} ,
{
/* end */
} ,
} ;
MODULE_DEVICE_TABLE ( of , omap_mailbox_of_match ) ;
2014-11-04 02:05:50 +03:00
static struct mbox_chan * omap_mbox_of_xlate ( struct mbox_controller * controller ,
const struct of_phandle_args * sp )
{
phandle phandle = sp - > args [ 0 ] ;
struct device_node * node ;
struct omap_mbox_device * mdev ;
struct omap_mbox * mbox ;
mdev = container_of ( controller , struct omap_mbox_device , controller ) ;
if ( WARN_ON ( ! mdev ) )
2015-05-04 20:36:36 +03:00
return ERR_PTR ( - EINVAL ) ;
2014-11-04 02:05:50 +03:00
node = of_find_node_by_phandle ( phandle ) ;
if ( ! node ) {
pr_err ( " %s: could not find node phandle 0x%x \n " ,
__func__ , phandle ) ;
2015-05-04 20:36:36 +03:00
return ERR_PTR ( - ENODEV ) ;
2014-11-04 02:05:50 +03:00
}
mbox = omap_mbox_device_find ( mdev , node - > name ) ;
of_node_put ( node ) ;
2015-05-04 20:36:36 +03:00
return mbox ? mbox - > chan : ERR_PTR ( - ENOENT ) ;
2014-11-04 02:05:50 +03:00
}
2014-06-25 04:43:41 +04:00
static int omap_mbox_probe ( struct platform_device * pdev )
{
struct resource * mem ;
int ret ;
2014-11-04 02:05:50 +03:00
struct mbox_chan * chnls ;
2014-06-25 04:43:41 +04:00
struct omap_mbox * * list , * mbox , * mboxblk ;
2014-09-10 23:20:59 +04:00
struct omap_mbox_fifo_info * finfo , * finfoblk ;
2014-06-25 04:43:43 +04:00
struct omap_mbox_device * mdev ;
2014-06-25 04:43:42 +04:00
struct omap_mbox_fifo * fifo ;
2014-09-10 23:20:59 +04:00
struct device_node * node = pdev - > dev . of_node ;
struct device_node * child ;
2018-07-12 02:42:12 +03:00
const struct omap_mbox_match_data * match_data ;
2014-09-10 23:20:59 +04:00
u32 intr_type , info_count ;
u32 num_users , num_fifos ;
u32 tmp [ 3 ] ;
2014-06-25 04:43:41 +04:00
u32 l ;
int i ;
2016-04-06 20:37:37 +03:00
if ( ! node ) {
pr_err ( " %s: only DT-based devices are supported \n " , __func__ ) ;
2014-06-25 04:43:41 +04:00
return - ENODEV ;
}
2018-07-12 02:42:12 +03:00
match_data = of_device_get_match_data ( & pdev - > dev ) ;
if ( ! match_data )
2016-04-06 20:37:37 +03:00
return - ENODEV ;
2018-07-12 02:42:12 +03:00
intr_type = match_data - > intr_type ;
2014-09-10 23:20:59 +04:00
2016-04-06 20:37:37 +03:00
if ( of_property_read_u32 ( node , " ti,mbox-num-users " , & num_users ) )
return - ENODEV ;
2014-09-10 23:20:59 +04:00
2016-04-06 20:37:37 +03:00
if ( of_property_read_u32 ( node , " ti,mbox-num-fifos " , & num_fifos ) )
return - ENODEV ;
2014-09-10 23:20:59 +04:00
2016-04-06 20:37:37 +03:00
info_count = of_get_available_child_count ( node ) ;
if ( ! info_count ) {
dev_err ( & pdev - > dev , " no available mbox devices found \n " ) ;
return - ENODEV ;
2014-09-10 23:20:59 +04:00
}
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 00:07:58 +03:00
finfoblk = devm_kcalloc ( & pdev - > dev , info_count , sizeof ( * finfoblk ) ,
2014-09-10 23:20:59 +04:00
GFP_KERNEL ) ;
if ( ! finfoblk )
return - ENOMEM ;
finfo = finfoblk ;
child = NULL ;
for ( i = 0 ; i < info_count ; i + + , finfo + + ) {
2016-04-06 20:37:37 +03:00
child = of_get_next_available_child ( node , child ) ;
ret = of_property_read_u32_array ( child , " ti,mbox-tx " , tmp ,
ARRAY_SIZE ( tmp ) ) ;
if ( ret )
return ret ;
finfo - > tx_id = tmp [ 0 ] ;
finfo - > tx_irq = tmp [ 1 ] ;
finfo - > tx_usr = tmp [ 2 ] ;
ret = of_property_read_u32_array ( child , " ti,mbox-rx " , tmp ,
ARRAY_SIZE ( tmp ) ) ;
if ( ret )
return ret ;
finfo - > rx_id = tmp [ 0 ] ;
finfo - > rx_irq = tmp [ 1 ] ;
finfo - > rx_usr = tmp [ 2 ] ;
finfo - > name = child - > name ;
if ( of_find_property ( child , " ti,mbox-send-noirq " , NULL ) )
finfo - > send_no_irq = true ;
2014-09-10 23:20:59 +04:00
if ( finfo - > tx_id > = num_fifos | | finfo - > rx_id > = num_fifos | |
finfo - > tx_usr > = num_users | | finfo - > rx_usr > = num_users )
return - EINVAL ;
}
2014-06-25 04:43:43 +04:00
mdev = devm_kzalloc ( & pdev - > dev , sizeof ( * mdev ) , GFP_KERNEL ) ;
if ( ! mdev )
return - ENOMEM ;
mem = platform_get_resource ( pdev , IORESOURCE_MEM , 0 ) ;
mdev - > mbox_base = devm_ioremap_resource ( & pdev - > dev , mem ) ;
if ( IS_ERR ( mdev - > mbox_base ) )
return PTR_ERR ( mdev - > mbox_base ) ;
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 00:07:58 +03:00
mdev - > irq_ctx = devm_kcalloc ( & pdev - > dev , num_users , sizeof ( u32 ) ,
2016-04-07 02:37:18 +03:00
GFP_KERNEL ) ;
if ( ! mdev - > irq_ctx )
return - ENOMEM ;
2014-06-25 04:43:41 +04:00
/* allocate one extra for marking end of list */
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 00:07:58 +03:00
list = devm_kcalloc ( & pdev - > dev , info_count + 1 , sizeof ( * list ) ,
2014-06-25 04:43:41 +04:00
GFP_KERNEL ) ;
if ( ! list )
return - ENOMEM ;
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 00:07:58 +03:00
chnls = devm_kcalloc ( & pdev - > dev , info_count + 1 , sizeof ( * chnls ) ,
2014-11-04 02:05:50 +03:00
GFP_KERNEL ) ;
if ( ! chnls )
return - ENOMEM ;
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 00:07:58 +03:00
mboxblk = devm_kcalloc ( & pdev - > dev , info_count , sizeof ( * mbox ) ,
2014-06-25 04:43:41 +04:00
GFP_KERNEL ) ;
if ( ! mboxblk )
return - ENOMEM ;
mbox = mboxblk ;
2014-09-10 23:20:59 +04:00
finfo = finfoblk ;
for ( i = 0 ; i < info_count ; i + + , finfo + + ) {
2014-06-25 04:43:42 +04:00
fifo = & mbox - > tx_fifo ;
2014-09-10 23:20:59 +04:00
fifo - > msg = MAILBOX_MESSAGE ( finfo - > tx_id ) ;
fifo - > fifo_stat = MAILBOX_FIFOSTATUS ( finfo - > tx_id ) ;
fifo - > intr_bit = MAILBOX_IRQ_NOTFULL ( finfo - > tx_id ) ;
fifo - > irqenable = MAILBOX_IRQENABLE ( intr_type , finfo - > tx_usr ) ;
fifo - > irqstatus = MAILBOX_IRQSTATUS ( intr_type , finfo - > tx_usr ) ;
fifo - > irqdisable = MAILBOX_IRQDISABLE ( intr_type , finfo - > tx_usr ) ;
2014-06-25 04:43:42 +04:00
fifo = & mbox - > rx_fifo ;
2014-09-10 23:20:59 +04:00
fifo - > msg = MAILBOX_MESSAGE ( finfo - > rx_id ) ;
fifo - > msg_stat = MAILBOX_MSGSTATUS ( finfo - > rx_id ) ;
fifo - > intr_bit = MAILBOX_IRQ_NEWMSG ( finfo - > rx_id ) ;
fifo - > irqenable = MAILBOX_IRQENABLE ( intr_type , finfo - > rx_usr ) ;
fifo - > irqstatus = MAILBOX_IRQSTATUS ( intr_type , finfo - > rx_usr ) ;
fifo - > irqdisable = MAILBOX_IRQDISABLE ( intr_type , finfo - > rx_usr ) ;
2014-06-25 04:43:42 +04:00
2015-09-23 03:14:52 +03:00
mbox - > send_no_irq = finfo - > send_no_irq ;
2014-06-25 04:43:42 +04:00
mbox - > intr_type = intr_type ;
2014-06-25 04:43:43 +04:00
mbox - > parent = mdev ;
2014-09-10 23:20:59 +04:00
mbox - > name = finfo - > name ;
mbox - > irq = platform_get_irq ( pdev , finfo - > tx_irq ) ;
2014-06-25 04:43:41 +04:00
if ( mbox - > irq < 0 )
return mbox - > irq ;
2014-11-04 02:05:50 +03:00
mbox - > chan = & chnls [ i ] ;
chnls [ i ] . con_priv = mbox ;
2014-06-25 04:43:41 +04:00
list [ i ] = mbox + + ;
}
2014-06-25 04:43:43 +04:00
mutex_init ( & mdev - > cfg_lock ) ;
mdev - > dev = & pdev - > dev ;
2014-09-10 23:20:59 +04:00
mdev - > num_users = num_users ;
mdev - > num_fifos = num_fifos ;
2016-04-07 02:37:17 +03:00
mdev - > intr_type = intr_type ;
2014-06-25 04:43:43 +04:00
mdev - > mboxes = list ;
2014-11-04 02:05:50 +03:00
/* OMAP does not have a Tx-Done IRQ, but rather a Tx-Ready IRQ */
mdev - > controller . txdone_irq = true ;
mdev - > controller . dev = mdev - > dev ;
mdev - > controller . ops = & omap_mbox_chan_ops ;
mdev - > controller . chans = chnls ;
mdev - > controller . num_chans = info_count ;
mdev - > controller . of_xlate = omap_mbox_of_xlate ;
2014-06-25 04:43:43 +04:00
ret = omap_mbox_register ( mdev ) ;
2014-06-25 04:43:41 +04:00
if ( ret )
return ret ;
2014-06-25 04:43:43 +04:00
platform_set_drvdata ( pdev , mdev ) ;
pm_runtime_enable ( mdev - > dev ) ;
2014-06-25 04:43:41 +04:00
2014-06-25 04:43:43 +04:00
ret = pm_runtime_get_sync ( mdev - > dev ) ;
2014-06-25 04:43:41 +04:00
if ( ret < 0 ) {
2014-06-25 04:43:43 +04:00
pm_runtime_put_noidle ( mdev - > dev ) ;
2014-06-25 04:43:41 +04:00
goto unregister ;
}
/*
* just print the raw revision register , the format is not
* uniform across all SoCs
*/
2014-06-25 04:43:43 +04:00
l = mbox_read_reg ( mdev , MAILBOX_REVISION ) ;
dev_info ( mdev - > dev , " omap mailbox rev 0x%x \n " , l ) ;
2014-06-25 04:43:41 +04:00
2014-06-25 04:43:43 +04:00
ret = pm_runtime_put_sync ( mdev - > dev ) ;
2014-06-25 04:43:41 +04:00
if ( ret < 0 )
goto unregister ;
2014-09-10 23:20:59 +04:00
devm_kfree ( & pdev - > dev , finfoblk ) ;
2014-06-25 04:43:41 +04:00
return 0 ;
unregister :
2014-06-25 04:43:43 +04:00
pm_runtime_disable ( mdev - > dev ) ;
omap_mbox_unregister ( mdev ) ;
2014-06-25 04:43:41 +04:00
return ret ;
}
static int omap_mbox_remove ( struct platform_device * pdev )
{
2014-06-25 04:43:43 +04:00
struct omap_mbox_device * mdev = platform_get_drvdata ( pdev ) ;
pm_runtime_disable ( mdev - > dev ) ;
omap_mbox_unregister ( mdev ) ;
2014-06-25 04:43:41 +04:00
return 0 ;
}
static struct platform_driver omap_mbox_driver = {
. probe = omap_mbox_probe ,
. remove = omap_mbox_remove ,
. driver = {
. name = " omap-mailbox " ,
2016-04-07 02:37:18 +03:00
. pm = & omap_mbox_pm_ops ,
2014-09-10 23:20:59 +04:00
. of_match_table = of_match_ptr ( omap_mailbox_of_match ) ,
2014-06-25 04:43:41 +04:00
} ,
} ;
2006-12-08 02:43:59 +03:00
2009-11-22 21:11:19 +03:00
static int __init omap_mbox_init ( void )
2006-12-08 02:43:59 +03:00
{
2010-05-18 17:15:32 +04:00
int err ;
err = class_register ( & omap_mbox_class ) ;
if ( err )
return err ;
2010-05-05 19:33:09 +04:00
/* kfifo size sanity check: alignment and minimal size */
mbox_kfifo_size = ALIGN ( mbox_kfifo_size , sizeof ( mbox_msg_t ) ) ;
2010-11-29 23:24:12 +03:00
mbox_kfifo_size = max_t ( unsigned int , mbox_kfifo_size ,
sizeof ( mbox_msg_t ) ) ;
2010-05-05 19:33:09 +04:00
2017-11-11 21:09:18 +03:00
err = platform_driver_register ( & omap_mbox_driver ) ;
if ( err )
class_unregister ( & omap_mbox_class ) ;
return err ;
2006-12-08 02:43:59 +03:00
}
2010-05-18 17:15:32 +04:00
subsys_initcall ( omap_mbox_init ) ;
2006-12-08 02:43:59 +03:00
2009-11-22 21:11:19 +03:00
static void __exit omap_mbox_exit ( void )
2006-12-08 02:43:59 +03:00
{
2014-06-25 04:43:41 +04:00
platform_driver_unregister ( & omap_mbox_driver ) ;
2010-05-18 17:15:32 +04:00
class_unregister ( & omap_mbox_class ) ;
2006-12-08 02:43:59 +03:00
}
2009-11-22 21:11:19 +03:00
module_exit ( omap_mbox_exit ) ;
2006-12-08 02:43:59 +03:00
2009-03-24 04:07:24 +03:00
MODULE_LICENSE ( " GPL v2 " ) ;
MODULE_DESCRIPTION ( " omap mailbox: interrupt driven messaging " ) ;
2010-05-05 19:33:07 +04:00
MODULE_AUTHOR ( " Toshihiro Kobayashi " ) ;
MODULE_AUTHOR ( " Hiroshi DOYU " ) ;