iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i2c: i801: Improve is_dell_system_with_lis3lv02d

Browse Source 
Replace the ugly cast of the return_value pointer with proper usage.
In addition use dmi_match() instead of open-coding it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
Heiner Kallweit
2021-08-06 23:15:15 +02:00
committed by Wolfram Sang
parent 294b29f154
commit 2b3db4db66
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/i2c/busses/i2c-i801.c
View File

@ -1192,7 +1192,7 @@ static acpi_status check_acpi_smo88xx_device(acpi_handle obj_handle,
kfree(info);
*((bool *)return_value) = true;
*return_value = NULL;
return AE_CTRL_TERMINATE;
smo88xx_not_found:
@ -1202,11 +1202,9 @@ smo88xx_not_found:
static bool is_dell_system_with_lis3lv02d(void)
{
bool found;
const char *vendor;
void *err = ERR_PTR(-ENOENT);
vendor = dmi_get_system_info(DMI_SYS_VENDOR);
if (!vendor || strcmp(vendor, "Dell Inc."))
if (!dmi_match(DMI_SYS_VENDOR, "Dell Inc."))
return false;
/*
@ -1217,11 +1215,9 @@ static bool is_dell_system_with_lis3lv02d(void)
* accelerometer but unfortunately ACPI does not provide any other
* information (like I2C address).
*/
found = false;
acpi_get_devices(NULL, check_acpi_smo88xx_device, NULL,
(void **)&found);
acpi_get_devices(NULL, check_acpi_smo88xx_device, NULL, &err);
return found;
return !IS_ERR(err);
}
/*