iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: endo: fix device-id allocation

Browse Source 
During endo registration, a unique device id was allocated but then
never used. Instead the default dev_id 0 (due to kzalloc) was used for
device-generation and later for id-deallocation.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2015-10-21 11:51:43 +02:00 committed by Greg Kroah-Hartman
parent 16cd787d2d
commit 3014712fe1
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/greybus/endo.c
View File

@ -438,11 +438,14 @@ static int create_modules(struct gb_endo *endo)
static int gb_endo_register(struct greybus_host_device *hd,
struct gb_endo *endo)
{
int dev_id;
int retval;
retval = ida_simple_get(&greybus_endo_id_map, 0, 0, GFP_KERNEL);
if (retval < 0)
return retval;
dev_id = ida_simple_get(&greybus_endo_id_map, 0, 0, GFP_KERNEL);
if (dev_id < 0)
return dev_id;
endo->dev_id = dev_id;
endo->dev.parent = hd->parent;
endo->dev.bus = &greybus_bus_type;