iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phy: qcom-qmp-pcie: clean up device-tree parsing

Browse Source 
Since the QMP driver split there will be at most a single child node so
drop the obsolete iteration construct.

While at it, drop the verbose error logging that would have been
printed also on probe deferrals.

Note that there's no need to check if there are additional child nodes
(the kernel is not a devicetree validator), but let's return an error if
there are no child nodes at all for now.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20221105145939.20318-5-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Johan Hovold 2022-11-05 15:59:27 +01:00 committed by Vinod Koul
parent 2fdedef3ea
commit 393ed5d515
1 changed files with 9 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
View File

@ -2250,7 +2250,6 @@ static int qmp_pcie_probe(struct platform_device *pdev)
void __iomem *serdes;
const struct qmp_phy_cfg *cfg = NULL;
struct qmp_pcie *qmp;
int num, id;
int ret;
qmp = devm_kzalloc(dev, sizeof(*qmp), GFP_KERNEL);
@ -2283,34 +2282,19 @@ static int qmp_pcie_probe(struct platform_device *pdev)
if (ret)
return ret;
num = of_get_available_child_count(dev->of_node);
/* do we have a rogue child node ? */
if (num > 1)
child = of_get_next_available_child(dev->of_node, NULL);
if (!child)
return -EINVAL;
id = 0;
for_each_available_child_of_node(dev->of_node, child) {
/* Create per-lane phy */
ret = qmp_pcie_create(dev, child, serdes, cfg);
if (ret) {
dev_err(dev, "failed to create lane%d phy, %d\n",
id, ret);
goto err_node_put;
}
ret = qmp_pcie_create(dev, child, serdes, cfg);
if (ret)
goto err_node_put;
/*
* Register the pipe clock provided by phy.
* See function description to see details of this pipe clock.
*/
ret = phy_pipe_clk_register(qmp, child);
if (ret) {
dev_err(qmp->dev,
"failed to register pipe clock source\n");
goto err_node_put;
}
ret = phy_pipe_clk_register(qmp, child);
if (ret)
goto err_node_put;
id++;
}
of_node_put(child);
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);