iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmet: use a macro for default error location

Browse Source 
This patch defines a new macro NVMET_NO_ERROR_LOC to represent the
default error location value in the nvme-error-log-page.
This is a pure cleanup patch and it does not change any functionality.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Chaitanya Kulkarni 2018-12-17 18:35:29 -08:00 committed by Christoph Hellwig
parent 66c6afbd73
commit 5698b805fb
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/nvme/target/core.c
View File

@ -663,7 +663,7 @@ static void nvmet_set_error(struct nvmet_req *req, u16 status)
req->rsp->status = cpu_to_le16(status << 1); req->rsp->status = cpu_to_le16(status << 1);
if (!ctrl || req->error_loc == (u16)-1) if (!ctrl || req->error_loc == NVMET_NO_ERROR_LOC)
return; return;
spin_lock_irqsave(&ctrl->error_lock, flags); spin_lock_irqsave(&ctrl->error_lock, flags);
@ -849,7 +849,7 @@ bool nvmet_req_init(struct nvmet_req *req, struct nvmet_cq *cq,
req->rsp->status = 0; req->rsp->status = 0;
req->rsp->sq_head = 0; req->rsp->sq_head = 0;
req->ns = NULL; req->ns = NULL;
req->error_loc = -1; req->error_loc = NVMET_NO_ERROR_LOC;
req->error_slba = 0; req->error_slba = 0;
/* no support for fused commands yet */ /* no support for fused commands yet */

1
drivers/nvme/target/nvmet.h
View File

@ -30,6 +30,7 @@
#define NVMET_ASYNC_EVENTS 4 #define NVMET_ASYNC_EVENTS 4
#define NVMET_ERROR_LOG_SLOTS 128 #define NVMET_ERROR_LOG_SLOTS 128
#define NVMET_NO_ERROR_LOC ((u16)-1)
/* /*
* Supported optional AENs: * Supported optional AENs: