iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: core: re-use gb_module_find() in gb_remove_module()

Browse Source 
Also fix print message.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Viresh Kumar 2014-11-14 17:25:05 +05:30 committed by Greg Kroah-Hartman
parent ab34291da5
commit 577f5f974c
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/staging/greybus/core.c
View File

@ -162,19 +162,12 @@ err_module:
void gb_remove_module(struct greybus_host_device *hd, u8 module_id)
{
struct gb_module *gmod;
bool found = false;
struct gb_module *gmod = gb_module_find(hd, module_id);
list_for_each_entry(gmod, &hd->modules, links)
if (gmod->module_id == module_id) {
found = true;
break;
}
if (found)
if (gmod)
gb_module_destroy(gmod);
else
dev_err(hd->parent, "module id %d remove error\n", module_id);
dev_err(hd->parent, "module id %d not found\n", module_id);
}
static void gb_remove_modules(struct greybus_host_device *hd)