iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

arm64: dts: imx8mm: correct interrupt flags

Browse Source 
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW
  ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH

In case of level low interrupts, enable also internal pull up.  It is
required at least on imx8mm-evk, according to schematics.

The schematics for Variscite imx8mm-var-som are not available and
I was unable to get proper configuration from Variscite.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-By: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2020-09-17 20:54:47 +02:00 committed by Shawn Guo
parent 1d93b292af
commit 5f67317bd9
4 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
View File

@ -74,7 +74,7 @@
reg = <0x4b>; reg = <0x4b>;
pinctrl-0 = <&pinctrl_pmic>; pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio1>; interrupt-parent = <&gpio1>;
interrupts = <3 GPIO_ACTIVE_LOW>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
rohm,reset-snvs-powered; rohm,reset-snvs-powered;
regulators { regulators {
@ -292,7 +292,7 @@
pinctrl_pmic: pmicirqgrp { pinctrl_pmic: pmicirqgrp {
fsl,pins = < fsl,pins = <
MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x41 MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x141
>; >;
}; };

4
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
View File

@ -123,7 +123,7 @@
reg = <0x4b>; reg = <0x4b>;
pinctrl-0 = <&pinctrl_pmic>; pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio1>; interrupt-parent = <&gpio1>;
interrupts = <3 GPIO_ACTIVE_LOW>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
rohm,reset-snvs-powered; rohm,reset-snvs-powered;
#clock-cells = <0>; #clock-cells = <0>;
@ -392,7 +392,7 @@
pinctrl_pmic: pmicirqgrp { pinctrl_pmic: pmicirqgrp {
fsl,pins = < fsl,pins = <
MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x41 MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x141
>; >;
}; };

2
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts
View File

@ -129,7 +129,7 @@
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&pinctrl_captouch>; pinctrl-0 = <&pinctrl_captouch>;
interrupt-parent = <&gpio5>; interrupt-parent = <&gpio5>;
interrupts = <4 GPIO_ACTIVE_HIGH>; interrupts = <4 IRQ_TYPE_LEVEL_HIGH>;
touchscreen-size-x = <800>; touchscreen-size-x = <800>;
touchscreen-size-y = <480>; touchscreen-size-y = <480>;

6
arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
View File

@ -137,7 +137,11 @@
reg = <0x4b>; reg = <0x4b>;
pinctrl-0 = <&pinctrl_pmic>; pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio2>; interrupt-parent = <&gpio2>;
interrupts = <8 GPIO_ACTIVE_LOW>; /*
* The interrupt is not correct. It should be level low,
* however with internal pull up this causes IRQ storm.
*/
interrupts = <8 IRQ_TYPE_EDGE_RISING>;
rohm,reset-snvs-powered; rohm,reset-snvs-powered;
#clock-cells = <0>; #clock-cells = <0>;