drm/amd/display: Avoid MPC infinite loop
[Why] In some cases MPC tree bottom pipe ends up point to itself. This causes iterating from top to bottom to hang the system in an infinite loop. [How] When looping to next MPC bottom pipe, check that the pointer is not same as current to avoid infinite loop. Reviewed-by: Jun Lei <Jun.Lei@amd.com> Acked-by: Tom Chung <chiahsuan.chung@amd.com> Signed-off-by: Josip Pavic <Josip.Pavic@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
committed by
Alex Deucher
parent
9c580e8f6c
commit
615fc50207
@ -131,6 +131,12 @@ struct mpcc *mpc1_get_mpcc_for_dpp(struct mpc_tree *tree, int dpp_id)
|
||||
while (tmp_mpcc != NULL) {
|
||||
if (tmp_mpcc->dpp_id == dpp_id)
|
||||
return tmp_mpcc;
|
||||
|
||||
/* avoid circular linked list */
|
||||
ASSERT(tmp_mpcc != tmp_mpcc->mpcc_bot);
|
||||
if (tmp_mpcc == tmp_mpcc->mpcc_bot)
|
||||
break;
|
||||
|
||||
tmp_mpcc = tmp_mpcc->mpcc_bot;
|
||||
}
|
||||
return NULL;
|
||||
|
@ -531,6 +531,12 @@ static struct mpcc *mpc2_get_mpcc_for_dpp(struct mpc_tree *tree, int dpp_id)
|
||||
while (tmp_mpcc != NULL) {
|
||||
if (tmp_mpcc->dpp_id == 0xf || tmp_mpcc->dpp_id == dpp_id)
|
||||
return tmp_mpcc;
|
||||
|
||||
/* avoid circular linked list */
|
||||
ASSERT(tmp_mpcc != tmp_mpcc->mpcc_bot);
|
||||
if (tmp_mpcc == tmp_mpcc->mpcc_bot)
|
||||
break;
|
||||
|
||||
tmp_mpcc = tmp_mpcc->mpcc_bot;
|
||||
}
|
||||
return NULL;
|
||||
|
Reference in New Issue
Block a user