block: Restore sector of flush requests

On completion of a flush sequence, blk_flush_restore_request() restores
the bio of a request to the original submitted BIO. However, the last
use of the request in the flush sequence may have been for a POSTFLUSH
which does not have a sector. So make sure to restore the request sector
using the iter sector of the original BIO. This BIO has not changed yet
since the completions of the flush sequence intermediate steps use
requeueing of the request until all steps are completed.

Restoring the request sector ensures that blk_mq_end_request() will see
a valid sector as originally set when the flush BIO was submitted.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Hans Holmberg <hans.holmberg@wdc.com>
Tested-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20240408014128.205141-2-dlemoal@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Damien Le Moal 2024-04-08 10:41:01 +09:00 committed by Jens Axboe
parent de4c7bef9d
commit 6f8fd758de

View File

@ -130,6 +130,7 @@ static void blk_flush_restore_request(struct request *rq)
* original @rq->bio. Restore it. * original @rq->bio. Restore it.
*/ */
rq->bio = rq->biotail; rq->bio = rq->biotail;
rq->__sector = rq->bio->bi_iter.bi_sector;
/* make @rq a normal request */ /* make @rq a normal request */
rq->rq_flags &= ~RQF_FLUSH_SEQ; rq->rq_flags &= ~RQF_FLUSH_SEQ;