iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: phy: c22: migrate to genphy_c45_write_eee_adv()

Browse Source 
Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv().

It should work as before except write operation to the EEE adv registers
will be done only if some EEE abilities was detected.

If some driver will have a regression, related driver should provide own
.get_features callback. See micrel.c:ksz9477_get_features() as example.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Oleksij Rempel 2023-02-11 08:41:10 +01:00 committed by David S. Miller
parent 022c3f87f8
commit 9b01c885be
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/phy/phy_device.c
View File

@ -2231,7 +2231,10 @@ int __genphy_config_aneg(struct phy_device *phydev, bool changed)
{ {
int err; int err;
if (genphy_config_eee_advert(phydev)) err = genphy_c45_write_eee_adv(phydev, phydev->supported_eee);
if (err < 0)
return err;
else if (err)
changed = true; changed = true;
err = genphy_setup_master_slave(phydev); err = genphy_setup_master_slave(phydev);
@ -2653,6 +2656,11 @@ int genphy_read_abilities(struct phy_device *phydev)
phydev->supported, val & ESTATUS_1000_XFULL); phydev->supported, val & ESTATUS_1000_XFULL);
} }
/* This is optional functionality. If not supported, we may get an error
* which should be ignored.
*/
genphy_c45_read_eee_abilities(phydev);
return 0; return 0;
} }
EXPORT_SYMBOL(genphy_read_abilities); EXPORT_SYMBOL(genphy_read_abilities);