iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clk: lmk04832: fix return value check in lmk04832_probe()

Browse Source 
In case of error, the function devm_kzalloc() and devm_kcalloc() return
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: 3bc61cfd6f ("clk: add support for the lmk04832")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Link: https://lore.kernel.org/r/20210630020322.2555946-1-wanghai38@huawei.com
Reviewed-by: Liam Beguin <lvb@xiphos.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
This commit is contained in:
Wang Hai 2021-06-30 10:03:22 +08:00 committed by Stephen Boyd
parent b1f247714a
commit b424f73b6c
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/clk/clk-lmk04832.c
View File

@ -1425,23 +1425,23 @@ static int lmk04832_probe(struct spi_device *spi)
lmk->dclk = devm_kcalloc(lmk->dev, info->num_channels >> 1,
sizeof(struct lmk_dclk), GFP_KERNEL);
if (IS_ERR(lmk->dclk)) {
ret = PTR_ERR(lmk->dclk);
if (!lmk->dclk) {
ret = -ENOMEM;
goto err_disable_oscin;
}
lmk->clkout = devm_kcalloc(lmk->dev, info->num_channels,
sizeof(*lmk->clkout), GFP_KERNEL);
if (IS_ERR(lmk->clkout)) {
ret = PTR_ERR(lmk->clkout);
if (!lmk->clkout) {
ret = -ENOMEM;
goto err_disable_oscin;
}
lmk->clk_data = devm_kzalloc(lmk->dev, struct_size(lmk->clk_data, hws,
info->num_channels),
GFP_KERNEL);
if (IS_ERR(lmk->clk_data)) {
ret = PTR_ERR(lmk->clk_data);
if (!lmk->clk_data) {
ret = -ENOMEM;
goto err_disable_oscin;
}