iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

amd/pds_core: core: No need for Null pointer check before kfree

Browse Source 
kfree()/vfree() internally perform NULL check on the
pointer handed to it and take no action if it indeed is
NULL. Hence there is no need for a pre-check of the memory
pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic
patch script.

Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Bragatheswaran Manickavel
2023-10-24 23:50:51 +05:30
committed by David S. Miller
parent 61450abfc9
commit d0110443cf
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/ethernet/amd/pds_core/core.c
View File

@ -152,11 +152,8 @@ void pdsc_qcq_free(struct pdsc *pdsc, struct pdsc_qcq *qcq)
dma_free_coherent(dev, qcq->cq_size,
qcq->cq_base, qcq->cq_base_pa);
if (qcq->cq.info)
vfree(qcq->cq.info);
if (qcq->q.info)
vfree(qcq->q.info);
vfree(qcq->cq.info);
vfree(qcq->q.info);
memset(qcq, 0, sizeof(*qcq));
}