iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Staging: vt6655-6: potential info leak in private_ioctl()

Browse Source 
Smatch has a new check for Rosenberg type information leaks where
structs are copied to the user with uninitialized stack data in them.

In this path, the .uLinkRate member doesn't get initialized so I've
set it to zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Dan Carpenter 2011-09-23 09:23:22 +03:00 committed by Greg Kroah-Hartman
parent 43664e14a0
commit de0920b1fe
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/staging/vt6655/ioctl.c
View File

@ -296,6 +296,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq) {
} }
else { else {
sLinkStatus.bLink = false; sLinkStatus.bLink = false;
sLinkStatus.uLinkRate = 0;
} }
if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) { if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) {
result = -EFAULT; result = -EFAULT;

1
drivers/staging/vt6656/ioctl.c
View File

@ -291,6 +291,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq) {
} }
else { else {
sLinkStatus.bLink = FALSE; sLinkStatus.bLink = FALSE;
sLinkStatus.uLinkRate = 0;
} }
if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) { if (copy_to_user(pReq->data, &sLinkStatus, sizeof(SCmdLinkStatus))) {
result = -EFAULT; result = -EFAULT;