iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rsi: use BUILD_BUG_ON check for fsm_state

Browse Source 
Whenever new fsm_state enum element is added, fsm_state array
also needs to be updated. If this change is missed, we may end
up doing invalid access in array. BUILD_BUG_ON check will help
to avoid this problem.

Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Amitkumar Karwar 2017-07-06 20:07:04 +05:30 committed by Kalle Valo
parent 1283c6174d
commit e0d0ae8a43
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/rsi/rsi_91x_debugfs.c
View File

@ -138,6 +138,8 @@ static int rsi_stats_read(struct seq_file *seq, void *data)
seq_puts(seq, "==> RSI STA DRIVER STATUS <==\n");
seq_puts(seq, "DRIVER_FSM_STATE: ");
BUILD_BUG_ON(ARRAY_SIZE(fsm_state) != NUM_FSM_STATES);
if (common->fsm_state <= FSM_MAC_INIT_DONE)
seq_printf(seq, "%s", fsm_state[common->fsm_state]);

4
drivers/net/wireless/rsi/rsi_main.h
View File

@ -40,7 +40,9 @@ enum RSI_FSM_STATES {
FSM_RESET_MAC_SENT,
FSM_RADIO_CAPS_SENT,
FSM_BB_RF_PROG_SENT,
FSM_MAC_INIT_DONE
FSM_MAC_INIT_DONE,
NUM_FSM_STATES
};
extern u32 rsi_zone_enabled;