iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: iio: cdc: ad7746: Use explicit be24 handling.

Browse Source 
Chance from fiddly local implementation of be24 to cpu endian conversion
by reading into a 3 byte buffer and using get_unaligned_be24()

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220626122938.582107-4-jic23@kernel.org
This commit is contained in:
Jonathan Cameron
2022-06-26 13:29:24 +01:00
parent 1efc41035f
commit ebf30bed14
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/staging/iio/cdc/ad7746.c
View File

@ -15,6 +15,8 @@
#include <linux/stat.h>
#include <linux/sysfs.h>
#include <asm/unaligned.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
@ -95,10 +97,7 @@ struct ad7746_chip_info {
u8 capdac[2][2];
s8 capdac_set;
union {
__be32 d32;
u8 d8[4];
} data ____cacheline_aligned;
u8 data[3] ____cacheline_aligned;
};
enum ad7746_chan {
@ -546,13 +545,14 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
/* Now read the actual register */
ret = i2c_smbus_read_i2c_block_data(chip->client,
chan->address >> 8, 3,
&chip->data.d8[1]);
chan->address >> 8,
sizeof(chip->data),
chip->data);
if (ret < 0)
goto out;
*val = (be32_to_cpu(chip->data.d32) & 0xFFFFFF) - 0x800000;
*val = get_unaligned_be24(chip->data) - 0x800000;
switch (chan->type) {
case IIO_TEMP: