71c3c5a8ef
staging: unisys: iochannel.h remove redundant comments
...
iochannel cleanup redudant comments in function declarations.
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com >
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-17 14:25:36 -08:00
79c07e9c1f
staging: unisys: iochannel fix block comments
...
This patch fixes warning messages from checkpatch.pl specifically:
WARNING: Block comments use a trailing */ on a separate lines
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com >
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-17 14:25:36 -08:00
34d96c0ded
staging: unisys: return error value directly
...
In case of error we are jumping to err_del_scsipending_ent and always
returning SCSI_MLQUEUE_DEVICE_BUSY from error path. We donot need a
variable to return a fixed error value, it can be returned directly.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-17 14:19:57 -08:00
559b7d2444
staging: unisys: remove unused variable
...
The variables op, sd and zmotion were never being used.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-17 14:19:57 -08:00
4811789503
staging: unisys: visorbus: visorbus_main.c: made checkpatch warning-free
...
Made visorbus_main.c checkpatch warning-free by fixing the comment style
issues.
Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
be1d6cb3e6
Staging: fwserial: Declare fwtty_port_put as static
...
Declare the function fwtty_port_put as static since it is used
only in this particular file. Also remove the corresponding
declaration from header file.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
3bf40d65dc
staging/rdma/hfi1: use one-shot LCB write
...
Use the one-shot LCB write implemented in the 8051 firmware.
This speeds up 8051 LCB writes by 2x. Use old method for older
firmwares.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com >
Signed-off-by: Dean Luick <dean.luick@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
a03a03e956
staging/rdma/hfi1: Remove spurious error messages
...
Changed the order in which diagnostics messages are printed,
taking into account the cases where the errors are handled in
rcv_hdrerr() and no further message is needed to report.
Reviewed-by: Mark Debbage <mark.debbage@intel.com >
Reviewed-by: Arthur Kepner <arthur.kepner@intel.com >
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com >
Signed-off-by: Ignacio Hernandez <ignacio.hernandez@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
801cfd6d8a
staging/rdma/hfi1: Fix for opaportconfig ledon by not checking for portNum
...
opaportconfig ledon fails with error message due to port
number being checked in the attr modifier. This change
removes the check for the port number in AttrMod, so the
P field is ignored.
Reviewed-by: Easwar Hariharan <easwar.hariharan@intel.com >
Signed-off-by: Sebastian Sanchez <sebastian.sanchez@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
7022497325
staging/rdma/hfi1: Select only devices with active links
...
When looking for or validating a user device, only use devices
that are currently active.
Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com >
Signed-off-by: Dean Luick <dean.luick@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
4ef98989cb
staging/rdma/hfi1: Disable thermal polling before sensor initialization
...
During driver load the thermal sensor needs to be reset prior
to initialization of the sensor. This prevents a possible sensor lock
up which can cause the wrong temperature value to be reported.
This fix leads to remove disabling thermal polling from
reset_asic_csrs() function.
Reviewed by: Dennis Dalessandro <dennis.dalessandro@intel.com >
Reviewed by: Easwar Hariharan <easwar.hariharan@intel.com >
Signed-off-by: Jareer Abdel-Qader <jareer.h.abdel-qader@intel.com >
Signed-off-by: Ira Weiny <ira.weiny@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
65fcf55764
staging/rdma/hfi1: Always download SBus firmware
...
B0 dual port parts require the SBus firmware to always be
downloaded.
Remove reset of the SBus Master spico. It is not necessary
since the SBus firmware download already does that.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com >
Signed-off-by: Dean Luick <dean.luick@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
bf70a77577
staging/rdma/hfi1: Enable WFR PCIe extended tags from the driver
...
Some BIOS implementations turn off extended tags in DevCtl (a RW
field) even though it was originally set and is advertised in DevCap
Fix is to set it in the driver
Reviewed-by: Dean Luick <dean.luick@intel.com >
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com >
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com >
Signed-off-by: Vennila Megavannan <vennila.megavannan@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
72a67ba2fa
staging/rdma/hfi1: Clear the QSFP reset that is asserted on FLR
...
The FLR on driver load asserts the QSFP reset pin and the driver does
not deassert it after. This patch allows the external QSFP cable to exit
reset by writing 1 to all the QSFP pins.
Reviewed-by: Dean Luick <dean.luick@intel.com >
Signed-off-by: Easwar Hariharan <easwar.hariharan@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
6c63e4238a
staging/rdma/hfi1: Convert dd_dev_info() to hfi1_cdbg() in process startup
...
Replacing dd_dev_info() for hfi1_cdbg() to avoid generating syslog
output for every context that is open by PSM.
Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com >
Signed-off-by: Sebastian Sanchez <sebastian.sanchez@intel.com >
Signed-off-by: Jubin John <jubin.john@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
e23afff948
staging: most: Delete an unnecessary check before the function call "module_put"
...
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
c904ffdaf3
staging: most: rename DIM_EnqueueBuffer to dim_enqueue_buffer
...
This patch renames DIM_EnqueueBuffer to dim_enqueue_buffer to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_EnqueueBuffer>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:877:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
60d5f66ce5
staging: most: rename DIM_GetChannelState to dim_get_channel_state
...
This patch renames DIM_GetChannelState to dim_get_channel_state to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_GetChannelState>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:865:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
e380925312
staging: most: fix argument name of DIM_GetChannelState
...
The second argument name of DIM_GetChannelState declaration changes from
dim_ch_state_ptr to state_ptr. The DIM_GetChannelState declaration and
definition has same argument name as state_ptr.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
0d08d54f8d
staging: most: rename DIM_ServiceChannel to dim_service_channel
...
This patch renames DIM_ServiceChannel to dim_service_channel to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_ServiceChannel>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:857:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
e5baa9e99c
staging: most: rename DIM_ServiceIrq to dim_service_irq
...
This patch renames DIM_ServiceIrq to dim_service_irq to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_ServiceIrq>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:819:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
a5e4d891a3
staging: most: rename DIM_DestroyChannel to dim_destroy_channel
...
This patch renames DIM_DestroyChannel to dim_destroy_channel to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_DestroyChannel>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:806:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
10e5efb7b5
staging: most: rename DIM_InitSync to dim_init_sync
...
This patch renames DIM_InitSync to dim_init_sync to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_InitSync>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:781:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
f1383176c9
staging: most: rename DIM_InitIsoc to dim_init_isoc
...
This patch renames DIM_InitIsoc to dim_init_isoc to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_InitIsoc>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:756:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
26303150c3
staging: most: rename DIM_InitAsync to dim_init_async
...
This patch renames DIM_InitAsync to dim_init_async to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_InitAsync>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:749:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
a3f3e92119
staging: most: rename DIM_InitControl to dim_init_control
...
This patch renames DIM_InitControl to dim_init_control to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_InitControl>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:742:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
aff1924508
staging: most: rename DIM_NormSyncBufferSize to dim_norm_sync_buffer_size
...
This patch renames DIM_NormSyncBufferSize to dim_norm_sync_buffer_size
to avoid camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_NormSyncBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:734:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
e302ca47b5
staging: most: rename DIM_NormIsocBufferSize to dim_norm_isoc_buffer_size
...
This patch renames DIM_NormIsocBufferSize to dim_norm_isoc_buffer_size
to avoid camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_NormIsocBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:720:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
c64c6073e8
staging: most: rename DIM_NormCtrlAsyncBufferSize to dim_norm_ctrl_async_buffer_size
...
This patch renames DIM_NormCtrlAsyncBufferSize to
dim_norm_ctrl_async_buffer_size to avoid camelcase found by checkpatch
CHECK: Avoid CamelCase: <DIM_NormCtrlAsyncBufferSize>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:709:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
58889788fc
staging: most: rename DIMCB_IoRead to dimcb_io_read
...
This patch renames DIMCB_IoRead to dimcb_io_read to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIMCB_IoRead>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:157:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
1efc456462
staging: most: rename DIMCB_IoWrite to dimcb_io_write
...
This patch renames DIMCB_IoWrite to dimcb_io_write to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIMCB_IoWrite>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:154:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
de6687313d
staging: most: rename DIMCB_OnError to dimcb_on_error
...
This patch renames DIMCB_OnError to dimcb_on_error to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIMCB_OnError>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:77:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
b724207b41
staging: most: rename DIM_GetLockState to dim_get_lock_state
...
This patch renames DIM_GetLockState to dim_get_lock_state to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_GetLockState>
FILE: drivers/staging/most/hdm-dim2/dim2_hdm.c:131:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
38c3854490
staging: most: rename DIM_DetachBuffers to dim_detach_buffers
...
This patch renames DIM_DetachBuffers to dim_detach_buffers to avoid
camelcase found by checkpatch.
CHECK: Avoid CamelCase: <DIM_DetachBuffers>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:886:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
50a45b170c
staging: most: rename DIM_Shutdown to dim_shutdown
...
This patch renames DIM_Shutdown to dim_shutdown to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_Shutdown>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:676:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
6417267f17
staging: most: rename DIM_Startup to dim_startup
...
This patch renames DIM_Startup to dim_startup to avoid camelcase
found by checkpatch.
CHECK: Avoid CamelCase: <DIM_Startup>
FILE: drivers/staging/most/hdm-dim2/dim2_hal.c:653:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
3c70754250
staging: most: add spaces preferred around that '<<'
...
This patch adds space around '<<' found by checkpatch.
CHECK: spaces preferred around that '<<' (ctx:VxV)
FILE: drivers/staging/most/hdm-dim2/dim2_reg.h:69:
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
23242684c1
staging: most: remove blank line after an open brace
...
This patch removes blank line after an open brace found by checkpatch.
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
fabb93f18f
staging: most: remove multiple blank lines
...
This patch removes multiple blank lines found by checkpatch.
CHECK: Please don't use multiple blank lines
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
25e168a4a3
staging: rtl8188eu: goto removed
...
malloc error handling moved into one place.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
4a3bda22fd
staging: rtl8188eu: goto replaced by 'else' branch
...
goto is not needed here.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
d14c07f6ff
staging: rtl8188eu: unused macros removed
...
IS_* and GET_CVID_* macros have not been used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
940f90eae6
staging: rtl8188eu: rarely used macros replaced by their definitions
...
IS_* macros (except one) occur only once.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
08ecab13e1
staging: rtl8188eu: for loop instead of while loop used
...
The range of elements to fill with zeros is determined by using a roundup macro
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
13cab3d422
staging: rtl8188eu: offset renamed to write_address
...
This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
7e91b28a01
staging: rtl8188eu: pu4BytePtr renamed to dword_buffer
...
This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
988c514688
staging: rtl8188eu: buf_ptr renamed to byte_buffer
...
This name is better suited for this variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
6e84aa6c82
staging: rtl8188eu: unnessesary braces for single statement block removed
...
checkpatch fix:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
429078e1f1
staging: rtl8188eu: unnecessary initialization removed
...
It is superfluous.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00
645d2a8f46
staging: rtl8188eu: types of local variables conformed with types of function arguments
...
The array should not change in any case.
Signed-off-by: Ivan Safonov <insafonov@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-11-15 20:02:47 -08:00