Brian Norris
c08f3a82f6
test: firmware_class: report errors properly on failure
...
commit 47e0bbb7fa985a0f1b5794a8653fae4f8f49de77 upstream.
request_firmware() failures currently won't get reported at all (the
error code is discarded). What's more, we get confusing messages, like:
# echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request
[ 8280.311856] test_firmware: loading 'notafile'
[ 8280.317042] test_firmware: load of 'notafile' failed: -2
[ 8280.322445] test_firmware: loaded: 0
# echo $?
0
Report the failures via write() errors, and don't say we "loaded"
anything.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-15 17:13:13 +01:00
..
2015-10-14 22:23:17 +08:00
2014-10-09 11:35:48 +03:00
2016-05-04 14:48:41 -07:00
2014-09-28 11:08:01 +02:00
2016-12-02 09:09:01 +01:00
2015-08-31 19:29:05 +02:00
2014-06-04 16:54:18 -07:00
2015-09-10 13:29:01 -07:00
2014-08-06 18:01:24 -07:00
2012-10-08 13:50:18 +10:30
2013-04-29 18:28:19 -07:00
2017-11-15 17:13:12 +01:00
2017-11-02 09:40:49 +01:00
2015-07-27 14:06:24 +02:00
2015-07-27 14:06:24 +02:00
2014-12-13 12:42:51 -08:00
2012-09-10 11:13:16 -07:00
2015-09-10 13:29:01 -07:00
2014-12-22 16:43:06 +00:00
2015-11-23 09:44:58 +01:00
2015-05-28 11:31:52 +09:30
2013-06-19 17:54:06 +02:00
2013-03-22 16:41:20 -07:00
2015-01-29 11:57:38 -08:00
2014-04-03 16:21:12 -07:00
2017-06-29 12:48:51 +02:00
2014-03-20 10:11:35 -04:00
2015-05-27 15:22:15 +02:00
2012-07-30 17:25:22 -07:00
2015-06-18 17:00:23 -10:00
2014-05-16 14:26:52 -04:00
2014-06-25 16:04:00 -07:00
2015-05-26 15:26:43 +02:00
2015-05-30 22:42:24 -07:00
2015-06-11 15:08:32 +02:00
2013-06-26 12:10:56 +02:00
2014-06-04 16:53:53 -07:00
2015-09-10 13:29:01 -07:00
2015-09-10 13:29:01 -07:00
2015-09-10 13:29:01 -07:00
2015-09-10 13:29:01 -07:00
2015-09-10 13:29:01 -07:00
2015-09-10 13:29:01 -07:00
2015-07-17 16:39:54 -07:00
2015-10-05 04:49:54 +01:00
2017-10-27 10:23:17 +02:00
2015-11-09 15:11:24 -08:00
2016-06-07 18:14:37 -07:00
2016-02-25 12:01:23 -08:00
2015-11-06 17:50:42 -08:00
2015-02-12 18:54:15 -08:00
2013-08-14 23:24:01 +02:00
2015-10-23 17:55:10 +09:00
2014-04-30 19:49:37 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2015-04-17 09:03:54 -04:00
2014-01-21 23:17:20 -08:00
2014-09-08 09:51:30 +09:00
2012-10-06 03:04:57 +09:00
2015-02-13 21:21:35 -08:00
2016-11-18 10:48:36 +01:00
2014-08-06 18:01:25 -07:00
2015-11-06 17:50:42 -08:00
2015-11-06 17:50:42 -08:00
2014-09-13 11:14:53 -07:00
2015-11-06 17:50:42 -08:00
2013-04-29 18:28:19 -07:00
2014-05-05 09:09:14 +02:00
2015-02-12 18:54:15 -08:00
2014-04-07 16:36:11 -07:00
2015-11-05 16:34:48 -08:00
2015-04-14 16:49:04 -07:00
2016-09-24 10:07:43 +02:00
2015-11-06 17:50:42 -08:00
2015-11-06 17:50:42 -08:00
2016-03-03 15:07:24 -08:00
2017-08-11 09:08:59 -07:00
2015-11-05 19:34:48 -08:00
2014-11-11 09:31:52 -06:00
2014-08-08 15:57:25 -07:00
2016-02-25 12:01:16 -08:00
2015-02-12 18:54:15 -08:00
2015-11-06 17:50:42 -08:00
2016-10-28 03:01:31 -04:00
2015-03-31 09:45:50 -06:00
2016-02-17 12:31:04 -08:00
2015-06-16 14:12:35 -04:00
2015-11-06 17:50:42 -08:00
2014-10-03 06:09:30 +02:00
2015-08-12 11:59:04 +02:00
2015-04-15 16:35:25 -07:00
2015-11-06 17:50:42 -08:00
2015-02-12 18:54:15 -08:00
2012-07-30 17:25:22 -07:00
2012-07-30 17:25:16 -07:00
2014-06-25 17:45:43 -07:00
2015-03-31 14:07:24 -04:00
2015-10-03 16:40:51 +01:00
2013-04-09 14:13:05 -04:00
2012-07-30 17:25:22 -07:00
2012-12-14 10:32:52 +11:00
2013-05-05 14:38:00 -07:00
2015-10-08 05:26:36 -07:00
2014-01-23 16:36:55 -08:00
2015-09-08 14:35:59 -07:00
2015-05-29 07:39:34 +10:00
2015-11-06 17:50:42 -08:00
2013-11-13 12:09:11 +09:00
2014-09-24 13:31:50 -04:00
2015-02-12 18:54:16 -08:00
2012-07-30 17:25:22 -07:00
2015-11-23 09:44:58 +01:00
2016-02-25 12:01:23 -08:00
2015-10-08 05:26:38 -07:00
2014-01-23 16:37:03 -08:00
2015-05-28 11:32:04 +09:30
2014-01-21 23:17:20 -08:00
2015-12-18 23:44:18 -05:00
2015-08-17 08:12:51 -06:00
2015-03-04 23:40:19 -05:00
2015-08-24 14:28:01 -06:00
2015-03-23 22:12:08 -04:00
2015-09-08 15:35:28 -07:00
2014-04-07 16:36:14 -07:00
2015-06-25 17:00:40 -07:00
2015-02-12 18:54:16 -08:00
2016-02-25 12:01:21 -08:00
2016-10-28 03:01:30 -04:00
2015-08-31 12:36:10 -07:00
2015-06-22 15:52:04 -07:00
2017-07-05 14:37:20 +02:00
2014-04-03 16:21:06 -07:00
2017-05-14 13:32:58 +02:00
2017-11-15 17:13:13 +01:00
2015-11-05 19:34:48 -08:00
2014-01-23 16:36:57 -08:00
2015-11-06 17:50:42 -08:00
2015-08-17 14:33:47 -07:00
2015-08-03 11:51:12 +02:00
2015-08-05 09:53:40 +02:00
2017-06-14 13:16:27 +02:00
2015-06-25 17:00:40 -07:00
2015-09-10 13:29:01 -07:00
2016-05-11 11:21:26 +02:00
2014-10-14 02:18:14 +02:00
2015-04-22 17:06:49 +02:00
2016-03-03 15:07:09 -08:00
2013-04-30 17:04:09 -07:00
2013-04-29 18:28:42 -07:00
2015-11-06 17:50:42 -08:00