Mirsad Goran Todorovac
0659aee089
test_firmware: fix the memory leak of the allocated firmware buffer
...
commit 48e156023059e57a8fc68b498439832f7600ffff upstream.
The following kernel memory leak was noticed after running
tools/testing/selftests/firmware/fw_run_tests.sh:
[root@pc-mtodorov firmware]# cat /sys/kernel/debug/kmemleak
.
.
.
unreferenced object 0xffff955389bc3400 (size 1024):
comm "test_firmware-0", pid 5451, jiffies 4294944822 (age 65.652s)
hex dump (first 32 bytes):
47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567..........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0
[<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240
[<ffffffff962704de>] kmalloc_trace+0x2e/0xc0
[<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180
[<ffffffff95fd813b>] kthread+0x10b/0x140
[<ffffffff95e033e9>] ret_from_fork+0x29/0x50
unreferenced object 0xffff9553c334b400 (size 1024):
comm "test_firmware-1", pid 5452, jiffies 4294944822 (age 65.652s)
hex dump (first 32 bytes):
47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567..........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0
[<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240
[<ffffffff962704de>] kmalloc_trace+0x2e/0xc0
[<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180
[<ffffffff95fd813b>] kthread+0x10b/0x140
[<ffffffff95e033e9>] ret_from_fork+0x29/0x50
unreferenced object 0xffff9553c334f000 (size 1024):
comm "test_firmware-2", pid 5453, jiffies 4294944822 (age 65.652s)
hex dump (first 32 bytes):
47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567..........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0
[<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240
[<ffffffff962704de>] kmalloc_trace+0x2e/0xc0
[<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180
[<ffffffff95fd813b>] kthread+0x10b/0x140
[<ffffffff95e033e9>] ret_from_fork+0x29/0x50
unreferenced object 0xffff9553c3348400 (size 1024):
comm "test_firmware-3", pid 5454, jiffies 4294944822 (age 65.652s)
hex dump (first 32 bytes):
47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567..........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0
[<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240
[<ffffffff962704de>] kmalloc_trace+0x2e/0xc0
[<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180
[<ffffffff95fd813b>] kthread+0x10b/0x140
[<ffffffff95e033e9>] ret_from_fork+0x29/0x50
[root@pc-mtodorov firmware]#
Note that the size 1024 corresponds to the size of the test firmware
buffer. The actual number of the buffers leaked is around 70-110,
depending on the test run.
The cause of the leak is the following:
request_partial_firmware_into_buf() and request_firmware_into_buf()
provided firmware buffer isn't released on release_firmware(), we
have allocated it and we are responsible for deallocating it manually.
This is introduced in a number of context where previously only
release_firmware() was called, which was insufficient.
Reported-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Fixes: 7feebfa487b92 ("test_firmware: add support for request_firmware_into_buf")
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <error27@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Russ Weight <russell.h.weight@intel.com>
Cc: Tianfei zhang <tianfei.zhang@intel.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: linux-kernel@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Luis R. Rodriguez <mcgrof@kernel.org>
Cc: linux-kselftest@vger.kernel.org
Cc: stable@vger.kernel.org # v5.4
Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Link: https://lore.kernel.org/r/20230509084746.48259-3-mirsad.todorovac@alu.unizg.hr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-06-09 10:34:27 +02:00
..
2020-08-10 01:32:59 +09:00
2022-08-26 18:40:14 +08:00
2023-05-24 17:32:31 +01:00
2022-12-31 13:31:56 +01:00
2023-05-11 23:03:05 +09:00
2022-06-15 10:29:10 +02:00
2022-07-17 17:31:39 -07:00
2022-07-29 18:12:34 -07:00
2021-09-08 11:50:26 -07:00
2023-03-10 09:32:52 +01:00
2021-07-08 11:48:20 -07:00
2022-03-08 15:20:21 -08:00
2022-10-11 17:42:58 -06:00
2022-02-13 16:50:06 -08:00
2022-11-23 19:50:15 +01:00
2021-10-19 23:44:30 +08:00
2020-08-10 01:32:59 +09:00
2020-12-29 15:36:49 -08:00
2021-09-24 16:13:35 -07:00
2023-04-06 12:10:38 +02:00
2022-04-26 17:58:51 -04:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-11-18 14:15:17 -06:00
2022-01-20 08:52:55 +02:00
2022-06-01 18:29:06 -07:00
2019-05-30 11:26:32 -07:00
2021-12-13 10:56:09 +01:00
2021-10-01 16:52:48 -04:00
2022-08-02 17:14:47 -06:00
2021-05-06 19:24:12 -07:00
2020-10-16 13:25:14 -06:00
2022-09-26 12:19:12 -07:00
2019-05-21 10:50:45 +02:00
2022-04-26 17:58:51 -04:00
2022-04-26 17:58:51 -04:00
2020-06-11 15:14:53 +02:00
2022-06-16 19:58:21 -07:00
2023-03-10 09:33:47 +01:00
2019-05-24 17:27:11 +02:00
2021-07-08 11:48:22 -07:00
2022-09-01 16:55:35 +02:00
2020-08-20 15:45:14 -04:00
2019-06-19 17:09:55 +02:00
2022-10-11 17:42:58 -06:00
2022-09-11 21:55:06 -07:00
2019-05-24 17:39:02 +02:00
2021-10-01 16:52:48 -04:00
2023-05-24 17:32:37 +01:00
2022-10-06 05:57:36 -07:00
2022-10-01 10:22:57 -07:00
2019-06-19 17:09:06 +02:00
2021-01-21 14:06:00 -07:00
2021-05-06 19:24:12 -07:00
2019-06-19 17:09:06 +02:00
2022-01-31 11:21:43 +11:00
2022-01-31 11:21:43 +11:00
2022-03-07 12:48:35 -07:00
2022-03-07 12:48:35 -07:00
2019-06-19 17:09:06 +02:00
2022-06-07 10:27:38 +02:00
2020-06-18 17:26:43 +10:00
2021-08-19 09:02:55 +09:00
2021-06-22 13:56:43 +02:00
2023-05-30 14:03:20 +01:00
2021-07-01 11:06:05 -07:00
2020-01-31 10:30:40 -08:00
2021-07-01 11:06:06 -07:00
2021-05-06 19:24:12 -07:00
2021-07-01 11:06:06 -07:00
2021-10-19 23:44:30 +08:00
2021-11-08 16:55:26 -08:00
2020-07-31 11:49:08 +02:00
2021-08-13 14:09:32 -10:00
2022-09-01 18:04:43 +02:00
2020-11-20 14:45:33 +11:00
2022-04-22 21:30:57 +02:00
2022-09-07 17:04:49 +02:00
2020-10-16 11:11:20 -07:00
2022-09-11 21:55:10 -07:00
2023-03-10 09:33:27 +01:00
2022-07-17 17:31:38 -07:00
2020-12-15 22:46:15 -08:00
2021-01-03 20:05:18 -05:00
2020-10-16 11:11:22 -07:00
2022-11-22 18:50:44 -08:00
2020-01-08 16:59:19 +00:00
2022-10-11 17:42:55 -06:00
2022-10-06 05:57:36 -07:00
2022-09-19 14:35:08 +02:00
2022-09-14 07:04:15 -07:00
2022-03-07 12:48:35 -07:00
2022-01-15 08:47:31 -08:00
2019-10-14 15:04:00 -07:00
2022-04-29 14:38:01 -07:00
2022-04-27 10:57:33 -07:00
2019-05-13 11:07:33 +02:00
2022-07-10 13:55:49 -07:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2022-10-03 14:03:21 -07:00
2022-10-03 14:03:18 -07:00
2022-04-13 21:32:21 +02:00
2019-05-30 11:26:32 -07:00
2022-09-07 16:37:27 -07:00
2019-05-24 17:27:11 +02:00
2021-08-19 09:02:55 +09:00
2022-10-10 13:04:25 -07:00
2023-01-07 11:11:55 +01:00
2022-10-03 14:02:57 -07:00
2022-04-22 12:32:04 +02:00
2022-03-22 15:57:11 -07:00
2022-10-11 12:01:24 +02:00
2022-11-08 15:57:24 -08:00
2022-07-14 15:45:26 -07:00
2021-07-08 11:48:20 -07:00
2019-06-19 17:09:08 +02:00
2021-12-28 11:26:18 +01:00
2023-03-10 09:33:30 +01:00
2022-05-13 07:20:13 -07:00
2021-05-19 15:05:11 +02:00
2020-10-16 11:11:19 -07:00
2021-08-13 18:37:38 +02:00
2022-06-16 19:58:20 -07:00
2021-07-08 11:48:20 -07:00
2022-04-05 13:32:27 -06:00
2022-09-11 21:55:06 -07:00
2021-12-04 10:56:24 +01:00
2023-02-01 08:34:34 +01:00
2022-03-11 10:42:56 +01:00
2021-02-17 17:31:06 -06:00
2022-07-17 17:31:37 -07:00
2019-05-24 17:39:02 +02:00
2022-11-08 15:57:22 -08:00
2023-05-24 17:32:51 +01:00
2022-09-07 16:37:48 -07:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2019-05-24 17:39:02 +02:00
2019-05-21 10:50:45 +02:00
2023-02-01 08:34:43 +01:00
2022-04-22 21:30:57 +02:00
2022-12-31 13:31:58 +01:00
2021-12-24 14:54:29 -08:00
2019-05-21 10:50:45 +02:00
2021-07-08 11:48:20 -07:00
2022-10-03 17:34:32 -07:00
2022-10-25 14:57:42 -07:00
2021-09-17 13:52:17 +01:00
2021-04-16 16:10:37 -07:00
2021-07-01 11:06:05 -07:00
2021-09-19 17:13:35 -07:00
2021-05-06 19:24:12 -07:00
2019-05-21 10:50:45 +02:00
2022-05-18 02:20:17 -04:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2022-05-22 11:32:30 -07:00
2022-07-17 17:31:38 -07:00
2022-10-11 17:42:58 -06:00
2022-08-24 13:46:57 +01:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2022-02-06 11:05:28 +00:00
2021-07-08 11:48:20 -07:00
2021-07-08 11:48:20 -07:00
2023-03-10 09:34:34 +01:00
2022-07-17 17:31:39 -07:00
2021-07-08 11:48:20 -07:00
2022-09-23 16:46:19 +02:00
2019-08-08 07:45:01 -06:00
2022-09-26 19:46:29 -07:00
2022-06-03 10:34:34 -07:00
2022-04-06 10:11:48 +02:00
2022-07-17 17:31:41 -07:00
2022-03-17 20:17:18 -07:00
2022-10-03 14:03:18 -07:00
2022-09-30 13:21:22 -06:00
2019-05-30 11:26:32 -07:00
2022-09-05 14:51:46 +01:00
2022-10-03 14:03:22 -07:00
2022-04-19 21:58:47 +02:00
2022-04-19 21:58:47 +02:00
2021-06-18 11:43:09 +02:00
2022-10-01 10:22:58 -07:00
2021-07-08 11:48:20 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2022-06-22 19:20:20 -07:00
2019-05-21 10:50:45 +02:00
2022-09-07 17:04:49 +02:00
2023-06-09 10:34:27 +02:00
2022-10-11 17:42:58 -06:00
2021-01-18 11:03:26 +01:00
2022-07-17 17:14:36 -07:00
2022-01-20 08:52:54 +02:00
2022-10-11 17:42:55 -06:00
2022-10-12 18:51:50 -07:00
2022-10-12 18:51:50 -07:00
2022-03-29 15:13:36 -07:00
2022-10-11 17:42:58 -06:00
2020-05-08 18:18:12 +01:00
2022-10-11 17:42:55 -06:00
2022-02-25 09:36:06 +01:00
2023-03-30 12:49:26 +02:00
2022-10-12 18:51:49 -07:00
2022-10-11 17:42:58 -06:00
2019-05-21 10:50:45 +02:00
2022-10-11 17:42:58 -06:00
2022-07-28 10:38:30 +02:00
2021-12-06 16:04:44 -08:00
2022-10-26 13:39:09 +01:00
2021-09-06 11:04:03 -07:00
2022-05-19 18:54:22 +02:00
2021-09-08 11:50:26 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2022-04-29 14:38:00 -07:00
2019-04-08 16:44:21 -06:00
2022-05-03 10:15:07 +02:00
2022-01-20 08:52:55 +02:00
2019-10-16 14:56:21 +02:00
2022-10-11 17:42:58 -06:00
2022-03-28 19:25:11 -04:00
2022-10-11 17:42:55 -06:00
2019-10-03 12:12:23 -04:00
2021-02-17 14:08:01 +01:00
2022-06-15 17:41:12 +02:00
2022-07-17 17:31:39 -07:00
2020-11-18 14:15:17 -06:00
2020-04-07 10:43:43 -07:00
2023-01-24 07:24:41 +01:00
2021-02-05 11:03:47 -08:00
2019-05-24 17:39:02 +02:00
2023-02-25 11:25:41 +01:00
2022-10-11 17:42:58 -06:00
2022-10-10 11:24:19 -07:00
2022-06-09 16:24:25 -04:00
2020-08-12 10:58:00 -07:00