Sungwoo Kim
f3fe681715
Bluetooth: L2CAP: Fix u8 overflow
...
[ Upstream commit bcd70260ef56e0aee8a4fc6cd214a419900b0765 ]
By keep sending L2CAP_CONF_REQ packets, chan->num_conf_rsp increases
multiple times and eventually it will wrap around the maximum number
(i.e., 255).
This patch prevents this by adding a boundary check with
L2CAP_MAX_CONF_RSP
Btmon log:
Bluetooth monitor ver 5.64
= Note: Linux version 6.1.0-rc2 (x86_64) 0.264594
= Note: Bluetooth subsystem version 2.22 0.264636
@ MGMT Open: btmon (privileged) version 1.22 {0x0001} 0.272191
= New Index: 00:00:00:00:00:00 (Primary,Virtual,hci0) [hci0] 13.877604
@ RAW Open: 9496 (privileged) version 2.22 {0x0002} 13.890741
= Open Index: 00:00:00:00:00:00 [hci0] 13.900426
(...)
> ACL Data RX: Handle 200 flags 0x00 dlen 1033 #32 [hci0] 14.273106
invalid packet size (12 != 1033)
08 00 01 00 02 01 04 00 01 10 ff ff ............
> ACL Data RX: Handle 200 flags 0x00 dlen 1547 #33 [hci0] 14.273561
invalid packet size (14 != 1547)
0a 00 01 00 04 01 06 00 40 00 00 00 00 00 ........@.....
> ACL Data RX: Handle 200 flags 0x00 dlen 2061 #34 [hci0] 14.274390
invalid packet size (16 != 2061)
0c 00 01 00 04 01 08 00 40 00 00 00 00 00 00 04 ........@.......
> ACL Data RX: Handle 200 flags 0x00 dlen 2061 #35 [hci0] 14.274932
invalid packet size (16 != 2061)
0c 00 01 00 04 01 08 00 40 00 00 00 07 00 03 00 ........@.......
= bluetoothd: Bluetooth daemon 5.43 14.401828
> ACL Data RX: Handle 200 flags 0x00 dlen 1033 #36 [hci0] 14.275753
invalid packet size (12 != 1033)
08 00 01 00 04 01 04 00 40 00 00 00 ........@...
Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-12-21 17:32:08 +01:00
..
2021-09-15 09:50:34 +02:00
2022-12-14 11:31:54 +01:00
2021-07-31 08:16:11 +02:00
2022-07-29 17:19:07 +02:00
2021-04-07 15:00:08 +02:00
2022-10-30 09:41:16 +01:00
2022-06-22 14:13:17 +02:00
2022-05-18 10:23:42 +02:00
2022-12-21 17:32:08 +01:00
2022-11-25 17:45:43 +01:00
2021-07-14 16:56:29 +02:00
2022-12-02 17:39:57 +01:00
2022-11-25 17:45:46 +01:00
2022-12-14 11:31:59 +01:00
2022-05-25 09:17:56 +02:00
2022-12-02 17:40:00 +01:00
2022-03-08 19:09:37 +01:00
2022-12-02 17:40:01 +01:00
2022-08-31 17:15:19 +02:00
2022-12-14 11:32:01 +01:00
2021-12-17 10:14:41 +01:00
2022-12-08 11:23:56 +01:00
2022-11-03 23:57:51 +09:00
2022-12-14 11:32:04 +01:00
2022-12-14 11:32:04 +01:00
2021-03-07 12:34:05 +01:00
2022-11-25 17:45:56 +01:00
2022-12-02 17:39:58 +01:00
2022-11-25 17:45:54 +01:00
2022-04-27 13:53:50 +02:00
2021-02-10 09:29:14 +01:00
2022-03-28 09:57:10 +02:00
2022-12-08 11:23:56 +01:00
2022-12-14 11:32:01 +01:00
2022-09-08 11:11:40 +02:00
2022-08-31 17:15:19 +02:00
2022-01-05 12:40:32 +01:00
2022-12-14 11:32:00 +01:00
2022-04-13 21:01:00 +02:00
2022-08-25 11:38:07 +02:00
2022-01-27 10:54:03 +01:00
2022-12-14 11:32:02 +01:00
2022-12-02 17:40:00 +01:00
2022-12-08 11:23:57 +01:00
2022-01-11 15:25:01 +01:00
2021-03-07 12:34:07 +01:00
2022-08-25 11:38:23 +02:00
2022-10-26 13:25:23 +02:00
2020-11-12 09:18:06 +01:00
2022-11-10 18:14:19 +01:00
2022-12-02 17:39:59 +01:00
2022-12-02 17:40:01 +01:00
2022-12-08 11:23:57 +01:00
2022-09-28 11:10:36 +02:00
2021-11-18 14:04:27 +01:00
2022-08-31 17:15:15 +02:00
2021-02-07 15:37:12 +01:00
2022-12-14 11:32:04 +01:00
2022-08-03 12:00:46 +02:00
2022-12-14 11:32:01 +01:00
2022-10-26 13:25:22 +02:00
2022-12-08 11:23:56 +01:00
2022-11-25 17:45:47 +01:00
2022-10-15 07:55:51 +02:00
2022-12-02 17:39:58 +01:00
2021-06-18 10:00:06 +02:00
2022-08-31 17:15:21 +02:00