Herve Codina
7d407ef183
lib/vsprintf: Fix %pfwf when current node refcount == 0
...
commit 5c47251e8c4903111608ddcba2a77c0c425c247c upstream.
A refcount issue can appeared in __fwnode_link_del() due to the
pr_debug() call:
WARNING: CPU: 0 PID: 901 at lib/refcount.c:25 refcount_warn_saturate+0xe5/0x110
Call Trace:
<TASK>
...
of_node_get+0x1e/0x30
of_fwnode_get+0x28/0x40
fwnode_full_name_string+0x34/0x90
fwnode_string+0xdb/0x140
...
vsnprintf+0x17b/0x630
...
__fwnode_link_del+0x25/0xa0
fwnode_links_purge+0x39/0xb0
of_node_release+0xd9/0x180
...
Indeed, an fwnode (of_node) is being destroyed and so, of_node_release()
is called because the of_node refcount reached 0.
From of_node_release() several function calls are done and lead to
a pr_debug() calls with %pfwf to print the fwnode full name.
The issue is not present if we change %pfwf to %pfwP.
To print the full name, %pfwf iterates over the current node and its
parents and obtain/drop a reference to all nodes involved.
In order to allow to print the full name (%pfwf) of a node while it is
being destroyed, do not obtain/drop a reference to this current node.
Fixes: a92eb7621b9f ("lib/vsprintf: Make use of fwnode API to obtain node names and separators")
Cc: stable@vger.kernel.org
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20231114152655.409331-1-herve.codina@bootlin.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-01-05 15:12:28 +01:00
..
2020-08-10 01:32:59 +09:00
2022-09-05 10:28:55 +02:00
2023-05-30 12:57:45 +01:00
2023-01-14 10:15:17 +01:00
2022-04-08 14:40:04 +02:00
2022-08-21 15:16:05 +02:00
2022-04-13 21:01:08 +02:00
2020-08-10 01:32:59 +09:00
2021-07-14 16:56:51 +02:00
2023-09-23 11:01:06 +02:00
2020-07-28 17:07:06 -07:00
2022-04-08 14:40:31 +02:00
2020-08-10 01:32:59 +09:00
2022-12-02 17:40:02 +01:00
2021-11-18 14:03:58 +01:00
2020-08-10 01:32:59 +09:00
2021-01-06 14:56:51 +01:00
2020-08-10 01:32:59 +09:00
2020-08-24 14:17:44 -07:00
2020-03-25 11:50:48 +01:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-08-24 14:17:44 -07:00
2022-06-06 08:42:41 +02:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-05-24 20:48:11 +02:00
2020-10-16 13:25:14 -06:00
2022-08-21 15:15:45 +02:00
2019-05-21 10:50:45 +02:00
2020-09-21 21:50:09 -04:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-05-14 09:50:32 +02:00
2019-05-24 17:27:11 +02:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2020-08-20 15:45:14 -04:00
2023-08-30 16:23:16 +02:00
2017-11-02 11:10:55 +01:00
2020-08-24 14:17:44 -07:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2023-06-14 11:09:45 +02:00
2021-02-17 11:02:24 +01:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-10-16 11:11:20 -07:00
2018-07-27 19:04:33 +08:00
2020-11-02 12:14:19 -08:00
2020-08-12 10:58:00 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-06-18 17:26:43 +10:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-06-30 08:47:18 -04:00
2023-07-27 08:44:36 +02:00
2018-06-12 23:33:24 +02:00
2020-10-16 11:11:19 -07:00
2020-01-31 10:30:40 -08:00
2021-07-20 16:05:46 +02:00
2020-08-12 10:58:00 -07:00
2019-05-24 17:37:53 +02:00
2021-11-18 14:03:58 +01:00
2020-09-03 10:13:09 +02:00
2020-07-31 11:49:08 +02:00
2020-09-10 18:30:01 +02:00
2019-07-10 18:43:43 -07:00
2020-06-09 09:39:13 -07:00
2022-10-26 13:25:34 +02:00
2020-10-16 11:11:20 -07:00
2020-10-16 11:11:20 -07:00
2023-12-08 08:46:12 +01:00
2019-04-09 14:19:06 +02:00
2018-04-27 08:51:26 -04:00
2019-09-25 17:51:39 -07:00
2020-10-16 11:11:22 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2019-06-05 17:36:38 +02:00
2020-10-16 11:11:19 -07:00
2020-06-04 19:06:25 -07:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-01-12 20:18:16 +01:00
2019-10-14 15:04:00 -07:00
2020-08-24 14:17:44 -07:00
2022-05-09 09:04:59 +02:00
2019-05-13 11:07:33 +02:00
2023-09-19 12:20:27 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2020-08-14 19:56:57 -07:00
2018-05-09 06:55:44 +02:00
2023-01-14 10:16:42 +01:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2022-06-22 14:13:18 +02:00
2023-10-25 11:54:18 +02:00
2020-10-13 18:38:32 -07:00
2020-08-24 15:09:58 -07:00
2020-09-28 12:14:08 +01:00
2020-10-16 11:11:22 -07:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2021-05-19 10:13:18 +02:00
2023-11-08 17:30:46 +01:00
2023-06-21 15:45:35 +02:00
2021-07-14 16:55:57 +02:00
2020-10-16 11:11:19 -07:00
2020-05-11 11:55:28 +01:00
2022-08-25 11:38:18 +02:00
2021-09-30 10:11:04 +02:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-07-14 16:56:10 +02:00
2023-02-01 08:23:18 +01:00
2021-03-17 17:06:25 +01:00
2019-05-24 17:37:53 +02:00
2019-05-24 17:39:02 +02:00
2022-06-22 14:13:18 +02:00
2018-10-16 13:45:44 +02:00
2022-06-22 14:13:18 +02:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2023-02-01 08:23:23 +01:00
2020-08-24 14:24:25 -07:00
2022-06-14 18:32:45 +02:00
2023-01-14 10:15:19 +01:00
2017-11-02 11:10:55 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2019-05-24 17:27:11 +02:00
2022-10-26 13:25:23 +02:00
2020-06-28 20:45:27 -07:00
2023-06-21 15:45:35 +02:00
2018-01-26 11:45:16 -06:00
2020-10-16 11:11:20 -07:00
2019-05-21 10:50:45 +02:00
2022-06-06 08:42:40 +02:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2023-08-30 16:23:16 +02:00
2022-05-30 09:33:38 +02:00
2022-08-31 17:15:20 +02:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2019-11-25 09:15:32 +01:00
2020-07-28 17:09:49 -07:00
2020-07-01 10:53:00 -06:00
2020-10-29 08:55:45 -06:00
2021-07-19 09:45:00 +02:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2022-05-30 09:33:26 +02:00
2019-09-24 15:54:09 -07:00
2022-05-30 09:33:43 +02:00
2022-08-21 15:16:08 +02:00
2019-11-14 13:15:11 -05:00
2021-05-22 11:40:55 +02:00
2019-05-30 11:26:32 -07:00
2020-09-30 10:50:30 +02:00
2020-09-26 10:33:57 -07:00
2020-11-19 11:56:16 -08:00
2020-05-01 12:35:21 +10:00
2020-12-03 09:52:44 -08:00
2020-09-08 22:21:33 -04:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2022-08-21 15:15:41 +02:00
2019-05-21 10:50:45 +02:00
2023-07-27 08:44:06 +02:00
2020-06-29 10:02:23 +02:00
2020-10-13 18:38:33 -07:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2020-07-10 16:24:28 -03:00
2022-01-27 10:54:36 +01:00
2018-10-15 16:31:29 -04:00
2020-10-13 18:38:32 -07:00
2021-05-19 10:13:11 +02:00
2023-06-21 15:45:35 +02:00
2020-05-08 18:18:12 +01:00
2021-09-30 10:11:04 +02:00
2022-04-08 14:40:35 +02:00
2018-10-16 13:45:44 +02:00
2023-10-25 11:54:13 +02:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2023-11-20 11:06:44 +01:00
2020-06-07 10:53:36 -07:00
2020-09-20 14:10:06 -07:00
2019-05-21 10:50:45 +02:00
2021-09-18 13:40:37 +02:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2020-10-16 11:11:20 -07:00
2022-04-13 21:01:10 +02:00
2019-10-16 14:56:21 +02:00
2020-06-29 11:59:26 -07:00
2022-04-08 14:40:40 +02:00
2020-07-15 12:45:06 +03:00
2019-10-03 12:12:23 -04:00
2019-07-24 17:38:01 +02:00
2023-07-27 08:43:43 +02:00
2020-08-24 14:17:44 -07:00
2020-04-07 10:43:43 -07:00
2023-02-01 08:23:20 +01:00
2021-02-17 11:02:24 +01:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2023-02-25 11:55:03 +01:00
2020-03-23 17:01:47 +01:00
2024-01-05 15:12:28 +01:00
2017-11-02 11:10:55 +01:00
2022-04-08 14:40:40 +02:00
2020-08-12 10:58:00 -07:00