Mirsad Goran Todorovac
539c387f0b
test_firmware: fix a memory leak with reqs buffer
...
[ Upstream commit be37bed754ed90b2655382f93f9724b3c1aae847 ]
Dan Carpenter spotted that test_fw_config->reqs will be leaked if
trigger_batched_requests_store() is called two or more times.
The same appears with trigger_batched_requests_async_store().
This bug wasn't trigger by the tests, but observed by Dan's visual
inspection of the code.
The recommended workaround was to return -EBUSY if test_fw_config->reqs
is already allocated.
Fixes: 7feebfa487b92 ("test_firmware: add support for request_firmware_into_buf")
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Russ Weight <russell.h.weight@intel.com>
Cc: Tianfei Zhang <tianfei.zhang@intel.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kselftest@vger.kernel.org
Cc: stable@vger.kernel.org # v5.4
Suggested-by: Dan Carpenter <error27@gmail.com>
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20230509084746.48259-2-mirsad.todorovac@alu.unizg.hr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-06-21 15:45:35 +02:00
..
2020-08-10 01:32:59 +09:00
2022-09-05 10:28:55 +02:00
2023-05-30 12:57:45 +01:00
2023-01-14 10:15:17 +01:00
2022-04-08 14:40:04 +02:00
2022-08-21 15:16:05 +02:00
2022-04-13 21:01:08 +02:00
2020-08-10 01:32:59 +09:00
2021-07-14 16:56:51 +02:00
2023-03-11 16:39:20 +01:00
2020-07-28 17:07:06 -07:00
2022-04-08 14:40:31 +02:00
2020-08-10 01:32:59 +09:00
2022-12-02 17:40:02 +01:00
2021-11-18 14:03:58 +01:00
2020-08-10 01:32:59 +09:00
2021-01-06 14:56:51 +01:00
2020-08-10 01:32:59 +09:00
2020-08-24 14:17:44 -07:00
2020-03-25 11:50:48 +01:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-08-24 14:17:44 -07:00
2022-06-06 08:42:41 +02:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-05-24 20:48:11 +02:00
2020-10-16 13:25:14 -06:00
2022-08-21 15:15:45 +02:00
2019-05-21 10:50:45 +02:00
2020-09-21 21:50:09 -04:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-05-14 09:50:32 +02:00
2019-05-24 17:27:11 +02:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2020-08-20 15:45:14 -04:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2020-08-24 14:17:44 -07:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2023-06-14 11:09:45 +02:00
2021-02-17 11:02:24 +01:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2017-09-26 15:01:20 -06:00
2019-06-19 17:09:06 +02:00
2020-10-16 11:11:20 -07:00
2018-07-27 19:04:33 +08:00
2020-11-02 12:14:19 -08:00
2020-08-12 10:58:00 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-06-18 17:26:43 +10:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-06-30 08:47:18 -04:00
2023-05-30 12:57:57 +01:00
2018-06-12 23:33:24 +02:00
2020-10-16 11:11:19 -07:00
2020-01-31 10:30:40 -08:00
2021-07-20 16:05:46 +02:00
2020-08-12 10:58:00 -07:00
2019-05-24 17:37:53 +02:00
2021-11-18 14:03:58 +01:00
2020-09-03 10:13:09 +02:00
2020-07-31 11:49:08 +02:00
2020-09-10 18:30:01 +02:00
2019-07-10 18:43:43 -07:00
2020-06-09 09:39:13 -07:00
2022-10-26 13:25:34 +02:00
2020-10-16 11:11:20 -07:00
2020-10-16 11:11:20 -07:00
2023-03-11 16:39:40 +01:00
2019-04-09 14:19:06 +02:00
2018-04-27 08:51:26 -04:00
2019-09-25 17:51:39 -07:00
2020-10-16 11:11:22 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2019-06-05 17:36:38 +02:00
2020-10-16 11:11:19 -07:00
2020-06-04 19:06:25 -07:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-01-12 20:18:16 +01:00
2019-10-14 15:04:00 -07:00
2020-08-24 14:17:44 -07:00
2022-05-09 09:04:59 +02:00
2019-05-13 11:07:33 +02:00
2022-07-12 16:32:23 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2020-08-14 19:56:57 -07:00
2018-05-09 06:55:44 +02:00
2023-01-14 10:16:42 +01:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2022-06-22 14:13:18 +02:00
2023-01-14 10:16:10 +01:00
2020-10-13 18:38:32 -07:00
2020-08-24 15:09:58 -07:00
2020-09-28 12:14:08 +01:00
2020-10-16 11:11:22 -07:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2021-05-19 10:13:18 +02:00
2020-09-07 11:24:17 +02:00
2023-06-21 15:45:35 +02:00
2021-07-14 16:55:57 +02:00
2020-10-16 11:11:19 -07:00
2020-05-11 11:55:28 +01:00
2022-08-25 11:38:18 +02:00
2021-09-30 10:11:04 +02:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-07-14 16:56:10 +02:00
2023-02-01 08:23:18 +01:00
2021-03-17 17:06:25 +01:00
2019-05-24 17:37:53 +02:00
2019-05-24 17:39:02 +02:00
2022-06-22 14:13:18 +02:00
2018-10-16 13:45:44 +02:00
2022-06-22 14:13:18 +02:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2023-02-01 08:23:23 +01:00
2020-08-24 14:24:25 -07:00
2022-06-14 18:32:45 +02:00
2023-01-14 10:15:19 +01:00
2017-11-02 11:10:55 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2019-05-24 17:27:11 +02:00
2022-10-26 13:25:23 +02:00
2020-06-28 20:45:27 -07:00
2023-06-21 15:45:35 +02:00
2018-01-26 11:45:16 -06:00
2020-10-16 11:11:20 -07:00
2019-05-21 10:50:45 +02:00
2022-06-06 08:42:40 +02:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2020-10-20 14:39:37 -07:00
2022-05-30 09:33:38 +02:00
2022-08-31 17:15:20 +02:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2019-11-25 09:15:32 +01:00
2020-07-28 17:09:49 -07:00
2020-07-01 10:53:00 -06:00
2020-10-29 08:55:45 -06:00
2021-07-19 09:45:00 +02:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2022-05-30 09:33:26 +02:00
2019-09-24 15:54:09 -07:00
2022-05-30 09:33:43 +02:00
2022-08-21 15:16:08 +02:00
2019-11-14 13:15:11 -05:00
2021-05-22 11:40:55 +02:00
2019-05-30 11:26:32 -07:00
2020-09-30 10:50:30 +02:00
2020-09-26 10:33:57 -07:00
2020-11-19 11:56:16 -08:00
2020-05-01 12:35:21 +10:00
2020-12-03 09:52:44 -08:00
2020-09-08 22:21:33 -04:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2022-08-21 15:15:41 +02:00
2019-05-21 10:50:45 +02:00
2023-06-21 15:45:35 +02:00
2020-06-29 10:02:23 +02:00
2020-10-13 18:38:33 -07:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2020-07-10 16:24:28 -03:00
2022-01-27 10:54:36 +01:00
2018-10-15 16:31:29 -04:00
2020-10-13 18:38:32 -07:00
2021-05-19 10:13:11 +02:00
2023-06-21 15:45:35 +02:00
2020-05-08 18:18:12 +01:00
2021-09-30 10:11:04 +02:00
2022-04-08 14:40:35 +02:00
2018-10-16 13:45:44 +02:00
2022-01-27 10:54:36 +01:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2019-07-16 19:23:22 -07:00
2020-06-07 10:53:36 -07:00
2020-09-20 14:10:06 -07:00
2019-05-21 10:50:45 +02:00
2021-09-18 13:40:37 +02:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2020-10-16 11:11:20 -07:00
2022-04-13 21:01:10 +02:00
2019-10-16 14:56:21 +02:00
2020-06-29 11:59:26 -07:00
2022-04-08 14:40:40 +02:00
2020-07-15 12:45:06 +03:00
2019-10-03 12:12:23 -04:00
2019-07-24 17:38:01 +02:00
2020-08-12 10:58:00 -07:00
2020-08-24 14:17:44 -07:00
2020-04-07 10:43:43 -07:00
2023-02-01 08:23:20 +01:00
2021-02-17 11:02:24 +01:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2023-02-25 11:55:03 +01:00
2020-03-23 17:01:47 +01:00
2022-05-30 09:33:38 +02:00
2017-11-02 11:10:55 +01:00
2022-04-08 14:40:40 +02:00
2020-08-12 10:58:00 -07:00