Zheng Liang
286f94453f
ovl: fix missing negative dentry check in ovl_rename() ...
commit a295aef603e109a47af355477326bd41151765b6 upstream.
The following reproducer
mkdir lower upper work merge
touch lower/old
touch lower/new
mount -t overlay overlay -olowerdir=lower,upperdir=upper,workdir=work merge
rm merge/new
mv merge/old merge/new & unlink upper/new
may result in this race:
PROCESS A:
rename("merge/old", "merge/new");
overwrite=true,ovl_lower_positive(old)=true,
ovl_dentry_is_whiteout(new)=true -> flags |= RENAME_EXCHANGE
PROCESS B:
unlink("upper/new");
PROCESS A:
lookup newdentry in new_upperdir
call vfs_rename() with negative newdentry and RENAME_EXCHANGE
Fix by adding the missing check for negative newdentry.
Signed-off-by: Zheng Liang <zhengliang6@huawei.com>
Fixes: e9be9d5e76e3 ("overlay filesystem")
Cc: <stable@vger.kernel.org> # v3.18
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-17 10:05:38 +02:00
2020-11-10 10:23:59 +01:00
2019-08-06 18:29:35 +02:00
2020-09-12 11:47:39 +02:00
2020-01-29 10:24:34 +01:00
2019-12-21 10:40:46 +01:00
2018-12-01 09:44:19 +01:00
2021-09-22 11:42:57 +02:00
2020-11-10 10:24:00 +01:00
2021-09-26 13:36:18 +02:00
2021-10-06 10:23:38 +02:00
2019-08-06 18:29:38 +02:00
2021-07-20 16:21:05 +02:00
2018-11-13 11:17:03 -08:00
2021-07-20 16:21:11 +02:00
2019-05-08 07:19:10 +02:00
2019-03-23 13:19:47 +01:00
2021-07-20 16:21:00 +02:00
2021-05-26 11:29:07 +02:00
2020-12-02 08:31:28 +01:00
2018-11-27 16:09:38 +01:00
2020-01-29 10:24:03 +01:00
2021-10-09 13:25:59 +02:00
2021-10-06 10:23:42 +02:00
2021-05-22 10:40:30 +02:00
2020-06-20 10:24:13 +02:00
2018-12-17 09:38:34 +01:00
2021-07-20 16:21:08 +02:00
2021-09-22 11:43:07 +02:00
2021-08-04 11:58:02 +02:00
2020-04-24 07:58:59 +02:00
2021-06-03 08:23:33 +02:00
2021-03-03 17:44:37 +01:00
2020-09-03 11:21:19 +02:00
2021-05-22 10:40:19 +02:00
2021-07-20 16:21:11 +02:00
2019-11-25 09:52:23 +01:00
2020-12-29 13:44:57 +01:00
2020-08-21 11:02:06 +02:00
2019-03-13 14:04:52 -07:00
2021-07-20 16:21:14 +02:00
2020-12-29 13:44:59 +01:00
2021-01-23 15:38:18 +01:00
2021-09-26 13:36:19 +02:00
2019-02-06 17:33:30 +01:00
2021-07-20 16:20:56 +02:00
2021-10-06 10:23:38 +02:00
2021-07-20 16:21:13 +02:00
2021-10-17 10:05:38 +02:00
2021-07-28 09:14:27 +02:00
2020-01-12 11:24:20 +01:00
2021-10-06 10:23:41 +02:00
2021-01-09 13:35:50 +01:00
2021-08-15 13:01:04 +02:00
2020-08-26 10:29:03 +02:00
2021-05-22 10:40:32 +02:00
2021-03-07 11:25:58 +01:00
2018-12-17 09:38:32 +01:00
2021-07-20 16:21:14 +02:00
2021-09-22 11:42:59 +02:00
2020-08-21 11:02:11 +02:00
2021-03-07 11:25:56 +01:00
2018-12-21 14:11:31 +01:00
2017-01-09 08:32:24 +01:00
2020-06-03 08:16:42 +02:00
2019-07-10 09:55:38 +02:00
2021-03-17 16:10:18 +01:00
2019-11-06 12:18:04 +01:00
2020-10-01 20:40:12 +02:00
2020-11-10 10:23:56 +01:00
2020-05-20 08:15:32 +02:00
2018-02-25 11:05:55 +01:00
2020-06-30 15:38:35 -04:00
2017-07-05 14:40:26 +02:00
2018-02-28 10:18:33 +01:00
2019-03-27 14:13:04 +09:00
2021-04-16 11:59:07 +02:00
2019-03-13 14:04:58 -07:00
2020-10-14 09:48:13 +02:00
2021-02-03 23:19:49 +01:00
2018-01-31 12:55:52 +01:00
2020-05-27 16:41:40 +02:00
2021-07-20 16:21:03 +02:00
2020-04-02 17:20:27 +02:00
2017-09-20 08:20:01 +02:00
2017-09-20 08:19:59 +02:00
2020-11-24 13:03:05 +01:00
2020-01-12 11:24:13 +01:00
2018-02-22 15:43:48 +01:00
2017-07-21 07:42:22 +02:00
2017-10-18 09:35:39 +02:00
2020-03-11 07:53:07 +01:00
2021-08-26 08:37:29 -04:00
2018-02-17 13:21:15 +01:00
2020-03-20 09:07:44 +01:00
2021-08-15 13:01:03 +02:00
2020-05-02 17:23:20 +02:00
2017-03-15 10:02:43 +08:00
2017-01-26 08:24:37 +01:00
2019-06-11 12:22:49 +02:00
2020-01-04 13:41:06 +01:00
2021-03-24 10:59:25 +01:00
2021-07-20 16:21:16 +02:00
2019-06-11 12:22:45 +02:00
2017-06-14 15:06:01 +02:00
2020-11-24 13:03:00 +01:00
2017-05-08 07:47:54 +02:00
2019-09-06 10:19:37 +02:00
2020-08-21 11:01:55 +02:00
286f94453f