iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/arch/x86/kernel
History
Chang S. Bae a401f45e38 x86/fpu: Exclude dynamic states from init_fpstate 
== Background ==

The XSTATE init code initializes all enabled and supported components.
Then, the init states are saved in the init_fpstate buffer that is
statically allocated in about one page.

The AMX TILE_DATA state is large (8KB) but its init state is zero. And the
feature comes only with the compacted format with these established
dependencies: AMX->XFD->XSAVES. So this state is excludable from
init_fpstate.

== Problem ==

But the buffer is formatted to include that large state. Then, this can be
the cause of a noisy splat like the below.

This came from XRSTORS for the task with init_fpstate in its XSAVE buffer.
It is reproducible on AMX systems when the running kernel is built with
CONFIG_DEBUG_PAGEALLOC=y and CONFIG_DEBUG_PAGEALLOC_ENABLE_DEFAULT=y:

 Bad FPU state detected at restore_fpregs_from_fpstate+0x57/0xd0, reinitializing FPU registers.
 ...
 RIP: 0010:restore_fpregs_from_fpstate+0x57/0xd0
  ? restore_fpregs_from_fpstate+0x45/0xd0
  switch_fpu_return+0x4e/0xe0
  exit_to_user_mode_prepare+0x17b/0x1b0
  syscall_exit_to_user_mode+0x29/0x40
  do_syscall_64+0x67/0x80
  ? do_syscall_64+0x67/0x80
  ? exc_page_fault+0x86/0x180
  entry_SYSCALL_64_after_hwframe+0x63/0xcd

== Solution ==

Adjust init_fpstate to exclude dynamic states. XRSTORS from init_fpstate
still initializes those states when their bits are set in the
requested-feature bitmap.

Fixes: 2308ee57d93d ("x86/fpu/amx: Enable the AMX feature in 64-bit mode")
Reported-by: Lin X Wang <lin.x.wang@intel.com>
Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Lin X Wang <lin.x.wang@intel.com>
Link: https://lore.kernel.org/r/20220824191223.1248-4-chang.seok.bae@intel.com
2022-10-17 15:44:25 +02:00
..
acpi
ACPI: CPPC: Fix enabling CPPC on AMD systems with shared memory
2022-07-13 21:13:14 +02:00
apic
x86/apic: Don't disable x2APIC if locked
2022-08-31 14:34:11 -07:00
cpu
treewide: use get_random_u32() when possible
2022-10-11 17:42:58 -06:00
fpu
x86/fpu: Exclude dynamic states from init_fpstate
2022-10-17 15:44:25 +02:00
kprobes
x86: kprobes: Remove unused macro stack_addr
2022-09-27 14:48:26 -04:00
.gitignore
…
alternative.c
- Make sure an INT3 is slapped after every unconditional retpoline JMP
2022-10-04 09:46:22 -07:00
amd_gart_64.c
x86: Fix various duplicate-word comment typos
2022-08-15 19:17:52 +02:00
amd_nb.c
x86/amd_nb: Add AMD PCI IDs for SMN communication
2022-07-20 17:35:40 +02:00
aperture_64.c
x86: Fix various duplicate-word comment typos
2022-08-15 19:17:52 +02:00
apm_32.c
x86/ibt: Disable IBT around firmware
2022-03-15 10:32:40 +01:00
asm-offsets_32.c
x86/stackprotector/32: Make the canary into a regular percpu variable
2021-03-08 13:19:05 +01:00
asm-offsets_64.c
KVM: x86: Support the vCPU preemption check with nopvspin and realtime hint
2022-04-02 05:41:21 -04:00
asm-offsets.c
KVM: VMX: Prevent RSB underflow before vmenter
2022-06-27 10:34:00 +02:00
audit_64.c
audit: add support for the openat2 syscall
2021-10-01 16:52:48 -04:00
bootflag.c
…
cfi.c
x86: Add support for CONFIG_CFI_CLANG
2022-09-26 10:13:16 -07:00
check.c
…
cpuid.c
smp: Cleanup smp_call_function*()
2020-11-24 16:47:49 +01:00
crash_core_32.c
…
crash_core_64.c
…
crash_dump_32.c
vmcore: convert copy_oldmem_page() to take an iov_iter
2022-04-29 14:37:59 -07:00
crash_dump_64.c
vmcore: convert read_from_oldmem() to take an iov_iter
2022-04-29 14:37:59 -07:00
crash.c
x86/crash: Fix minor typo/bug in debug message
2022-04-13 19:39:54 +02:00
devicetree.c
Devicetree updates for v5.16:
2021-11-02 22:22:13 -07:00
doublefault_32.c
exit/doublefault: Remove apparently bogus comment about rewind_stack_do_exit
2021-10-20 13:09:43 -05:00
dumpstack_32.c
…
dumpstack_64.c
x86/mm/64: Improve stack overflow warnings
2021-09-21 13:57:43 +02:00
dumpstack.c
- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in
2022-10-10 17:53:04 -07:00
e820.c
x86/kexec: Carry forward IMA measurement log on kexec
2022-07-01 15:22:16 +02:00
early_printk.c
x86/earlyprintk: Clean up pciserial
2022-08-29 12:19:25 +02:00
early-quirks.c
drm/i915/rpl-p: Add PCI IDs
2022-04-19 17:14:09 -07:00
ebda.c
…
eisa.c
…
espfix_64.c
random: handle archrandom with multiple longs
2022-07-25 13:26:14 +02:00
ftrace_32.S
x86: Prepare asm files for straight-line-speculation
2021-12-08 12:25:37 +01:00
ftrace_64.S
x86/ftrace: Remove OBJECT_FILES_NON_STANDARD usage
2022-06-06 11:50:22 -07:00
ftrace.c
Tracing updates for 5.20 / 6.0
2022-08-05 09:41:12 -07:00
head32.c
…
head64.c
x86: Clear .brk area at early boot
2022-07-01 11:11:34 +02:00
head_32.S
x86/asm/32: Fix ANNOTATE_UNRET_SAFE use on 32-bit
2022-07-13 12:43:26 +02:00
head_64.S
objtool: Add entry UNRET validation
2022-06-27 10:34:00 +02:00
hpet.c
rtc: Check return value from mc146818_get_time()
2021-12-16 21:50:06 +01:00
hw_breakpoint.c
x86/debug: Prevent data breakpoints on cpu_dr7
2021-02-05 20:13:12 +01:00
i8237.c
…
i8253.c
…
i8259.c
x86: Avoid magic number with ELCR register accesses
2021-08-10 23:31:43 +02:00
idt.c
x86/traps: Add #VE support for TDX guest
2022-04-07 08:27:51 -07:00
io_delay.c
…
ioport.c
…
irq_32.c
asm-generic: Conditionally enable do_softirq_own_stack() via Kconfig.
2022-09-05 17:20:55 +02:00
irq_64.c
x86/softirq/64: Inline do_softirq_own_stack()
2021-02-10 23:34:17 +01:00
irq_work.c
…
irq.c
x86/irq: Ensure PI wakeup handler is unregistered before module unload
2021-10-22 12:45:35 -04:00
irqflags.S
x86: Prepare asm files for straight-line-speculation
2021-12-08 12:25:37 +01:00
irqinit.c
x86/headers: Remove APIC headers from <asm/smp.h>
2020-08-06 16:13:09 +02:00
itmt.c
x86/sched: Decrease further the priorities of SMT siblings
2021-10-05 15:51:59 +02:00
jailhouse.c
locking/seqlock, headers: Untangle the spaghetti monster
2020-08-06 16:13:13 +02:00
jump_label.c
jump_label: make initial NOP patching the special case
2022-06-24 09:48:55 +02:00
kdebugfs.c
x86/boot: Fix memremap of setup_indirect structures
2022-03-09 12:49:44 +01:00
kexec-bzimage64.c
integrity-v6.0
2022-08-02 15:21:18 -07:00
kgdb.c
x86: Fix various typos in comments
2021-03-18 15:31:53 +01:00
ksysfs.c
x86/boot: Fix memremap of setup_indirect structures
2022-03-09 12:49:44 +01:00
kvm.c
x86: kvm: remove NULL check before kfree
2022-06-20 06:22:04 -04:00
kvmclock.c
x86/kvm: Don't waste kvmclock memory if there is nopv parameter
2022-04-13 13:37:19 -04:00
ldt.c
memcg: enable accounting for ldt_struct objects
2021-09-03 09:58:13 -07:00
machine_kexec_32.c
x86/kexec: Set_[gi]dt() -> native_[gi]dt_invalidate() in machine_kexec_*.c
2021-05-21 12:36:45 +02:00
machine_kexec_64.c
x86/kexec: fix memory leak of elf header buffer
2022-06-01 15:57:16 -07:00
Makefile
- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in
2022-10-10 17:53:04 -07:00
mmconf-fam10h_64.c
x86/msr: Rename MSR_K8_SYSCFG to MSR_AMD64_SYSCFG
2021-05-10 07:51:38 +02:00
module.c
treewide: use prandom_u32_max() when possible, part 1
2022-10-11 17:42:55 -06:00
mpparse.c
x86: Avoid magic number with ELCR register accesses
2021-08-10 23:31:43 +02:00
msr.c
x86/MSR: Filter MSR writes through X86_IOC_WRMSR_REGS ioctl too
2021-01-27 19:06:47 +01:00
nmi_selftest.c
…
nmi.c
x86/nmi: Make register_nmi_handler() more robust
2022-05-17 09:25:25 +02:00
paravirt-spinlocks.c
x86/paravirt: Add new features for paravirt patching
2021-03-11 19:51:49 +01:00
paravirt.c
x86/ibt,paravirt: Sprinkle ENDBR
2022-03-15 10:32:36 +01:00
pci-dma.c
swiotlb: merge swiotlb-xen initialization into swiotlb
2022-04-18 07:21:13 +02:00
pcspeaker.c
…
perf_regs.c
- Remove all uses of TIF_IA32 and TIF_X32 and reclaim the two bits in the end
2020-12-14 13:45:26 -08:00
platform-quirks.c
…
pmem.c
x86/pmem: Fix platform-device leak in error path
2022-06-20 18:01:16 +02:00
probe_roms.c
x86/kernel: Validate ROM memory before accessing when SEV-SNP is active
2022-04-06 13:23:09 +02:00
process_32.c
- Remove all the code around GS switching on 32-bit now that it is not
2022-05-23 18:42:07 -07:00
process_64.c
x86: kmsan: skip shadow checks in __switch_to()
2022-10-03 14:03:24 -07:00
process.c
treewide: use prandom_u32_max() when possible, part 1
2022-10-11 17:42:55 -06:00
process.h
x86: Snapshot thread flags
2021-12-01 00:06:43 +01:00
ptrace.c
x86/32: Remove lazy GS macros
2022-04-14 14:09:43 +02:00
pvclock.c
x86: Fix various typos in comments
2021-03-18 15:31:53 +01:00
quirks.c
x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
2020-10-06 11:18:04 +02:00
reboot_fixups_32.c
…
reboot.c
x86: Use do_kernel_power_off()
2022-05-19 19:30:31 +02:00
relocate_kernel_32.S
x86/kexec: Disable RET on kexec
2022-07-09 13:12:32 +02:00
relocate_kernel_64.S
x86/kexec: Disable RET on kexec
2022-07-09 13:12:32 +02:00
resource.c
x86/PCI: Revert "x86/PCI: Clip only host bridge windows for E820 regions"
2022-06-17 14:24:14 -05:00
rethook.c
x86,rethook: Fix arch_rethook_trampoline() to generate a complete pt_regs
2022-03-28 19:38:51 -07:00
rtc.c
x86/rtc: Rename mach_set_rtc_mmss() to mach_set_cmos_time()
2022-08-14 11:24:29 +02:00
setup_percpu.c
mm: percpu: add generic pcpu_populate_pte() function
2022-01-20 08:52:52 +02:00
setup.c
x86/setup: Use rng seeds from setup_data
2022-07-11 09:59:31 +02:00
sev_verify_cbit.S
x86: Prepare asm files for straight-line-speculation
2021-12-08 12:25:37 +01:00
sev-shared.c
Revert "x86/sev: Expose sev_es_ghcb_hv_call() for use by HyperV"
2022-07-27 18:09:13 +02:00
sev.c
x86/sev: Mark snp_abort() noreturn
2022-08-25 15:54:03 +02:00
signal_compat.c
signal: Deliver SIGTRAP on perf event asynchronously if blocked
2022-04-22 12:14:05 +02:00
signal.c
x86/32: Remove lazy GS macros
2022-04-14 14:09:43 +02:00
smp.c
x86: Fix various typos in comments, take #2
2021-03-21 23:50:28 +01:00
smpboot.c
smp: add set_nr_cpu_ids()
2022-09-19 17:51:53 -07:00
stacktrace.c
x86: remove __range_not_ok()
2022-02-25 09:36:05 +01:00
static_call.c
x86/static_call: Serialize __static_call_fixup() properly
2022-07-12 14:23:32 +02:00
step.c
ptrace: Reimplement PTRACE_KILL by always sending SIGKILL
2022-05-11 14:34:28 -05:00
sys_ia32.c
x86: switch to kernel_clone()
2020-08-20 13:12:58 +02:00
sys_x86_64.c
x86/mm: Cleanup the control_va_addr_alignment() __setup handler
2022-05-04 18:20:42 +02:00
tboot.c
mm: remove rb tree.
2022-09-26 19:46:16 -07:00
time.c
…
tls.c
x86/stackprotector/32: Make the canary into a regular percpu variable
2021-03-08 13:19:05 +01:00
tls.h
x86: switch to ->regset_get()
2020-07-27 14:31:07 -04:00
topology.c
drivers/base/node: consolidate node device subsystem initialization in node_dev_init()
2022-03-22 15:57:10 -07:00
trace_clock.c
…
trace.c
trace/osnoise: Fix an ifdef comment
2021-10-25 23:02:36 -04:00
tracepoint.c
x86/traceponit: Fix comment about irq vector tracepoints
2022-05-26 22:03:52 -04:00
traps.c
x86: Add support for CONFIG_CFI_CLANG
2022-09-26 10:13:16 -07:00
tsc_msr.c
Misc fixes and small updates all around the place:
2020-08-15 10:38:03 -07:00
tsc_sync.c
x86/tsc: Add a timer to make sure TSC_adjust is always checked
2021-12-02 00:40:35 +01:00
tsc.c
x86/tsc: Be consistent about use_tsc_delay()
2022-03-15 18:20:33 +01:00
umip.c
x86/umip: Downgrade warning messages to debug loglevel
2021-09-25 13:23:28 +02:00
unwind_frame.c
x86: kmsan: don't instrument stack walking functions
2022-10-03 14:03:25 -07:00
unwind_guess.c
x86/unwind: Recover kretprobe trampoline entry
2021-09-30 21:24:07 -04:00
unwind_orc.c
x86/unwind/orc: Unwind ftrace trampolines with correct ORC entry
2022-08-21 12:19:32 +02:00
uprobes.c
x86/uprobes: Convert to insn_decode()
2021-03-15 12:05:03 +01:00
verify_cpu.S
x86: Prepare asm files for straight-line-speculation
2021-12-08 12:25:37 +01:00
vm86_32.c
x86/32: Remove lazy GS macros
2022-04-14 14:09:43 +02:00
vmlinux.lds.S
Just when you thought that all the speculation bugs were addressed and
2022-07-11 18:15:25 -07:00
vsmp_64.c
…
x86_init.c
x86/rtc: Rename mach_set_rtc_mmss() to mach_set_cmos_time()
2022-08-14 11:24:29 +02:00