Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
2008-02-14 14:22:12 +09:00
2007-05-14 09:18:35 +09:00
2006-10-03 13:16:15 +09:00
2005-04-16 15:20:36 -07:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:58 +09:00
2008-01-28 13:18:52 +09:00
2008-04-18 09:50:01 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-03-06 17:23:15 +09:00
2005-04-16 15:20:36 -07:00
2007-09-21 11:57:53 +09:00
2007-05-09 17:36:15 +09:00
2007-05-09 08:58:16 +02:00
2005-04-16 15:20:36 -07:00
2007-07-17 10:23:11 -07:00
2006-01-16 23:15:28 -08:00
2007-06-18 13:58:32 +09:00
2008-01-28 13:19:01 +09:00
2007-09-21 11:57:51 +09:00
2008-02-14 14:22:11 +09:00
2008-05-08 19:52:03 +09:00
2008-04-18 00:46:34 +02:00
2007-09-21 11:57:48 +09:00
2008-02-14 14:22:09 +09:00
2008-05-08 19:51:37 +09:00
2006-01-10 08:01:34 -08:00
2008-02-14 14:22:07 +09:00
2005-04-16 15:20:36 -07:00
2008-02-14 14:22:12 +09:00
2008-05-16 15:09:08 +09:00
2007-05-07 02:11:55 +00:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-01-28 23:21:18 +01:00
2008-04-18 09:50:03 -07:00
2006-02-15 15:32:22 -08:00
2008-05-08 19:51:37 +09:00
2007-02-13 10:54:45 +09:00
2008-01-28 13:18:39 +09:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-01-28 13:19:01 +09:00
2008-01-28 13:18:55 +09:00
2005-04-16 15:20:36 -07:00
2008-04-28 08:58:23 -07:00
2008-04-28 08:58:23 -07:00
2006-09-27 16:20:22 +09:00
2007-05-11 08:29:34 -07:00
2005-04-16 15:20:36 -07:00
2008-02-14 14:22:09 +09:00
2008-01-28 13:19:04 +09:00
2006-12-06 10:45:37 +09:00
2005-04-16 15:20:36 -07:00
2008-04-17 10:42:34 -04:00
2005-04-16 15:20:36 -07:00
2007-02-15 18:20:52 +09:00
2005-04-16 15:20:36 -07:00
2008-04-18 09:50:00 -07:00
2005-04-16 15:20:36 -07:00
2006-10-19 17:31:22 +09:00
2008-01-28 13:18:57 +09:00
2005-04-16 15:20:36 -07:00
2007-06-08 02:43:43 +00:00
2005-04-16 15:20:36 -07:00
2008-02-14 14:22:09 +09:00
2008-04-18 09:50:01 -07:00
2008-02-14 14:22:07 +09:00
2008-02-14 14:22:07 +09:00
2008-01-28 23:21:18 +01:00
2005-04-16 15:20:36 -07:00
2008-05-08 19:51:37 +09:00
2007-10-19 11:53:34 -07:00
2008-05-08 19:51:37 +09:00
2005-04-16 15:20:36 -07:00
2008-02-14 14:22:08 +09:00
2008-02-14 14:22:08 +09:00
2008-02-07 08:42:30 -08:00
2007-11-07 20:19:30 +09:00
2006-09-27 12:31:01 +09:00
2005-04-16 15:20:36 -07:00