Christof Schmitt
39562e7839
[SCSI] FC transport: Locking fix for common-code FC pass-through patch ...
Fix this:
------------[ cut here ]------------
Badness at block/blk-core.c:244
CPU: 0 Tainted: G W 2.6.31-rc1-00004-gd3a263a #3
Process zfcp_wq (pid: 901, task: 000000002fb7a038, ksp: 000000002f02bc78)
Krnl PSW : 0704300180000000 00000000002141ba (blk_remove_plug+0xb2/0xb8)
R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:0 CC:3 PM:0 EA:3
Krnl GPRS: 0000000000000001 0000000000000001 0000000022811440 0000000022811798
000000000027ff4e 0000000000000000 0000000000000000 000000002f00f000
070000000006a0f4 000000002af70000 000000002af2a800 00000000228d1c00
0000000022811440 000000000050c708 000000002f02bca8 000000002f02bc80
Krnl Code: 00000000002141b0: b9140022 lgfr %r2,%r2
00000000002141b4: 07fe bcr 15,%r14
00000000002141b6: a7f40001 brc 15,2141b8
>00000000002141ba: a7f4ffbe brc 15,214136
00000000002141be: 0707 bcr 0,%r7
00000000002141c0: ebaff0680024 stmg %r10,%r15,104(%r15)
00000000002141c6: c0d00017c2a9 larl %r13,50c718
00000000002141cc: a7f13fc0 tmll %r15,16320
Call Trace:
([<000000000050e7d8>] C.272.16122+0x88/0x110)
[<00000000002141ec>] __blk_run_queue+0x2c/0x154
[<000000000028013a>] fc_remote_port_add+0x85e/0x95c
[<000000000037596e>] zfcp_scsi_rport_work+0xe6/0x148
[<000000000006908c>] worker_thread+0x25c/0x318
[<000000000006f10c>] kthread+0x94/0x9c
[<000000000001c2b2>] kernel_thread_starter+0x6/0xc
[<000000000001c2ac>] kernel_thread_starter+0x0/0xc
INFO: lockdep is turned off.
Last Breaking-Event-Address:
[<00000000002141b6>] blk_remove_plug+0xae/0xb8
The FC pass-through support triggers the WARN_ON(!irqs_disabled()) in
blk_plug_device. Since blk_plug_device requires being called with
disabled interrupts, use spin_lock_irqsave in fc_bsg_goose_queue to
disable the interrupts before calling into the block layer.
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Acked-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2009-06-26 10:29:48 -05:00
2009-06-24 01:22:20 -04:00
2009-06-23 01:54:30 -04:00
2009-06-16 19:50:13 -07:00
2009-06-18 09:56:20 +02:00
2009-06-15 03:02:23 -07:00
2009-06-24 09:55:50 -07:00
2009-06-17 16:37:26 +09:00
2009-06-15 11:49:41 -04:00
2009-06-18 19:31:09 +08:00
2009-06-24 18:34:40 +01:00
2009-06-18 13:03:57 -07:00
2009-06-16 19:50:13 -07:00
2009-06-22 21:29:52 -07:00
2009-06-17 09:35:24 -07:00
2009-06-19 16:46:03 -07:00
Merge branches 'acerhdf', 'acpi-pci-bind', 'bjorn-pci-root', 'bugzilla-12904', 'bugzilla-13121', 'bugzilla-13396', 'bugzilla-13533', 'bugzilla-13612', 'c3_lock', 'hid-cleanups', 'misc-2.6.31', 'pdc-leak-fix', 'pnpacpi', 'power_nocheck', 'thinkpad_acpi', 'video' and 'wmi' into release
2009-06-24 01:19:50 -04:00
2009-06-15 21:30:25 -07:00
2009-06-16 19:50:13 -07:00
2009-06-24 00:18:56 +01:00
2009-06-21 22:48:03 -07:00
2009-06-22 21:29:52 -07:00
2009-06-13 23:36:29 -07:00
2009-06-23 10:38:47 -07:00
2009-06-20 10:17:02 -07:00
2009-06-17 04:31:16 -07:00
2009-06-16 11:29:17 -07:00
2009-06-22 10:12:37 +01:00
2009-06-23 03:29:57 -03:00
2009-06-22 08:54:14 -05:00
2009-06-20 18:39:43 +00:00
2009-06-18 13:04:04 -07:00
2009-06-21 21:01:00 +02:00
2009-06-22 16:56:22 -07:00
2009-06-24 10:01:12 -07:00
2009-06-15 09:40:05 -07:00
2009-06-15 21:30:28 -07:00
2009-06-22 11:29:00 -07:00
2009-06-24 10:17:07 -07:00
2009-06-16 19:50:13 -07:00
2009-06-24 01:34:00 -04:00
Merge branches 'acerhdf', 'acpi-pci-bind', 'bjorn-pci-root', 'bugzilla-12904', 'bugzilla-13121', 'bugzilla-13396', 'bugzilla-13533', 'bugzilla-13612', 'c3_lock', 'hid-cleanups', 'misc-2.6.31', 'pdc-leak-fix', 'pnpacpi', 'power_nocheck', 'thinkpad_acpi', 'video' and 'wmi' into release
2009-06-24 01:19:50 -04:00
2009-06-18 13:04:04 -07:00
2009-06-15 16:47:25 +10:00
2009-06-15 21:45:32 -05:00
2009-06-15 11:18:27 +01:00
2009-06-19 16:46:05 -07:00
2009-06-22 12:08:23 +02:00
2009-06-16 04:56:57 -07:00
2009-06-26 10:29:48 -05:00
2009-06-24 09:55:50 -07:00
2009-06-19 16:46:05 -07:00
2009-06-24 18:34:41 +01:00
2009-06-15 21:30:27 -07:00
2009-06-18 11:16:55 +10:00
2009-06-23 12:50:05 -07:00
2009-06-16 19:47:52 -07:00
2009-06-24 14:35:57 -07:00
2009-06-23 07:13:52 +00:00
2009-06-18 13:04:04 -07:00
2009-06-18 13:04:04 -07:00
39562e7839