Anssi Hannula 44fa816bb7 dm cache: fix race affecting dirty block count ...

nr_dirty is updated without locking, causing it to drift so that it is
non-zero (either a small positive integer, or a very large one when an
underflow occurs) even when there are no actual dirty blocks.  This was
due to a race between the workqueue and map function accessing nr_dirty
in parallel without proper protection.

People were seeing under runs due to a race on increment/decrement of
nr_dirty, see: https://lkml.org/lkml/2014/6/3/648

Fix this by using an atomic_t for nr_dirty.

Reported-by: roma1390@gmail.com
Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org

2014-08-01 12:25:22 -04:00

..

bcache

arch: Mass conversion of smp_mb__*()

2014-04-18 14:20:48 +02:00

persistent-data

dm transaction manager: fix corruption due to non-atomic transaction commit

2014-03-27 16:56:23 -04:00

bitmap.c

md/bitmap: remove confusing code from filemap_get_page.

2014-05-29 16:59:47 +10:00

bitmap.h

kernfs: s/sysfs_dirent/kernfs_node/ and rename its friends accordingly

2013-12-11 15:28:36 -08:00

dm-bio-prison.c

dm bio prison: implement per bucket locking in the dm_bio_prison hash table

2014-06-11 16:48:54 -04:00

dm-bio-prison.h

dm thin: return ENOSPC instead of EIO when error_if_no_space enabled

2014-06-03 13:44:08 -04:00

dm-bio-record.h

dm: Refactor for new bio cloning/splitting

2013-11-23 22:33:55 -08:00

dm-bufio.c

dm bufio: fully initialize shrinker

2014-08-01 12:07:21 -04:00

dm-bufio.h

dm snapshot: use dm-bufio prefetch

2014-01-14 23:23:03 -05:00

dm-builtin.c

dm sysfs: fix a module unload race

2014-01-14 23:23:04 -05:00

dm-cache-block-types.h

dm cache: remove remainder of distinct discard block size

2014-03-27 16:56:23 -04:00

dm-cache-metadata.c

dm cache metadata: do not allow the data block size to change

2014-07-15 14:07:50 -04:00

dm-cache-metadata.h

dm cache: fix a lock-inversion

2014-04-04 14:53:05 -04:00

dm-cache-policy-cleaner.c

dm cache: policy change version from string to integer set

2013-03-20 17:21:27 +00:00

dm-cache-policy-internal.h

dm cache: add remove_cblock method to policy interface

2013-11-11 11:37:50 -05:00

dm-cache-policy-mq.c

dm cache mq: fix memory allocation failure for large cache devices

2014-02-28 12:18:29 -05:00

dm-cache-policy.c

dm cache: add policy name to status output

2014-01-16 13:44:11 -05:00

dm-cache-policy.h

dm cache: add policy name to status output

2014-01-16 13:44:11 -05:00

dm-cache-target.c

dm cache: fix race affecting dirty block count

2014-08-01 12:25:22 -04:00

dm-crypt.c

dm crypt, dm zero: update author name following legal name change

2014-07-10 16:44:14 -04:00

dm-delay.c

Merge branch 'for-3.14/core' of git://git.kernel.dk/linux-block

2014-01-30 11:19:05 -08:00

dm-era-target.c

dm era: check for a non-NULL metadata object before closing it

2014-06-03 13:44:08 -04:00

dm-exception-store.c

dm: replace simple_strtoul

2012-07-27 15:07:59 +01:00

dm-exception-store.h

dm snapshot: test chunk size against both origin and snapshot

2010-08-12 04:13:51 +01:00

dm-flakey.c

block: Abstract out bvec iterator

2013-11-23 22:33:47 -08:00

dm-io.c

dm io: fix a race condition in the wake up code for sync_io

2014-07-10 16:44:14 -04:00

dm-ioctl.c

dm: allow remove to be deferred

2013-11-09 18:20:22 -05:00

dm-kcopyd.c

dm: stop using WQ_NON_REENTRANT

2013-08-23 09:02:13 -04:00

dm-linear.c

block: Abstract out bvec iterator

2013-11-23 22:33:47 -08:00

dm-log-userspace-base.c

dm log userspace: allow mark requests to piggyback on flush requests

2014-01-21 23:46:27 -05:00

dm-log-userspace-transfer.c

connector: add portid to unicast in addition to broadcasting

2014-02-07 15:40:17 -08:00

dm-log-userspace-transfer.h

dm log: userspace add luid to distinguish between concurrent log instances

2009-09-04 20:40:34 +01:00

dm-log.c

dm: use memweight()

2012-07-30 17:25:16 -07:00

dm-mpath.c

dm mpath: fix IO hang due to logic bug in multipath_busy

2014-07-10 16:44:15 -04:00

dm-mpath.h

…

dm-path-selector.c

md: Add module.h to all files using it implicitly

2011-10-31 19:31:18 -04:00

dm-path-selector.h

dm mpath: add start_io and nr_bytes to path selectors

2009-06-22 10:12:27 +01:00

dm-queue-length.c

dm: reject trailing characters in sccanf input

2012-03-28 18:41:26 +01:00

dm-raid1.c

dm raid1: fix immutable biovec related BUG when retrying read bio

2014-02-18 10:48:57 -05:00

dm-raid.c

MD: Remember the last sync operation that was performed

2013-06-26 12:38:24 +10:00

dm-region-hash.c

block: Abstract out bvec iterator

2013-11-23 22:33:47 -08:00

dm-round-robin.c

dm: reject trailing characters in sccanf input

2012-03-28 18:41:26 +01:00

dm-service-time.c

dm: reject trailing characters in sccanf input

2012-03-28 18:41:26 +01:00

dm-snap-persistent.c

dm snapshot: fix metadata corruption

2014-03-03 17:58:13 -05:00

dm-snap-transient.c

md: Add in export.h for files using EXPORT_SYMBOL

2011-10-31 19:31:19 -04:00

dm-snap.c

. Add dm_accept_partial_bio interface to DM core to allow DM targets

2014-06-12 13:33:29 -07:00

dm-stats.c

dm stats: initialize read-only module parameter

2013-12-10 19:13:21 -05:00

dm-stats.h

dm: add statistics support

2013-09-05 20:46:06 -04:00

dm-stripe.c

block: Abstract out bvec iterator

2013-11-23 22:33:47 -08:00

dm-switch.c

block: Abstract out bvec iterator

2013-11-23 22:33:47 -08:00

dm-sysfs.c

dm sysfs: fix a module unload race

2014-01-14 23:23:04 -05:00

dm-table.c

dm: remove symbol export for dm_set_device_limits

2014-06-04 09:46:34 -04:00

dm-target.c

dm: allow error target to replace bio-based and request-based targets

2013-09-05 20:46:05 -04:00

dm-thin-metadata.c

dm thin metadata: do not allow the data block size to change

2014-07-15 14:05:26 -04:00

dm-thin-metadata.h

dm thin: ensure user takes action to validate data and metadata consistency

2014-03-05 15:25:35 -05:00

dm-thin.c

dm thin: update discard_granularity to reflect the thin-pool blocksize

2014-06-11 16:56:12 -04:00

dm-uevent.c

md: Add in export.h for files using EXPORT_SYMBOL

2011-10-31 19:31:19 -04:00

dm-uevent.h

…

dm-verity.c

dm verity: fix biovecs hash calculation regression

2014-04-15 12:19:24 -04:00

dm-zero.c

dm crypt, dm zero: update author name following legal name change

2014-07-10 16:44:14 -04:00

dm.c

dm: allocate a special workqueue for deferred device removal

2014-07-10 16:44:13 -04:00

dm.h

dm table: add dm_table_run_md_queue_async

2014-03-27 16:56:24 -04:00

faulty.c

block: Abstract out bvec iterator

2013-11-23 22:33:47 -08:00

Kconfig

dm: add era target

2014-03-27 16:56:23 -04:00

linear.c

block: Introduce new bio_split()

2013-11-23 22:33:57 -08:00

linear.h

md/linear: typedef removal: linear_conf_t -> struct linear_conf

2011-10-11 16:48:54 +11:00

Makefile

dm: add era target

2014-03-27 16:56:23 -04:00

md.c

md: flush writes before starting a recovery.

2014-07-03 10:44:45 +10:00

md.h

md/bitmap: don't abuse i_writecount for bitmap files.

2014-04-09 12:26:59 +10:00

multipath.c

block: Abstract out bvec iterator

2013-11-23 22:33:47 -08:00

multipath.h

md/multipath: typedef removal: multipath_conf_t -> struct mpconf

2011-10-11 16:48:57 +11:00

raid0.c

block: Introduce new bio_split()

2013-11-23 22:33:57 -08:00

raid0.h

md: add proper merge_bvec handling to RAID0 and Linear.

2012-03-19 12:46:39 +11:00

raid1.c

md/raid1: r1buf_pool_alloc: free allocate pages when subsequent allocation fails.

2014-04-09 14:42:23 +10:00

raid1.h

raid1: Rewrite the implementation of iobarrier.

2013-11-19 15:19:18 +11:00

raid5.c

Assorted md fixes for 3.16

2014-06-11 08:33:41 -07:00

raid5.h

raid5: add an option to avoid copy data from bio to stripe cache

2014-05-29 16:59:47 +10:00

raid10.c

md/raid10: call wait_barrier() for each request submitted.

2014-05-06 09:49:26 +10:00

raid10.h

MD RAID10: Improve redundancy for 'far' and 'offset' algorithms (part 1)

2013-02-26 11:55:30 +11:00