iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Frederic Weisbecker 3f259d092c reiserfs: fix dependency inversion between inode and reiserfs mutexes 
The reiserfs mutex already depends on the inode mutex, so we can't lock
the inode mutex in reiserfs_unpack() without using the safe locking API,
because reiserfs_unpack() is always called with the reiserfs mutex locked.

This fixes:

  =======================================================
  [ INFO: possible circular locking dependency detected ]
  2.6.35c #13
  -------------------------------------------------------
  lilo/1606 is trying to acquire lock:
   (&sb->s_type->i_mutex_key#8){+.+.+.}, at: [<d0329450>] reiserfs_unpack+0x60/0x110 [reiserfs]

  but task is already holding lock:
   (&REISERFS_SB(s)->lock){+.+.+.}, at: [<d032a268>] reiserfs_write_lock+0x28/0x40 [reiserfs]

  which lock already depends on the new lock.

  the existing dependency chain (in reverse order) is:

  -> #1 (&REISERFS_SB(s)->lock){+.+.+.}:
         [<c1056347>] lock_acquire+0x67/0x80
         [<c12f083d>] __mutex_lock_common+0x4d/0x410
         [<c12f0c58>] mutex_lock_nested+0x18/0x20
         [<d032a268>] reiserfs_write_lock+0x28/0x40 [reiserfs]
         [<d0329e9a>] reiserfs_lookup_privroot+0x2a/0x90 [reiserfs]
         [<d0316b81>] reiserfs_fill_super+0x941/0xe60 [reiserfs]
         [<c10b7d17>] get_sb_bdev+0x117/0x170
         [<d0313e21>] get_super_block+0x21/0x30 [reiserfs]
         [<c10b74ba>] vfs_kern_mount+0x6a/0x1b0
         [<c10b7659>] do_kern_mount+0x39/0xe0
         [<c10cebe0>] do_mount+0x340/0x790
         [<c10cf0b4>] sys_mount+0x84/0xb0
         [<c12f25cd>] syscall_call+0x7/0xb

  -> #0 (&sb->s_type->i_mutex_key#8){+.+.+.}:
         [<c1056186>] __lock_acquire+0x1026/0x1180
         [<c1056347>] lock_acquire+0x67/0x80
         [<c12f083d>] __mutex_lock_common+0x4d/0x410
         [<c12f0c58>] mutex_lock_nested+0x18/0x20
         [<d0329450>] reiserfs_unpack+0x60/0x110 [reiserfs]
         [<d0329772>] reiserfs_ioctl+0x272/0x320 [reiserfs]
         [<c10c3228>] vfs_ioctl+0x28/0xa0
         [<c10c3c5d>] do_vfs_ioctl+0x32d/0x5c0
         [<c10c3f53>] sys_ioctl+0x63/0x70
         [<c12f25cd>] syscall_call+0x7/0xb

  other info that might help us debug this:

  1 lock held by lilo/1606:
   #0:  (&REISERFS_SB(s)->lock){+.+.+.}, at: [<d032a268>] reiserfs_write_lock+0x28/0x40 [reiserfs]

  stack backtrace:
  Pid: 1606, comm: lilo Not tainted 2.6.35c #13
  Call Trace:
   [<c1056186>] __lock_acquire+0x1026/0x1180
   [<c1056347>] lock_acquire+0x67/0x80
   [<c12f083d>] __mutex_lock_common+0x4d/0x410
   [<c12f0c58>] mutex_lock_nested+0x18/0x20
   [<d0329450>] reiserfs_unpack+0x60/0x110 [reiserfs]
   [<d0329772>] reiserfs_ioctl+0x272/0x320 [reiserfs]
   [<c10c3228>] vfs_ioctl+0x28/0xa0
   [<c10c3c5d>] do_vfs_ioctl+0x32d/0x5c0
   [<c10c3f53>] sys_ioctl+0x63/0x70
   [<c12f25cd>] syscall_call+0x7/0xb

Reported-by: Jarek Poplawski <jarkao2@gmail.com>
Tested-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: <stable@kernel.org>		[2.6.32 and later]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-10-01 10:50:59 -07:00
..
9p
fs/9p: Don't use dotl version of mknod for dotu inode operations
2010-09-13 08:13:03 -05:00
adfs
check ATTR_SIZE contraints in inode_change_ok
2010-08-09 16:47:39 -04:00
affs
AFFS: wait for sb synchronization when needed
2010-08-09 16:48:51 -04:00
afs
Merge git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6
2010-08-13 10:37:30 -07:00
autofs
autofs/autofs4: Move compat_ioctl handling into fs
2010-08-09 00:13:34 +02:00
autofs4
autofs4: remove unneeded null check in try_to_fill_dentry()
2010-08-11 08:59:06 -07:00
befs
fix typos concerning "initiali[zs]e"
2010-06-16 18:05:05 +02:00
bfs
BFS: clean up the superblock usage
2010-08-09 16:48:53 -04:00
btrfs
Merge branch 'for-2.6.36' of git://git.kernel.dk/linux-2.6-block
2010-08-10 15:22:42 -07:00
cachefiles
Add a dummy printk function for the maintenance of unused printks
2010-08-12 09:51:35 -07:00
ceph
ceph: select CRYPTO
2010-09-17 12:30:31 -07:00
cifs
cifs: fix potential double put of TCP session reference
2010-09-14 23:21:03 +00:00
coda
Coda: mount hangs because of missed REQ_WRITE rename
2010-09-19 11:03:09 -07:00
configfs
fix setattr error handling in sysfs, configfs
2010-06-04 17:16:29 -04:00
cramfs
cramfs: only unlock new inodes
2010-08-18 01:01:33 -04:00
debugfs
Add x64 support to debugfs
2010-05-19 22:41:57 -04:00
devpts
Simplify devpts_get_sb() failure exits
2010-05-21 18:31:12 -04:00
dlm
fs/dlm: Drop unnecessary null test
2010-08-05 14:23:45 -05:00
ecryptfs
eCryptfs: Fix encrypted file name lookup regression
2010-08-27 10:50:53 -05:00
efs
…
exofs
Merge branch 'for-linus' of git://git.open-osd.org/linux-open-osd
2010-08-11 09:19:43 -07:00
exportfs
…
ext2
mbcache: Remove unused features
2010-08-09 16:48:45 -04:00
ext3
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6
2010-08-10 11:26:52 -07:00
ext4
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6
2010-08-10 11:26:52 -07:00
fat
remove SWRITE* I/O types
2010-08-18 01:09:01 -04:00
freevxfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6
2010-08-10 11:26:52 -07:00
fscache
Add a dummy printk function for the maintenance of unused printks
2010-08-12 09:51:35 -07:00
fuse
fuse: fix lock annotations
2010-09-07 13:42:41 +02:00
gfs2
GFS2: gfs2_logd should be using interruptible waits
2010-09-17 14:00:10 +01:00
hfs
convert remaining ->clear_inode() to ->evict_inode()
2010-08-09 16:48:37 -04:00
hfsplus
convert remaining ->clear_inode() to ->evict_inode()
2010-08-09 16:48:37 -04:00
hostfs
hostfs ->follow_link() braino
2010-08-18 06:21:10 -04:00
hpfs
switch hpfs to ->evict_inode()
2010-08-09 16:48:17 -04:00
hppfs
switch hppfs to ->evict_inode()
2010-08-09 16:48:16 -04:00
hugetlbfs
new helper: end_writeback()
2010-08-09 16:47:49 -04:00
isofs
isofs: Fix lseek() to position beyond 4 GB
2010-08-11 00:29:47 -04:00
jbd
remove SWRITE* I/O types
2010-08-18 01:09:01 -04:00
jbd2
remove SWRITE* I/O types
2010-08-18 01:09:01 -04:00
jffs2
Merge git://git.infradead.org/mtd-2.6
2010-08-10 11:49:21 -07:00
jfs
jfs: don't allow os2 xattr namespace overlap with others
2010-08-10 15:33:09 -07:00
lockd
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
logfs
logfs: kill BKL
2010-08-14 00:24:24 +02:00
minix
minix: fix regression in minix_mkdir()
2010-09-09 18:57:25 -07:00
ncpfs
Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing
2010-08-10 13:58:28 -07:00
nfs
SUNRPC: Fix the NFSv4 and RPCSEC_GSS Kconfig dependencies
2010-09-12 19:57:50 -04:00
nfs_common
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
nfsd
SUNRPC: Fix the NFSv4 and RPCSEC_GSS Kconfig dependencies
2010-09-12 19:57:50 -04:00
nilfs2
nilfs2: fix leak of shadow dat inode in error path of load_nilfs
2010-08-30 10:18:03 +09:00
nls
…
notify
fsnotify: drop two useless bools in the fnsotify main loop
2010-08-27 21:42:11 -04:00
ntfs
convert remaining ->clear_inode() to ->evict_inode()
2010-08-09 16:48:37 -04:00
ocfs2
ocfs2: Don't walk off the end of fast symlinks.
2010-09-29 17:33:05 -07:00
omfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/bcopeland/omfs
2010-08-10 11:47:36 -07:00
openpromfs
…
partitions
[S390] partitions: fix build error in ibm partition detection code
2010-08-13 10:06:55 +02:00
proc
proc: make /proc/pid/limits world readable
2010-10-01 10:50:59 -07:00
qnx4
get rid of cont_write_begin_newtrunc
2010-08-09 16:47:31 -04:00
quota
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6
2010-08-10 11:26:52 -07:00
ramfs
check ATTR_SIZE contraints in inode_change_ok
2010-08-09 16:47:39 -04:00
reiserfs
reiserfs: fix dependency inversion between inode and reiserfs mutexes
2010-10-01 10:50:59 -07:00
romfs
…
smbfs
switch smbfs to evict_inode()
2010-08-09 16:48:00 -04:00
squashfs
Squashfs: fix checkpatch.pl warnings
2010-08-08 22:29:33 +00:00
sysfs
sysfs: checking for NULL instead of ERR_PTR
2010-09-03 17:26:28 -07:00
sysv
fs/sysv/super.c: add support for non-PDP11 v7 filesystems
2010-08-11 08:59:23 -07:00
ubifs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6
2010-08-10 11:26:52 -07:00
udf
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6
2010-08-10 11:26:52 -07:00
ufs
remove SWRITE* I/O types
2010-08-18 01:09:01 -04:00
xfs
xfs: force background CIL push under sustained load
2010-09-29 07:51:03 -05:00
aio.c
aio: do not return ERESTARTSYS as a result of AIO
2010-09-22 17:22:39 -07:00
anon_inodes.c
Revert "anon_inode: set S_IFREG on the anon_inode"
2010-05-27 22:03:05 -04:00
attr.c
check ATTR_SIZE contraints in inode_change_ok
2010-08-09 16:47:39 -04:00
bad_inode.c
bkl: Remove locked .ioctl file operation
2010-08-14 00:24:24 +02:00
binfmt_aout.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
binfmt_elf_fdpic.c
binfmt_elf_fdpic: Fix clear_user() error handling
2010-06-01 08:11:06 -07:00
binfmt_elf.c
…
binfmt_em86.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
binfmt_flat.c
flat: tweak default stack alignment
2010-06-29 15:29:31 -07:00
binfmt_misc.c
binfmt_misc: fix binfmt_misc priority
2010-09-09 18:57:24 -07:00
binfmt_script.c
Make do_execve() take a const filename pointer
2010-08-17 18:07:43 -07:00
binfmt_som.c
…
bio-integrity.c
fs/bio-integrity.c: return -ENOMEM on kmalloc failure
2010-08-23 13:36:59 +02:00
bio.c
block: unify flags for struct bio and struct request
2010-08-07 18:20:39 +02:00
block_dev.c
blkdev: cgroup whitelist permission fix
2010-08-11 08:59:18 -07:00
buffer.c
remove SWRITE* I/O types
2010-08-18 01:09:01 -04:00
char_dev.c
char: Mark /dev/zero and /dev/kmem as not capable of writeback
2010-09-22 09:48:47 +02:00
compat_binfmt_elf.c
…
compat_ioctl.c
bkl: Remove locked .ioctl file operation
2010-08-14 00:24:24 +02:00
compat.c
Prevent freeing uninitialized pointer in compat_do_readv_writev
2010-09-22 17:22:38 -07:00
dcache.c
fs: brlock vfsmount_lock
2010-08-18 08:35:48 -04:00
dcookies.c
…
direct-io.c
O_DIRECT: fix the splitting up of contiguous I/O
2010-09-09 18:57:22 -07:00
drop_caches.c
simplify checks for I_CLEAR/I_FREEING
2010-08-09 16:47:44 -04:00
eventfd.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
eventpoll.c
sched, wait: Use wrapper functions
2010-05-11 17:43:58 +02:00
exec.c
execve: make responsive to SIGKILL with large arguments
2010-09-10 08:10:26 -07:00
fcntl.c
vfs: take O_NONBLOCK out of the O_* uniqueness test
2010-09-09 18:57:25 -07:00
fifo.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
file_table.c
fs: scale files_lock
2010-08-18 08:35:48 -04:00
file.c
vfs: use kmalloc() to allocate fdmem if possible
2010-08-11 08:59:02 -07:00
filesystems.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
fs_struct.c
fs: fs_struct rwlock to spinlock
2010-08-18 08:35:46 -04:00
fs-writeback.c
bdi: Fix warnings in __mark_inode_dirty for /dev/zero and friends
2010-09-22 09:48:47 +02:00
generic_acl.c
vfs: update ctime when changing the file's permission by setfacl
2010-08-18 01:04:22 -04:00
inode.c
Merge branch 'for-linus' of git://git.infradead.org/users/eparis/notify
2010-08-10 11:39:13 -07:00
internal.h
fs: brlock vfsmount_lock
2010-08-18 08:35:48 -04:00
ioctl.c
bkl: Remove locked .ioctl file operation
2010-08-14 00:24:24 +02:00
ioprio.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
Kconfig
fs/Kconfig: Fix typo Userpace -> Userspace
2010-07-20 17:30:22 +02:00
Kconfig.binfmt
…
libfs.c
check ATTR_SIZE contraints in inode_change_ok
2010-08-09 16:47:39 -04:00
locks.c
…
Makefile
Take statfs variants to fs/statfs.c
2010-05-21 18:31:17 -04:00
mbcache.c
mbcache: Limit the maximum number of cache entries
2010-08-18 06:24:41 -04:00
mpage.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
namei.c
fs: brlock vfsmount_lock
2010-08-18 08:35:48 -04:00
namespace.c
VFS: Sanity check mount flags passed to change_mnt_propagation()
2010-09-07 13:46:20 -07:00
nfsctl.c
…
no-block.c
…
open.c
fs: cleanup files_lock locking
2010-08-18 08:35:47 -04:00
pipe.c
pipe: fix check in "set size" fcntl
2010-06-10 19:08:34 +02:00
pnode.c
fs: brlock vfsmount_lock
2010-08-18 08:35:48 -04:00
pnode.h
…
posix_acl.c
…
read_write.c
fsnotify: pass a file instead of an inode to open, read, and write
2010-07-28 09:58:32 -04:00
read_write.h
…
readdir.c
vfs: fix warning: 'dirent' is used uninitialized in this function
2010-08-09 20:45:05 -07:00
select.c
…
seq_file.c
…
signalfd.c
signalfd: fill in ssi_int for posix timers and message queues
2010-08-11 08:59:20 -07:00
splice.c
splice: fix misuse of SPLICE_F_NONBLOCK
2010-08-07 18:52:56 +02:00
stack.c
…
stat.c
Mark arguments to certain syscalls as being const
2010-08-13 16:53:13 -07:00
statfs.c
add f_flags to struct statfs(64)
2010-08-09 16:48:44 -04:00
super.c
fs: scale files_lock
2010-08-18 08:35:48 -04:00
sync.c
get rid of file_fsync()
2010-08-09 16:47:43 -04:00
timerfd.c
fs/timerfd.c: make use of wait_event_interruptible_locked_irq()
2010-05-20 13:21:42 -07:00
utimes.c
Mark arguments to certain syscalls as being const
2010-08-13 16:53:13 -07:00
xattr_acl.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
xattr.c
fs: xattr_handler table should be const
2010-05-21 18:31:18 -04:00