iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/mac80211
History
Gustavo A. R. Silva 40b5a0f8c6 mac80211: remove unnecessary NULL check 
Both old and new cannot be NULL at the same time, hence checking
new when old is not NULL is unnecessary.

Also, notice that new is being dereferenced before it is checked:

	idx = new->conf.keyidx;

The above triggers a static code analysis warning.

Address this by removing the NULL check on new and adding a code
comment based on the following piece of code:

387        /* caller must provide at least one old/new */
388        if (WARN_ON(!new && !old))
389                return 0;

Addresses-Coverity-ID: 1473176 ("Dereference before null check")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-09-05 10:15:48 +02:00
..
aead_api.c
mac80211: use crypto_aead_authsize()
2017-10-11 15:46:45 +02:00
aead_api.h
mac80211: aead api to reduce redundancy
2017-10-11 09:37:35 +02:00
aes_ccm.h
mac80211: aead api to reduce redundancy
2017-10-11 09:37:35 +02:00
aes_cmac.c
mac80211: aes-cmac: switch to shash CMAC driver
2017-02-08 09:19:33 +01:00
aes_cmac.h
mac80211: aes-cmac: switch to shash CMAC driver
2017-02-08 09:19:33 +01:00
aes_gcm.h
mac80211: aead api to reduce redundancy
2017-10-11 09:37:35 +02:00
aes_gmac.c
mac80211: move struct aead_req off the stack
2016-10-17 16:14:04 +02:00
aes_gmac.h
mac80211: move struct aead_req off the stack
2016-10-17 16:14:04 +02:00
agg-rx.c
mac80211: add support for HE
2018-06-18 22:40:32 +02:00
agg-tx.c
mac80211: add support for HE
2018-06-18 22:40:32 +02:00
cfg.c
mac80211: in AP mode, set bss_conf::he_supported
2018-09-05 10:03:13 +02:00
chan.c
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
debug.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debugfs_key.c
mac80211: move TKIP TX IVs to public part of key struct
2016-02-24 09:04:38 +01:00
debugfs_key.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debugfs_netdev.c
networking: convert many more places to skb_put_zero()
2017-06-16 11:48:35 -04:00
debugfs_netdev.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debugfs_sta.c
wireless: align to draft 11ax D3.0
2018-09-05 10:09:50 +02:00
debugfs_sta.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debugfs.c
mac80211: add an option for station management TXQ
2018-09-05 10:10:11 +02:00
debugfs.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
driver-ops.c
mac80211: add offset_tsf driver op and use it for mesh
2016-09-30 13:45:44 +02:00
driver-ops.h
mac80211: add an option for drivers to check if packets can be aggregated
2018-09-05 10:11:50 +02:00
ethtool.c
mac80211: use BIT_ULL for NL80211_STA_INFO_* attribute types
2018-06-29 09:53:09 +02:00
fils_aead.c
Some more updates:
2017-02-10 14:31:51 -05:00
fils_aead.h
mac80211: FILS AEAD protection for station mode association frames
2016-10-27 16:03:25 +02:00
he.c
mac80211: add support for HE
2018-06-18 22:40:32 +02:00
ht.c
ieee80211: bump IEEE80211_MAX_AMPDU_BUF to support HE
2018-06-18 22:39:39 +02:00
ibss.c
mac80211: add ability to parse CCFS2
2018-09-05 10:03:14 +02:00
ieee80211_i.h
mac80211: add ability to parse CCFS2
2018-09-05 10:03:14 +02:00
iface.c
net: allow ndo_select_queue to pass netdev
2018-07-09 13:41:34 -07:00
Kconfig
mac80211: fils_aead: Use crypto api CMAC shash rather than bare cipher
2017-02-08 09:19:17 +01:00
key.c
mac80211: remove unnecessary NULL check
2018-09-05 10:15:48 +02:00
key.h
mac80211: aes-cmac: switch to shash CMAC driver
2017-02-08 09:19:33 +01:00
led.c
leds: triggers: let struct led_trigger::activate() return an error code
2018-07-05 23:21:10 +02:00
led.h
mac80211: make LED triggering depend on activation
2015-05-05 14:21:56 +02:00
main.c
mac80211: Store sk_pacing_shift in ieee80211_hw
2018-09-05 10:03:15 +02:00
Makefile
mac80211: add support for HE
2018-06-18 22:40:32 +02:00
mesh_hwmp.c
mac80211: mesh: fix HWMP sequence numbering to follow standard
2018-08-29 11:15:30 +02:00
mesh_pathtbl.c
rhashtable: Change rhashtable_walk_start to return void
2017-12-11 09:58:38 -05:00
mesh_plink.c
mac80211: mesh: fix premature update of rc stats
2018-05-18 10:02:28 +02:00
mesh_ps.c
networking: make skb_put & friends return void pointers
2017-06-16 11:48:39 -04:00
mesh_sync.c
mac80211: Use appropriate name for functions and messages
2016-12-13 16:22:27 +01:00
mesh.c
mac80211: add ability to parse CCFS2
2018-09-05 10:03:14 +02:00
mesh.h
mac80211: Convert timers to use timer_setup()
2017-11-20 16:55:11 +01:00
michael.c
mac80211: add get TID helper
2018-02-22 21:13:03 +01:00
michael.h
mac80211: fix some missing includes
2014-04-09 14:49:43 +02:00
mlme.c
mac80211: fix saving a few HE values
2018-09-05 10:08:42 +02:00
ocb.c
mac80211: Convert timers to use timer_setup()
2017-11-20 16:55:11 +01:00
offchannel.c
mac80211: support scan features for improved scan privacy
2018-06-15 13:34:40 +02:00
pm.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
rate.c
mac80211: Dynamically set CoDel parameters per station
2017-05-17 16:03:40 +02:00
rate.h
mac80211: make rate control tx status API more extensible
2017-04-28 10:57:33 +02:00
rc80211_minstrel_debugfs.c
net: Use octal not symbolic permissions
2018-03-26 12:07:48 -04:00
rc80211_minstrel_ht_debugfs.c
net: Use octal not symbolic permissions
2018-03-26 12:07:48 -04:00
rc80211_minstrel_ht.c
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
rc80211_minstrel_ht.h
mac80211: minstrel_ht: move supported bitrate mask out of group data
2016-12-15 11:07:52 +01:00
rc80211_minstrel.c
net: remove blank lines at end of file
2018-07-24 14:10:43 -07:00
rc80211_minstrel.h
mac80211: minstrel: make prob_ewma u16 instead of u32
2016-12-15 11:07:53 +01:00
rx.c
mac80211: support reporting 0-length PSDU in radiotap
2018-09-05 10:08:25 +02:00
scan.c
This round's updates:
2018-06-30 21:08:12 +09:00
spectmgmt.c
mac80211: add ability to parse CCFS2
2018-09-05 10:03:14 +02:00
sta_info.c
mac80211: add an optional TXQ for other PS-buffered frames
2018-09-05 10:03:13 +02:00
sta_info.h
mac80211: add support for HE
2018-06-18 22:40:32 +02:00
status.c
mac80211: average ack rssi support for data frames
2018-05-07 21:41:16 +02:00
tdls.c
mac80211: enable TDLS peer buffer STA feature
2017-12-11 12:16:05 +01:00
tkip.c
mac80211: move TKIP TX IVs to public part of key struct
2016-02-24 09:04:38 +01:00
tkip.h
mac80211: move TKIP TX IVs to public part of key struct
2016-02-24 09:04:38 +01:00
trace_msg.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
trace.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
trace.h
mac80211: add support for HE
2018-06-18 22:40:32 +02:00
tx.c
mac80211: add an option for drivers to check if packets can be aggregated
2018-09-05 10:11:50 +02:00
util.c
mac80211: add ability to parse CCFS2
2018-09-05 10:03:14 +02:00
vht.c
mac80211: copy VHT EXT NSS BW Support/Capable data to station
2018-09-05 10:03:14 +02:00
wep.c
mac80211: Add RX flag to indicate ICV stripped
2017-01-12 10:15:18 +01:00
wep.h
mac80211: move RX WEP weak IV counting
2012-03-13 14:54:16 -04:00
wme.c
mac80211: mark expected switch fall-throughs
2017-12-11 12:16:04 +01:00
wme.h
mac80211: add WMM admission control support
2014-10-22 10:42:09 +02:00
wpa.c
mac80211: add get TID helper
2018-02-22 21:13:03 +01:00
wpa.h
mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers
2015-01-27 11:10:13 +01:00