iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
45c2fdde01
linux/drivers/char/hw_random
History
Thomas Petazzoni 45c2fdde01 hwrng: omap - write registers after enabling the clock 
Commit 383212425c ("hwrng: omap - Add device variant for SafeXcel
IP-76 found in Armada 8K") added support for the SafeXcel IP-76 variant
of the IP. This modification included getting a reference and enabling a
clock. Unfortunately, this was done *after* writing to the
RNG_INTMASK_REG register. This generally works fine when the driver is
built-in because the clock might have been left enabled by the
bootloader, but fails short when the driver is built as a module: it
causes a system hang because a register is being accessed while the
clock is not enabled.

This commit fixes that by making the register access *after* enabling
the clock.

This issue was found by the kernelci.org testing effort.

Fixes: 383212425c ("hwrng: omap - Add device variant for SafeXcel IP-76 found in Armada 8K")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2017-03-08 14:01:11 +08:00
..
amd-rng.c hwrng: amd - Fix return value check in mod_init() 2016-09-22 18:27:48 +08:00
atmel-rng.c hwrng: atmel - use clk_disable_unprepare instead of clk_disable 2016-11-17 23:34:57 +08:00
bcm63xx-rng.c hwrng: bcm63xx - fix device tree compilation 2016-04-05 20:23:11 +08:00
bcm2835-rng.c hwrng: bcm2835 - handle of_iomap failures 2016-09-07 21:08:24 +08:00
cavium-rng-vf.c hwrng: cavium - Use per device name to allow for multiple devices. 2017-02-11 17:52:30 +08:00
cavium-rng.c hwrng: cavium - Add Cavium HWRNG driver for ThunderX SoC. 2016-08-31 23:00:40 +08:00
core.c sched/headers: Prepare to move signal wakeup & sigpending methods from <linux/sched.h> into <linux/sched/signal.h> 2017-03-02 08:42:32 +01:00
exynos-rng.c hwrng: exynos - fixup IO accesors 2016-06-13 17:47:50 +08:00
geode-rng.c hwrng: geode - fix return value check in mod_init() 2016-09-22 18:27:49 +08:00
hisi-rng.c hwrng: hisi - Add support for Hisilicon SoC RNG 2016-04-15 22:36:36 +08:00
intel-rng.c
iproc-rng200.c
ixp4xx-rng.c
Kconfig hwrng: omap - update Kconfig help description 2017-02-15 13:23:48 +08:00
Makefile hwrng: cavium - Add Cavium HWRNG driver for ThunderX SoC. 2016-08-31 23:00:40 +08:00
meson-rng.c hwrng: meson - Remove unneeded platform MODULE_ALIAS 2016-10-25 11:08:25 +08:00
msm-rng.c hwrng: Make explicit that max >= 32 always 2016-11-21 22:50:45 +08:00
mxc-rnga.c hwrng: mxc-rnga - Use the preferred format for kzalloc 2015-09-21 22:00:39 +08:00
n2-asm.S
n2-drv.c hwrng: n2 - update version info 2017-01-13 18:47:20 +08:00
n2rng.h hwrng: n2 - support new hardware register layout 2017-01-13 18:47:19 +08:00
nomadik-rng.c
octeon-rng.c hwrng: octeon - Use devm_hwrng_register 2015-09-21 22:00:38 +08:00
omap3-rom-rng.c hwrng: omap3-rom - Remove obsoleted functions 2016-08-24 21:04:50 +08:00
omap-rng.c hwrng: omap - write registers after enabling the clock 2017-03-08 14:01:11 +08:00
pasemi-rng.c hwrng: pasemi - Use linux/io.h instead of asm/io.h 2016-09-13 20:27:21 +08:00
pic32-rng.c hwrng: Make explicit that max >= 32 always 2016-11-21 22:50:45 +08:00
powernv-rng.c
pseries-rng.c hwrng: Make explicit that max >= 32 always 2016-11-21 22:50:45 +08:00
st-rng.c hwrng: st - Fix missing clk_disable_unprepare() on error in st_rng_probe() 2016-09-13 20:27:24 +08:00
stm32-rng.c hwrng: stm32 - fix maybe uninitialized variable warning 2016-05-31 16:41:57 +08:00
timeriomem-rng.c
tpm-rng.c
tx4939-rng.c hwrng: tx4939 - Use devm_hwrng_register instead of hwrng_register 2016-08-31 23:00:49 +08:00
via-rng.c x86/fpu: Remove irq_ts_save() and irq_ts_restore() 2016-11-01 07:47:54 +01:00
virtio-rng.c
xgene-rng.c hwrng: xgene - fix handling platform_get_irq 2015-09-21 22:57:37 +08:00