Kees Cook
3f649ab728
treewide: Remove uninitialized_var() usage
...
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings
(e.g. "unused variable"). If the compiler thinks it is uninitialized,
either simply initialize the variable or make compiler changes.
In preparation for removing[2] the[3] macro[4], remove all remaining
needless uses with the following script:
git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \
xargs perl -pi -e \
's/\buninitialized_var\(([^\)]+)\)/\1/g;
s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;'
drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid
pathological white-space.
No outstanding warnings were found building allmodconfig with GCC 9.3.0
for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64,
alpha, and m68k.
[1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Reviewed-by: Leon Romanovsky <leonro@mellanox.com> # drivers/infiniband and mlx4/mlx5
Acked-by: Jason Gunthorpe <jgg@mellanox.com> # IB
Acked-by: Kalle Valo <kvalo@codeaurora.org> # wireless drivers
Reviewed-by: Chao Yu <yuchao0@huawei.com> # erofs
Signed-off-by: Kees Cook <keescook@chromium.org>
2020-07-16 12:35:15 -07:00
..
2019-07-03 16:57:17 +02:00
2020-05-08 15:32:17 +10:00
2019-07-25 11:34:39 -07:00
2019-06-20 10:11:24 +02:00
2020-06-01 14:23:25 -06:00
2020-01-17 11:12:06 +01:00
2020-06-10 19:14:17 -07:00
2020-06-11 18:17:47 -07:00
2020-06-09 10:03:12 -07:00
2020-06-01 12:00:10 -07:00
2020-04-09 00:12:48 +09:00
2019-07-02 08:41:37 +02:00
2020-06-11 15:54:31 -07:00
2019-11-15 18:34:00 -08:00
2020-01-31 10:30:40 -08:00
2020-01-31 10:30:40 -08:00
2020-06-04 19:06:25 -07:00
2019-09-15 19:42:16 +02:00
2020-03-25 11:50:48 +01:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:27:11 +02:00
2019-05-24 17:27:11 +02:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-05-24 20:48:11 +02:00
2020-06-10 19:14:17 -07:00
2019-05-21 10:50:45 +02:00
2020-03-03 17:38:42 -05:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2020-06-01 08:23:42 -04:00
2019-05-24 17:27:11 +02:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2020-05-29 16:11:50 -04:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2019-06-19 17:09:06 +02:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-10-18 15:01:57 +02:00
2020-03-20 13:06:18 +01:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2017-09-26 15:01:20 -06:00
2019-06-19 17:09:06 +02:00
2019-02-15 19:50:07 +01:00
2018-07-27 19:04:33 +08:00
2017-02-24 17:46:57 -08:00
2020-01-23 11:40:01 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-05-19 15:47:21 +02:00
2020-01-17 15:45:01 +01:00
2018-06-12 23:33:24 +02:00
2018-07-27 19:16:38 +08:00
2020-01-31 10:30:40 -08:00
2019-06-19 17:09:55 +02:00
2019-05-24 17:37:53 +02:00
2017-11-02 11:10:55 +01:00
2020-01-06 09:45:59 +01:00
2019-07-10 18:43:43 -07:00
2020-06-09 09:39:13 -07:00
2020-06-08 11:05:56 -07:00
2017-11-15 11:56:19 -08:00
2019-06-05 17:36:37 +02:00
2019-10-17 16:23:25 +02:00
2019-04-09 14:19:06 +02:00
2018-04-27 08:51:26 -04:00
2019-09-25 17:51:39 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2019-06-05 17:36:38 +02:00
2020-01-31 10:30:41 -08:00
2020-06-04 19:06:25 -07:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2019-12-04 19:44:13 -08:00
2019-10-14 15:04:00 -07:00
2017-02-24 17:46:57 -08:00
2017-02-24 17:46:57 -08:00
2019-09-25 17:51:39 -07:00
2019-05-13 11:07:33 +02:00
2019-11-01 22:26:34 -04:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2019-01-22 13:39:59 +01:00
2018-05-09 06:55:44 +02:00
2020-06-09 09:39:13 -07:00
2020-03-21 09:41:55 +01:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2020-06-01 15:45:27 -07:00
2020-06-17 10:38:42 +09:00
2020-06-25 13:45:39 +02:00
2020-06-11 20:04:00 +02:00
2020-05-18 17:49:27 +01:00
2020-06-11 20:03:59 +02:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2019-04-01 07:37:12 +02:00
2020-06-07 10:53:36 -07:00
2018-10-31 08:54:13 -07:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2020-05-11 11:55:28 +01:00
2018-04-11 10:28:35 -07:00
2019-06-20 14:07:34 -06:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-10-09 12:46:10 +02:00
2019-06-07 13:15:06 -07:00
2020-05-07 14:54:26 +08:00
2019-05-24 17:37:53 +02:00
2019-05-24 17:39:02 +02:00
2020-06-11 20:02:46 +02:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2019-11-07 15:44:29 +01:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2020-04-30 17:51:42 -07:00
2018-07-09 14:10:40 +02:00
2017-11-02 11:10:55 +01:00
2019-07-03 16:57:18 +02:00
2017-11-02 11:10:55 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2019-05-24 17:27:11 +02:00
2017-11-04 09:26:51 +09:00
2019-05-03 10:49:17 -04:00
2017-02-03 16:35:42 -05:00
2019-06-19 17:09:06 +02:00
2018-01-26 11:45:16 -06:00
2018-08-30 12:56:40 +02:00
2019-05-21 10:50:45 +02:00
2020-06-04 19:06:25 -07:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2020-07-16 12:35:15 -07:00
2019-05-17 11:32:47 -07:00
2019-06-05 17:37:16 +02:00
2019-09-25 17:51:39 -07:00
2020-04-07 10:43:43 -07:00
2019-11-25 09:15:32 +01:00
2020-06-06 15:51:17 -07:00
2019-12-20 16:51:54 -07:00
2020-04-07 10:43:43 -07:00
2020-06-15 18:22:43 -07:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2020-05-08 15:32:17 +10:00
2019-09-24 15:54:09 -07:00
2019-04-25 19:47:24 +02:00
2020-06-11 15:14:36 +02:00
2019-11-14 13:15:11 -05:00
2020-04-07 10:43:43 -07:00
2019-05-30 11:26:32 -07:00
2019-07-16 19:23:22 -07:00
2020-02-21 11:22:15 -08:00
2020-06-04 19:06:25 -07:00
2020-05-01 12:35:21 +10:00
2019-04-05 09:26:43 -04:00
2018-06-27 18:58:49 +03:00
2020-04-07 10:43:43 -07:00
2020-06-10 19:14:18 -07:00
2019-07-01 19:34:46 -07:00
2020-02-24 16:20:09 -08:00
2019-05-21 10:50:45 +02:00
2020-04-17 09:59:39 +02:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2020-05-19 16:48:30 -03:00
2020-06-26 00:27:37 -07:00
2018-10-15 16:31:29 -04:00
2020-06-03 20:09:42 -07:00
2020-04-07 10:43:43 -07:00
2020-05-08 18:18:12 +01:00
2019-05-21 10:50:45 +02:00
2020-07-16 12:35:15 -07:00
2018-10-16 13:45:44 +02:00
2019-12-04 19:44:13 -08:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2019-07-16 19:23:22 -07:00
2017-02-26 11:03:38 -05:00
2020-06-07 10:53:36 -07:00
2019-06-19 17:09:55 +02:00
2017-01-09 13:58:57 -05:00
2019-05-21 10:50:45 +02:00
2020-04-07 10:43:43 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2020-06-09 10:03:12 -07:00
2019-03-07 18:32:00 -08:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2020-06-02 10:59:11 -07:00
2020-01-31 15:09:49 -05:00
2019-10-03 12:12:23 -04:00
2019-07-24 17:38:01 +02:00
2020-04-07 10:43:42 -07:00
2020-04-07 10:43:43 -07:00
2020-04-07 10:43:43 -07:00
2020-06-04 19:06:28 -07:00
2019-11-17 09:02:42 +08:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2020-06-11 20:02:46 +02:00
2020-03-23 17:01:47 +01:00
2020-06-01 12:13:30 -07:00
2017-11-02 11:10:55 +01:00
2020-03-12 17:42:08 -04:00
2017-08-15 09:02:07 -07:00