Jinjie Ruan
9acb294ebd
kunit: Fix wild-memory-access bug in kunit_free_suite_set()
...
[ Upstream commit 2810c1e99867a811e631dd24e63e6c1e3b78a59d ]
Inject fault while probing kunit-example-test.ko, if kstrdup()
fails in mod_sysfs_setup() in load_module(), the mod->state will
switch from MODULE_STATE_COMING to MODULE_STATE_GOING instead of
from MODULE_STATE_LIVE to MODULE_STATE_GOING, so only
kunit_module_exit() will be called without kunit_module_init(), and
the mod->kunit_suites is no set correctly and the free in
kunit_free_suite_set() will cause below wild-memory-access bug.
The mod->state state machine when load_module() succeeds:
MODULE_STATE_UNFORMED ---> MODULE_STATE_COMING ---> MODULE_STATE_LIVE
^ |
| | delete_module
+---------------- MODULE_STATE_GOING <---------+
The mod->state state machine when load_module() fails at
mod_sysfs_setup():
MODULE_STATE_UNFORMED ---> MODULE_STATE_COMING ---> MODULE_STATE_GOING
^ |
| |
+-----------------------------------------------+
Call kunit_module_init() at MODULE_STATE_COMING state to fix the issue
because MODULE_STATE_LIVE is transformed from it.
Unable to handle kernel paging request at virtual address ffffff341e942a88
KASAN: maybe wild-memory-access in range [0x0003f9a0f4a15440-0x0003f9a0f4a15447]
Mem abort info:
ESR = 0x0000000096000004
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
FSC = 0x04: level 0 translation fault
Data abort info:
ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000
CM = 0, WnR = 0, TnD = 0, TagAccess = 0
GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
swapper pgtable: 4k pages, 48-bit VAs, pgdp=00000000441ea000
[ffffff341e942a88] pgd=0000000000000000, p4d=0000000000000000
Internal error: Oops: 0000000096000004 [#1 ] PREEMPT SMP
Modules linked in: kunit_example_test(-) cfg80211 rfkill 8021q garp mrp stp llc ipv6 [last unloaded: kunit_example_test]
CPU: 3 PID: 2035 Comm: modprobe Tainted: G W N 6.5.0-next-20230828+ #136
Hardware name: linux,dummy-virt (DT)
pstate: a0000005 (NzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : kfree+0x2c/0x70
lr : kunit_free_suite_set+0xcc/0x13c
sp : ffff8000829b75b0
x29: ffff8000829b75b0 x28: ffff8000829b7b90 x27: 0000000000000000
x26: dfff800000000000 x25: ffffcd07c82a7280 x24: ffffcd07a50ab300
x23: ffffcd07a50ab2e8 x22: 1ffff00010536ec0 x21: dfff800000000000
x20: ffffcd07a50ab2f0 x19: ffffcd07a50ab2f0 x18: 0000000000000000
x17: 0000000000000000 x16: 0000000000000000 x15: ffffcd07c24b6764
x14: ffffcd07c24b63c0 x13: ffffcd07c4cebb94 x12: ffff700010536ec7
x11: 1ffff00010536ec6 x10: ffff700010536ec6 x9 : dfff800000000000
x8 : 00008fffefac913a x7 : 0000000041b58ab3 x6 : 0000000000000000
x5 : 1ffff00010536ec5 x4 : ffff8000829b7628 x3 : dfff800000000000
x2 : ffffff341e942a80 x1 : ffffcd07a50aa000 x0 : fffffc0000000000
Call trace:
kfree+0x2c/0x70
kunit_free_suite_set+0xcc/0x13c
kunit_module_notify+0xd8/0x360
blocking_notifier_call_chain+0xc4/0x128
load_module+0x382c/0x44a4
init_module_from_file+0xd4/0x128
idempotent_init_module+0x2c8/0x524
__arm64_sys_finit_module+0xac/0x100
invoke_syscall+0x6c/0x258
el0_svc_common.constprop.0+0x160/0x22c
do_el0_svc+0x44/0x5c
el0_svc+0x38/0x78
el0t_64_sync_handler+0x13c/0x158
el0t_64_sync+0x190/0x194
Code: aa0003e1 b25657e0 d34cfc42 8b021802 (f9400440)
---[ end trace 0000000000000000 ]---
Kernel panic - not syncing: Oops: Fatal exception
SMP: stopping secondary CPUs
Kernel Offset: 0x4d0742200000 from 0xffff800080000000
PHYS_OFFSET: 0xffffee43c0000000
CPU features: 0x88000203,3c020000,1000421b
Memory Limit: none
Rebooting in 1 seconds..
Fixes: 3d6e44623841 ("kunit: unify module and builtin suite definitions")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Rae Moar <rmoar@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-09-19 12:28:08 +02:00
..
2020-08-10 01:32:59 +09:00
2022-08-26 18:40:14 +08:00
2023-05-24 17:32:31 +01:00
2022-12-31 13:31:56 +01:00
2023-09-19 12:28:08 +02:00
2022-06-15 10:29:10 +02:00
2022-07-17 17:31:39 -07:00
2022-07-29 18:12:34 -07:00
2021-09-08 11:50:26 -07:00
2023-03-10 09:32:52 +01:00
2021-07-08 11:48:20 -07:00
2022-03-08 15:20:21 -08:00
2022-10-11 17:42:58 -06:00
2022-02-13 16:50:06 -08:00
2022-11-23 19:50:15 +01:00
2021-10-19 23:44:30 +08:00
2020-08-10 01:32:59 +09:00
2020-12-29 15:36:49 -08:00
2021-09-24 16:13:35 -07:00
2023-04-06 12:10:38 +02:00
2022-04-26 17:58:51 -04:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-11-18 14:15:17 -06:00
2022-01-20 08:52:55 +02:00
2022-06-01 18:29:06 -07:00
2019-05-30 11:26:32 -07:00
2021-12-13 10:56:09 +01:00
2021-10-01 16:52:48 -04:00
2022-08-02 17:14:47 -06:00
2021-05-06 19:24:12 -07:00
2020-10-16 13:25:14 -06:00
2023-07-19 16:21:58 +02:00
2019-05-21 10:50:45 +02:00
2022-04-26 17:58:51 -04:00
2022-04-26 17:58:51 -04:00
2020-06-11 15:14:53 +02:00
2022-06-16 19:58:21 -07:00
2023-03-10 09:33:47 +01:00
2019-05-24 17:27:11 +02:00
2021-07-08 11:48:22 -07:00
2022-09-01 16:55:35 +02:00
2020-08-20 15:45:14 -04:00
2023-08-30 16:11:08 +02:00
2022-10-11 17:42:58 -06:00
2022-09-11 21:55:06 -07:00
2019-05-24 17:39:02 +02:00
2021-10-01 16:52:48 -04:00
2023-06-14 11:15:22 +02:00
2022-10-06 05:57:36 -07:00
2022-10-01 10:22:57 -07:00
2019-06-19 17:09:06 +02:00
2021-01-21 14:06:00 -07:00
2021-05-06 19:24:12 -07:00
2019-06-19 17:09:06 +02:00
2022-01-31 11:21:43 +11:00
2022-01-31 11:21:43 +11:00
2022-03-07 12:48:35 -07:00
2022-03-07 12:48:35 -07:00
2019-06-19 17:09:06 +02:00
2022-06-07 10:27:38 +02:00
2020-06-18 17:26:43 +10:00
2021-08-19 09:02:55 +09:00
2021-06-22 13:56:43 +02:00
2023-08-11 12:08:23 +02:00
2021-07-01 11:06:05 -07:00
2020-01-31 10:30:40 -08:00
2021-07-01 11:06:06 -07:00
2021-05-06 19:24:12 -07:00
2021-07-01 11:06:06 -07:00
2021-10-19 23:44:30 +08:00
2021-11-08 16:55:26 -08:00
2020-07-31 11:49:08 +02:00
2021-08-13 14:09:32 -10:00
2022-09-01 18:04:43 +02:00
2020-11-20 14:45:33 +11:00
2022-04-22 21:30:57 +02:00
2022-09-07 17:04:49 +02:00
2020-10-16 11:11:20 -07:00
2022-09-11 21:55:10 -07:00
2023-03-10 09:33:27 +01:00
2022-07-17 17:31:38 -07:00
2020-12-15 22:46:15 -08:00
2021-01-03 20:05:18 -05:00
2020-10-16 11:11:22 -07:00
2022-11-22 18:50:44 -08:00
2020-01-08 16:59:19 +00:00
2022-10-11 17:42:55 -06:00
2022-10-06 05:57:36 -07:00
2022-09-19 14:35:08 +02:00
2022-09-14 07:04:15 -07:00
2022-03-07 12:48:35 -07:00
2022-01-15 08:47:31 -08:00
2019-10-14 15:04:00 -07:00
2022-04-29 14:38:01 -07:00
2022-04-27 10:57:33 -07:00
2019-05-13 11:07:33 +02:00
2023-09-19 12:28:03 +02:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2022-10-03 14:03:21 -07:00
2022-10-03 14:03:18 -07:00
2022-04-13 21:32:21 +02:00
2019-05-30 11:26:32 -07:00
2022-09-07 16:37:27 -07:00
2019-05-24 17:27:11 +02:00
2021-08-19 09:02:55 +09:00
2022-10-10 13:04:25 -07:00
2023-01-07 11:11:55 +01:00
2022-10-03 14:02:57 -07:00
2022-04-22 12:32:04 +02:00
2022-03-22 15:57:11 -07:00
2022-10-11 12:01:24 +02:00
2022-11-08 15:57:24 -08:00
2022-07-14 15:45:26 -07:00
2021-07-08 11:48:20 -07:00
2019-06-19 17:09:08 +02:00
2021-12-28 11:26:18 +01:00
2023-03-10 09:33:30 +01:00
2022-05-13 07:20:13 -07:00
2021-05-19 15:05:11 +02:00
2020-10-16 11:11:19 -07:00
2021-08-13 18:37:38 +02:00
2022-06-16 19:58:20 -07:00
2021-07-08 11:48:20 -07:00
2022-04-05 13:32:27 -06:00
2022-09-11 21:55:06 -07:00
2021-12-04 10:56:24 +01:00
2023-02-01 08:34:34 +01:00
2022-03-11 10:42:56 +01:00
2021-02-17 17:31:06 -06:00
2022-07-17 17:31:37 -07:00
2019-05-24 17:39:02 +02:00
2023-08-11 12:08:10 +02:00
2023-08-30 16:11:13 +02:00
2022-09-07 16:37:48 -07:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2019-05-24 17:39:02 +02:00
2019-05-21 10:50:45 +02:00
2023-02-01 08:34:43 +01:00
2022-04-22 21:30:57 +02:00
2022-12-31 13:31:58 +01:00
2021-12-24 14:54:29 -08:00
2019-05-21 10:50:45 +02:00
2021-07-08 11:48:20 -07:00
2022-10-03 17:34:32 -07:00
2022-10-25 14:57:42 -07:00
2021-09-17 13:52:17 +01:00
2021-04-16 16:10:37 -07:00
2021-07-01 11:06:05 -07:00
2021-09-19 17:13:35 -07:00
2021-05-06 19:24:12 -07:00
2019-05-21 10:50:45 +02:00
2022-05-18 02:20:17 -04:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2022-05-22 11:32:30 -07:00
2023-08-30 16:11:08 +02:00
2022-10-11 17:42:58 -06:00
2022-08-24 13:46:57 +01:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2022-02-06 11:05:28 +00:00
2021-07-08 11:48:20 -07:00
2021-07-08 11:48:20 -07:00
2023-03-10 09:34:34 +01:00
2022-07-17 17:31:39 -07:00
2021-07-08 11:48:20 -07:00
2022-09-23 16:46:19 +02:00
2019-08-08 07:45:01 -06:00
2022-09-26 19:46:29 -07:00
2022-06-03 10:34:34 -07:00
2022-04-06 10:11:48 +02:00
2022-07-17 17:31:41 -07:00
2022-03-17 20:17:18 -07:00
2022-10-03 14:03:18 -07:00
2022-09-30 13:21:22 -06:00
2019-05-30 11:26:32 -07:00
2022-09-05 14:51:46 +01:00
2022-10-03 14:03:22 -07:00
2022-04-19 21:58:47 +02:00
2022-04-19 21:58:47 +02:00
2021-06-18 11:43:09 +02:00
2023-08-11 12:08:10 +02:00
2021-07-08 11:48:20 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2022-06-22 19:20:20 -07:00
2019-05-21 10:50:45 +02:00
2022-09-07 17:04:49 +02:00
2023-08-03 10:24:19 +02:00
2022-10-11 17:42:58 -06:00
2021-01-18 11:03:26 +01:00
2022-07-17 17:14:36 -07:00
2022-01-20 08:52:54 +02:00
2022-10-11 17:42:55 -06:00
2022-10-12 18:51:50 -07:00
2022-10-12 18:51:50 -07:00
2022-03-29 15:13:36 -07:00
2022-10-11 17:42:58 -06:00
2020-05-08 18:18:12 +01:00
2022-10-11 17:42:55 -06:00
2022-02-25 09:36:06 +01:00
2023-08-03 10:23:55 +02:00
2023-09-19 12:27:57 +02:00
2022-10-11 17:42:58 -06:00
2019-05-21 10:50:45 +02:00
2022-10-11 17:42:58 -06:00
2022-07-28 10:38:30 +02:00
2021-12-06 16:04:44 -08:00
2022-10-26 13:39:09 +01:00
2023-09-19 12:28:05 +02:00
2022-05-19 18:54:22 +02:00
2021-09-08 11:50:26 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2022-04-29 14:38:00 -07:00
2019-04-08 16:44:21 -06:00
2022-05-03 10:15:07 +02:00
2022-01-20 08:52:55 +02:00
2019-10-16 14:56:21 +02:00
2022-10-11 17:42:58 -06:00
2022-03-28 19:25:11 -04:00
2022-10-11 17:42:55 -06:00
2019-10-03 12:12:23 -04:00
2021-02-17 14:08:01 +01:00
2022-06-15 17:41:12 +02:00
2023-07-19 16:21:13 +02:00
2020-11-18 14:15:17 -06:00
2020-04-07 10:43:43 -07:00
2023-01-24 07:24:41 +01:00
2021-02-05 11:03:47 -08:00
2019-05-24 17:39:02 +02:00
2023-02-25 11:25:41 +01:00
2022-10-11 17:42:58 -06:00
2022-10-10 11:24:19 -07:00
2023-09-13 09:43:00 +02:00
2020-08-12 10:58:00 -07:00